This PR fixed an edge case we found:

if skipSavingDuplicateTranslation is set to true and all translationAttributes have values that PHP considers "empty" in empty(), no translation is created even when creating a new record.

To fix this, in modelEqualsFallbackTranslation() we should only check the presence of $model->$translationAttribute with isset(), not the value with emtpy().

Our usecase are translation tables in which we store only a translatable active/inactive status attribute of a base model as 0|1 values with default set to 0.

I also added a test which try to cover these edgeCase and where you can see where the problem can occur.

Cc: @cebe @schmunk42

added possibility to use fallback languages for a model, see also updates in README

@tonydspaniard Let me know if you've questions or feedback regarding this PR, we heavily rely on this in most of our projects.

It should be BC @cebe Please correct me if not.

Hi @2amigos

I added new event (EVENT_AFTER_DELETE) which delete translations.

Could you check it ?

Do you think it's more safe to leave translations undeleted ?

• Allow configuration of afterDelete event
• implement $restrictDeletion property, to prevent deletion of records with multiple translations

default behavior does not change, it just go more flexible by allowing more configuration.

I have the following validation in model IngredientGroupLang:

    public function rules()
    {
        return [
            [['ingredient_group_id', 'language', 'name'], 'required'],
            [['ingredient_group_id'], 'integer'],
            [['language', 'name'], 'string', 'max' => 255],
            [['language', 'name'], 'unique', 'targetAttribute' => ['language', 'name']],
        ];
    }

Uniqueness validation error of IngredientGroupLang at saving of an instance of IngredientGroup remains hidden, what causes that theIngredientGroup will be saved without IngredientGroupLang record, causing an inconsistent database. Even if I overwrite the save method of IngredientGroup to run in transaction, it does not help, because I can not catch the validation error of the translation.

I think, the problem is, that validation error at saving the translation should raise an exception and the validation error should be bubbled up into the main model instance. The exception could than be catched.

Do you have any idea? I need a uniqueness validation on the name attribute.

I'm using the 2amigos/yii2-translateable-behavior, and when I limit the query set (aka, use per-page parameter), the query is returning all translations of records that match the query criteria.

Let me try explain this better, imagine the following scenario: I have the table ARTICLE, each article can have one or more translations, stored in ARTICLE_LANG table. I want to return the first 5, if those five only have 1 translation (meaning, original language), I will receive 5 unique records. Now, imagine this twist, where those 5 records, the 2 first records have 2 translations each, what the query will return is 4 records corresponding to the first two, and the fifth will be ARTICLE no.3

That makes the api return only 3 unique records, instead of the 5 I've requested. @tonydspaniard

I've installed this great extension and everything works fine with displaying data already in database. But when i try to update data nothing happens. As far I can see, title property never gets marked as dirty and so never gets updated. I have Article and ArticleTranslation models setup up as by instructions. This is in my activeForm among other fields.

<?= $form->field($model, 'title')->textInput() ?>

Example:

        $query = Property::find();
        $query->with([
            'translations'=>function($query){
                $query->onCondition(['lang' => ['es','de']]);
            },
        ]);

At the moment I use https://github.com/creocoder/yii2-translateable in my media model. In this model I translate the alt and title attribute for images. In some cases I don't need the translation in every view. Therefore it is good that there is no ActiveRecord::EVENT_AFTER_FIND. I think it is better to instancetiate the model with Model::find()->with('translations') if you need the translation.

It would be nice if it was possible to define a default translation in case of missing Eg: My site is in 'pt-pt' but I have only translations in 'en-gb'... i think is preferible see the info in another language, than no info at all... Thank you!

Assumption

I have same schema as https://github.com/2amigos/yii2-translateable-behavior#preparation

this is behavior config in tour model

public function behaviors()
{
    return [
        'trans' => [ // name it the way you want
            'class' => TranslateableBehavior::className(),
            // in case you named your relation differently, you can setup its relation name attribute
            // 'relation' => 'translations',
            // in case you named the language column differently on your translation schema
            // 'languageField' => 'language',
            'translationAttributes' => [
                'title', 'description'
            ]
        ],
    ];
}

Now when i save model in actionCreate as

$tour_model->lang = 'en';

getting error

yii\base\UnknownPropertyException: Setting unknown property: \models\Tour::lang in ...

now i add a lang in behavior as

'translationAttributes' => [
                'title', 'description', 'lang'
            ]

and having below line in controller, all works fine

$tour_model->lang = 'en';

Is this a issue or doc should be updated? I think the doc should be updated that lang att should also be in translationAttributes

feel free to ask more details if needed

Hi, I am storing for different accounts separate translations via your model. But that means that I am using this

 return $this->hasMany(Translation::class, ['fk_id' => 'field_id'])
        ->andOnCondition(['customer_id' => Yii::$app->session['active_customer_id']])
        ;

But somehow the query that your behavour fires, does not include the andOn condition. Am I doing something wrong?

Thanks for any hint....

gb5256