I have a Laravel 5.5 application that needs to use okta/sdk. When trying to install their latest release, composer says:

composer require 'okta/sdk':'1.2.0'                                      ~/Sites/oc-okta
    1/2:        http://repo.packagist.org/p/provider-latest$931036c372fbe3590c8c2636d1dd3cf98af373996e4de279afdfb2d462f9587e.json
    2/2:        http://repo.packagist.org/p/provider-2019-01$295ff58f1da61afb5b4db61b40b610468ad8bfe323a279f4e9f7ed454e44bb1f.json
    Finished: success: 2, skipped: 0, failure: 0, total: 2
./composer.json has been updated                           
Loading composer repositories with package information
Updating dependencies (including require-dev)              
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - don't install tightenco/collect v5.8.31|don't install laravel/framework v5.5.46
    - don't install tightenco/collect v5.8.31|remove laravel/framework v5.5.46
    - don't install tightenco/collect v5.8.31|don't install laravel/framework v5.5.46
    - okta/sdk 1.2.0 requires tightenco/collect 5.8.31 -> satisfiable by tightenco/collect[v5.8.31].
    - Installation request for okta/sdk 1.2.0 -> satisfiable by okta/sdk[1.2.0].
    - Installation request for laravel/framework 5.5.46 -> satisfiable by laravel/framework[v5.5.46]

I have contacted Okta, to which they say the issue has been fixed; however, as you can see, there are still problems. Are there any suggestions on how I can work around this issue?

Any feedback is appreciated, thanks!

https://getcomposer.org/doc/04-schema.md#replace

This is so that framework-agnostic libraries that depend on this one can be installed in Laravel applications.

It seems to be related to the loading sequence I guess, when installing the dev dependencies the issue is gone. So in dev I have no issues, but on non-dev environments the issue is 100% persistent.

How can we prevent the error?

PHP Version: 7.1.12 Laravel: 5.6.8 tightenco/collect: 5.6.7

Type error: Argument 1 passed to Illuminate\Routing\Router::sortMiddleware() must be an instance of Illuminate\Support\Collection, instance of Tightenco\Collect\Support\Collection given, called in xxx/vendor/laravel/framework/src/Illuminate/Routing/Router.php on line 676

This is what this PR is doing:

~1) Changing the namespace from Illuminate to Tightenco.~

2. Generating Collect from scratch. We now have an upgrade.sh script, which:

• Completely deletes /src and ´/tests` directories:

This way, is someone removes something from the classes (or tests) arrays, we won't leave zombies in the repository:

Then it:

• Finds the newest version of laravel/framework on Github.
• Downloads the zip file and unzip it.
• Copies everything to the right places.
• Copy the stubs (tests/bootstrap.php and helpers.php).
• Download the PHP tests files, which are not present in the repository zip file.
• Rename the namespace on all files.
• Deletes the vendor directory and composer.lock for a fresh:
• Composer install.
• Run all tests.

3. Adding some missing classes and tests, which helped me find some missing classes/interfaces, like Illuminate/Support/Carbon and Contracts/Support/Htmlable.php.

This is what a run of upgrade.sh should look like:

antoniocarlos at MacBookProAukeyDongle in ~/code/TightenCo/collect (rename-namespace)
$ ./upgrade.sh
-- Upgrading...
Getting current version from https://github.com/laravel/framework.git...
Upgrading to laravel/framework 5.5.26
Cleaning ./src and ./tests/Support...
-- Downloading https://github.com/laravel/framework/archive/v5.5.26.zip to ./src
-- Extracting framework.zip...
-- Moving classes and contracts...
Moving ./framework-5.5.26/src/Illuminate/Contracts/Support/Arrayable.php...
Moving ./framework-5.5.26/src/Illuminate/Contracts/Support/Jsonable.php...
Moving ./framework-5.5.26/src/Illuminate/Contracts/Support/Htmlable.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Arr.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Collection.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Carbon.php...
Moving ./framework-5.5.26/src/Illuminate/Support/HigherOrderCollectionProxy.php...
Moving ./framework-5.5.26/src/Illuminate/Support/helpers.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Traits/Macroable.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Debug/Dumper.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Debug/HtmlDumper.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Str.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Optional.php...
Moving ./framework-5.5.26/src/Illuminate/Support/Collection.php...
mv: ./framework-5.5.26/src/Illuminate/Support/Collection.php: No such file or directory
Moving ./framework-5.5.26/src/Illuminate/Support/HigherOrderTapProxy.php...
Moving ./framework-5.5.26/src/Illuminate/Support/HtmlString.php...
-- Copying stubs...
Copying ./stubs/src/Tightenco/Support/helpers.php to ./src/Tightenco/Support/helpers.php...
Copying ./stubs/tests/bootstrap.php to ./tests/bootstrap.php...
-- Copying tests...
---- Downloading test https://raw.githubusercontent.com/laravel/framework/v5.5.26/tests/Support/SupportCollectionTest.php to ./tests/Support/SupportCollectionTest.php...
---- Downloading test https://raw.githubusercontent.com/laravel/framework/v5.5.26/tests/Support/SupportArrTest.php to ./tests/Support/SupportArrTest.php...
---- Downloading test https://raw.githubusercontent.com/laravel/framework/v5.5.26/tests/Support/SupportMacroableTest.php to ./tests/Support/SupportMacroableTest.php...
---- Downloading test https://raw.githubusercontent.com/laravel/framework/v5.5.26/tests/Support/SupportStrTest.php to ./tests/Support/SupportStrTest.php...
---- Downloading test https://raw.githubusercontent.com/laravel/framework/v5.5.26/tests/Support/SupportCarbonTest.php to ./tests/Support/SupportCarbonTest.php...
-- Renaming namespace from Illuminate to Tightenco...
-- Cleaning up ./framework-5.5.26...
-- Running tests...
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 34 installs, 0 updates, 0 removals
  - Installing symfony/polyfill-mbstring (v1.6.0): Loading from cache
  - Installing symfony/var-dumper (v3.4.2): Loading from cache
  - Installing symfony/translation (v3.4.2): Loading from cache
  - Installing nesbot/carbon (1.22.1): Loading from cache
  - Installing hamcrest/hamcrest-php (v2.0.0): Loading from cache
  - Installing mockery/mockery (1.0): Loading from cache
  - Installing sebastian/version (2.0.1): Loading from cache
  - Installing sebastian/resource-operations (1.0.0): Loading from cache
  - Installing sebastian/object-reflector (1.1.1): Loading from cache
  - Installing sebastian/recursion-context (3.0.0): Loading from cache
  - Installing sebastian/object-enumerator (3.0.3): Loading from cache
  - Installing sebastian/global-state (2.0.0): Loading from cache
  - Installing sebastian/exporter (3.1.0): Loading from cache
  - Installing sebastian/environment (3.1.0): Loading from cache
  - Installing sebastian/diff (2.0.1): Loading from cache
  - Installing sebastian/comparator (2.1.0): Loading from cache
  - Installing doctrine/instantiator (1.1.0): Loading from cache
  - Installing phpunit/php-text-template (1.2.1): Loading from cache
  - Installing phpunit/phpunit-mock-objects (5.0.5): Loading from cache
  - Installing phpunit/php-timer (1.0.9): Loading from cache
  - Installing phpunit/php-file-iterator (1.4.5): Loading from cache
  - Installing theseer/tokenizer (1.1.0): Loading from cache
  - Installing sebastian/code-unit-reverse-lookup (1.0.1): Loading from cache
  - Installing phpunit/php-token-stream (2.0.2): Loading from cache
  - Installing phpunit/php-code-coverage (5.3.0): Loading from cache
  - Installing phpdocumentor/reflection-common (1.0.1): Loading from cache
  - Installing phpdocumentor/type-resolver (0.4.0): Loading from cache
  - Installing webmozart/assert (1.2.0): Loading from cache
  - Installing phpdocumentor/reflection-docblock (4.2.0): Loading from cache
  - Installing phpspec/prophecy (1.7.3): Loading from cache
  - Installing phar-io/version (1.0.1): Loading from cache
  - Installing phar-io/manifest (1.0.1): Loading from cache
  - Installing myclabs/deep-copy (1.7.0): Loading from cache
  - Installing phpunit/phpunit (6.5.5): Loading from cache
symfony/var-dumper suggests installing ext-intl (To show region name in time zone dump)
symfony/var-dumper suggests installing ext-symfony_debug ()
symfony/translation suggests installing symfony/config ()
symfony/translation suggests installing symfony/yaml ()
symfony/translation suggests installing psr/log (To use logging capability in translator)
sebastian/global-state suggests installing ext-uopz (*)
phpunit/phpunit suggests installing phpunit/php-invoker (^1.1)
Writing lock file
Generating autoload files
PHPUnit 6.5.5 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.2.0 with Xdebug 2.6.0alpha1
Configuration: /Users/antoniocarlos/code/TightenCo/collect/phpunit.xml

...............................................................  63 / 266 ( 23%)
............................................................... 126 / 266 ( 47%)
............................................................... 189 / 266 ( 71%)
............................................................... 252 / 266 ( 94%)
..............                                                  266 / 266 (100%)

Time: 201 ms, Memory: 8.00MB

OK (266 tests, 761 assertions)

Hi, Here a conflict with the Arrayable interface.

I have a Laravel Collection with several Tightenco collection inside.

When using toArray() on the main Laravel Collection, it doesn't touch the Tightenco ones... 😞

It's because of the \Illuminate\Contracts\Support\Arrayable and \Tightenco\Collect\Contracts\Support\Arrayable Interfaces.

Because of these sort of bugs, packages that use Tightenco/collect can't be used with Laravel anymore... 😥

Hi, it's me again! After some problems in sf projects, I've them now during a Laravel update.

In fact:

In mathieutu/exporter v2.0.0 I'm requiring tightenco/collect ^5.6 : https://github.com/mathieutu/exporter/blob/master/composer.json.

With this package in a Laravel project, I can't update laravel/framework to 5.6.4 (where the change of collect replace was done):

Problem 1
    - mathieutu/exporter 2.0.0 requires tightenco/collect ^5.6 -> satisfiable by laravel/framework[v5.6.3], illuminate/support[v5.6.0, v5.6.1, v5.6.2, v5.6.3], tightenco/collect[5.6.4.x-dev, v5.6.0, v5.6.4].
    - mathieutu/exporter 2.0.0 requires tightenco/collect ^5.6 -> satisfiable by laravel/framework[v5.6.3], illuminate/support[v5.6.0, v5.6.1, v5.6.2, v5.6.3], tightenco/collect[5.6.4.x-dev, v5.6.0, v5.6.4].
    - Can only install one of: laravel/framework[v5.6.4, v5.6.3].
    - don't install illuminate/support v5.6.0|don't install laravel/framework v5.6.4
    - don't install illuminate/support v5.6.1|don't install laravel/framework v5.6.4
    - don't install illuminate/support v5.6.2|don't install laravel/framework v5.6.4
    - don't install illuminate/support v5.6.3|don't install laravel/framework v5.6.4
    - don't install tightenco/collect 5.6.4.x-dev|don't install laravel/framework v5.6.4
    - don't install tightenco/collect v5.6.0|don't install laravel/framework v5.6.4
    - don't install tightenco/collect v5.6.4|don't install laravel/framework v5.6.4
    - Installation request for laravel/framework 5.6.4 -> satisfiable by laravel/framework[v5.6.4].
    - Installation request for mathieutu/exporter ^2.0 -> satisfiable by mathieutu/exporter[2.0.0].

If I require tightenco/collect in my root project, it's fine, and I can update. If I remove it, laravel is downgraded to 5.6.3.

Do you guys have any idea of where the problem could come from??

Thank you for your help.

Hi,

After a composer update, I have those errors in my terminal when I call shell commands: PHP Warning: Class 'Tightenco\Collect\Support\Debug\Dumper' not found in /home/kreezalid/app/vendor/tightenco/collect/src/Collect/Support/alias.php on line 18 PHP Warning: Class 'Tightenco\Collect\Support\Debug\HtmlDumper' not found in /home/kreezalid/app/vendor/tightenco/collect/src/Collect/Support/alias.php on line 18

Here are the composer update info: Package operations: 0 installs, 2 updates, 0 removals

• Updating aws/aws-sdk-php (3.67.4 => 3.67.5): Downloading (100%)
• Updating tightenco/collect (v5.6.37 => v5.7.1): Downloading (100%)

I'm using CakePHP but I think one of my dependances is using your package.

Cheers

Given that the purpose of this package is to decouple Laravel collections from the rest of Laravel so they can be used in other contexts, would it be OK to allow a superset of versions for symfony/var-dumper so that projects using Symfony 3.4 LTS (supported until late 2020) can use latest versions? This PR doesn't increase the maximal constraint on the package, but reduces the minimum constraint to 3.4, to allow use with the full stack Symfony framework at that version.

In the specific case of this package, the only method that is called is (unsurprisingly) \Symfony\Component\VarDumper\VarDumper::dump(), and the API for that method hasn't changed in any Symfony 2+ version, neither is it expected to change. So I hope you'd agree this increases interoperability without risking a break.

I really hope it's a simple mistake, but it seems that You've changed the namespace from \Illuminate to \Tightenco\Collect and made minor and bugfix releases including it.

It's a backward incompatible change which should be released as a major 6.0.0. It broke a lot of my tests in several projects. For now, I'm locking my requirement to 5.5.32.

In my global composer directory where I have my laravel valet installed, I'm getting this error. Probably it is related to this: http://prntscr.com/krlymp

And here is the full dump of the error:

Stack trace:
#0 [internal function]: {closure}(2, 'Class 'Tightenc...', '/Users/zigastrg...', 18, Array)
#1 /Users/zigastrgar/.composer/vendor/tightenco/collect/src/Collect/Support/alias.php(18): class_alias('Tightenco\\Colle...', 'Illuminate\\Supp...')
#2 /Users/zigastrgar/.composer/vendor/composer/autoload_real.php(66): require('/Users/zigastrg...')
#3 /Users/zigastrgar/.composer/vendor/composer/autoload_real.php(56): composerRequire59860c76f3932111d8d7b49da118e358('caf31cc6ec7cf22...', '/Users/zigastrg...')
#4 /Users/zigastrgar/.composer/vendor/autoload.php(7): ComposerAutoloaderInit59860c76f3932111d8d7b49da118e358::getLoader()
#5 /Users/zigastrgar/.composer/vendor/friendsofphp/php-cs-fixer/php-cs-fixer(60): require_once('/Users/zigastrg...')
#6 {main}
  thrown in /Users/zigastrgar/.composer/vendor/tightenco/collect/src/Collect/Support/alias.php on line 18

Fatal error: Uncaught ErrorException: Class 'Tightenco\Collect\Support\Debug\Dumper' not found in /Users/zigastrgar/.composer/vendor/tightenco/collect/src/Collect/Support/alias.php:18
Stack trace:
#0 [internal function]: {closure}(2, 'Class 'Tightenc...', '/Users/zigastrg...', 18, Array)
#1 /Users/zigastrgar/.composer/vendor/tightenco/collect/src/Collect/Support/alias.php(18): class_alias('Tightenco\\Colle...', 'Illuminate\\Supp...')
#2 /Users/zigastrgar/.composer/vendor/composer/autoload_real.php(66): require('/Users/zigastrg...')
#3 /Users/zigastrgar/.composer/vendor/composer/autoload_real.php(56): composerRequire59860c76f3932111d8d7b49da118e358('caf31cc6ec7cf22...', '/Users/zigastrg...')
#4 /Users/zigastrgar/.composer/vendor/autoload.php(7): ComposerAutoloaderInit59860c76f3932111d8d7b49da118e358::getLoader()
#5 /Users/zigastrgar/.composer/vendor/friendsofphp/php-cs-fixer/php-cs-fixer(60): require_once('/Users/zigastrg...')
#6 {main}
  thrown in /Users/zigastrgar/.composer/vendor/tightenco/collect/src/Collect/Support/alias.php on line 18```

Hi again! I'm sorry to be the one who open all theses issues, but as I'm working a lot with collect and Laravel for now, I'm seeing all the problems.

Again a problem due to the namespace change (and so, the composer replace) but not the fault of composer this time:

I have a regression in my project because of a Tightenco\Collect\Support\Collection::make

In fact you can reproduce easily the problem in a Laravel project:

$items = User::all();
Tightenco\Collect\Support\Collection::make($items);

The function that converts $items is this one:

 protected function getArrayableItems($items)
    {
        if (is_array($items)) {
            return $items;
        } elseif ($items instanceof self) {
            return $items->all();
        } elseif ($items instanceof Arrayable) {
            return $items->toArray();
        } elseif ($items instanceof Jsonable) {
            return json_decode($items->toJson(), true);
        } elseif ($items instanceof JsonSerializable) {
            return $items->jsonSerialize();
        } elseif ($items instanceof Traversable) {
            return iterator_to_array($items);
        }

        return (array) $items;
    }

Previously, when collect was replaced by Laravel Collections, the return value was

            return $items->all();

because $thisand $items was from the same class.

Now, because they are from different classes the value will be

            return $items->toArray();

which is not the same at all and breaks totally my package, and my project! 😅

I don't have right now a simple solution, but I definitely think that changing the package namespace was much more complicated than we thought.. 😕

Maybe, you or @adamwathan (as he uses it too in his packages, and so will have the same problems) should discuss with Taylor about a more global solution (extract definitely the collections from Laravel for example).

Thank's for your work, I'll hope we will find a solution to keep using this cool package.

Using branches & PRs means we get the benefit of CI running across all environments, not just the dev's local machine.

• [x] Make it create a branch
• [x] Drop tagging (because we can't tag until after green tests)
• [ ] Fix up the validator to actually work
• [ ] Make it create a PR using hub or whatever after pushing the PR

https://github.com/laravel/framework/pull/32478

Taylor's opened a PR to extract Collections from Support (🥳), so Collect won't be needed.

The simplest thing we could do is to just stop releasing after 8.0.

But I'm curious whether package authors who rely on Collect would prefer we make 8.x a bridge version so it's not a sudden deprecation, and whether, if we did that, we should have it continue to be a full split like it is, or if we could just require the Illuminate Collection package and then alias it to Tighten and then call it a day?