This PR is related to #12 and also to #33 proposition.

Ssn is now a singleton class in order to make validate function static like other validators does.

I also add tests that simply call generate function to verify if is not crashing. I don't know how to assert results of generate, any advice @ronanguilloux?

Method based on this article: http://www.phptherightway.com/pages/Design-Patterns.html#singleton

Please not: This is BC break for libraries that implement IsoCodes. Must be on 1.2 version at least.

Use auto-generated sources from http://i18napis.appspot.com with more countries available.

Deprecated the validateNetherlands($zipcode) calls in favor of the validate($zipcode, 'nl') so they could be removed some time (Or you would need to add methods for each country?)

This doesn't change the tests (and haven't run the tests yet). Test could perhaps be modified to verify the examples from zipex in the data, but that wouldn't be needed if the source already tested those.

• --dev is by default for almost a year
• use Travis' composer and phpunit (no need to maintain them by yourself)
• also, phpunit.xml.dist is loaded by default (if phpunit.xml not found)

I see on your README file that your NIF validator if for Spain codes (Número de Identificación Fiscal) but, stop me if I'm wrong, NIF codes are Europeans.

See here: http://ec.europa.eu/taxation_customs/taxation/tax_cooperation/mutual_assistance/tin/index_fr.htm

Are we speaking about the same NIF?

Is your NIF validator compliant with EU conventions?

Regards

Hello,

According Wikipedia, the following exception exists and should be taken in consideration: https://fr.wikipedia.org/wiki/Formule_de_Luhn#Cas_particulier

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -

Test for this card number fails on windows because a number this long can't be stored as an integer. Instead it becomes a float and when converted into string it is 6.3041E+15 instead of 6304100000000008.

In my opinion CreditCard::validate should only allow string arguments or at least throw an exception if a float is passed as parameter to prevent this error.

In a nutshell:

• composer vendor directory cache
• dist-mode for composer update
• GitHub oauth. You need to set a token on GITHUB_OAUTH_TOKEN variable. Mark it as private to secure it.
• Lowest deps mode to check composer dependencies going right.
• Some Travis optimizations for composer. Some time composer could be long to resolve and consume huge memory

I have some another optimizations idea but I'll talk about it later on another PR. ;-)

Since #24, this project require php >=5.4.

So we can now use the new array short syntax as defined on this change-log: http://php.net/manual/en/migration54.new-features.php

@stof just for advice, are you agree with that?

Regards.

The SSN validator is special. We have to instantiate it before use it for validation.

I think is for avoid code generation (generate('CA')) on each validation?

In this case, could we think about use it as a singleton class?

See here (FR): http://fr.wikipedia.org/wiki/Singleton_%28patron_de_conception%29#PHP_5

I suggest it because with this code design, I will have to instantiate it on each validation with my Symfony Validator wrapping.

Could work on it. This should be on a next major release.

PHP is required to be compiled with "--enable-bcmath" for some checks but this is not mentioned in the documentation. Please update the documentation or provide a fallback method if possible.

Thomas

| Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -

https://dvv.fi/en/reform-of-personal-identity-code New punctuation marks for personal identity codes 1 January 2023

The new punctuation marks are:

• For those born in the 2000s: B, C, D, E and F, from letter B in addition to the current letter A
• For those born in the 20th century, Y, X, W, V, U, from the letter Y in addition to the current symbol -.

DVV's assessment of the implementation schedule Situation 11/2022: According to the current estimate, personal IDs with new separators under the new separator decree will be issued for the first time in April2024. The estimate is based on the average volume of issuances from 2016 to 2021 and the estimation of future issuances. If the need for personal identity codes increases, for example, due to persons moving to Finland for work, new separators may be introduced sooner.

Previous pull requests for Finnish ID (HETU): https://github.com/ronanguilloux/IsoCodes/pull/128, https://github.com/ronanguilloux/IsoCodes/pull/130

PhoneNumber::validate("+49 171 1234567", "DE") // valid number, all ok

PhoneNumber::validate("+49 171 1234567tt", "DE") //passes validation, must be false

PhoneNumber::validate("+49 171 1234567ttttt", "DE") //catches as wrong number

package vertion: 2.3.6

Example: https://github.com/code-lts/Laravel-FCM/blob/main/.gitattributes

vendor/ronanguilloux/isocodes
├── CHANGELOG.md
├── .circleci                  <------------------ remove the folder
│   └── config.yml
├── CODE_OF_CONDUCT.md <----- remove it
├── commit.template <----- remove it
├── composer.json
├── CONTRIBUTING.md
├── .coveralls.yml <----- remove it
├── .gitignore <----- remove it
├── LICENSE
├── Makefile <----- remove it
├── .php_cs.php <----- remove it
├── phpunit.xml.dist <----- remove it
├── pre-commit <----- remove it
├── README.md
├── .scrutinizer.yml <----- remove it
├── src [...]
├── tests [...]                   <------------------ remove the folder ?
└── .travis.yml <----- remove it

6 directories, 108 files

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to increase the usage of combined operators accordingly.

diff --git a/src/IsoCodes/CreditCard.php b/src/IsoCodes/CreditCard.php
index b663322..3fd260e 100644
--- a/src/IsoCodes/CreditCard.php
+++ b/src/IsoCodes/CreditCard.php
@@ -35,7 +35,7 @@ class CreditCard implements IsoCodeInterface
             if ((($length - $i) % 2) == 0) {
                 $digit = (int) $digit * 2;
                 if ($digit > 9) {
-                    $digit = $digit - 9;
+                    $digit -= 9;
                 }
             }
             $tot += (int) $digit;
diff --git a/src/IsoCodes/Iban.php b/src/IsoCodes/Iban.php
index 4bb97c8..52d9a9b 100644
--- a/src/IsoCodes/Iban.php
+++ b/src/IsoCodes/Iban.php
@@ -110,7 +110,7 @@ class Iban implements IsoCodeInterface
             return false;
         }
         // Fetch needed string for validation
-        $check = $check.substr($iban, 0, 4);
+        $check .= substr($iban, 0, 4);
         // Replace characters by decimal values
         $check = str_replace(
             ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z'],
diff --git a/src/IsoCodes/Iswc.php b/src/IsoCodes/Iswc.php
index 9ead1a7..82a8394 100644
--- a/src/IsoCodes/Iswc.php
+++ b/src/IsoCodes/Iswc.php
@@ -28,7 +28,7 @@ class Iswc extends Luhn implements IsoCodeInterface
         $sum = 1;
 
         for ($i = 1; $i <= 9; ++$i) {
-            $sum = $sum + $i * (int) $iswc[$i];
+            $sum += $i * (int) $iswc[$i];
         }
 
         $rem = $sum % 10;

This cause incompatible signature errors on PHP >=7.

We may also set the strict typing signature for the main interface, but it should be done on a new major release as it's a breaking change for implementation.