I am getting this error while seeding the countries

ErrorException: sizeof(): Parameter must be an array or an object that implements Countable in ../../vendor/webpatser/laravel-countries/src/Webpatser/Countries/Countries.php:43

If I remove the sizeof check it works.

//Get the countries from the JSON file
// if (sizeof($this->countries) == 0){
    $this->countries = json_decode(file_get_contents(__DIR__ . '/Models/countries.json'), true);
//}

//Return the countries
return $this->countries;

initializing protected $countries = []; with empty array can fix it.

I am running PHP 7.2

When I run php artisan migrate --seed or php artisan db:seed --class=CountriesSeeder, an error show to my terminal and no data inserted into the database:

In Countries.php line 43:
  sizeof(): Parameter must be an array or an object that implements Countable

Exception as follows:

[RuntimeException]
Error Output: PHP Fatal error: Call to undefined method Webpatser\Countries\CountriesServiceProvider::publishes() in /Users/rgvdev1/Documents/workspace/Kepler Workspace/Merchant Dashboard/vendor/webpatser/laravel-countries/src/Webpatser/Countries/CountriesServiceProvider.php on line 29

When i run php artisan countries:migration i get Method Webpatser\Countries\MigrationCommand::handle() does not exist on the console i'm using Laravel 5.5

I think it may be worthwhile to support ISO 639 language codes and maybe match them to country codes. I think geonames does it https://github.com/ipalaus/geonames/wiki http://download.geonames.org/export/dump/countryInfo.txt

Hello Dear @webpatser First of all thank you for this awesome package, I've just one question: From where have you obtained countries' region & subregion codes? I'm curios if there's some sort official reference or may be ISO list?

Hi I have this error in composer after update to the latest version:

PHP Parse error: syntax error, unexpected '[' in ... /src/commands/MigrationCommand.php on line 94

$migrationFiles is supposed to be an array, isn't it ? I can send you a pull request, but maybe it's easy for you to solve it directly.... Whatever you want.

Thank you for the bundle anyway :)

Best regards

Is there a particular reason why you opted to use the VARCHAR data type for columns that will have values of identical length?

The columns in question:

• country_code
• iso_3166_2
• iso_3166_3
• region_code
• sub_region_code

Changing the columns to CHAR will offer multiple performance improvements and is generally considered a best practice especially if you consider the fact that they are likely to be indexed.

Having the ctor load and parse the JSON takes up a large amount of memory and in my current setup I get the following

[11-May-2014 22:20:44 UTC] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 32 bytes) in /vagrant/www/vendor/webpatser/laravel-countries/src/Webpatser/Countries/Countries.php on line 30

Using the JSON as the main data source would also mean that in the getList() function if a user added a new country into the database it wouldn't be picked up. The comment for $this->countries also states that it should be a string with the path to the directory containing country data as where the code uses it as an array with all the data.

In certain random times I am having the following error:

sizeof(): Parameter must be an array or an object that implements Countable```

This fixes this issue by setting the value also when `$this->countries` is unset|null

As PHP 7.2, an E_WARNING will be emitted when attempting to count() non-countable types (this includes the sizeof() alias function). ^[source]

Since null is a non-countable type, trying to use this bundle with bleeding PHP will throw a error when seeding database.

This pull request closes issue https://github.com/webpatser/laravel-countries/issues/79.

I found an issue with the countries:migration laravel command excecution. I have fixed it chanching the seeds forder for seeders folder name. In the /vendor/webpatser/laravel-countries/src/commands/MigrationCommand.php

$seeder_file = $this->laravel->path."/../database/seeders/CountriesSeeder.php";

I think this could be a laravel version case. but is easy to fix it.

Thxs!

The path to the CountriesSeeders in webpatser/laravel-countries/src/MigrationCommand on line 119 is obsolete. Please change $seeder_file = $this->laravel->path."/../database/seeds/CountriesSeeder.php"to $seeder_file = $this->laravel->path."/../database/seeders/CountriesSeeder.php"