Basically the {{ is used by some other front-end systems like vuejs.

I know we can escape the {{, but in case I don't need the sytax itself.

Do you think it is a good idea ? I have looked into the code, but seems the current compiler is hard coded inside the TemplateLocator .

Hi ! Nice and interesting lib :) I try to use Qiq but I think there is a little problem : {{= $this->name}} work but not {{= $name}} in template (Undefined variable $name).

You can easily reproduce this behavior modifying the tests/templates/index.php with {{= hello($name)}}. It work when I use the render() method because I pass string $__NAME__, array $__VARS__ = [] parameters by hand ( $actual = ($this->template)->render('index', ['name' => 'Index']);) but not with the __invoke because $__VARS__ parameter is not pass in render().

I propose something like this to resolve this problem :

// in src/TemplateCore.php
  public function __invoke() : string
  {
      $view = $this->getView();
      $data = (array) $this->getData();
      $this->content = ($view === null) ? '' : $this->render($view, $data);
      $layout = $this->getLayout();

      if ($layout === null) {
          return $this->content;
      }

      return $this->render($layout, $data);
  }

Alternative can be to merge $__VARS__ with $this->getData() in Template#render() method.

I can make a PR if you want !

@koriym @harikt and anyone else interested:

~~This branch https://github.com/qiqphp/qiq/tree/1.x-stan-poc is a proof-of-concept for enabling static analysis on Qiq template files.~~ Here is a more limited/restricted POC branch, with only the Container and assigned-variable differences. https://github.com/qiqphp/qiq/tree/1.x-stan-poc-limited

~~The diff is at https://github.com/qiqphp/qiq/compare/1.x-stan-poc?expand=1~~ Limited/restricted diff here https://github.com/qiqphp/qiq/compare/1.x-stan-poc-limited?expand=1

It solves a couple of problems raised by @koriym and others, namely that of helper-object creation through containers, and of template analysis. It is a substantial BC break and will warrant a 2.x release if we go with it.

tl;dr:

• HelperLocator is now a ContainerInterface implementation
• You don't register helpers, you create traits for them, and use those traits inside a Template class of your own
• Assigned variables are $foo and not $this->foo
• Use docblocks in the template file to enable static analysis

Look to the README-STAN.md file for detailed information.

Please let me know what you think, if you have alternative implementation ideas, if it's dumb and everything is fine as it is now, etc.

Thanks, and Happy New Year!

Can we move the render method from Template class to TemplateCore ?

Any specific reason for not keeping it inside TemplateCore .

This probably is also related to discussion https://github.com/qiqphp/qiq/issues/8 different compiler, passing additional factories to helperlocator if https://github.com/qiqphp/qiq/pull/9 is merged etc.

This PR will allow helper factories that are currently pre-registered all helper with the service locator to be registered with autoload on demand.

Users can use the helpers by simply creating their own helper files without touching any code for initialization.

This would be useful, for example, when using the same set of custom helpers in several applications.

<?php
namespace Qiq\Helper;

class MyRot13 extends Helper
{
    public function __invoke(string $input) : string
    {
        // ...
       return $output;
    }
}

( We need to set the autoload in composer.json so that this class will be autoloaded properly in the user application.)