Twig 2.0 will be released really soon now (hopefully by the end of the year). So, it's time again to reconsider the minimum PHP version we want to support.

I would like to bump it to PHP 5.6 for the following reasons:

• PHP 5.5 is not supported anymore (not even security fixes now);

• the latest Ubuntu LTS is already using PHP 7!

• #2228 allows to improve performance significantly and having this without the ifstatement makes the optimization more interesting.

What do you think?

Everything is explained in the updated documentation.

Basically, it gives more flexibility when it comes to manage many templates that are not necessarily related (think frontent vs backend for instance, or templates from different Symfony bundles, ...). It is useful if, for each namespace, you need to look for templates in different directories. This implementation would probably be enough to replace the current Symfony bundle template paths, with more flexibility and less restrictions.

Feedback is more than welcome. One thing I'm not sure about is the # separator between the namespace and the template path. Is it the best choice? We need a character that is not used in filesystem paths, so good candidates are: @, !, %, $, *, ;, ?.

Some immediate benefits: give the same template flexibility that we have in Symfony to other frameworks using Twig like Silex. Another benefit would be the ability to share template between Symfony and other frameworks like Twig (more on a proof of concept later).

Hello,

since f2e5f40 I get An exception has been thrown during the rendering of a template ("Notice: Undefined offset: 0"). which makes it impossible to display any template. The problem comes from the modification made in lib/Twig/Profiler/NodeVisitor/Profiler.php.

I don't have a solution nor an idea as to why it crashes, I hope someone can fix this quickly.

base.html.twig:

{% import "macro.html.twig" as macro %}

{% block content '' %}

child.html.twig:

{% extends 'base.html.twig' %}

{% block content %}
    {{ macro.foo() }}
{% endblock %}

Warning:

Deprecated: Using the dot notation on an instance of __CLASS is deprecated since version 1.28 and won't be supported anymore in 2.0.

Is this expected behavior? There is no warning, when I import the macro in child.html.twig again.

There is a bug when using the PHP extension and trying to access a public property of an object implementing the \ArrayAccess interface.

Using the following object:

<?php

class TwigTest implements \ArrayAccess
{
    public $vars;
    private $data;

    public function __construct()
    {
        $this->vars = array('foo' => 1);
        $this->data = array('bar' => 1);
    }

    public function offsetExists($offset)
    {
        return array_key_exists($offset, $this->data);
    }

    public function offsetGet($offset)
    {
        if (!$this->offsetExists($offset)) {
            throw new \RuntimeException("Offset '$offset' does not exist !");
        }

        return $this->data[$offset];
    }

    public function offsetSet($offset, $value)
    {
        $this->data[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        unset($this->data[$offset]);
    }
}

and trying to access the vars property from a template:

<?php
// Controller    
    /**
     * @Template
     */
    public function testAction()
    {
        return array(
            'view'      => new TwigTest(),
        );
    }

{# test.html.twig #}

{{ dump(view.vars) }}

The error message is: Twig_Error_Runtime: An exception has been thrown during the rendering of a template ("Offset 'vars' does not exist !")

It means that the code is using the \ArrayAccess interface to get the value when it should directly access the public property on the object.

This error is caused by the PHP extension (it does not occur when the extension is not enabled). I have managed to narrow down the root cause to the TWIG_PROPERTY() call in the extension.

If you look at the body of the function, you'll see calls to TWIG_GET_ARRAY_ELEMENT which should be the root cause of the issue. We should only be returning the value of the property at this place as it is done by the PHP code.

I don't know the internals of PHP enough in order to come with a proper fix so any help with debugging this would be much appreciated.

Related issues:

• symfony/symfony#5064
• #668

I saw Twig extension is now tested against PHP7 but compile failed :

phpize-7.0.0
./configure --with-php-config=/usr/bin/php-config-7.0.0 --enable-twig
make

Leads to :

make
/bin/sh /usr/src/build/php/Twig/ext/twig/libtool --mode=compile cc  -I. -I/usr/src/build/php/Twig/ext/twig -DPHP_ATOM_INC -I/usr/src/build/php/Twig/ext/twig/include -I/usr/src/build/php/Twig/ext/twig/main -I/usr/src/build/php/Twig/ext/twig -I/usr/include/php/7.0.0/php -I/usr/include/php/7.0.0/php/main -I/usr/include/php/7.0.0/php/TSRM -I/usr/include/php/7.0.0/php/Zend -I/usr/include/php/7.0.0/php/ext -I/usr/include/php/7.0.0/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /usr/src/build/php/Twig/ext/twig/twig.c -o twig.lo
mkdir .libs
 cc -I. -I/usr/src/build/php/Twig/ext/twig -DPHP_ATOM_INC -I/usr/src/build/php/Twig/ext/twig/include -I/usr/src/build/php/Twig/ext/twig/main -I/usr/src/build/php/Twig/ext/twig -I/usr/include/php/7.0.0/php -I/usr/include/php/7.0.0/php/main -I/usr/include/php/7.0.0/php/TSRM -I/usr/include/php/7.0.0/php/Zend -I/usr/include/php/7.0.0/php/ext -I/usr/include/php/7.0.0/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /usr/src/build/php/Twig/ext/twig/twig.c  -fPIC -DPIC -o .libs/twig.o
/usr/src/build/php/Twig/ext/twig/twig.c:23:40: error: ext/standard/php_smart_str.h: No such file or directory
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_ARRAY_KEY_EXISTS':
/usr/src/build/php/Twig/ext/twig/twig.c:100: warning: passing argument 2 of 'zend_hash_exists' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:157: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:100: error: too many arguments to function 'zend_hash_exists'
/usr/src/build/php/Twig/ext/twig/twig.c:102: error: 'IS_BOOL' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:102: error: (Each undeclared identifier is reported only once
/usr/src/build/php/Twig/ext/twig/twig.c:102: error: for each function it appears in.)
/usr/src/build/php/Twig/ext/twig/twig.c:110: warning: passing argument 2 of 'zend_symtable_exists' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:372: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:110: error: too many arguments to function 'zend_symtable_exists'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_INSTANCE_OF_USERLAND':
/usr/src/build/php/Twig/ext/twig/twig.c:128: warning: passing argument 1 of 'zend_lookup_class' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_execute.h:43: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:128: error: too many arguments to function 'zend_lookup_class'
/usr/src/build/php/Twig/ext/twig/twig.c:128: warning: comparison between pointer and integer
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_GET_ARRAYOBJECT_ELEMENT':
/usr/src/build/php/Twig/ext/twig/twig.c:141: warning: passing argument 1 of 'zend_call_method' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_interfaces.h:41: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:141: warning: passing argument 6 of 'zend_call_method' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_interfaces.h:41: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:143: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_ISSET_ARRAYOBJECT_ELEMENT':
/usr/src/build/php/Twig/ext/twig/twig.c:164: warning: passing argument 1 of 'zend_call_method' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_interfaces.h:41: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:164: warning: passing argument 6 of 'zend_call_method' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_interfaces.h:41: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:166: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:175: error: 'IS_BOOL' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_CALL_USER_FUNC_ARRAY':
/usr/src/build/php/Twig/ext/twig/twig.c:206: warning: passing argument 2 of 'zend_hash_get_current_data_ex' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:169: note: expected 'HashPosition *' but argument is of type 'void **'
/usr/src/build/php/Twig/ext/twig/twig.c:206: error: too many arguments to function 'zend_hash_get_current_data_ex'
/usr/src/build/php/Twig/ext/twig/twig.c:214:36: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c:214: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:217: error: incompatible types when assigning to type 'zval' from type 'struct zval *'
/usr/src/build/php/Twig/ext/twig/twig.c:220: error: 'zend_fcall_info' has no member named 'object_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:224: error: 'zend_fcall_info' has no member named 'retval_ptr_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:226: warning: assignment from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_CALL_BOOLEAN':
/usr/src/build/php/Twig/ext/twig/twig.c:248: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_GET_STATIC_PROPERTY':
/usr/src/build/php/Twig/ext/twig/twig.c:261: warning: assignment makes pointer from integer without a cast
/usr/src/build/php/Twig/ext/twig/twig.c:263: warning: passing argument 2 of 'zend_std_get_static_property' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_object_handlers.h:165: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:263: error: too many arguments to function 'zend_std_get_static_property'
/usr/src/build/php/Twig/ext/twig/twig.c:263: warning: assignment from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_GET_ARRAY_ELEMENT_ZVAL':
/usr/src/build/php/Twig/ext/twig/twig.c:284: warning: passing argument 2 of 'zend_hash_find' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:152: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:284: error: too many arguments to function 'zend_hash_find'
/usr/src/build/php/Twig/ext/twig/twig.c:287: error: 'IS_BOOL' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:291: error: too many arguments to function 'zend_hash_index_find'
/usr/src/build/php/Twig/ext/twig/twig.c:295: warning: passing argument 2 of 'zend_symtable_find' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:348: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:295: error: too many arguments to function 'zend_symtable_find'
/usr/src/build/php/Twig/ext/twig/twig.c:316:42: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_GET_ARRAY_ELEMENT':
/usr/src/build/php/Twig/ext/twig/twig.c:316: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:322: warning: passing argument 2 of 'zend_symtable_find' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:348: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:322: error: too many arguments to function 'zend_symtable_find'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_PROPERTY':
/usr/src/build/php/Twig/ext/twig/twig.c:334: error: too few arguments to function 'object->value.obj->handlers->read_property'
/usr/src/build/php/Twig/ext/twig/twig.c:338: error: 'zend_executor_globals' has no member named 'uninitialized_zval_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:375:40: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_PROPERTY_CHAR':
/usr/src/build/php/Twig/ext/twig/twig.c:375: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:390:31: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_CALL_S':
/usr/src/build/php/Twig/ext/twig/twig.c:390: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:394:34: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c:397: error: incompatible types when assigning to type 'zval' from type 'struct zval *'
/usr/src/build/php/Twig/ext/twig/twig.c:400: error: 'zend_fcall_info' has no member named 'object_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:404: error: 'zend_fcall_info' has no member named 'retval_ptr_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:406: warning: assignment from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c:411: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:415: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_CALL_SB':
/usr/src/build/php/Twig/ext/twig/twig.c:425: error: 'IS_BOOL' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:428: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:446:34: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_CALL_ZZ':
/usr/src/build/php/Twig/ext/twig/twig.c:446: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:449: error: incompatible types when assigning to type 'zval' from type 'struct zval *'
/usr/src/build/php/Twig/ext/twig/twig.c:452: error: 'zend_fcall_info' has no member named 'object_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:456: error: 'zend_fcall_info' has no member named 'retval_ptr_ptr'
/usr/src/build/php/Twig/ext/twig/twig.c:458: warning: assignment from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c:468: error: 'IS_BOOL' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:470: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_NEW':
/usr/src/build/php/Twig/ext/twig/twig.c:485: warning: passing argument 1 of 'zend_lookup_class' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_execute.h:43: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:485: error: too many arguments to function 'zend_lookup_class'
/usr/src/build/php/Twig/ext/twig/twig.c:485: warning: comparison between pointer and integer
/usr/src/build/php/Twig/ext/twig/twig.c:489: error: lvalue required as left operand of assignment
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'twig_add_array_key_to_string':
/usr/src/build/php/Twig/ext/twig/twig.c:506: error: 'smart_str' has no member named 'len'
/usr/src/build/php/Twig/ext/twig/twig.c:510: error: 'zend_hash_key' has no member named 'nKeyLength'
/usr/src/build/php/Twig/ext/twig/twig.c:515: error: 'zend_hash_key' has no member named 'arKey'
/usr/src/build/php/Twig/ext/twig/twig.c:515: error: 'zend_hash_key' has no member named 'nKeyLength'
/usr/src/build/php/Twig/ext/twig/twig.c:515: warning: passing argument 3 of 'php_addcslashes' from incompatible pointer type
/usr/include/php/7.0.0/php/ext/standard/php_string.h:127: note: expected 'char *' but argument is of type 'int *'
/usr/src/build/php/Twig/ext/twig/twig.c:515: error: too many arguments to function 'php_addcslashes'
/usr/src/build/php/Twig/ext/twig/twig.c:515: warning: assignment from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c:516: warning: assignment makes pointer from integer without a cast
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_IMPLODE_ARRAY_KEYS':
/usr/src/build/php/Twig/ext/twig/twig.c:528: warning: excess elements in struct initializer
/usr/src/build/php/Twig/ext/twig/twig.c:528: warning: (near initialization for 'collector')
/usr/src/build/php/Twig/ext/twig/twig.c:531: warning: passing argument 2 of 'zend_hash_apply_with_arguments' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:132: note: expected 'apply_func_args_t' but argument is of type 'int (*)(void *, int,  struct __va_list_tag *, struct zend_hash_key *)'
/usr/src/build/php/Twig/ext/twig/twig.c:534: error: 'smart_str' has no member named 'c'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_RUNTIME_ERROR':
/usr/src/build/php/Twig/ext/twig/twig.c:551: warning: passing argument 1 of 'zend_lookup_class' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_execute.h:43: note: expected 'struct zend_string *' but argument is of type 'char *'
/usr/src/build/php/Twig/ext/twig/twig.c:551: error: too many arguments to function 'zend_lookup_class'
/usr/src/build/php/Twig/ext/twig/twig.c:551: warning: comparison between pointer and integer
/usr/src/build/php/Twig/ext/twig/twig.c:570:69: error: macro "ZVAL_STRINGL" passed 4 arguments, but takes just 3
/usr/src/build/php/Twig/ext/twig/twig.c:570: error: 'ZVAL_STRINGL' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:571:33: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c:571: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:575:79: error: macro "ZVAL_STRINGL" passed 4 arguments, but takes just 3
/usr/src/build/php/Twig/ext/twig/twig.c:576: warning: passing argument 2 of 'call_user_function' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_API.h:469: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:581: warning: passing argument 2 of 'call_user_function' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_API.h:469: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:581: warning: passing argument 6 of 'call_user_function' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_API.h:469: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:583: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:584: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:585: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:586: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'TWIG_GET_CLASS_NAME':
/usr/src/build/php/Twig/ext/twig/twig.c:597: error: 'zend_uint' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:597: error: expected ';' before 'class_name_len'
/usr/src/build/php/Twig/ext/twig/twig.c:603: error: 'class_name_len' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'twig_add_method_to_class':
/usr/src/build/php/Twig/ext/twig/twig.c:624: warning: passing argument 1 of 'strlen' from incompatible pointer type
/usr/include/string.h:397: note: expected 'const char *' but argument is of type 'struct zend_string *'
/usr/src/build/php/Twig/ext/twig/twig.c:625: warning: passing argument 1 of '_estrndup' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_alloc.h:81: note: expected 'const char *' but argument is of type 'struct zend_string *'
/usr/src/build/php/Twig/ext/twig/twig.c:628: error: too many arguments to function 'add_assoc_stringl_ex'
/usr/src/build/php/Twig/ext/twig/twig.c:649:116: error: macro "zend_unmangle_property_name" passed 4 arguments, but takes just 3
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'twig_add_property_to_class':
/usr/src/build/php/Twig/ext/twig/twig.c:649: error: 'zend_unmangle_property_name' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:654:50: error: macro "add_assoc_string" passed 4 arguments, but takes just 3
/usr/src/build/php/Twig/ext/twig/twig.c:654: error: 'add_assoc_string' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'twig_add_class_to_cache':
/usr/src/build/php/Twig/ext/twig/twig.c:664: warning: assignment makes pointer from integer without a cast
/usr/src/build/php/Twig/ext/twig/twig.c:673: warning: passing argument 2 of 'zend_hash_apply_with_arguments' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:132: note: expected 'apply_func_args_t' but argument is of type 'int (*)(void *, int,  struct __va_list_tag *, struct zend_hash_key *)'
/usr/src/build/php/Twig/ext/twig/twig.c:674: warning: passing argument 2 of 'zend_hash_apply_with_arguments' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_hash.h:132: note: expected 'apply_func_args_t' but argument is of type 'int (*)(void *, int,  struct __va_list_tag *, struct zend_hash_key *)'
/usr/src/build/php/Twig/ext/twig/twig.c: In function 'zif_twig_template_get_attributes':
/usr/src/build/php/Twig/ext/twig/twig.c:752: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:831: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:872: warning: passing argument 1 of 'zval_get_type' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_types.h:312: note: expected 'const struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:872: warning: initialization from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c:872: warning: passing argument 1 of 'zval_get_type' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_types.h:312: note: expected 'const struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:872: warning: passing argument 1 of '_convert_to_string' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_operators.h:242: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:876: warning: passing argument 1 of 'zval_get_type' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_types.h:312: note: expected 'const struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:876: warning: initialization from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c:876: warning: passing argument 1 of 'zval_get_type' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_types.h:312: note: expected 'const struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:876: warning: passing argument 1 of '_convert_to_string' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_operators.h:242: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:881: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:1032:33: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/usr/src/build/php/Twig/ext/twig/twig.c:1032: error: 'ZVAL_STRING' undeclared (first use in this function)
/usr/src/build/php/Twig/ext/twig/twig.c:1036: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:1056: warning: passing argument 1 of 'TWIG_INSTANCE_OF' from incompatible pointer type
/usr/src/build/php/Twig/ext/twig/twig.c:114: note: expected 'struct zval *' but argument is of type 'struct zend_object *'
/usr/src/build/php/Twig/ext/twig/twig.c:1086: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:1088: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
/usr/src/build/php/Twig/ext/twig/twig.c:1096: warning: passing argument 1 of '_zval_ptr_dtor' from incompatible pointer type
/usr/include/php/7.0.0/php/Zend/zend_variables.h:111: note: expected 'struct zval *' but argument is of type 'struct zval **'
make: *** [twig.lo] Error 1

At Sensio, we manage websites with many mostly-static pages that share almost the same structure (with different content of course), but with some subtle differences. After trying many different possibilities (external templates, inheritance, macros, and some ugly ones that I won't even tell you about ;)) to structure our templates, we came to the conclusion that we needed a new concept.

This new concept is implemented via a new tag, inline, which I want to include in Twig 1.8 (not for the upcoming 1.7 which is due this week). But before merging this code into master, I want to gather some feedback from the community. One of my questions being: Will you use this new possibility?

I won't tell you more here as the tag is fully documented in the diff.

In a CSS selector, you can easily check if a value start with/ends with/contains something:

[att ^= val] – the “begins with” selector
[att $= val] – the “ends with” selector
[att *= val] – the “contains” selector

In the new Symfony ExpressionLanguage component, there is also two operators (based on Perl) to check if a value matches something:

attr =~ /regex/  {# regex #}
attr !~ /regex/  {# not regex #}

As you can see, the = sign is not at the same place in both examples.

Another way to provide the same feature would be to add tests instead of operators:

attr is startingwith(val)
attr is endingwith(val)
attr is containing(val)
attr is matching(regex)

attr is not startingwith(val)
attr is not endingwith(val)
attr is not containing(val)
attr is not matching(regex)

So, here are my questions:

• Any interest in having this feature in Twig Core extension? or in a new extension in core? or in a new extension in Twig-extensions? or is that just too much?
• Would it be better to have the feature implemented as operators (to be consistent with CSS selectors) or tests (probably easier to read/understand)?

Note: If we were to implement this feature in Twig as tests, we would replace the Perl regex style operators in the Symfony component with the matching test instead.

Thoughts?

I updated vendors, and only update version twig.

 - Removing twig/twig (1.x-dev 460712d)
  - Installing twig/twig (1.x-dev 04ef7a1)
    Loading from cache

But now I get the following error:

FatalErrorException in Environment.php line 17: Error: Cannot redeclare class Twig_Environment

I cleared cache... but the error continue... I did a compare two commits... but I dont see nothing unusual...

https://github.com/twigphp/Twig/compare/460712d...04ef7a1#diff-d4416d290253c72cec40c63f54354b16

any idea ?

This is my composer

	"require" : {
		"php" : "^5.6|^7.0",
		"ext-mcrypt" : "*",
		"twig/extensions" : "^1.4",
		"sensio/framework-extra-bundle" : "~3.0",
		"sensio/generator-bundle" : "~3.0",
		"symfony/assetic-bundle": "2.8.1",
		"incenteev/composer-parameter-handler" : "~2.0",
		"twbs/bootstrap" : "dev-master",
		"knplabs/knp-paginator-bundle" : "dev-master",
		"craue/formflow-bundle" : "2.1.8",
		"shtumi/useful-bundle" : "dev-master",
		"sonata-project/formatter-bundle" : "2.3.2",
		"sonata-project/doctrine-extensions" : "1.0.2",
		"frequence-web/contact-bundle" : "*",
		"jms/serializer-bundle" : "^1.1",
        "sylius/sylius": "1.0.0-alpha.2",
		"presta/sitemap-bundle" : "~1.3@dev",
		"beelab/recaptcha2-bundle" : "1.2.1",
		"dizda/cloud-backup-bundle" : "^3.2",
		"aws/aws-sdk-php" : "2.8.24",
		"lexik/maintenance-bundle" : "2.1.1",
		"hwi/oauth-bundle" : "0.3.x",
		"friendsofsymfony/rest-bundle" : "1.8.x",
		"crevillo/payum-redsys" : "^1.0",
		"payum/paypal-express-checkout-nvp" : "^1.3",
		"php-http/guzzle6-adapter" : "^1.1",
		"oyejorge/less.php": "v1.7.0.10",
		"doctrine/doctrine-cache-bundle": "^1.3",
		"predis/predis": "^1.1",
		"snc/redis-bundle": "^2.0",
		"knplabs/knp-gaufrette-bundle": "^0.3.0",
		"liip/imagine-bundle": "1.7.2",
		"phpdocumentor/reflection-docblock": "2.0.4"
	},
	"require-dev" : {
		"raulfraile/ladybug-bundle" : "~1.0",
		"behat/behat" : "~3.0",
		"behat/symfony2-extension" : "~2.0@dev",
		"behat/mink-extension" : "~2.0@dev",
		"behat/mink-browserkit-driver" : "~1.2@dev",
		"behat/mink-selenium2-driver" : "@dev",
		"behat/mink" : "~1.6@dev",
		"fzaninotto/faker" : "~1.2",
		"phpunit/phpunit" : "<=5.7",
		"visithor/visithor-bundle" : "^0.1.0@dev",
		"michaelmoussa/doctrine-qbmocker": "^0.12.0"
	},

I have a test that I can use as follows:

    {% if app.user is user_that_has_more_than_one_partner %}

This is verbose, and I was wondering if it might not make more sense to create a has keyword that triggers a test like is does. That way, we could use:

    {% if app.user has more_than_one_partner %}

Since has typically returns a boolean response, I would consider this useful in many more instances.

I didn't find any discussion about this, neither issues.

What about adding to Twig core ests about the type of variable?

It could be achieved in various way.

1) many tests like:

{% if var is string %}

Looking at PHP gettype() function, I would suggest:

{% if var is boolean %}
{% if var is integer %}
{% if var is double %}
{% if var is string %}
{% if var is array %}
{% if var is object %}
{% if var is resource %}

2) a new filter:

{% var | type %}

| type filter would return a value specified in PHP gettype() function, letting it possible to use:

{% if var | type is sameas('string') %}
{% if var | type is sameas('array') %}
...

3) a new comparison operator:

    {% if var is type of 'string' %}

and

    {% if var is not type of 'string' %}

I don't know which is preferable: 2) lets know the type of a var independently by being in a if statement 3) is more elegant but ca be used only in a if

what do you think? maybe can be implemented both 2) and 3), they would be redundant only partially

When an error occures we currently get the message e.g. "An exception has been thrown during the rendering of a template ("Warning: Undefined array key "select"")."

The problem is, that we don't know in which file and where the error occured so it is very hard to find the "cause" of the problem. If we add the File and Line it is quite easy to find the problem:

I am looking for a way to shim unknown tags from a loaded Twig file, while preserving internal nodes available to the parser/walker.

Are there code examples of how to use registerUndefinedTokenParserCallback()? It's rather trivial to shim with registerUndefinedFunctionCallback() and registerUndefinedFilterCallback(), but I have not found a way to skip unknown tags.

This code works for functions and filters, i.e. $env->registerUndefinedFunctionCallback(shimTwig(TwigFunction::class))

    function shimTwig(string $type) {
        return function ($name) use ($type) {
            return new $type($name);
        };
    }

Example usage:

<!-- button.html.twig -->
{# required #}
{%- set text = text -%}

{# optional #}
{%- set id = id|default(null) -%}
{%- set skin = skin|default('primary') -%}
{%- set type = type|default('button') -%}
{%- set disabled = disabled|default(false) -%}
{%- set href = href|default(null) -%}

{% set attributes = {
    'id': id,
    'class': html_classes(
        'c-button',
        {
            'c-button--primary': skin == 'primary',
            'c-button--secondary': skin == 'secondary',
            'c-button--borderless': skin == 'borderless',
        },
    ),
    'href': href,
    'type': not href ? type : null,
    'disabled': disabled,
} %}

{% set tag = href ? 'a' : 'button' %}

<{{ tag }} {{ attributes|html_attributes }}>
    {{- text -}}
</{{ tag }}>

TODO

• [x] Escape Value
• [ ] Add Test Case

Following this tweet: https://twitter.com/ramsey/status/1561894460560138241, this PR adds the configuration options for commonmark to the twig-extra-bundle.

The configuration is added to the LeagueCommonMarkConverterFactory and in turn injected in the CommonMarkConverter. This way a user can provide the configuration for usage inside twig.

I'm not sure if adding the configuration inside the extension is the way to go.

Hope this helps out at least @ramsey :-)

Added ignoreExtraKeys to be somewhat future proof in case extra configuration is added later on, and also to be able to provide de configuration for extensions.

In our project (Craft CMS) we have some common html patterns, which would ideally be wrapped around user content based on a "style" selection. E.g. an image gallery which either appears as slides or as thumbnails based on the surrounding html.

For this purpose we would like to create partials, which contain the different patterns / surrounding html. Ideally we would include the patterns AROUND the user generated content.

There are multiple ways to handle this with TWIG, like

• using include and pass the content as a variable
• using embed and passing the content as a block
• using apply and a special wrapincfilter (wrap-include) we created as extension, which workarounds that requirement:

The main file:

{% apply wrapincfilter('wrapinc-include', {class: 'turbo'}) %}
    This is wrapped. Today's date: {{ 'now'|date('d.m.Y') }}
{% endapply %}

wrapinc-include:

<div class="{{ class }}">
    {{ _wrapped }}
</div>

• But by far the nicest way for us would be this:

{% include 'wrapinc-include' with {class: 'turbo'} %}
This is wrapped. Today's date: {{ 'now'|date('d.m.Y') }}
{% endinclude %}

The wrapped content should be provided as some reserved-name variable (or any other best practice) to the included file.

Conclusion: The Feature Request is: give {% include %} an optional {% endinclude %}

I'm using the twig extra bundle's markdown_to_html filter on Symfony 6.1 with League/CommonMark as the markdown parser library.

The library has a few configuration options that can be passed to the CommonMarkConverter constructor and cannot be adjusted after the CommonMarkConverter object has been constructed. See https://commonmark.thephpleague.com/2.3/configuration/

Currently however, the LeagueCommonMarkConverterFactory class seems to call the CommonMarkConverter without any parameters: https://github.com/twigphp/Twig/blob/3cefebac2bdc754031578a50732dd7ffdd09bfec/extra/twig-extra-bundle/LeagueCommonMarkConverterFactory.php#L34

Is there therefore currently no simple way to pass configuration to the library or have I missed something obvious?

I have been able to bypass the factory class by manually declaring the CommonMarkConverter constructor arguments in the services.yaml file as such:

League\CommonMark\CommonMarkConverter:
    arguments:
        $config: {allow_unsafe_links: false}

twig.markdown.league_common_mark_converter:
    alias: League\CommonMark\CommonMarkConverter

However as this bypasses the Factory class I then lose the capability of including any CommonMark extensions.