A server software for Minecraft: Bedrock Edition in PHP

it said this boost server performance 20 %, so i copies changes to pmmp

( not tested yet, please merge so i can download src zip )

i think it fixed entity movement leak

Issue description

https://forums.pmmp.io/threads/weird-block-glitch-on-interact.4658/#post-44516

Steps to reproduce the issue

1. generate a new world
2. TP to somewhere not generated yet
3. click blocks around you and see if they vanish

OS and versions

• PocketMine-MP: 67a576722c778939baba5274fd9ec797588409fd
• PHP: 7.2.0
• Server OS: win

Issue description

The server freezes without cause and other errors in the unloading of the world. Another strange thing is that the process no longer exists.

OS and versions

• PocketMine-MP: 41592a04b7d0124d155ea6d99be8f11fe14d1de1
• PHP: 7.2.1
• Server OS: Linux Debian 8.6 jessie

Plugins

DevTools v1.12.7, ModalFormsAPI v1, clans v1, quests v1, DonateCases v1, RegionGuard v1.0.0, area v1, Kits v1.0.0, Shop v1, Economy v1, MineReset v3, PurePerms v1.4.0-INDEV, Evaluator v0.0.1, Horses v1.0.0, ToyBox v1, API v1.0.0, PureChat v1.4.0

Issue description

On both PocketMine-MP_1.6.1dev-73_794ff643_API-2.1.0 and PocketMine-MP_1.6.1dev-76_8214e50b_API-2.1.0, (Windows 10 Pro) after two or more hours of operation, unattended with no players in the game, upon returning to the console there is no response to commands. The game is still functioning, players may login and the world responds normally. However, at the console (the server terminal window), commands such as "list" or "version" are ignored. Characters typed appear on the screen, but without effect. Ctrl-C is recognized, terminating the program.

Steps to reproduce the issue

1. start.cmd
2. verify operation of console (terminal window) by issuing "version" command.
3. verify game operation by briefly logging in from Windows Phone 8.1 device.
4. exit device from game.
5. leave system idle for two hours.
6. attempt "version" command again.
7. verify game operation by logging in from gaming device.

OS and versions

[23:37:31] [Server thread/INFO]: This server is running PocketMine-MP 1.6.1dev-#76 「Unleashed」 implementing API version 2.1.0 for Minecraft: PE v0.16.0.5 alpha (protocol version 91)

• Title Bar: PocketMine-MP 1.6.1dev-#76 | Online 0/20 | Memory 16.11/0/16.11/20 MB @ 6 threads | U 0 D 0 kB/s | TPS 20 | Load 0.28%

• PocketMine-MP: PocketMine-MP_1.6.1dev-76_8214e50b_API-2.1.0

• PHP: PHP7.0.13

• Server OS: Windows 10 Pro

• Game version: PE

Crashdump, backtrace or other files

• ...

Issue description

When using the latest version of the api3/blocks branch, something extremely strange happened, which keeps occuring over and over again. So it may sound really weird, but here it goes. Sometimes, when walking around or joining the game, the client seems to be stuck in a chiseled stone brick block. Huge amounts of block sounds can be heard when this happens. Over the coming 5-10 seconds the client completely freezes because of the FPS lag. Teleporting does not seem to work. Kicking the player through console is the only way that seems to work.

Now too badly I do not know how to reproduce this issue. It happens not very occasionally, and seem to occur most when teleporting and with walking on slabs and stairs. The chiseled stone bricks block always show up, even though there were absolutely none nearby.

Steps to reproduce the issue

1. Possible reproduction methods mentioned above.

OS and versions

• PocketMine-MP: api3/blocks: 7a3ee42bfa719ae5642e89672a0ab88112587890
• PHP: 7.0
• Server OS: Ubuntu
• Game version: PE (possibly win10)

Crashdump, backtrace or other files

I also noticed the issue below. I do not know whether this has to do with it or not.

[Server thread/CRITICAL]: TypeError: "Argument 1 passed to pocketmine\Player::sendPosition() must be an instance of pocketmine\math\Vector3, null given, called in phar:///
home/blabla/PocketMine-MP.phar/src/pocketmine/Player.php on line 2189" (EXCEPTION) in "/src/pocketmine/Player" at line 3838

What this adds

• Title Command
• Player->resetTitles()
• Player->addSubTitle(string)

If you need me to change anything please just ask.

Apparently any translations with the same key as in MCPE displays as %ommands.(cmd).usage. Probably a client bug, or because im using 1.0.5 and theres already been an update.

~~There's currently an issue where settings the subtitle using the command doesnt set it. Maybe we need a seperate method in the Player class to set the subtitle?~~

~~EDIT: We definitely need a seperate method to set subtitle, i'll add it now~~

Issue description

When I try to reconnect a player to a server, this happens:

[02:15:50] [Server thread/CRITICAL]: Error: "Call to a member function addChunkPacket() on null" (EXCEPTION) in "/home/data/other/src/pocketmine/Player" at line 2147 [02:15:50] [Server thread/CRITICAL]: [Network] Stopped interface pocketmine\network\mcpe\RakLibInterface due to Undefined index: X.X.X.X:62724 (my ip was here)

I let players reconnect to the server if they are stuck or something.

Steps to reproduce the issue

1. Transfer a player to the same server they're already on using code below.

OS and versions

• PocketMine-MP: ALPHA7 (is that enough info?)
• PHP: 7.0
• Server OS: ubuntu linux
• Game version: irrelevant

Plugins

No it isn't reproducable without plugins. but this isnt a plugin error.. public function transfer(Player $player, string $identifier, $msg = ""){ $pk = new TransferPacket(); $pk->address = $this->getAddress(); //server ip $pk->port = $this->getPortByIdentifier($identifier); //server port $player->directDataPacket($pk); if($msg != "") $this->addTransferMessage($player, $msg); $player->close(); }

UPDATE: It doesn't do this anymore with Player->kick(), but I still think this is unexpected behavior..? Shouldn't crash.

This isn't an issue but i don't know where i can contact you. Can you add or can you give me the permission to add new Player functions to get the OS of the player, the game edition and other new things discovered in the LoginPacket like $player->getDeviceOs() ? Thanks.

Issue description

The problem still exist. I think, that could be like a continuation of issue https://github.com/pmmp/PocketMine-MP/issues/1505. Now the problem appears so the player is connected in a console, but the game client displays “locating server” and afterwards “disconnected from server”

Steps to reproduce the issue

I'm sorry, but I don't know. This is manifested from half of my players.

OS and versions

• PocketMine-MP: https://github.com/pmmp/PocketMine-MP/commit/d728154e87b0383bba5814a72c1c3a0f60f2e3f5
• RakLib: https://github.com/pmmp/RakLib/commit/998af685be51d6ee8a1e206066ccd96c21450bfd
• PHP: 7.2.1
• Server OS: CentOS 7.4.1708
• Game version: PE/Win10

Plugins

• Server are tested without plugins.

Crashdump, backtrace or other files

[03:43:22] [RakLibServer thread/DEBUG]: Created session for 192.162.35.203 47772 with MTU size 1492
[03:43:22] [Server thread/DEBUG]: RFulkren is logged into Xbox Live
[03:43:34] [Server thread/INFO]: RFulkren[/192.162.35.203:47772] вошел с id сущности 23 на (survival, -2728.3154, 69.5387, 1688.4355)
[03:44:12] [RakLibServer thread/DEBUG]: Closed session for 192.162.35.203 47772
[03:44:12] [RakLibServer thread/DEBUG]: Ignored connected packet from 192.162.35.203 47772 due to no session opened (0xc0)
[03:44:12] [RakLibServer thread/DEBUG]: Ignored connected packet from 192.162.35.203 47772 due to no session opened (0xa0)
[03:44:12] [Server thread/INFO]: RFulkren[/192.162.35.203:47772] отключился: client disconnect

Issue description

It's well known by now that the API versioning introduced last year (as documented in #179) is not very good at properly describing the server API.

Background

Problem

Proposal

After several months of discussions, I have come up with a proposal for a new, more sane way of versioning the API. This breaks away from SemVer, since SemVer is impractical to apply to MCPE-related things (as earlier discussed), and also because PocketMine-MP is not very modular (SemVer doesn't apply very well to projects with very large exposed API).

The proposed new versioning scheme consists of a 3-point x.y.z system which is more rational to the user.

• Major: This is bumped when big things change the entire API in a backwards-incompatible way, which will affect anything and everything. ALPHA7 is a good example of when this version might be bumped (the entire API was broken). This is locked to a single number (e.g. 4.0.0 is not compatible with 3.0.0)
• Minor: This is changed when there are isolated backward-incompatible changes in one area of the API that might affect some plugins. This is also locked to a single number, so other numbers are not compatible (e.g 3.1.0 is not compatible with 3.2.0)
• Patch: This is changed when features and bugfixes are added in a backwards-compatible fashion. This is not locked to a single number, but the plugin number must be <= the server number (e.g. plugin 3.2.0 is compatible with server 3.2.1, but not vice-versa).

Comments and suggestions

Are welcomed, please comment on the issue.

Introduction

One small part of the jigsaw to making PocketMine-MP support true multi-world. Global difficulty is annoying and rather restrictive.

Let's say you had a survival world on your server, where you do what you do in survival. Let's assume for a moment that mobs are implemented, and that hostile mobs spawn in easy, normal or hard. Then let's say you have a creative plots world where people can build things. You can't prevent mobs spawning in that world with difficulty, meaning you have to resort to ugly plugin hacks to prevent this.

Above is merely one of the annoyances that result from this restriction. I'm sure people reading this PR description can think of other ways that can be annoying.

Changes

API changes

• Added API methods Level->getDifficulty(), Level->setDifficulty(), Level->sendDifficulty()
• Added Level constants DIFFICULTY_PEACEFUL, DIFFICULTY_EASY, DIFFICULTY_NORMAL, DIFFICULTY_HARD
• Deprecated some Server methods to do with difficulty

Behavioural changes

• Levels will now be able to have difficulty applied to each of them instead of being subject to a global Server difficulty.
• The Difficulty NBT tag will now be used for Level difficulty. If not found, this currently defaults to Normal difficulty

Backwards compatibility

TODO

Follow-up

• Make PvP, hardcore, gamemode, inventory per-world
• Make /difficulty able to deal with single levels instead of setting all levels' difficulty
• /time command should be able to set time per-world

Issue description

While this rate limit is clearly advantageous for production servers, it's pretty inconvenient for debugging, since it interferes with debugging.

If a breakpoint is hit, and not resumed from within 5 seconds, any clients will be immediately kicked from the server when the breakpoint is finally resumed from.

Steps to reproduce the issue

1. Connect a client
2. Connect the server to a debugger (xdebug_break())
3. Wait for >5 seconds, and then resume from the breakpoint

OS and versions

• PocketMine-MP: 4.12.6
• PHP: 8.1
• Using JIT: no
• Server OS: Windows

Issue description

• Expected result:

• Actual result:

Steps to reproduce the issue

1. Place the blocks side by side

OS and versions

• PocketMine-MP: 5.0.0-ALPHA7+dev
• PHP: 8.1.13
• Using JIT: no
• Server OS: win
• Game version: Android/Win10

Issue description

• Expected result: PlayerInteractEvent (start of break) is run before BlockBreakEvent (end of break)
• Actual result: BlockBreakEvent is occasionally run before PlayerInteractEvent for the same acting while instant mining blocks.

Steps to reproduce the issue

1. Call PlayerInteractEvent and BlockBreakEvent
2. adding any type of print statement to both shows that they are not always called in proper order.

OS and versions

• PocketMine-MP: 4.12.4
• PHP: 8.0.13
• Using JIT: no
• Server OS: linux

Introduction

So, now all the vanilla commands pass their name from their constructor like the other things (aliases, permissions, description..)

Changes

API changes

No

Behavioural changes

No

Backwards compatibility

BC break, I think?

Introduction

Currently, when frosted ice is placed on the block, it melts immediately if there are not at least 2 other blocks of frosted ice nearby. This is not the normal behavior in vanilla.

Tests

Vanilla behavior: https://cdn.discordapp.com/attachments/715214348338855987/1059349977480052806/vanilla_frosted_ice_test.mp4