Describe the bug When you add money to a player, the scorehud is updated for 1 millisecond to the money you have added, but after a second it disappears and returns to the money you had before.

To Reproduce Steps to reproduce the behavior: https://streamable.com/43poru

Expected behavior ScoreHud will be updated correctly when adding or removing money.

Screenshots Video up

OS and version (please complete the following information):

• Server OS: linux
• PocketMine-MP version: 4.2.4
• Version: 2.0.7
• Plugins (2): BedrockEconomy v2.0.7, ScoreHud v7.0.0

Additional context X

using sql to make an economy plugin is very unsuitable and will really lag your server a lot for nothing so I advise you to put the db in json or yml (preferably json) if people want to make a system of economy inter server why not make a plugin that will take care of it and suddenly will be able to attract more people because people who want to do just a server can do it without having to make db and those who want can do it just by installing a " extension" which will do it automatically

Hey, can you please create BedrockmoneyScore? for my ScoreHud

here a example https://poggit.pmmp.io/p/EcoAPIScore/1.1.0

Would be cool if you could do something like that because the money doesn't show up in the ScoreHud

[16:57:48.900] [Server thread/CRITICAL]: UnhandledMatchError: "Unhandled match value of type string" (EXCEPTION) in "plugins/BedrockEconomy.phar/src/cooldogedev/BedrockEconomy/BedrockEconomy" at line 123

--- Stack trace ---

#0 (): cooldogedev\BedrockEconomy\BedrockEconomy->cooldogedev\BedrockEconomy{closure}(array[4])

#1 plugins/BedrockEconomy.phar/src/cooldogedev/BedrockEconomy/BedrockEconomy(122): array_map(object Closure#100285, array[7])

#2 plugins/BedrockEconomy.phar/src/cooldogedev/BedrockEconomy/BedrockEconomy(99): cooldogedev\BedrockEconomy\BedrockEconomy->initializeCommands()

#3 pmsrc/src/plugin/PluginBase(137): cooldogedev\BedrockEconomy\BedrockEconomy->onEnable()

#4 pmsrc/src/plugin/PluginManager(437): pocketmine\plugin\PluginBase->onEnableStateChange(true)

#5 pmsrc/src/Server(1385): pocketmine\plugin\PluginManager->enablePlugin(object cooldogedev\BedrockEconomy\BedrockEconomy#101592)

#6 pmsrc/src/Server(1011): pocketmine\Server->enablePlugins(object pocketmine\plugin\PluginEnableOrder#24932)

#7 pmsrc/src/PocketMine(304): pocketmine\Server->__construct(object BaseClassLoader#2, object pocketmine\utils\MainLogger#3, string[16] /home/minecraft/, string[24] /home/minecraft/plugins/)

#8 pmsrc/src/PocketMine(327): pocketmine\server()

#9 pmsrc(11): require(string[57] phar:///home/minecraft/pocketmine.phar/src/PocketMine.php)

--- End of exception information ---

Error:

[Server thread/CRITICAL]: Error: "Class "cooldogedev\libSQL\context\ClosureContext" not found" (EXCEPTION) in "plugins/Perks-main/src/flxiboy/Perks/provider/BedrockEconomyProvider" at line 44

Code:

use cooldogedev\BedrockEconomy\api\BedrockEconomyAPI;
use cooldogedev\libSQL\context\ClosureContext;

        BedrockEconomyAPI::getInstance()->getPlayerBalance(
            strtolower($player->getName()),
            ClosureContext::create(
                function (?int $balance): void {
                    var_dump($balance);
                },
            )
        );

Describe the bug As soon as I stopped my server, cmd window said that 'Stopping other threads' and a window with title 'CLI has stopped working'. The cmd window was freezed, I can't did anything.

To Reproduce Steps to reproduce the behavior:

1. Add BedrockEconomy to plugins folder'...'
2. Start Pocketmine server'
3. Stop the server by type 'stop' then Enter
4. See essue

Expected behavior

Screenshots

OS and version

• Server OS: [Windows 10]
• PocketMine-MP version [4.12.2]
• PHP 8.0
• Version [2.0.8]

Additional context

Hey, Ehm one last question, when I do this, it always comes out as 0, is there another possibility? Have already tried with $end = 0, $end = $balance, return $end doesn't work either.

        BedrockEconomyAPI::getInstance()->getPlayerBalance(
            strtolower($player->getName()),
            ClosureContext::create(
                function (?int $balance) {
                    return $balance;
                },
            )
        );
        return 0;

If the user has money, when the server restarts the money will reset to 0 according to the default config /addbalance to player and restart server, and also some translation message like /pay is missing

Can you make the command for the ui. idk how to do this on your way. But the menu i can do!!! i send in requests and you make the command. Output: $this->EcoUI($sender);

it is okay if i use Form api? or have i to do it self?

Sorry cooldogedev for the first one ( i closed it) Because it was not Good Constucted now IT is and i think some Peoples like SWITZERLAND LANGUAGE!!!!

Greetings from Switzerland

Could you possibly add better arrangements.

for instance change 1000 = 1.000 or 1k

Would be very helpfull to have this both in the scorehud and the actual plugin

Describe the bug Balance is set incorrectly

To Reproduce Steps to reproduce the behavior:

1. /setbalance Boo 0
2. /setbalance Boo -1 (This error occurs with all negative numbers)

Expected behavior Boo's balance will be -1 or 0

Screenshots

OS and version (please complete the following information):

• Server OS: [Windows 11]
• PocketMine-MP version: [4.6.0]
• Version [2.0.8]

Additional context N/A

Describe the bug When the server starts up, the server crashes once a player joins.

To Reproduce Steps to reproduce the behavior:

1. Add the plugin to the server
2. Start the server
3. Join the server
4. See error

Expected behavior For the plugin not to crash the server or give an error?

OS and version (please complete the following information):

• Server OS: Windows 10
• PocketMine-MP version: 4.2.4
• Version: Version of what, Minecraft? 1.18.31

Additional context Here is the error, [Server thread/CRITICAL]: TypeError: "pocketmine\command\SimpleCommandMap::getCommand(): Argument #1 ($name) must be of type string, int given, called in phar://C:/Users/Tristyn/Documents/PocketMine-MP-PM4/plugins/BedrockEconomy.phar/src/cooldogedev/BedrockEconomy/libs/CortexPE/Commando/PacketHooker.php on line 72" (EXCEPTION) in "pmsrc/src/command/SimpleCommandMap" at line 241

Is your feature request related to a problem? Please describe. Rather than storing the balance in a column we store it in a label-based json format, doing so will add more flexibility to implement new features such as the following https://github.com/cooldogedev/BedrockEconomy/issues/73, https://github.com/cooldogedev/BedrockEconomy/issues/69, https://github.com/cooldogedev/BedrockEconomy/issues/46

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe. getPlayerBalance is constantly abused for incorrect code where they check for whether the player has enough balance through getPlayerBalance and call subtractFromPlayerBalance without actually checking whether the latter is successful.

Describe the solution you'd like Remove the method. It is good for nothing other than abuse.

People who want to display the balance should use an API dedicated for displaying, such as InfoAPI. getPlayerBalance is good for nothing.

Is your feature request related to a problem? Please describe. Currently, I am working on supporting some economy plugins in my plugin. After implementing Capital, I noticed something BedrockEconomy's API lacks: There are multiple reasons why a transaction gets cancelled, e.g. the player didn't have enough money or the TransactionEvent was simply cancelled. What BedrockEconomy lacks is a way to get the reason why a transaction failed.

Describe the solution you'd like I personally like Capital's approach to that problem: When the transaction failed, an exception is thrown where the error code is specifically set to a reason. But I know that there isn't a simple solution since BedrockEconomy uses PMMP's promise system which doesn't support parameters in their failure callbacks.

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe. I just updated the version (to Dev #24) and the language section has not been updated. I don't know if that happens with the config.yml (since in this update there have been no changes in that). There are other plugins that do update the plugins_data when you add a new version and it contains changes in resources, although I don't know how it works since I'm not a dev.

Describe the solution you'd like X

Describe alternatives you've considered X

Additional context X