Slim injects the dependency container every time a middleware is created from a class. This commit uses that instead of assuming that the $next callable is going to be an instance of \Slim\App.

Also, looks like there's no need to get the request object from the dependency container since the middleware is already receiving it as a parameter, otherwise any changes made to the PSR-7 request object are lost.

The above causes an issue for example when using Slim-Csrfbecause the request would no longer have "attributes" set by this middleware.

Hope it helps.

Regards!

I must be doing something lame here that is not allowing me to use Whoops to handle errors...

<?php

/** 
 * Create Slim instance
 */

$app = new \Slim\App([
    'debug' => true,
]);

/**
 * Add Whoops middleware into slim application
 */
$app->add(new \Zeuxisoo\Whoops\Provider\Slim\WhoopsMiddleware);

/** 
 * Loads environment variables from .env to getenv(), $_ENV and $_SERVER automagically.
 * Access via $app->environment[]
 */

$dotenv = new Dotenv\Dotenv('../');
$dotenv->load();

/** 
 * Require specific ENV vars to be defined.
 */
$dotenv->required(['debug']);

/** 
 * Register classes in DI Container
 */

$container = $app->getContainer();
$container->register(new \App\Services\PageService('../content/pages'));
$container->register(new \App\Services\GlobalService('../content', 'globals.yml'));
$container->register(new \Slim\Views\Twig('../templates', [
    'debug' => $app->environment['debug'],
    'cache' => '../cache/templates'
]));

/**
 * Get classes and inject into controllers as dependencies
 */
$container['App\Controllers\PageController'] = function ($c) {
    return new App\Controllers\PageController($c['page'], $c['view']);
};

/**
 * Add Twig view extensions
 */

$twig = $container->get('view')->getEnvironment();

// Twig core
$twig->addExtension(new Twig_Extension_Debug());

// Twig extensions
$twig->addExtension(new Twig_Extensions_Extension_Text());
$twig->addExtension(new Twig_Extensions_Extension_Date());

// Third party
$twig->addExtension(new Aptoma\Twig\Extension\MarkdownExtension(new Aptoma\Twig\Extension\MarkdownEngine\MichelfMarkdownEngine()));

// API
$twig->addExtension(new App\Extensions\RequestExtension($app->request));
$twig->addExtension(new App\Extensions\PageExtension($container->get('page')));
$twig->addExtension(new App\Extensions\GlobalExtension($container->get('global')));

// Helpers
$twig->addExtension(new App\Extensions\StringExtension());

/**
 * Routes
 */

include('routes.php');

/** 
 * Run app
 */

$app->run();

Any ideas why the default error pages (basic Slim error page handler is showing)?

Getting a Whoops\Exception\ErrorException as the title goes.

File and line number: vendor/zeuxisoo/slim-whoops/src/Zeuxisoo/Whoops/Provider/Slim/WhoopsMiddleware.php:31

Here is the actual line:

'Route Name' => $app->router()->getCurrentRoute()->getName() ?: '<none>',

This only happens when I go to an URL that matches no route.

...

class WhoopsMiddleware extends Middleware {
    public function call() {
        $app = $this->app;

        if ($app->config('debug') === true) {
            // Switch to custom error handler by disable debug
            $app->config('debug', false);
//          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

...

Why you make this? Debug mode is important for other components!

Please add a tag to your repo so that I can add to my composer.json rather than using dev-master, because if you were to make a breaking change to master, my code would break.

the setting for editor pretty much only lets you set the editor like "phpstorm" etc. but it doesnt include the option to add the "resolver" part

 $prettyPageHandler->setEditor($this->settings['editor']);

as in

$prettyPageHandler->addEditor( 'phpstorm', 'http://localhost:8091?message=%file:%line' );

on windows we dont have a native protocol for phpstorm, so using a plugin "remote call" we can trigger the same thing using the above resolver.

https://plugins.jetbrains.com/plugin/6027-remote-call

I think is better to add slim in the required dependencies. I've slim 3. When i require this package i get the latest version for slim 4 instead of the slim 3 compatible version. Thanks.

@zeuxisoo can you recommend where to put your setup code for global mode? I'm using https://github.com/slimphp/Slim-Skeleton so it would be most helpful to know in that context how to insert elegantly :).

I know, when placing the Middleware call into my src/middleware.php file, it will automatically replace Slim's error message with Whoops (haven't tested yet). But sometimes, I run into trouble with PHP errors.

Is there a way to replace them with Whoops too? If so, how? Haven't found it anywhere.

EDIT: Tried the rest, to see if the Error Handler is replaced, but it's not. Doing it like so: $app->response()->status(500);

This is my public/index.php file:

<?php

require __DIR__ . '/../vendor/autoload.php';

session_start();

// Instantiate the app
$settings = require __DIR__ . '/../src/settings.php';
$app = new \Slim\App($settings);

// Set up dependencies
require __DIR__ . '/../src/dependencies.php';

// Register middleware
require __DIR__ . '/../src/middleware.php';

// Register routes
require __DIR__ . '/../src/routes.php';

// Run app
$app->run();

In the src/middleware.php is the Middleware call as in the Readme $app->add(new \Zeuxisoo\Whoops\Provider\Slim\WhoopsMiddleware($app));.

This time I am mostly certain it is my fault. But I am using a class to get whoops to work in slim.

Would you happen to know how to solve this issue ?

Here is my file : https://github.com/concept-core/laraslim/blob/master/base/AppStarter.php#L47-L72

Fatal error: Cannot use object of type Closure as array in vendor\zeuxisoo\slim-whoops\src\Zeuxisoo\Whoops\Provider\Slim\WhoopsMiddleware.php on line 12

with Slim 3

Hey, I switched to using this middleware (and whooops) also for APIs. Endpoints accessed by javascript that encounter an exception get a 500 error message - see discussion in https://github.com/filp/whoops/issues/666 ... I'd basically need to extend the PrettyPageHandler ... I guess that

• adding support for a variable PrettyPageHandler
• adding the ability to pass custom headers via a config option
• or similar

might do the trick. Or do you see another way around? Thanks

Bumps twig/twig from 3.3.7 to 3.3.8.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.