Instead of manually doing:

code: |
    parent::__construct();

It would be very useful to add a call_parent key:

call_parent: true #(default to false)

It would just do a basic call parent call passing the parameters of the method. For custom behaviour, we could always rely on the code key.

This would be good to implement in the Object Generator Component.

The Object Generator that uses Nette/Php-Generator does not output code that is valid with the default settings of PHP-CS-Fixer. This causes mismatches of coding styles making commits diff all the generated files.

It would be better to integrate PHP-CS-Fixer in the compilation process, to automatically fix the compiled files according to its config file if present.

Sometimes for code scaffolding, the overwrite functionality of the compiler can get in the way. Instead, we could add a new Layer Object Configuration Key like so:

- schema: ...
  compile: ~ # one in once, never, always

Where:

• once: Would compile the object only if its Layer Object File does not exist
• never: Would disable the compiler for this object
• always: Would always recompile and overwrite the Layer Object File (default value)

Because of this line: https://github.com/Morebec/Orkestra/blob/e5a04a4c468d560538a43a5707be9e6ad458d018/src/ProjectCompilation/Infrastructure/Loader/YamlModuleConfigurationLoader.php#L20

If the configuration of a module is not valid Yaml, it throws an exception, but this exception does not display the name of the file that errored.

Instead, it would be better to catch the exception and throw a new InvalidModuleConfigurationException and specify the name of the file that caused the error.

This would greatly help debug OC files.

Make Coded Layer Object Templates use an anonymous function.

handleTemple = function($config, array $data): array {
    return $data;
}

It requires updating the code of the LayerObjectCompiler

We need to delete compiled Layer Object Files before Compile.

This would ensure that the layer object configurations specified in a module, gets deleted if it gets deleted from the module. And also when using the watch option, some editor like PHPStorm save the file continually, meaning sometimes the compiler on watch tries to compile incomplete paths. It would those files compiled at temporary locations.

It would mean to scan the source directory for all files containing @Orkestra\Generated and delete those files.

It would be very useful to implement a --watch option that detects changes in the modules configured directory to recompile on file change. It could look like this:

$ orkestra compile:project --watch

This would allow us to easily see which classes are generated, and which are not while developing. As sometimes this can get a bit confusing for project that use both Generated code and manual code.

Some places in the code use array_key_first however this is restricted to PHP7 >= 7.3.0 It makes the tests fail for PHP7.2. The project wants to support at least PHP 7.2 and this impacts Object Generator Component as well.

There is a polyfill proposed here:

<?php
if (!function_exists('array_key_first')) {
    function array_key_first(array $arr) {
        foreach($arr as $key => $unused) {
            return $key;
        }
        return NULL;
    }
}