a lessphp port to minify, i've taken somebody else's work and rebased it to current master

overall expression: a group with single .less file: worked

@mrclay: could you drop your guidelines how to improve and make this work as you would intend?

tasks:

• [x] lessphp support
• [x] support import statements (multiple file caching/monitoring)
• [x] Convert Minify_Source::lastModifiedTime to ->getModifiedTime() #114
• [x] getCache interface #120

Originally reported on Google Code with ID 78

Minify version: 2.1.1
PHP version: 5.2.7

What steps will reproduce the problem?
1. Installing
2. Creating configuration file (attached)
3. calling via any method.

Expected output:

Minified output of js / css file(s).

Actual output:

400 Bad Request

Did any unit tests FAIL? Unknown.

Please provide any additional information below.

Request Headers:

Host: www.devbrewards.co.uk
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.5)
Gecko/2008120122 Firefox/3.0.5 (.NET CLR
 3.5.30729)
Accept: text/css,*/*;q=0.1
Accept-Language: en-gb
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Referer: http://www.devbrewards.co.uk/
Cookie: CAKEPHP=gr62h029k2buteruujlcb6fnn0;
SESS55e30b91742880ca57848b3a725fc4b3=vnashmcr3vasft9c08divi9me2

Response Headers:

Date: Wed, 21 Jan 2009 09:57:01 GMT
Server: Apache/2.2.10 (Win32) PHP/5.2.7-dev
X-Powered-By: PHP/5.2.7-dev
Content-Length: 24
Connection: close
Content-Type: text/html; charset=UTF8

Response: HTTP/1.0 400 Bad Request

Reported by ibnormedia on 2009-01-21 10:01:30

Hello, For whatever reason there is a problem with minify, if bootstrap.css uses (bootstrap 3) from the Less compilation.

No notification but stylesheet not loaded

My webpage is directly under the document root, not in a sub directory. Using Apache (2.4) under Windows. I got every time the message "File ... is outside $allowDirs ...". Document root is: $min_documentRoot = dirname(DIR) and it gives the right document root back. No Sym-Links, but I also tried this: $min_symlinks = array('//' => $min_documentRoot);

I found a work around for this by changing the line (near line 142 in /lib/Minify/Source/Factory.php) from if (strpos($spec['filepath'], $allowDir) !== 0) { to if (strpos($spec['filepath'], rtrim($allowDir, '/')) !== 0) {

The whole block of (changed) code is here:

    if ($this->options['checkAllowDirs']) {
        foreach ((array)$this->options['allowDirs'] as $allowDir) {
            if (strpos($spec['filepath'], rtrim($allowDir, '/')) !== 0) {
                throw new Minify_Source_FactoryException("File '{$spec['filepath']}' is outside \$allowDirs."
                    . " If the path is resolved via an alias/symlink, look into the \$min_symlinks option.");
            }
        }
    }

I have no defined "$allowDir"s, but the variable is set and ends with a '/' that causes this wrong behavior.

currently if using groupsConfig, then cache id becames simply max(mtime) of all files.

so, the cache id will remain the same, if i add more files to the group having identical timestamp.

i guess there should be added * NUMBER_OF_FILES to avoid this problem

so i had in my groupsConfig.php:

  'l' => array(
      '/path/to/lazyload.js'
  ),

then url built with was:

  g=l&1338376276

later i added one more file:

  'l' => array(
      '/path/to/uaft.js',
      '/path/to/lazyload.js'
  ),

and the url remained the same:

  g=l&1338376276

as the files have identical timestamp:

$ ls -l --full uaft.js lazyload.js 
-rw-r--r-- 1 root root 1.3K 2012-05-30 14:11:16.000000000 +0300 lazyload.js
-rw-r--r-- 1 root root 1.7K 2012-05-30 14:11:16.000000000 +0300 uaft.js

expanding that timestamp:

$ LC_ALL=C php -r 'echo strftime("%c %z\n", 1338376276);'
Wed May 30 14:11:16 2012 +0300

Originally reported on Google Code with ID 176

Minify version:
PHP version:    5.2.12 

What steps will reproduce the problem?
1.deactivating mbstring.func_overload
2.
3.

Expected output:

Actual output:
hte full result but never less than 3min. responsetime

Did any unit tests FAIL? (Please do not post the full list)
sorry, will going to test it.
Please provide any additional information below. If this has to do with URI
rewriting, please include your DOCUMENT_ROOT, the

Reported by [email protected] on 2010-05-06 10:42:55

Originally reported on Google Code with ID 71

Minify version: 2.1.1
PHP version: 5.2.6
jQuery 1.2.6-min.js
tinyMCE 3.2.1

What steps will reproduce the problem?
1. /min?f=js/jquery.js,js/tiny_mce/tiny_mce.js,js/init.js&debug=1
2. in init.js i have tinyMCE.init({ ... standard methods to initiate TinMCE
... });

Expected output: correct one

Actual output: JS ERROR (Firebug output):
missing ; before statement
[Break on this error] /* 28 *|
xhr.open(type,s.url,s.async);tr...[s.url]=modRes;if(!jsonp)success();}else

Did you run the unit tests? Did any FAIL? All went OK

Please provide any additional information below.
Sometimes 301 Moved permamently repeats with this request and never stops
making browser to hang and request never ends

Reported by popec82 on 2008-11-26 12:01:28

Originally reported on Google Code with ID 129

I've studies the Minify builder a little, but couldn't make much of the way 
the html is minified.

A nice way would be the following, where Minify would follow the config.
<?php ob_start(); ?>
<!-- html -->

<?
$contents = 0b_get_contents();
ob_end_clean();
require '/min/Minify.php';
Minify::serve('Page', $contents);
// This as a cleaner alternative to http://code.google.com/p/minify/source/browse/trunk/min/builder/index.php

Reported by Kramieb on 2009-08-04 12:58:38

Originally reported on Google Code with ID 82

Minify version: 2.1.1
PHP version:5.2.4-2ubuntu5.4

What steps will reproduce the problem?
1. Create a css file with a relative image path in it for a background,
such as:
*****
url("../images/fieldset-bg.gif") 
*****
2. Minify the css files with a relative image path in it :
array(
        '//styles/somefile.css'
);

2. Compare the re-written image path in the compressed file:

Expected output:
original: "../images/fieldset-bg.gif"
modified: "../images/fieldset-bg.gif"

Actual output:

original: "../images/fieldset-bg.gif"
modified: "/../images/fieldset-bg.gif" 

Did any unit tests FAIL?

Running test_all.php produces the following failures:
*****
!FAIL: Minify_Cache_File : store (1 of 10 tests run so far have failed)
!FAIL: Minify_Cache_File : isValid (2 of 12 tests run so far have failed)
!FAIL: Minify_Cache_File : display (3 of 13 tests run so far have failed)
!FAIL: Minify_Cache_File : fetch (4 of 14 tests run so far have failed)
!FAIL: Minify_Cache_File : store w/ lock (5 of 15 tests run so far have failed)
!FAIL: Minify_Cache_File : isValid (6 of 17 tests run so far have failed)
!FAIL: Minify_Cache_File : display w/ lock (7 of 18 tests run so far have
failed)
!FAIL: Minify_Cache_File : fetch w/ lock (8 of 19 tests run so far have failed)
!FAIL: environment : PHP/server does not auto-HTTP-encode content (9 of 60
tests run so far have failed)
*****

Please provide any additional information below.

This issue was discussed in brief here:
http://groups.google.com/group/minify/browse_thread/thread/895cb58e4bbfe17

Reported by bmharris on 2009-01-26 21:16:02

Split off from https://github.com/mrclay/minify/pull/657.

Apply following php-cs-fixer rules:

• align_multiline_comment
• array_indentation
• binary_operator_spaces
• blank_line_before_statement
• braces
• cast_spaces
• class_attributes_separation
• combine_consecutive_unsets
• concat_space
• explicit_string_variable
• function_declaration
• general_phpdoc_annotation_remove
• method_argument_space
• new_with_braces
• no_alternative_syntax
• no_blank_lines_after_phpdoc
• no_empty_phpdoc
• no_extra_blank_lines
• no_null_property_initialization
• no_short_echo_tag
• no_spaces_inside_parenthesis
• no_trailing_whitespace
• no_trailing_whitespace_in_comment
• no_unneeded_control_parentheses
• no_unused_imports
• no_useless_else
• no_whitespace_before_comma_in_array
• no_whitespace_in_blank_line
• normalize_index_brace
• ordered_imports
• php_unit_internal_class
• php_unit_method_casing
• phpdoc_add_missing_param_annotation
• phpdoc_annotation_without_dot
• phpdoc_inline_tag
• phpdoc_no_access
• phpdoc_no_alias_tag
• phpdoc_no_package
• phpdoc_order
• phpdoc_scalar
• phpdoc_separation
• phpdoc_trim
• phpdoc_trim_consecutive_blank_line_separation
• phpdoc_types
• phpdoc_types_order
• phpdoc_var_without_name
• return_assignment
• semicolon_after_instruction
• single_blank_line_at_eof
• single_quote
• trailing_comma_in_multiline_array
• unary_operator_spaces
• whitespace_after_comma_in_array
• yoda_style

3.0 has support for serving .less files via Minify_LessCssSource which supports correct handling of getLastModified

however, when using Minify_HTML_Helper::getUri the instances to Minify_LessCssSource are not made in setGroup and as a result _lastModified is set to main .less file, not the one of included one.

@mrclay how do you suggest to solve this shortcoming?

for serving, this is done in SourceFactory

I found that I have published closure-compiler-httpserver at some point:

• https://github.com/glensc/closure-compiler-httpserver

its purpose is to keep the java VM loaded, not execute java for every compile call, resulting in faster response and less CPU usage.

I've never used it myself in production, but the code seems complete.

Now the question: where to add a document about it?

Is there a way to remove to remove the source mapping URLs from the JS files? In the dev console I get the errors that the source map cannot be found. Another solution would be to modify the source mapping URLs in the JS files. Thank you very much for this library. Any thoughts on this issue?

See: https://www.php.net/manual/en/function.htmlspecialchars.php

8.1.0 | flags changed from ENT_COMPAT to ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401.

https://github.com/mrclay/minify/blob/master/lib/Minify.php#L474

This line, written in config.php $min_serveOptions['minifiers'][Minify::TYPE_JS] = 'someCustomMinifier'; has no effect when requesting files in Static mode

That is, the custom minifier for such a request does not work: https://example.com/min/static/0/f=min/quick-test.js

But the minifier works for such a request: https://example.com/min/f=min/quick-test.js

* Naturally, I cleaned the cache, deleted "static" files, it does not help.

Can you please tell me how to make a custom minifier work in Static mode?

Bonjour, Je n'arrive pas à trouver d'où vient le problème, que ce soit en local ou sur le nouveau hebergement, j'ai un problème d'affichage, on dirait que mon site n'arrive plus à récupérer js + css. Pourriez vous m'apporter de l'aide svp?