Given that HTTP factories exist, why do we need to use CallableHandler to execute the handler Why not simplify the execution path and force the handler to return a ResponseInterface?

Hey, I wanted to extend RequestHandler but wasn't able to access $this->container or $this->handlerAttribute because they're private. This PR degrades the properties to protected so that we can access them if we need to.

Should I send also migration from Travis to GitHub actions? Since Travis is ultra-slow these days and obviously does not have PHP 8.0 ready, GitHub actions are far better nowadays.

When no valid attribute is present, the middleware could keep delegating after all... Or is there just no sensible use-case?

Asking because middlewares/base-path-router#3 makes me imagine a situation where the router has dynamic prefixes, but no default handler, it could just delegate to its own handler. Using request-handler as that delegate would then lead to a situation where request-handler would need a fallthrough. Isn't that the best place for the defaultHandler? After all, the router isn't useful without request-handler anyway, so it could just rely on the latter for the default handler.

Hi,

I looked at the fastroute & aurarouter middleware and they both claim you can add a handler as a closure, callable, controller...Etc :

FastRoute allows anything to be defined as the router handler (a closure, callback, action object, controller class, etc). The middleware will store this handler in a request attribute.

But in your middleware requestHandler, the handler retrieved in the request can only be a typeof middlewareinterface or requesthandlerinterface or a string (a key to search in the container), but if the handler is of type : closure or callable, then this middleware will not be working (no handler execution).

you explain me why this possibility is not present ? thank you.

Keep up the good work.

Hi, this adds support for psr/container ^2.0. It merely adds a return type to one of the ContainerInterface methods, so there is no breaking change for this package. Also, since psr/container is a hard dependency now, I've removed it from suggest where it seems redundant.

@oscarotero the build is failing just because of the new dependency phpspec/prophecy-phpunit, which I added - because of new PHPUnit deprecated calling prophesize and suggests to install this package and use Trait from it.

https://github.com/middlewares/request-handler/blob/master/tests/RequestHandlerTest.php#L23 https://github.com/middlewares/request-handler/blob/master/tests/RequestHandlerTest.php#L82

I've managed to use the request-handler combined with aura-router with a single router handler.

Am trying to implement route specific middleware, as opposed to the 'global' application middleware.

$routerContainer = new RouterContainer();
$map = $routerContainer->getMap();

// Works fine...
$map->get('index', '/', 'App\Http\Controllers\HomeController::index');

// Error: Invalid request handler: array
$map->get('index', '/', [
    new SampleRouteMiddleware(),
    'App\Http\Controllers\HomeController::index'
]);

$request = ServerRequestFactory::fromGlobals($_SERVER, $_GET, $_POST, $_COOKIE, $_FILES);

$requestContainer = new RequestHandlerContainer();

$dispatcher = new Dispatcher([
    new SampleAppMiddleware(),
    new AuraRouter($routerContainer),
    new RequestHandler($requestContainer),
]);

$response = $dispatcher->dispatch($request);