In 1.1Alpha i use this:

$collection->attachRoute(new PHPRouter\Route('/sitemap/info.xml', [
    '_controller' => 'App\Controllers\Sitemap::Sitemap',
    'methods' => ['POST','GET'],
    'parameters'=> ['template_file'=>'ajax'],
]));

and get_object_vars($route)['_config']['parameters']['template_file'] to get "ajax" value, but now in last version this not working.

How to make something like this ?

hi,

i just found this ... another router class .... I start already play with AltoRouter, which work fine, can you explain the difference between phprouter-altorouter?

Thanks

• PHPRouter version: dev-master
• PHP version: 7.2

Hi, I'm currently facing a small challenge where I didn't found any solution for in the README or the Issues.

I want to have this: Access /id/1 and I want to pass the 1 over to the Controller. I've tried many things and am stuck on this for 3 hours now. Help is much apprecicated!

This is my current code (reset everything):

<?php
require("vendor/autoload.php");

use Angle\Engine\Router\Collection;
use Angle\Engine\Router\Route;
use Angle\Engine\Router\Router;
use \Angle\Engine\Template\Engine;

use Tracy\Debugger;

Debugger::enable();

define("MYSQL_HOST", "localhost");
define("MYSQL_USER", "bennet");
define("MYSQL_PASSWORD", "root");
define("MYSQL_DATABASE", "bennet");

$collection = new Collection();

$engine = new Engine();

$collection->attach(new Route("/", array(
    "_controller" => '\Blog\Controllers\Overview::display',
    "parameters" => ["engine" => $engine],
    "methods" => 'GET'
)));

// id url
$collection->attachRoute(new Route("/id/:id", array(
    "_controller" => '\Blog\Controllers\Overview::display',
    "parameters" => ["engine" => $engine],
    "methods" => 'GET'
)));


$router = new Router($collection);
$router->matchCurrentRequest();

URI's like this:

http://example.com/account/authenticate/facebook/http%3A%2F%2Fexample.com%2Fpub%2Flogin%2Fadmin%2F%23!%2F

Is not accepted by the regex..

$router->map('/account/authenticate/:external_auth_vendor/:location', array('controller' => 'PageController', 'action' => 'external_auth'), array('methods' => 'GET', 'name' => 'account_login_external'));  

Ran into this today,

I was adding routes like so:

thing/:handle (just GET) thing/update (GET and POST)

as you can see the one with the variable is there first,

I would request thing/update so when the router filters through the routes it hits thing/:handle and stops because it matches, the only way around this is to add thing/update before thing/:handle,

if there was a way to sort it by ones that do not have variables (static routes) that would be awesome

• PHPRouter version: 1.2alpha
• PHP version 8.1

Hi again, guys :)

I started a topic in stackoverflow for my previous problem and there is some replies: https://stackoverflow.com/questions/71241075/php-8-unknown-named-parameter-dannyvankooten-router/71241345?noredirect=1#comment125927353_71241345

They told me to remove this line from code: 'parameters'=> ['template_file'=>'ajax'],

to my script start working, but this is so important ... I started this one to give a suggestion to making edit in router code to start working like this :)

This is important, because i use template engine mustache and i pass the variables like this: $tpl = $mustache->loadTemplate(get_object_vars($route)['_config']['parameters']['template_file']);

and this: $tpl = $mustache->loadTemplate($route->getParameters()['template_file']);

both working in php 5.4> and <php7.4

Without this ones i'm lost and my CMS can't working... This is very important... Its so easy to set a template file in routes and to catch this one from my template system... It's very clear and pleasant way.. If you help me to start this working i will be very happy :)

Thanks in advance.

• PHPRouter version: 1.2alpha
• PHP version 7.4

Hello guys, i have a question about the routers, this one: '_controller' => 'App\Controllers\BaseController::__construct', works.

but this one: '_controller' => 'App\Controllers\BaseController::__construct::the_tickets::ajax', not works...

i check in base controller with class_exists('the_tickets') and it shows true... My question is about can i access more than one method in routing... Thank you for any replies.. :)

Hi,

I like this package because it's a very simple Router. To keep this project very simple and independent, I think it would be nice to allow configs to be in Yaml OR Json format, to avoid the Yaml library dependency. Yaml mode could also use the php native methods when available ( http://php.net/manual/fr/book.yaml.php )

The objective is to avoid avoidable dependencies.

Have a good day

Hi!

I use the following (test) Routingfile:

-- CUT HERE base_path: /api

routes: ping: [/ping, \Myuniquename\Api\Test.ping, GET] -- CUT HERE

When i call my "frontcontroller" i get:

-- index.php

$routes = Config::loadFromFile($basePath . '/config/routes.yaml');

Array (size=2) 'base_path' => string '/api' (length=4) 'routes' => array (size=1) 'ping' => array (size=3) 0 => string '/ping' (length=5) 1 => string '\Myuniquename\Api\Test.ping' (length=27) 2 => string 'GET' (length=3)

$router = Router::parseConfig($routes);

Object(PHPRouter\Router)[35] private '_routes' => object(PHPRouter\RouteCollection)[33] private '_namedRoutes' => array (size=0) empty private '_basePath' => string '' (length=0)

// Look above: the basepath is empty, But i set it in routes.yaml.

So this will not work (but should because of base_path):

 http://www.foo.bar/api/ping

but this will work (but should not):

 http://www.foo.bar/ping

But i set "base_path" in yaml-File (as described in README).

Maybe my mistake ?

CU, Kai.

As an enhancement, it could be useful to have a "shouldDispatchCallback".

• Router class have a setShouldDispatchCallback method
• Just before the call to $routes->dispatch(), the router calls the callback, if callback return false, route is ignored, else the callback returns the route.

=> it can be used to allow / disallow access to routes

Hi,

i have a problem with setFilters, when i'm going on http://dn.tld/js/library.js all work fine, but when i'm trying to access http://dn.tld/js/library.min.js $router->matchCurrentRequest(); return false, this is really weird.

$routes[++$i] = new Route('/js/:filename.js', ['_controller' => 'App\Controller\Misc\Minify::JS', 'methods' => 'GET']);
$routes[$i]->setFilters([':filename' => '([[:alnum:]\.]+)'], true);

I have tried with POSIX, Ascii and Unicode expression and i have the same problem with all of them, the router seem match only the default regex.

• PHPRouter version: @dev-master
• PHP version:
• Exact steps to cause this issue
  1. Create abstraction of router.
  2. Create controllers with customs params and at first the id, and load routes.
  3. Sending request.
• What you expected
  • e.g. I expected to get my custom params with the id.
• What happened instead
  • e.g. Instead, I got Error : Too few arguments to function Controller::test(), 1 passed and exactly 2.

Hey ! just found an exception about controllers method params. I wanted to pass (with or without url dynamic param) some custom object like a RequestObject.

To fix it, in Router.php, match() function, just before call $routes->setParameters($params);, add

foreach ($routes->getParameters() as $parameter) {
           $params[] = $parameter;
}

Thanks you.

It is a very simple and naive implementation actually not PSR-15 compliant, but maybe it is a good start for PSR-15 compliance.

The idea is to set a callback before dispatching the route, with these rules :

• The callback take one parameter which is the Route to be dispatched
• if the callback returns false or equivalent, the route is ignored and the router continues to check other routes.
• if the callback returns a route, it is dispatched. So you can simply return the route to allow it, or generate a new Route in replacement (like an Error route for example).

• PHPRouter version: 1.2.0-alpha
• PHP version: PHP 7.1:
• Exact steps to cause this issue
  1. I configured RouteCollection
  2. I run method matchCurrentRequest on Router
• What you expected
  • I expected to get all information about route and use this information in other middleware using psr 15
• What happened instead
  • Router create controller object and run the action

Is it possible to turn of run method dispatch() after find route by configuration flag.

I want to submit a nice request ( i think ) For now in methods we have: GET POST etc... i want to be added one more "XHR" or "Ajax" and this one can be accepted only ajax requests. Now my controllers with ajax must be like this:

 if(parent::is_ajax()) {
 //my code
}

is_ajax function is:

  public function is_ajax() {
    return (isset($_SERVER['HTTP_X_REQUESTED_WITH']) && !empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest');
  }

I need this to be added and my routers will be:

$collection->attachRoute(new PHPRouter\Route('/', [
    '_controller' => 'App\Controllers\Index::Index',
    'methods' => 'AJAX',
    'parameters'=> ['template_file'=>'index'],
]));

instead

$collection->attachRoute(new PHPRouter\Route('/', [
    '_controller' => 'App\Controllers\Index::Index',
    'methods' => 'GET',
    'parameters'=> ['template_file'=>'index'],
]));

is this possible ?