Hi,
This is a follow-up on the https://github.com/magento/magento2/pull/33353#issuecomment-874976048.
While working on https://github.com/magento/magento2/pull/33353, there were added following changes:
diff --git a/lib/internal/Magento/Framework/Escaper.php b/lib/internal/Magento/Framework/Escaper.php
index dae830dd889d..cb23deb0be4a 100644
--- a/lib/internal/Magento/Framework/Escaper.php
+++ b/lib/internal/Magento/Framework/Escaper.php
@@ -289,7 +289,7 @@ public function escapeUrl($string)
* @return string
* @since 101.0.0
*/
- public function encodeUrlParam($string)
+ public function encodeUrlParam(string $string)
{
return $this->getEscaper()->escapeUrl($string);
}
@@ -328,7 +328,7 @@ function ($matches) {
* @return string
* @since 101.0.0
*/
- public function escapeCss($string)
+ public function escapeCss(string $string)
{
return $this->getEscaper()->escapeCss($string);
}
The SVC failure was failing:
Level | Target/Location | Code/Reason
-- | -- | --
MAJOR | Magento\Framework\Escaper::encodeUrlParam/lib/internal/Magento/Framework/Escaper.php:292 | V085 [public] Method parameter typing added.
MAJOR | Magento\Framework\Escaper::escapeCss/lib/internal/Magento/Framework/Escaper.php:331 | V085 [public] Method parameter typing added.
Basically, adding argument type shouldn't introduce any breaking changes since PHP 7.2 (thanks to https://wiki.php.net/rfc/parameter-no-type-variance).
Examples:
Here are two examples that works fine
- ✔ w/o strict types, pass string https://3v4l.org/IBGCK
<?php
class A
{
public function encodeUrlParam(string $string)
{
echo $string;
}
}
class extendedA extends A
{
public function encodeUrlParam($string)
{
echo $string;
}
}
$a = new extendedA();
$a->encodeUrlParam('test');
- ✔with strict types, pass string https://3v4l.org/eFu0n
<?php
declare(strict_types=1);
class A
{
public function encodeUrlParam(string $string)
{
echo $string;
}
}
class extendedA extends A
{
public function encodeUrlParam($string)
{
echo $string;
}
}
$a = new extendedA();
$a->encodeUrlParam('test');
- ✔ w/o strict types, pass int https://3v4l.org/KDom7
<?php
class A
{
public function encodeUrlParam(string $string)
{
echo $string;
}
}
class extendedA extends A
{
public function encodeUrlParam($string)
{
echo $string;
}
}
$a = new extendedA();
$a->encodeUrlParam(1);
- ✔with strict types, pass int https://3v4l.org/cGn61
<?php
declare(strict_types=1);
class A
{
public function encodeUrlParam(string $string)
{
echo $string;
}
}
class extendedA extends A
{
public function encodeUrlParam($string)
{
echo $string;
}
}
$a = new extendedA();
$a->encodeUrlParam(1);
:exclamation: ❌ Note: it doesn't work like that for return types https://3v4l.org/ti9uU
<?php
class A
{
public function encodeUrlParam(string $string): string
{
echo $string;
}
}
class extendedA extends A
{
public function encodeUrlParam($string)
{
echo $string;
}
}
$a = new extendedA();
$a->encodeUrlParam('test');
Progress: done
![[Pyrrans] AC-3208: updated symfony/console to the latest version](https://avatars.githubusercontent.com/u/30952336?v=4)
192 Jan 8, 2023
1 Jan 9, 2022
1.5k Dec 17, 2022
16 Sep 7, 2022
13 Nov 11, 2022
51 Dec 5, 2022
0 Oct 7, 2022
28 Apr 19, 2021
107 Oct 17, 2022
61 Aug 10, 2022
144 Nov 18, 2022
213 Sep 24, 2022
3 Jun 30, 2020
37 Sep 26, 2020
23 Dec 20, 2022
26 Jun 3, 2020
95 Feb 11, 2022
123 Nov 20, 2021
62 Apr 1, 2022