Hej @juriansluiman,

I started to think about SlmMail.

Basically, I've removed all the Di stuff, all the message, services... As I told you some weeks ago, I think it makes no sense to have the service send the message. To my opinion this is transport role.

I think a lot of logic could be moved to AbstractHttpTransport, by making each transport filling a kind of "descriptor" (for instance, say that from email is stored in "from_email" in params), so that we don't duplicate the boring stuff accross all transports.

I also think we must separate Transactional emails and Campaign emails. I suppose we should add a "Campaign" namespace into SlmMail to handle Campaign and List (List could extend from AddressList and implements custom logic).

Hi, My primary usage for the mail is using AWS SES . While this module supports that, but I don't see anywhere to set a template for the same. I am not sure how to do this. Would be great if someone could outline how to extend it so that it will support setTemplate and passing data to the template page . It would be great if the module starts supporting sendy.

By throwing your own generic exception in https://github.com/juriansluiman/SlmMail/blob/master/src/SlmMail/Service/PostmarkService.php#L350 you're reducing information and obfuscating the true reason for failure.

It must be possible for the consumer to process the response from postmark. Either make the response available or pass it to the exception as context so it can be extracted in a catch block.

I have been using this module with SendGrid and just started sending attachments. Oddly, my excel files were "corrupted" and easily fixed by excel, but the byte size did not match what I sent it (~100 bytes more).

I dug into the SendGridService and see this line:

$post->set('files[' . $attachment->filename . ']', $attachment->getRawContent() . ';type=' . $attachment->type);

However, this is not correct as the type is being appended to the end of the file. Removing this fixed my corruption issue. I recommend removing this line from production because ";type=whatever" is not a standard file protocol. I don't mind doing this and pull requesting.

Line should be:

$post->set('files[' . $attachment->filename . ']', $attachment->getRawContent());

This makes it possible to use it with stuff like SxMail and other modules relying on Zend\Mail\TransportInterface.

Frankly, I think this interface should be dropped in favor of Zend\Mail\TransportInterface, as they are identical.

I've started work on adding a test_mode config value.

When test_mode is true, SlmMail wont actually send any emails. This is needed when doing QA or testing. You might want to test with real costumer data, but not actually sending emails.

Right now when test_mode is true i just return an array instead of doing the actual $response->send. I don't know if this is the right way to do it?

Will add unit-test when i've gotten clarified if return array() is correct.

It appears that this is presently undocumented so I'll at least list this as an issue. This module depends on the older version of the AWS ZF2 module and not on the latest version.

Converting to a newer version looks to be as simple as modifying SesServiceFactory to:

namespace SlmMail\Factory;

use SlmMail\Service\SesService;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Aws\Sdk;

class SesServiceFactory implements FactoryInterface
{

    /**
     *
     * {@inheritDoc}
     *
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        return new SesService($serviceLocator->get(Sdk::class)->createSes());
    }
}

Is this something that is planned in the near future? I realize that this may also affect other modules like SlmQueue and should probably be committed in parallel for projects that depends on both SlmQueue as well as SlmMail.

This is my composer.json file

{ "name": "test site", "description": "test site", "license": "BSD-3-Clause", "minimum-stability": "dev", "repositories": [ { "type": "composer", "url": "https://packages.zendframework.com/" } ], "require": { "php": ">=5.3.3", "zendframework/zendframework": "dev-develop", "zfcampus/zf-apigility": "dev-master", "doctrine/doctrine-orm-module":"0.", "doctrine/common": "2.3.0", "silvester/reverse-oauth2": "dev-master", "FortAwesome/Font-Awesome": "", "aws/aws-sdk-php-zf2": "1.0.", "codeception/codeception": "1.8.", "neilime/zf2-assets-bundle": "dev-master", "ocramius/ocra-service-manager": "dev-master" }, "require-dev": { "zendframework/zftool": "dev-master", "zendframework/zend-developer-tools": "dev-master" } }

I need to install the SlmMail package but it give lot of dependency errors. How can I install SlmMail package with above configs.

For the final 1.0.0 release, let's make the documentation better.

@juriansluiman, there are some parts here https://github.com/juriansluiman/SlmMail/issues/7, I don't know how to do them better. The installation is already short enough. What kind of description would you like in Introduction ?

It seems that Amazon SES now support attachments (in fact it supports them since 2011, don't know why I didn't see it): http://aws.typepad.com/aws/2011/07/amazon-simple-email-service-now-supports-attachments.html).

We will need:

• To add a SesMessage class
• Change the send method in service to send attachments using the SendRawEmail method.

Any SES user is encouraged to do it =)

Each of the services' sendMessage() methods has a section like this:

$params = array(
    'subject'  => $message->getSubject(),
    'html'     => $message->getBody(),
    'text'     => $message->getBodyText(),
);

There is a bug here and and it's root is a misunderstanding of getBody() and getBodyText().

The difference between these two methods is that the former returns an object and the latter a string (the contents of the object). Unlike ZF1, the message doesn't include the fields for HTML and text: they are objects of type \Zend\Mime\Message.

Most services allow for sending HTML and/or text, so the service should support that aswell.

The code should check the 'content-type' of each mime part in the message body and decide whether it's HTML or text. Then send only the types that exist to the server.

Am I missing anything?

I'm interested to know how many companies are actually using SlmMail for their company. Feel free to drop a comment below with a link to your product. I'll update the issue with these responses.

• Webador, a DIY website builder.
• Research Square, a preprint platform and an academic author services company.
• Bright Answer, part of tool that builds custom online research and psychometrics solutions.
• Tiki24 to let their customers send mail using different adapters.

Hello,

I use Mandrill for months, but since it's not free anymore, I'm going to use Mailgun. I saw there is a template feature in Mailgun, but nothing in the SlmMail Mailgun support.

Is it a missing feature ? Or I'm missing something ?

Thanks for your awesome work !

While doing a quick overview of what's new in all the API we support, I realized that Postage support variables per recipient. We only support global variables. (Reference: http://help.postageapp.com/kb/api/send_message)

I suggest:

• Renaming getVariables to getGlobalVariables (as in Mandrill, and because it makes sense)
• Adding a getVariables which take recipient address as first parameter (as in Mandrill).

As this is a BC, we may do it for 2.0 (I don't think it's a big deal to iterate quickly, as SlmMail is really working well, I see no problem at quickly having another major version for such things).