It seems that timezone is always saved as "America/New_York". This seems to be some sort of default / localhost value.

I now have to do another check after login to see if NULL or "America/New_York" and update accordingly.

All of my calls to geoip()->getLocation() seem to work correctly, so don't know what's happening in in this library's Login listener that fails.

i want to use this command in my model like this:

    public function getTimeAttribute($value){
        return Timezone::convertFromLocal($this->start);
    }

but it returns this error: Class 'App\Timezone' not found

Related to issue #8

@jamesmills & @ridz1208 I did some initial implementation on that issue, please take a look and feel free to add comments, commits, etc. ;)

I initially thought of creating a lookup table so we can search in whatever attribute inside the request helper, by any key. Having in mind when the key is found inside the attribute, that key will be used.

Hello!

Installed as shown, but once i Login i Get the message "Invalid argument supplied for foreach()".

here:

        /**

    * @return mixed

    */

    private function getFromLookup()

    {

        $result = null;

 

        foreach (config('timezone.lookup') as $type => $keys) {

            if (empty($keys)) {

                continue;

            }

 

            $result = $this->lookup($type, $keys);

 

            if (is_null($result)) {

                continue;

            }

        }

 

        return $result;

    }

 

    /**

At Timezone::convertToLocal has an if statement which checks if the date is not null. That statement is never reached because the method signature required the first param to be a Carbon Object.

I had sometimes my date are null which broke the @displayDate directive.

Hi, thanks for great laravel package, i think Method 'convertFromLocal' should convert local time to Laravel Default Timezone, not UTC due some application use different Timezone

Hi!

User timezone value are always been saved as 'America/New_York', or wathever the default timezon in geoip config is.

It is because i'm on localhost? Or maybe I've missed something during installation?

Thanks in advance!

It would be very useful to make the included migration publishable and to use current date for filename. I am having issues with your package trying to update users table that has not yet been created.

Hi,

Thanks for this nice package, I've integrated it on live server, and I'm using ipgeolocation service in geoip package config. So, I found this bug here :

if (config('timezone.overwrite') == true || $user->timezone == null) {
                $user->timezone = $geoip_info['timezone'];
                $user->save();
                $this->notify($geoip_info);
 }

This : $geoip_info['timezone'] returns Null Here dd($geoip_info) (See Attached) So to fix it : ` $user->timezone = $geoip_info->time_zone['name'];

`

Thanks.

Added an event listener to clear config cache (#33).

The event used is pre-package-install Composer Scripts - Package Events

To read mode Composer Scripts

Laravel gives us the ability to use custom classes when casting attributes directly from the model.

Docs (https://laravel.com/docs/7.x/eloquent-mutators#custom-casts)

Basic usage

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use JamesMills\LaravelTimezone\Casts\Timezone;

class Foo extends Model
{
    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'created_at' => Timezone::class,
    ];
}

Advanced usage

Custom format

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use JamesMills\LaravelTimezone\Casts\Timezone;

class Foo extends Model
{
    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'created_at' => Timezone::class.':Y-m-d H:i:s',
    ];
}

Return the timezone as a string passing along the format.

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use JamesMills\LaravelTimezone\Casts\Timezone;

class Foo extends Model
{
    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'created_at' => Timezone::class.':d/m/Y H:i:s,true',
    ];
}

Return the timezone as a string using the default format.

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use JamesMills\LaravelTimezone\Casts\Timezone;

class Foo extends Model
{
    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'created_at' => Timezone::class.':null,true',
    ];
}

It is important to note the addition of: use App\Models\User in the modified file... This may not be compatible with earlier versions of Laravel. Is there a way to conditionally use App\Models\User OR App\User depending on the version?

It seems like this package doesn't support stateless requests (only web middleware). If we aren't using Web routes, we get Illuminate\\Auth\\RequestGuard::loginUsingId does not exist - how can we use this? Thanks for the help.

At this moment, if IP is not found, the loop skips but eventually the last resolved IP is taken.

IMHO it should be the first IP grabbed, for example I'd like to get real user IP from cloudflare using this code:

'lookup' => [
        'server' => [
            'HTTP_CF_CONNECTING_IP',
            'REMOTE_ADDR',
        ],
        'headers' => [

        ],
    ],

Now, I need to use 'HTTP_CF_CONNECTING_IP' as the last option which is not intuitive, and we unnecessarily loop through all the items.

Solves: https://github.com/jamesmills/laravel-timezone/issues/78

At this moment, the library takes the last found IP from the 'lookup' config key. In documentation there is written "Having in mind when the key is found inside the attribute, that key will be used.", and I believe it should be the first taken.

I'd go with this changes to the lookup() method:

private function lookup($type, $keys)
    {
        $value = null;

        foreach ($keys as $key) {
            if (request()->$type->has($key)) {
                return request()->$type->get($key);
            }
        }

        return $value;
    }