Simple forum software for building great communities.

In every extension, we have an AddClientAssets listener which is basically the same:

class AddClientAssets
{
    public function subscribe(Dispatcher $events)
    {
        $events->listen(ConfigureClientView::class, [$this, 'addAssets']);
    }

    public function addAssets(ConfigureClientView $event)
    {
        if ($event->isForum()) {
            $event->addAssets([
                __DIR__.'/../../js/forum/dist/extension.js',
                __DIR__.'/../../less/forum/extension.less'
            ]);
            $event->addBootstrapper('flarum/auth/facebook/main');
        }

        if ($event->isAdmin()) {
            $event->addAssets([
                __DIR__.'/../../js/admin/dist/extension.js',
                __DIR__.'/../../less/forum/extension.less'
            ]);
            $event->addBootstrapper('flarum/auth/facebook/main');
        }
    }
}

Given that this asset file-structure is a best practice, we could reduce this duplication by providing an instantiable AddDefaultClientAssets listener. In bootstrap.php, instead of:

return function (Dispatcher $events) {
    $events->subscribe(Listener\AddClientAssets::class);
};

you would use:

return function (Dispatcher $events, Extension $extension) {
    $events->subscribe(new AddDefaultClientAssets($extension));
};

This would add the default asset file paths if they exist, along with JS bootstrappers using the Extension's ID as a prefix.

We could also extend this idea of shortcut listeners to other things, e.g.:

return function (Dispatcher $events) {
    $events->subscribe(new AddForumRoute($extension, 'get', '/auth/facebook', 'auth', FacebookAuthController::class));

    $events->subscribe(new AddPostType(DiscussionStickiedPost::class));
};

This needs discussion because to me it's a little unclear how far we would want to go with providing these helpers. Where do we draw the line?

Bug report

• Version of Flarum: 0.1.0-beta.7
• The webserver you are running: apache + nginx
• PHP version: 7.1.7
• MySQL version: MariaDB 10.2.7

Getting this error when trying to install:

Something went wrong: SQLSTATE[42000]: Syntax error or access violation: 1067 Invalid default value for 'notifications_read_time' (SQL: ALTER TABLE main_users CHANGE notification_read_time notifications_read_time DATETIME DEFAULT 'NULL')

UPDATE: Adding composer show

components/font-awesome         4.7.0         The iconic font designed for use with Twitter Bootstrap.
danielstjules/stringy           1.10.0        A string manipulation library with multibyte support
dflydev/fig-cookies             v1.0.2        Cookies for PSR-7 HTTP Message Interface.
doctrine/annotations            v1.5.0        Docblock Annotations Parser
doctrine/cache                  v1.7.0        Caching library offering an object-oriented API for many cache backends
doctrine/collections            v1.5.0        Collections Abstraction library
doctrine/common                 v2.8.0        Common Library for Doctrine projects
doctrine/dbal                   v2.6.0        Database Abstraction Layer
doctrine/inflector              v1.2.0        Common String Manipulations with regard to casing and singular/plural rules.
doctrine/lexer                  v1.0.1        Base library for a lexer that can be used in Top-Down, Recursive Descent Parsers.
filp/whoops                     2.1.9         php error handling for cool kids
flarum/core                     v0.1.0-beta.7 Delightfully simple forum software.
flarum/flarum-ext-akismet       v0.1.0-beta.6 Stop spam using the Akismet anti-spam service.
flarum/flarum-ext-approval      v0.1.0-beta.7 Make discussions and posts require moderator approval.
flarum/flarum-ext-auth-facebook v0.1.0-beta.6 Allow users to log in with Facebook.
flarum/flarum-ext-auth-github   v0.1.0-beta.6 Allow users to log in with GitHub.
flarum/flarum-ext-auth-twitter  v0.1.0-beta.6 Allow users to log in with Twitter.
flarum/flarum-ext-bbcode        v0.1.0-beta.5 Allow posts to be formatted with BBCode.
flarum/flarum-ext-emoji         v0.1.0-beta.6 Convert text and unicode emoji into Twemoji.
flarum/flarum-ext-english       v0.1.0-beta.7 English language pack.
flarum/flarum-ext-flags         v0.1.0-beta.7 Allow users to flag posts for moderator review.
flarum/flarum-ext-likes         v0.1.0-beta.6 Allow users to like posts.
flarum/flarum-ext-lock          v0.1.0-beta.7 End a discussion and don't let anyone add further replies.
flarum/flarum-ext-markdown      v0.1.0-beta.5 Allow posts to be formatted with Markdown.
flarum/flarum-ext-mentions      v0.1.0-beta.7 Mention and reply to specific posts and users.
flarum/flarum-ext-pusher        v0.1.0-beta.6 See new discussions and posts in real-time using Pusher.
flarum/flarum-ext-sticky        v0.1.0-beta.7 Pin discussions to the top of the list.
flarum/flarum-ext-subscriptions v0.1.0-beta.6 Allow users to follow discussions and receive notifications for new posts.
flarum/flarum-ext-suspend       v0.1.0-beta.7 Suspend users so they can't post.
flarum/flarum-ext-tags          v0.1.0-beta.8 Organize discussions into a hierarchy of tags and categories.
franzl/studio                   0.11.2        Develop your Composer libraries with style
franzl/whoops-middleware        0.4.1        
guzzlehttp/guzzle               6.3.0         Guzzle is a PHP HTTP client library
guzzlehttp/promises             v1.3.1        Guzzle promises library
guzzlehttp/psr7                 1.4.2         PSR-7 message implementation that also provides common utility methods
http-interop/http-middleware    0.2.0         Common interface for HTTP middleware
illuminate/bus                  v5.1.41       The Illuminate Bus package.
illuminate/cache                v5.1.41       The Illuminate Cache package.
illuminate/config               v5.1.41       The Illuminate Config package.
illuminate/container            v5.1.41       The Illuminate Container package.
illuminate/contracts            v5.1.41       The Illuminate Contracts package.
illuminate/database             v5.1.41       The Illuminate Database package.
illuminate/events               v5.1.41       The Illuminate Events package.
illuminate/filesystem           v5.1.41       The Illuminate Filesystem package.
illuminate/hashing              v5.1.41       The Illuminate Hashing package.
illuminate/mail                 v5.1.41       The Illuminate Mail package.
illuminate/pipeline             v5.1.41       The Illuminate Pipeline package.
illuminate/support              v5.1.41       The Illuminate Support package.
illuminate/validation           v5.1.41       The Illuminate Validation package.
illuminate/view                 v5.1.41       The Illuminate View package.
intervention/image              2.4.0         Image handling and manipulation library with support for Laravel integration
ircmaxell/random-lib            v1.2.0        A Library For Generating Secure Random Numbers
ircmaxell/security-lib          v1.1.0        A Base Security Library
league/flysystem                1.0.40        Filesystem abstraction: Many filesystems, one API.
league/oauth1-client            1.7.0         OAuth 1.0 Client Library
league/oauth2-client            1.4.2         OAuth 2.0 Client Library
league/oauth2-facebook          1.4.5         Facebook OAuth 2.0 Client Provider for The PHP League OAuth2-Client
league/oauth2-github            0.2.2         Github OAuth 2.0 Client Provider for The PHP League OAuth2-Client
matthiasmullie/minify           1.3.46        CSS & JS minifier
matthiasmullie/path-converter   1.1.0         Relative path converter
monolog/monolog                 1.23.0        Sends your logs to files, sockets, inboxes, databases and various web services
nesbot/carbon                   1.22.1        A simple API extension for DateTime.
nikic/fast-route                v0.6.0        Fast request router for PHP
oyejorge/less.php               v1.7.0.14     PHP port of the Javascript version of LESS http://lesscss.org (Originally maintained by Josh Schmidt)
paragonie/random_compat         v1.4.2        PHP 5.x polyfill for random_bytes() and random_int() from PHP 7
psr/http-message                1.0.1         Common interface for HTTP messages
psr/log                         1.0.2         Common interface for logging libraries
pusher/pusher-php-server        2.6.4         Library for interacting with the Pusher REST API
s9e/text-formatter              0.8.5         Multi-purpose text formatting and markup library. Plugins offer support for BBCodes, Markdown, emoticons, HTML, embedding media (YouTube, e...
swiftmailer/swiftmailer         v5.4.8        Swiftmailer, free feature-rich PHP mailer
symfony/console                 v2.8.25       Symfony Console Component
symfony/debug                   v2.7.32       Symfony Debug Component
symfony/filesystem              v3.3.5        Symfony Filesystem Component
symfony/finder                  v2.7.32       Symfony Finder Component
symfony/http-foundation         v2.7.32       Symfony HttpFoundation Component
symfony/polyfill-mbstring       v1.4.0        Symfony polyfill for the Mbstring extension
symfony/process                 v3.3.5        Symfony Process Component
symfony/translation             v2.7.32       Symfony Translation Component
symfony/yaml                    v2.8.25       Symfony Yaml Component
tijsverkoyen/akismet            1.1.1         Akismet is a wrapper-class to communicate with the Akismet API.
tobscure/json-api               v0.3.0        JSON-API responses in PHP
zendframework/zend-diactoros    1.4.0         PSR HTTP Message implementations
zendframework/zend-escaper      2.5.2        
zendframework/zend-stratigility 1.3.3         Middleware for PHP

This (i think) fixes #258. Please give me feedback to make anything better :wink:

The only thing missing is the locale in flarum/flarum-ext-english I've tested it, and it works fine; aka it puts the data in the database correctly. Here is a screenshot:

Before stable we need to:

• decide on a permission convention
• decide whether we want to enact this convention
• if so, apply the changes to core and bundled extensions.

Some options in the conventions:

• using dot namespaced permission, eg user.edit
• using camelcase userEdit

What we have to consider is that permissions are usually made an attribute on a model. So it's pretty confusing if different conventions are used for model attributes, permissions and permission grid keys, for instance:

camelCase used in core for viewDiscussions: https://github.com/flarum/core/blob/88366fe8af3baa566ad625743016acb85a0cf345/js/src/admin/components/PermissionGrid.js#L104-L113

camelCase and dot mixed viewLastSeenAt and user.viewLastSeenAt: https://github.com/flarum/core/blob/88366fe8af3baa566ad625743016acb85a0cf345/js/src/admin/components/PermissionGrid.js#L153-L157

Part of #262.

The base Component class is an abstraction layer on top of Mithril's raw components which makes components a bit easier to work with, a bit more React-like, and is better for extensibility.

It's very generic, with no specific ties to Flarum, so it should be extracted into its own external package so it can be used in other projects and developed independently of Flarum.

Unfortunately, its API is also very unfamiliar. It's really an odd mix of Mithril and React. We have the view method from Mithril, config as a method instead of a vdom attribute, onunload from Mithril, this.props from React, this.$() from Ember, and some of our own inventions like init and initProps. This mixture is bad for onboarding new core/extension developers, because they'll have to learn something new/different even if they're already familiar with Mithril/React.

I propose that when we extract this package, we change the API so that it reflects React as closely as possible. (The React API is more flexible and better for extensibility than the Mithril API.) The package can be called tobscure/mithreact – a React-like API for Mithril components.

Here is an example of a simple component – first with the current API, and then the equivalent with my proposed Mithreact API:

Current

class MyComponent extends Component {
  // 1. Initialize props as they come in
  static initProps(props) {
    props.icon = props.icon || 'mail';
    props.className += ' bar';
  }

  init() {
    super.init();

    // 2. Set initial state
    this.email = m.prop('[email protected]');

    // 3. Determine whether the component should redraw by dirty-checking a value
    this.subtree = new SubtreeRetainer(this.email);
  }

  view() {
    // 3. Determine whether the component should redraw by dirty-checking a value
    return this.subtree.retain() || () =>
      <div className={this.props.className}>
        <i className={'fa fa-'+this.props.icon}/>
        // 4. Get and set component state
        <input type="text" value={this.email()} onchange={m.withAttr('value', this.email)}/>
      </div>;
  }

  config(isInitialized) {
    if (!isInitialized) {
      // 5. Initialize the DOM
      this.$('input').css('border-color', 'red');
    } else {
      // 6. Update the DOM
      this.$('input').css('border-color', 'blue');
    }
  }

  onunload(e) {
    // 7. Hook onto component dismount, and potentially prevent it
    if (this.email() !== '[email protected]') {
      e.preventDefault();
    }
  }
}

Mithreact

class Dropdown extends Component {
  // 1. Initialize props as they come in
  getDefaultProps() {
    return {icon: 'mail'};
  }

  componentWillReceiveProps(nextProps) {
    nextProps.className += ' bar';
  }

  // 2. Set initial state
  getInitialState() {
    return {email: '[email protected]'};
  }

  render() {
    return (
      <div className={this.props.className}>
        <i className={'fa fa-'+this.props.icon}/>
        // 4. Get and set component state
        <input type="text" value={this.state.email} onchange={this.handleEmailChange.bind(this)}/>
      </div>
    );
  }

  handleEmailChange(e) {
    this.setState({email: e.target.value});
  }

  componentDidMount() {
    // 5. Initialize the DOM
    this.$('input').css('border-color', 'red');
  }

  shouldComponentUpdate(nextProps, nextState) {
    // 3. Determine whether the component should redraw by dirty-checking a value
    return nextState.email !== this.state.email;
  }

  componentDidUpdate() {
    // 6. Update the DOM
    this.$('input').css('border-color', 'blue');
  }

  componentWillUnmount() {
    // 7. Hook onto component dismount, and potentially prevent it
    if (this.email() !== '[email protected]') {
      return false;
    }
  }
}

Advantages of Mithreact:

• It's more or less the same as the React API, so people will be familiar with it
• By dividing things up into more methods with less arguments, things are cleaner, and extensions will have an easier time monkey-patching
• Component state is encapsulated so we can potentially get some performance gains for free

Disadvantages:

• Lots of refactoring to do for core + existing extensions

Thoughts?

_1 Upvote_ The Extensions page should be divided into categories so extensions will be easier to locate.

Possible categories to add:

• Authentication & Security
• Formatting (Markdown, BBcode, etc.)
• Language packs
• Themes
• Other

The Extension page will need to use composer.json tag info to determine which category an installed extension should be displayed under.

Bug Report

Current Behavior In Internet Explorer Version 11 (11.407.17134.0) on Windows 10 (10.0.17134 Build 17134), I am unable to create a discussion or even reply to one when I am logged in. What makes this absolutely weird is that I'm getting no errors in the console and the only reason how I came across these bugs was that I was in the process of retesting to #1174. I can reproduce this both locally and on Flarum Discuss (despite Flarum Discuss running on dev-master). I have kept in mind that Microsoft does not support this browser anymore as of January 12, 2016, but it is still bundled with the OS and is still widely used with legacy web applications.

Steps to Reproduce

Part 1:

1. Open up Internet Explorer (Version 11).
2. Go to your locally hosted Flarum or https://discuss.flarum.org/
3. Log in if you aren't already.
4. Click on the "Start a Discussion button".
5. Observe as the discussion composer does not appear.

Part 2:

1. Open up Internet Explorer (Version 11).
2. Go to your locally hosted Flarum or https://discuss.flarum.org/
3. Log in if you aren't already.
4. Open up any discussion that is not locked.
5. Attempt to reply to the discussion.
6. Observe as the reply/pos composer does not appear.

Expected Behavior In using IE11, I should be able to create a new discussion and see the discussion composer pop-up as well as being able to reply to any discussion that is not locked.

Screenshots N/A

Environment

• Flarum version: v0.1.0-beta.8.1 (locally hosted) or dev-master on Flarum Discuss
• Website URL: Localhost or https://discuss.flarum.org/
• Webserver: Apache (locally hosted)
• Hosting environment: Locally hosted (WAMP)
• PHP version: 7.2.4 (locally hosted)
• Browser: Internet Explorer Version 11 (11.407.17134.0)

Output of "php flarum info", run this in terminal in your Flarum directory.

Flarum core 0.1.0-beta.8.1
PHP version: 7.2.4
Loaded extensions: Core, bcmath, calendar, ctype, date, filter, hash, iconv, jso
n, mcrypt, SPL, pcre, readline, Reflection, session, standard, mysqlnd, tokenize
r, zip, zlib, libxml, dom, PDO, bz2, SimpleXML, xml, wddx, xmlreader, xmlwriter,
 openssl, curl, fileinfo, gd, gettext, gmp, intl, imap, ldap, mbstring, exif, my
sqli, Phar, pdo_mysql, pdo_sqlite, soap, sockets, sqlite3, xmlrpc, xsl
+----------------------+-----------------+--------+
| Flarum Extensions    |                 |        |
+----------------------+-----------------+--------+
| ID                   | Version         | Commit |
+----------------------+-----------------+--------+
| flarum-approval      | v0.1.0-beta.8   |        |
| flarum-bbcode        | v0.1.0-beta.8   |        |
| flarum-emoji         | v0.1.0-beta.8   |        |
| flarum-lang-english  | v0.1.0-beta.8   |        |
| flarum-flags         | v0.1.0-beta.8.1 |        |
| flarum-likes         | v0.1.0-beta.8.1 |        |
| flarum-lock          | v0.1.0-beta.8   |        |
| flarum-markdown      | v0.1.0-beta.8   |        |
| flarum-mentions      | v0.1.0-beta.8.1 |        |
| flarum-statistics    | v0.1.0-beta.8   |        |
| flarum-sticky        | v0.1.0-beta.8   |        |
| flarum-subscriptions | v0.1.0-beta.8   |        |
| flarum-suspend       | v0.1.0-beta.8   |        |
| flarum-tags          | v0.1.0-beta.8.2 |        |
+----------------------+-----------------+--------+
Base URL: http://b81.test
Installation path: C:\wamp64\www\b81.test
Debug mode: off

Possible Solution N/A

Additional Context N/A

Closes #1236

Related PRs https://github.com/flarum/flarum-ext-akismet/pull/10 https://github.com/flarum/flarum-ext-approval/pull/15 https://github.com/flarum/flarum-ext-flags/pull/15 https://github.com/flarum/flarum-ext-likes/pull/16 https://github.com/flarum/flarum-ext-lock/pull/16 https://github.com/flarum/flarum-ext-mentions/pull/34 https://github.com/flarum/flarum-ext-sticky/pull/11 https://github.com/flarum/flarum-ext-subscriptions/pull/18 https://github.com/flarum/flarum-ext-suspend/pull/19 https://github.com/flarum/flarum-ext-tags/pull/53

See example below:

Hey lcarlos!

rafaelazem mentioned you in a post in Transportadora no FKcarrier - dobrando o valor do frete.

http://www.modulosfk.com.br/modulosfk/flarum/d/19/6

---

@lcarlos resolvido! Muito obrigado!

Apenas uma última dúvida, o FKcorreios G2 substitui o FKcarrier em suas funcionalidades, isto?

Obrigado!

Currently username can be any matching regex:/^[a-z0-9_-]+$/i and the other rules (eg, min: 3). A drawback of this regex is that it allows for numeric usernames. As a consequence consider:

User

• id: 1337 username: Toby
• id: 1338 username: 1337

Hitting /api/user/1337 returns user 1337 for any other user.

What we have to do is disallow any numeric usernames, the UserValidator has to be modified. A consideration is what to do with existing users.

We want to offer an extensible user list which displays users sorted by metrics (no. of posts/discussions in core, and could be extended to show no. of likes received, etc.)

What needs to be done:

• Decide if this should be part of core, or should be a default extension. (i.e. should we allow it to be disabled?)
• Design it.
• Implementation needs to be nutted out

Apologies if this is not the correct repo to report at. I encountered the below styling issues on the latest version of Chrome Android.

1. Long titles don't show entirely in the notifications area.
2. The margins of the tags don't seem to be correct.

Attaching Screenshots. Taken at community.sheetgo.com.

GrapheneOS is currently using 'unix_socket' => '/run/mysqld/mysqld.sock' in production and it works fine, just that the config file needs to manually edited and the database wizard doesn't seem to expose this.

Changes proposed in this pull request:

Creates a new TagSelector component, designed for use within buildSettingComponent in conjuction with core PR #3494.

This allows extensions to more easily select tag model instances within their settings pages.

Reviewers should focus on:

Checks may fail until #3494 is merged.

Screenshot

https://user-images.githubusercontent.com/7406822/174515268-493ee6e2-19ee-4a27-a7a6-7ce54ab8b4cb.mp4

Necessity

• [x] Has the problem that is being solved here been clearly explained?
• [x] If applicable, have various options for solving this problem been considered?
• [x] For core PRs, does this need to be in core, or could it be in an extension?
• [x] Are we willing to maintain this for years / potentially forever?

Confirmed

• [x] Frontend changes: tested on a local Flarum installation.
• [x] Core developer confirmed locally this works as intended.
• [x] Tests have been added, or are not appropriate here.

Required changes:

• [ ] Related core PRs: #3494

Need to:

• [x] move workflow definitions from .github to the monorepo (here) (https://github.com/flarum/framework/pull/3490).
• [ ] start testing with PHP 8.2

https://github.com/flarum/framework/blob/main/framework/core/views/install/update.php#L20

https://github.com/flarum/framework/blob/main/framework/core/views/install/install.php#L69

Changes proposed in this pull request: In this PR I've worked on making it possible to have multiple dialogs opened at the same time and make them stackable. I have partly used code of #3246 and altered it. It also removed the bootstrap modal dependency.

However, I did not proceed using the native HTML Dialog element for this PR due to lack of animations (for example, the backdrop is not animatable) and responsiveness with the interface.

A third parameter has been added to the app.modal.show function which is a boolean and defaults to false. This means that all already existing modals will keep their intended behaviour.

I also copied the new 'dismissable' options from the other PR, such as an option to hide the dialog on escape key, clicking on the backdrop or using the close button and managing them seperately per modal. This means there is a deprecation too which was mentioned in the code.

Reviewers should focus on:

• Current modals are opening and closing as intended
• Stacking multiple modals works
• Responsiveness is still good

Necessity

• [x] Has the problem that is being solved here been clearly explained?
• [x] If applicable, have various options for solving this problem been considered?
• [x] For core PRs, does this need to be in core, or could it be in an extension?
• [x] Are we willing to maintain this for years / potentially forever?

Confirmed

• [ ] Frontend changes: tested on a local Flarum installation.
• [ ] Backend changes: tests are green (run composer test).
• [ ] Core developer confirmed locally this works as intended.
• [ ] Tests have been added, or are not appropriate here.