The following class instance variable:

    /**
     * If you’ve enabled user specific timezones, you may set or update the
     * user timezone.
     * @see https://docs.looker.com/reference/embedding/timezones
     * @var string|null
     */
    public $userTimeZone = null;

Produces the error:

  [InvalidArgumentException]
  "\Kounta\Insights\Looker\https://docs.looker.com/reference/embedding/timezones" is not a valid Fqsen.

using the latest release v.0.1.0 I am running into the following error

$ php phpdoc-to-typehint.phar .
PHP Fatal error:  Cannot use 'Void' as class name as it is reserved in phar://C:
/Users/mstaab/Documents/GitHub/deployer/phpdoc-to-typehint.phar/vendor/phpdocume
ntor/type-resolver/src/Types/Void.php on line 23

Fatal error: Cannot use 'Void' as class name as it is reserved in phar://C:/User
s/mstaab/Documents/GitHub/deployer/phpdoc-to-typehint.phar/vendor/phpdocumentor/
type-resolver/src/Types/Void.php on line 23

seems like the downloaded phar is unusable to run on php7.1+

$ php -v
PHP 7.1.2 (cli) (built: Feb 14 2017 21:24:45) ( NTS MSVC14 (Visual C++ 2015) x64 )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies

Before

    /**
     * The copy the specified message(s) to a specified mailbox.
     *
     * @param string $msgSet  Message(s) to fetch
     * @param string $mailbox Name of mailbox to copy messages to
     * @param bool   $uid     Weather to use UID
     *
     * @return array Raw from responce()
     */
    public function copy($msgSet, $mailbox, $uid = false)
    {
    }

after

    /**
     * The copy the specified message(s) to a specified mailbox.
     *
     * @param string $msgSet  Message(s) to fetch
     * @param string $mailbox Name of mailbox to copy messages to
     * @param bool   $uid     Weather to use UID
     *
     * @return array Raw from responce()
     */
    public function copy($msgSet, string $mailbox, bool $uid = false): array
    {
    }

• Add development dependency on phpunit/phpunit ^6.0
• Update composer.lock for PHPUnit only
• Change .travis.yml to use PHPUnit in vendor directory
• Put expected test results into a new directory

Hello,

Are there any plans to support PHP7.1 new type declarations and nullable types? Example:

function returnsNothing(iterable $iterable, ?string $nullableString): void {
...
}

Only in effect on all-lowercase types. This is to filter out stuff like mixed, void, $this, etc.

Currently return type hints like mixed, void or $this, which are quite common, get converted literally into PHP.

mixed and void are expected to be classes, $this isn't an allowed syntax.

The idea of this PR is that, in case the whole type hint is in lowercase, it must be one of the supported type declarations as listed at http://php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration ; otherwise the type hint gets just ignroed.

This automatically filters out a lot of unsupported stuff.

An edge case is when referring to all-lowercase classes. This PR wouldn't support them.

If this is acceptable, I can provide tests too.

This works, but I cannot get phpunit anymore as a dependency. This because of phpspec/prophecy does not support phpdocumentor/reflection-docblock:^5 yet.

Should I go for including the phpunit.phar archive ? Should we wait the support of phpdocumentor/reflection-docblock:^5 by prophecy? Maybe another solution...

WDYT ?

/**
 * @param array $array
 */
function test(&$array) {}

Becomes

/**
 * @param array $array
 */
function test(&array $array) {}

Should have been

/**
 * @param array $array
 */
function test(array &$array) {}

I don't think it is correct to generate code which will put an argument with a default value before an argument without a default value.

In the example the generated code produces a function like that:

function bar(int $a = null, string $b, bool $c, callable $d = null) : float

This means the first argument is optional, but the second and third aren't.

I realise = null is the only way in PHP before 7.1 to specify a type-hinted argument could also be null, but generating such code I think is incorrect.

My suggestion is to never make a parameter without a default value to have one.

When PHP 7.1 is available - #16, the example could be using ?int which would be correct.

If the function is overriding a parent method there are limitations to changing the method signature. Future PHP versions could improve that with more support for Covariance and Contravariance, but there are still cases where signatures could not blindly be changed.

If the PHPDoc to typehints conversion take this into account and don't change things which would produce a direct PHP error it would be less risky and could be deployed more widely. It could even work in a CI environment.

Code like this:

class Foo
{
	public const BAR = 1;
}

produces the following error:

[PhpParser\Error]
  Syntax error, unexpected T_CONST, expecting T_FUNCTION on line 16

This is valid code in PHP 7.1.