At Version Version 3.2.2 I got a RuntimeException when the Date reaches the German time change.

The following Code works fine:

$cronExpression = new CronExpression('0 0 1 * *');
$date = new \DateTime('2022-10-30', new \DateTimeZone("UTC"));
$cronExpression->getNextRunDate($date)

but if I change the Timezone to Europe/Berlin:

$cronExpression = new CronExpression('0 0 1 * *');
$date = new \DateTime('2022-10-30', new \DateTimeZone("Europe/Berlin"));
$cronExpression->getNextRunDate($date)

I get a RuntimeException: Impossible CRON expression

Debugging from AbstractField::timezoneSafeModify:

    protected function timezoneSafeModify(DateTimeInterface $dt, string $modification): DateTimeInterface
    {
        $timezone = $dt->getTimezone();
        var_dump($dt);
        $dt = $dt->setTimezone(new \DateTimeZone("UTC"));
        var_dump($dt);
        $dt = $dt->modify($modification);
        $dt = $dt->setTimezone($timezone);
        die(var_dump($dt));
        return $dt;
    }

object(DateTime)[2430]
  public 'date' => string '2022-10-30 00:00:00.000000' (length=26)
  public 'timezone_type' => int 3
  public 'timezone' => string 'Europe/Berlin' (length=13)
/src/Cron/AbstractField.php:327:
object(DateTime)[2430]
  public 'date' => string '2022-10-29 22:00:00.000000' (length=26)
  public 'timezone_type' => int 3
  public 'timezone' => string 'UTC' (length=3)
/src/Cron/AbstractField.php:330:
object(DateTime)[2430]
  public 'date' => string '2022-10-30 23:00:00.000000' (length=26)
  public 'timezone_type' => int 3
  public 'timezone' => string 'Europe/Berlin' (length=13)

If needed, i can pr a failing Test by tomorrow.

I love this library. I'm using it to run billing on varying schedules.

I just ran into a situation where one customer needs an invoice generated from the 1st of the month through the 15th of the month, and from the 15th of the month through the last day of the month. So invoice generation needs to run at the end of the day (for them this is 6:00 PM PST) on the 15 and the last day of the month. My schedule looks like this:

0 18 L,15 * *

Unfortunately, it does not look like the "day of the month" supports multiple comma-separated days including "L" for the last day, the way it does numeric days.

If this is a desired feature, I'm happy to try and tackle it.

Input

$expression = '2,17,35,47 5-7,11-13 * * *';

Expected behaviour

• CronExpression::isValidExpression($expression) returns true
• CronExpression::factory($expression) returns a CronExpression instance.

Referring to crontab.guru this is a valid expression.

Actual behaviour

• CronExpression::isValidExpression($expression) returns false
• CronExpression::factory($expression) throws an InvalidArgumentException with message Invalid CRON field value 5-7,11-13 at position 1

Identified cause

Range and list at the same time in the same field are not accepted.

See https://github.com/dragonmantank/cron-expression/blob/v2.0.0/src/Cron/AbstractField.php#L210

I would like to provide a PR, if you confirm this is a valid issue.

I once implemented a cron expression validator myself, which allows this expression. I updated it today to be compatible with the PHPUnit 6+ version.

@dragonmantank

cron schedule: 0-59/59 10 * * *

$times = [];
$now = new Carbon();

$cron = CronExpression::factory("0-59/59 10 * * *");
for ($k = 0 ; $k < 20; $k++){
	$times[] = $cron->getNextRunDate($now, $k);
}

There is a bug. 2020-08-20 10:00:00 is missed. The first time is 2020-08-20 10:59:00

I think it is useful to have working PHPCS functionality in the project it self, which can now simply be executed using:

composer phpcs for a dry run composer phpcs-fix for actual fixing.

For now only applied @PSR2

@dragonmantank I'm using v2 of library:

$now = new Carbon();
$cron = CronExpression::factory("41-59/24 5 * * 5");
for ($k = 0 ; $k < 20; $k++){
	$t = $cron->getNextRunDate($now, $k);
	$times[] = $t; // Store next 20 values
}
		

Error:

range(): step exceeds the specified range

/vendor/dragonmantank/cron-expression/src/Cron/AbstractField.php:148 /vendor/dragonmantank/cron-expression/src/Cron/AbstractField.php:53 /vendor/dragonmantank/cron-expression/src/Cron/MinutesField.php:31 /vendor/dragonmantank/cron-expression/src/Cron/CronExpression.php:362 /vendor/dragonmantank/cron-expression/src/Cron/CronExpression.php:199

Hello,

I do:

• Set PHPStan to level max (ie 8) https://phpstan.org/user-guide/rule-levels.
• Fix issues throws by PHPStan
• Add PHPStan to Travis

It improve DX :rocket:

I use the library in a script that monitors cronjobs. Now we have the issue that crond handle the expression in another way than the library predicted.

The expression is: 30 0 1 * 1

Crond run on every monday and on every 1th of the month. Crond use OR. The library use AND. So the library thinks cron would only run when the 1th of the month is a monday.

Is it intentional that the library behaves like this or is it a bug?

The library supports all PHP Versions >=7.0.0 according to the composer.json. That's why this PR adds strict scalar type hints to the methods that are currently defined in the src folder. I added the types according to the DocBlock of each function.

Feedback is much appreciated :tada:

This allows extending classes to access the order for parts the same way as the base class.

This introduces no breaking changes. Could be introduced as a patch release.

FEATURE request:

It would be nice to have a method to translate cron string to a human readable format, like prettyCron js library (http://azza-bazoo.github.io/prettycron/). So for example:

Cron expression: 0 * * * * Human readable: Every hour, on the hour

Cron expression: 30 * * * 1 Human readable: Every 30th minute past every hour on Mon

Cron expression: 15,45 9,21 * * * Human readable: 09:15, 09:45, 21:15 and 21:45 every day

Cron expression: 18,19 7 5 * * Human readable: 07:18 and 07:19 on the 5th of every month

Cron expression: * * 25 12 * Human readable: Every minute on the 25th in Dec

Cron expression: 0 * 1,3 * * Human readable: Every hour, on the hour on the 1 and 3rd of every month

Cron expression: 0 17 * 1,4,7,10 * Human readable: 17:00 every day in Jan, Apr, Jul and Oct

Might be a stupid question.

Can someone explain what $blah->Due() is for...... I thought it was to check if a datetime = exactly now? So if it's not 12 am on the 11th of November (eg. before it) it would return false eg. $blah = new Cron\CronExpression( 'blah '); $blah->Due( '2022-11-11 00:00:00' ); but it always returns true

Do we need to check ourselves if a datetime = exactly now?

Hi Michael !

thanks for the repo, great job here !

I try to find out if I'm doing something wrong, or if the lib just doesn't handle the 'LW' combination option at the DayOfMonthField position.

like 0 10 LW * * stands for "At 10:00 AM, on the last weekday of the month" but I've got an error "Uncaught Error: Call to a member function format() on bool in /var/www/html/vendor/dragonmantank/cron-expression/src/Cron/DayOfMonthField.php:51"

could you please confirm if LW works !?

This solves #137

Passing two question marks into a cron expression does not really make sense in my opinion, as you would neither specify the day of month nor the day of week. Wikipedia states

In some implementations, used instead of '*' for leaving either day-of-month or day-of-week blank.

I guess, this is the implementation this library is following.

I've also added a check to validate if there are question marks in parts, where they are not allowed. Maybe there should be an extra step to validate each part against it's allowed values. What do you think about this?