Nginx is becoming a very widely used httpd lately. YOURLS should have some official support for the httpd so it can be used on more platforms. All you need to do is make a config for us Nginx users in the wiki :P

Hello,

My issue is similar to: http://code.google.com/p/yourls/issues/detail?id=1262

I'm using PHP v 5.4.9 ... All tables were installed correctly. I inserted a cookie from http://yourls.org/cookie .. I also deleted the username, password, cookie and replaced to see if that fixed the problem. It did not. I only have 1 username and PW in the config.php file.

Basically, when you enter the correct information into the admin login it says "Please Log In" ... anything incorrect entered gets an "Invalid Username / Password" ...

I see the request for var_dump() in functions-auth.php or auth.php but I am not necessarily an expert - I was wondering if anyone might point me in the direction of the lines to place the var_dump on and on what variable so I can see where exactly it is breaking.

I am using the latest 1.7 master because I had to use the master as it fixed a table install issue I believe w/ the version of MySQL I saw on another issue. So tables were removed and now appear as installed correctly.

I also tried this: define( 'YOURLS_NO_HASH_PASSWORD', true ); .. but no help .. to see if it was something to do with the password not being hashed in config.php

Finally, I am running nginx w/ the following config, although this may be unrelated (running varnish, hence 8080 - excluded yourls domain/directory in varnish config w/ pass):

server { listen 127.0.0.1:8080; server_name site.us; port_in_redirect off; access_log off; error_log /var/log/nginx/site.us.error.log; root /usr/share/nginx/www/site; location / { rewrite ^/([0-9a-z-]+)/?$ /s/yourls-go.php?id=$1 last; location ~ .php$ { try_files $uri =404; fastcgi_split_path_info ^(.+.php)(/.+)$; fastcgi_pass unix:/var/run/php5-fpm.sock; fastcgi_index index.php; fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; include fastcgi_params; }

} }

Thank you in advance for any guidance on how to identify this problem exactly. I am new to using var_dump.

This is a pull request for an implementation of time zone support and should resolve #1344 .

A new config parameter was added to the sample-config.php file called YOURLS_TIMEZONE. When this value is left empty, the value of YOURLS_HOURS_OFFSET is used, which allows for backward compatibility. This allows to keep using YOURLS_HOURS_OFFSET and avoids the need for all users to add the new config parameter YOURLS_TIMEZONE to their config file.

I first experimented with DateTime objects, but eventually went for a solution that calculates the offset of the timezone such that most of the original code can be kept, which reduces the risk of bugs.

Feedback and reviews are highly welcome, PHP is not my main language and I'm not sure either about the performance impact of my fix. Thanks!

I'm sure I config it right, but still can't access. I had the error "can't create table bla bla bla" then fixed, but I was getting "mysql version is too old bla bla bla" and then uploading the updated master version I get this error.

Edit: I tought it was a permission error, tryed to chmod 777 the admin dir but it won't access to the install page (sort of timeout)

EDIT2: Updated by erasing all the directory, all the databases, all the users databases, then reuploaded and recreated all. And this is what I get.

Redefinition of the interface to improve YOURLS experience.

Second interface preview. Need completions.

Interface Styling

• [x] Design with HTML5 - CSS3
  • Bootstrap 3.0.0
  • Flat UI
  • Font Awesome
  • Introduce Responsive-design
• [x] Clean HTML template
  • Clean declarations
  • More separated container
    • Header simplifying
    • Nav improving
    • Foot cleaning
• [x] Basic Installation corrections
  • Be friendly with errors - notices
  • Fix interface when re-loading installation
• [x] Loading pages & animation
• [x] Reduce request and loading time
  • Minimize in one file all code
• [x] Improve JavaScript
  • jQuery 2.0.0
  • ZeroClipboard
  • New interactions
• [x] Move assets in assets/ folder
• [x] Move flags into CSS

Themes

• [x] Create theme-sample repo
  • Import & use LESS files
• [x] Allow overwriting official style - resolves #1234
  • CSS - JS enqueue
  • Filters
• [x] Customize HTML structure
• [x] Add full bootstrap theme

Extra

Coding Style

• [x] Clean PHP with HTML
• [x] Apply strictly standards everywhere

Specific Cases

• [x] Fix unlicensed favicon
• [x] Remake graphically readme.html - resolves #1390
• [x] Twitter profile

It would be nice if YOURLS supported named time zones, e.g. "America/Los_Angeles" in addition to numbered time offsets (from server time zone), as it does currently.

This way daylight savings time would be handled correctly.

This can be done without complicating the PHP code, by letting MySQL handle it, by explicitly setting the time zone when the MySQL connection is made.

What steps will reproduce the problem?

1. Enter the following long URL: http://domain.com/good space/
2. The long URL is correctly stored as http://domain.com/good%20space/
3. Now, enter the following long URL: http://domain.com/bad%20space/
4. The long URL is incorrectly stored as http://domain.com/bad%2520space/

What is the expected output? What do you see instead?

What I expect is that YOURLS should be smart enough to know that '%20' is a space and should be left alone. Instead, what's happening is that YOURLS is converting the '%' to '%25' and therefore, the '%20' becomes '%2520'.

Perhaps there could be a check before cleaning up the long URL to detect '%20' or whatever else it could be (e.g. '%5C' for backspace, etc).

This is a COPY of Issue 1303: %20 in long URL not handled correctly, filed on Google Code before the project was moved on Github.

• Submitted on 2013-02-19T06:49:18.000Z by [email protected]
• Status: New

This is a COPY of Issue 1254: Full fledged installer, filed on Google Code before the project was moved on Github.

• Submitted on 2012-12-10T17:32:01.000Z by [email protected]
• Status: Accepted

Please review the original issue and especially its comments. Comments here on closed issues will be ignored. Thanks.

Original description

It would be neat to have a real installer with a web form instead of requiring users to manually edit the config.php

Copy "Famous WordPress 5 minutes install" (and make that "Famous YOURLS 4 minutes install", ah! beat that)

The installer should prompt for:
- YOURLS_DB_USER
- YOURLS_DB_PASS
- YOURLS_DB_NAME
- YOURLS_DB_HOST
- YOURLS_DB_PREFIX
- admin login / password

The installer should guess (and ask user if correct)
- YOURLS_SITE
- YOURLS_HOURS_OFFSET

The installer should generate
- YOURLS_COOKIEKEY

The installer should set default values for
- YOURLS_PRIVATE to true
- YOURLS_UNIQUE_URLS to true
- YOURLS_URL_CONVERT to 36 or 62? 62 seems to be the internet's default
- YOURLS_DEBUG to false

When shorting this URL: /Page.jsp?tI=ND6AWbgS5U4ky08ndJoxQg%253D%253D&uI=sA2%252BUi1VNUjpVsdS0GJGtw%253D%253D

it gets saved as: /Page.jsp?tI=ND6AWbgS5U4ky08ndJoxQg==&uI=sA2+Ui1VNUjpVsdS0GJGtw==

Looks the URL encoding gets decoded.

I searched for other closed/open issues related, and they were closed without resolution:

1. https://github.com/YOURLS/YOURLS/issues/1887
2. https://github.com/YOURLS/YOURLS/issues/2089
3. Hmm I thought I saw a 3rd one, but just about to run out the door, will edit later

Perhaps someone could offer some insight? I can confirm there was nothing in console, even with debug mode on (no CORS blocks or anything like that).

I checked out the site to get things working or I wouldn't have been able to add/edit/view things to begin with :) I have about 3 pages of links. It started when I went to edit a link, then that's when I realized.. nothing works! Funny enough, you can still delete. I can view and delete, but not edit or add. Strange, right?

Issue 1887 (#1 link above) has the EXACT issue as me -- worked fine, suddenly doesn't work with same reproduced results.

The last activity performed that I recall was adding "blog3" shorturl to a tumblr site. Doesn't seem too iregular : https://myblogtumblr.com/post/12345679/url-is-quite-long-with-dashes-like-this

I don't know if it was triggered by that or when I went to edit a random entry that's related to another social site - nothing special or no odd naming conventions or special chars.

There is one consistent thing I noticed: Every open issue, the same mod closed it blaming the hosting service: How about instead of closing this ticket, let's work together and find the solution, hm? This seems to be reproduced lately.

Another thing to add that seems quite important: I reinstalled using a new db, and seemed to work again. I curiously swapped back to the old DB to see if that would work. Everything was back AND I could add things .. and a few days later, this issue reproduced identically: Can suddenly, randomly, no longer add/edit.

Technical details

• YOURLS version: Latest
• PHP version: 5.6
• Win10 with multiple stable browsers

Reproducible Bug Summary

1. Install yourls and setup db
2. Run yourls successfully for a few weeks
3. Out of nowhere, I cannot change, add links. No changes at all. I almost wish I did change something so I knew what caused this.

This is a bug because you can no longer add/edit urls or you get a loading GIF that never goes away.

I get the feedback from some users that urls do not work and generate the following error:

Fatal error: Uncaught PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'country_code' cannot be null in /www/htdocs/w01882f8/pnde/includes/vendor/aura/sql/src/ExtendedPdo.php:748 Stack trace: #0 /www/htdocs/w01882f8/pnde/includes/vendor/aura/sql/src/ExtendedPdo.php(748): PDOStatement->execute() #1 /www/htdocs/w01882f8/pnde/includes/vendor/aura/sql/src/ExtendedPdo.php(306): Aura\Sql\ExtendedPdo->perform('INSERT INTOyo...', Array) #2 /www/htdocs/w01882f8/pnde/includes/functions.php(897): Aura\Sql\ExtendedPdo->fetchAffected('INSERT INTO yo...', Array) #3 /www/htdocs/w01882f8/pnde/includes/functions.php(740): yourls_log_redirect('o') #4 /www/htdocs/w01882f8/pnde/yourls-go.php(21): yourls_redirect_shorturl('https://phantan...', 'o') #5 /www/htdocs/w01882f8/pnde/yourls-loader.php(37): require_once('/www/htdocs/w01...') #6 {main} thrown in /www/htdocs/w01882f8/pnde/includes/vendor/aura/sql/src/ExtendedPdo.php on line 748

This seems to be the case on iOs and Safari, but also on some instances of Firefox on Windows. Probably caused by some anti-tracking solution blocking the users country in some referral.

For most users this works, but I got multiple reports of this proiblem today for the url

http://pnde.eu/o

What can be the problem? Thanks in advance.

Edit: I see that Facebook crippled the error message, I will try to get a complete one and add it here.

People are unhappy that Google indexes their shortlinks (#2202 and others). Then people are unhappy that Google does not index their shortlinks (#2970 and others).

Put the google indexing logic into its own function and make it filterable so everybody can use the plugin they want

https://github.com/YOURLS/YOURLS/blob/master/includes/functions.php#L284-L287

Fix for Issue #3484 Id will be passed to yourls_table_edit_row resulting in the correct line in the table to be updated. Also the nonce will be calculated correctly now for this line.

Code of Conduct

• [X] I agree to follow this project's Code of Conduct.

Submission validity

• [X] This is not a personal support request, that should be posted on discussions community.
• [X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

• [X] I've read the documentation and made sure to follow it.
• [X] I've read the troubleshooting first steps and frequent issues guides.

Version

1.9.1

Description

When editing not the first url in list (e.g. second) and saving it, the changed entry will be placed on top of the list.

When refreshing the page it shows that it is saved correctly.

Javascript bug when saving.

Expectation

When saved the correct line is being updated.

Reproduction steps

1. Go to Admin
2. Have at least two entries
3. Edit second entry inline and hit save
4. Will be placed in the first line

Context

Investigation:

• yourls_table_edit_row is handling the keyword only
• it calls yourls_unique_element_id without any id parameter thus always returning the id for the first row
• html of the ajax request for getting edit html will always returning the edit row with the first result

Suggested solution:

• call yourls_table_edit_row with optional parameter (id / row id)
• in yourls_table_edit_row call yourls_unique_element_id with parameter

Code of Conduct

• [X] I agree to follow this project's Code of Conduct.

Submission validity

• [X] This is not a personal support request, that should be posted on discussions community.
• [X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

• [X] I've read the documentation and made sure to follow it.
• [X] I've read the troubleshooting first steps and frequent issues guides.

Version

1.9.1

Description

set filter more than 0 clicks, it still show links with 0 clicks, set more than 1, shows with 2 and more clicks, that is right.

Expectation

No response

Reproduction steps

No response

Context

No response

Code of Conduct

• [X] I agree to follow this project's Code of Conduct.

Submission validity

• [X] This is not a personal support request, that should be posted on discussions community.
• [X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Summary

i love YOURLS. But it counts my own clicks, which is very unhelpful. Please add a feature to ignore my own clicks.

Could be IP, but i'm always changing location, so that would add excessive maintenance. Every time i go to a new coffeshop, i'd have to add the new IP.

Motivation

Improve stats.

Describe the solution

Alternate suggestion, which would be much easier: allow a "nocount" parameter at the end of the url. Your counter would ignore any clicks with that parameter. https://mydomain/myshorturl?nocount

thanks!