Issue

As of now, anvils are very rough around the edges when it comes to server-side verification, especially when it comes to combining enchanted items / changing the name of an item. This should be top priority before anything else.

Solution

I see no evident way to clean this piece up, though there definitely are a million solutions that I haven't even thought of yet.

Reason

In libVanilla's current state, we'd have to create sessions for each of our features. This makes for an unnecessarily messy codebase to deal with as the project expands.

Features

Instead, all of the session data are merged into one class, PlayerSession. This class aims to combine the functionality into one class, where you can instead use managers and properties to cleanly handle it all.

This pull request also implements a new class, VanillaListener. VanillaListener is a clean way to register and unregister listeners. This will be needed as our listener count increases, and the complexity of our project expands.

Error: Illegal offset type
File: plugins/Vanilla/src/sylvrs\vanilla/item/enchantment/EnchantmentManager
Line: 66
Type: TypeError
Backtrace:
#0 plugins/Vanilla/src/sylvrs\vanilla/item/enchantment/EnchantmentManager(59): sylvrs\vanilla\item\enchantment\EnchantmentManager::addBlacklisted(object pocketmine\item\enchantment\KnockbackEnchantment#22793)
#1 plugins/Vanilla/src/sylvrs\vanilla/VanillaBase(25): sylvrs\vanilla\item\enchantment\EnchantmentManager::load()
#2 pmsrc/src/plugin/PluginBase(75): sylvrs\vanilla\VanillaBase->onLoad()
#3 pmsrc/src/plugin/PluginManager(213): pocketmine\plugin\PluginBase->__construct(object DevTools\FolderPluginLoader#22014, object pocketmine\Server#10, object pocketmine\plugin\PluginDescription#22676, string[70] C:/Users/rom1_/Documents/_Projet/Serveur Local/plugin_data/VanillaBase, string[62] C:\Users\****\Documents\_Projet\Serveur Local\plugins\Vanilla, object pocketmine\plugin\DiskResourceProvider#21893)
#4 pmsrc/src/plugin/PluginManager(362): pocketmine\plugin\PluginManager->internalLoadPlugin(string[62] C:\Users\rom1_\Documents\_Projet\Serveur Local\plugins\Vanilla, object DevTools\FolderPluginLoader#22014, object pocketmine\plugin\PluginDescription#22676)
#5 pmsrc/src/Server(1007): pocketmine\plugin\PluginManager->loadPlugins(string[55] C:\Users\***\Documents\_Projet\Serveur Local\plugins\, int 0)
#6 pmsrc/src/PocketMine(305): pocketmine\Server->__construct(object BaseClassLoader#2, object pocketmine\utils\MainLogger#3, string[47] C:\Users\rom1_\Documents\_Projet\Serveur Local\, string[55] C:\Users\***\Documents\_Projet\Serveur Local\plugins\)
#7 pmsrc/src/PocketMine(328): pocketmine\server()
#8 pmsrc(11): require(string[91] phar://C:/Users/***/Documents/_Projet/Serveur Local/PocketMine-MP.phar/src/Poc)

Code:
[57] 
[58] 	public static function load(): void {
[59] 		self::addBlacklisted(VanillaEnchantments::KNOCKBACK()); // TODO: Load from configuration
[60] 		foreach (self::ENCHANTMENT_LIST as $id => $info) {
[61] 			EnchantmentIdMap::getInstance()->register($id, new Enchantment(1000 - $id, ...$info));
[62] 		}
[63] 	}
[64] 
[65] 	private static function addBlacklisted(Enchantment $enchantment): void {
[66] 		self::$BLACKLISTED_ENCHANTS[$enchantment->getName()] = true;
[67] 	}
[68] 
[69] 	#[Pure]
[70] 	public static function isBlacklisted(Enchantment $enchantment): bool {
[71] 		return isset(self::$BLACKLISTED_ENCHANTS[$enchantment->getName()]);
[72] 	}
[73] }

Issue

Besides simple debugging, there is no reason that the server has to verify the client's output. This provides unnecessary amounts of work when attempting to verify.

Solution

The simplest solution to the problem is to remove the extraneous amounts of verification in the transaction. This will reduce code complexity, remove unneeded methods from the transaction class, and will provide for a cleaner implementation overall.

Issue

As shown by this.) method (among many others), the current enchant system is not configurable & is stuck on a <1.8 enchantment system. This isn't optimal, especially in circumstances where the user wants to increase the difficulty of enchanting.

Solution

This isn't a large issue, but will require a minor amount of work to make it configurable. Optimally, we'd have a category called enchanting with a boolean for adding lapis by default.