@shnoulle: Looks like we are nearly there with this template.

Still I find the alignment of input/label combination in radio buttons and checkboxes (especially when the label is multiple lines) not nice, but don't know how to solve it.

What do you think: shall I put back the original darker blue, so users get more or less the same feeling?

I think that the color combination now is ultimately very dull, but a good basis for further work. I do not want to make the default template too flashy...

Formerly opened form master #977, now for develop

Some notes: in order for innoDb to work one needs:

• innodb_large_prefix = 1
• innodb_file_format = Barracuda;
• innodb_file_format_max = Barracuda;

otherwise you will get the "Error 1071: Specified key was too long; max key length is 767 bytes" for the text indexes, (Error 1071: Specified key was too long; max key length is 767 bytes)

I enabled this for travis https://github.com/LimeSurvey/LimeSurvey/compare/develop...TonisOrmisson:develop-innodb?expand=1#diff-354f30a63fb0907d4ad57269548329e3R45

and checking of this will be done in installer validation here https://github.com/LimeSurvey/LimeSurvey/compare/develop...TonisOrmisson:develop-innodb?expand=1#diff-12a8fc159f48cb97e97609f6c43aab0aR258

Did some major changes in the installer logic. Why? because I needed to check the Innodb settings status in the model validation: so the dbConnection needed to move from the controller to the Model. And so all of the connection related things were moved to model. Controller got much more cleaner and is now not doing things that logically should not be there.

Also cleaned up the view along that since there was code that should not be in the view.

Tests: I enabled separate set of tests for InnoDB and MyIsam. So the whole test set runs both ways now. Also added PHP 7.2 to the matrix.

... I think we should also use the pgsql for testing on travis. As far as I understand this is also included for travis so I would use an ENV DBTYPE to run test matrix also on available non-mysql options.

I have tested this manually also during the work, but since there is a lot of changes here I would ask for you to review the code as well as also help to test manually. Especially for MSSQL that I do not have and is not tested against!

• [x] Set an alias to a survey [Must Have]
• [x] Run the survey using the alias [Must Have]
• [x] Uniqueness Validation [Must Have]
• [x] Add short url display in overview [Must Have]
• [x] Automatic tests [Must Have]
• [x] Test: Does it work with tokens? [Must Have]
• [x] Test: Does it work with parameter? [Must Have]
• [x] Replacement variable for writing mails. [Could Have]

New feature #13175: Ability to show calculated values based on all users

• set null to js function in ValidFunction : set this function as static
• static function mean done in PHP return a static part for EM js
• statFunctions plugin with statCount and statCountIf
• related issue #11589 quota accessible by EM
• related issue #12248 expose mt_rand (made it more simple)
• test must be done (lsa is here)

The fix is applied only for the case of removal of survey permissions. More to come later, after this is approved.

Created JS script for turning links (used to be sent as GET) into POST forms. This can be later extended to other situations.

Integrated the new top bar system into the new controllers. Needed a way for sharing topBars among views and also a general framework where to place common topBar parts (ease maintenance).

Key parts: LayoutHelper:renderTopbar() called from layouts. Base top bar with Left and Right side configurable. Totally overridable if needed. Implemented it for email templates.

WIP Next step survey toolbar, which is shared among many screens.

Use case:

I am using LimeSurvey as data collector for mixed mode surveys. EG. Its the data collection engine for CATI as well as online filling. A typical scenario is when a respondent is contacted via telephone and interview is started and then respondent wishes to complete the interview on its own online.

Now - the problem is that CATI template has some specific custom UI elements - some extra buttons & info fields that are CATI specific and not needed for online direct filling. The easy fix is to allow loading a different template depending on the mode (CATI vs online).

https://bugs.limesurvey.org/view.php?id=12102

This fix will speed up front-end rendering with 14% on my machine. Benchmarked with:

$ ab -lk -c 5 -n 50 "http://localhost/limesurvey/index.php?r=survey/index&sid=437521&newtest=Y&lang=pt-BR"

The speed-up will probably be bigger with bigger surveys (more questions -> bigger speed-up).

The crucial question is when to CLEAR the cache. I suggest:

• When newtest=Y is set
• When survey, question or group is saved

NB: Cache is never active when debug = 2.

More discussion here: https://bugs.limesurvey.org/view.php?id=14859

When using global template on a survey, the template name saved on DB is "inherit". That was taken literal sometimes and caused errors, as there is no template called "inherit"

"inherit" template is now converted to the proper template name, set at global level.

From these requirements:

• a flag to activate/deactivate the user (so I could reset the user when I start a new class)
• a field to set an expiry date for the password
• a field to set an expiry date for the user
• a field with "last login date" to display the last date they logged in the system

We believe it is ok to start with these:

• [x] a field to set an expiry date for the user
• [x] a field with "last login date" to display the last date they logged in the system

Moving attribute-value-fecthing-code to service class. Reusing that from different places, as to return values for advanced attributes sometimes and some other return all attribute and values.

same thing as https://github.com/LimeSurvey/LimeSurvey/pull/2832

but different, as the admin_theme branch theme css works completely different, and the adminbasics.css doesn't exist anymore.

New feature #18565: Provide more descriptive log about exceptions happen during running LimeSurvey Dev: use Yii::app()->onException, PHP Parse error and other already goes to error_log