We have a very large application that has multiple JSON translation files, registered with Lang::addJsonPath(). These files are split based on multiple modules within the app.

It looks like it'd be relatively simple to update GettextPOGenerator::jsonFiles() to use all the registered JSON paths. Something like:

$paths = [$this->application['path.lang']];

$loader = Lang::getLoader();
if ($loader instanceof FileLoader) {
  foreach ($loader->jsonPaths() as $jsonPath) {
    $paths[] = $jsonPath;
  }
}

foreach ($paths as $path) {
  foreach (glob($path . DIRECTORY_SEPARATOR . '*.json') as $filename) {
    $files[] = $filename;
  }
}

The trickier issue would be resolving which JSON file to write back to on sync. Is this something you're interested in supporting? I've been digging around in GettextTranslationSaver and it seems like it'd take a bit of a refactor to support this use-case.

Hey @armandsar, I added Gettext support to this package.

A lot of Gettext syntaxes are now supported. You can see how in that file: tests/fixtures/gettext/example.php.

As you can see, some are quite classic (_("") or _n("", "", number)) and some are added for easier interpolation (_i("hello %s", "world")).

There are some tests for both client/server behaviour but also to test GetText functions.

You'll see that there are also sync_and_purge and sync_and_show_purgeable methods in the package. They work like to the ones in Ruby: https://github.com/aurels/translation-gem#usage

I also renamed php artisan translations:xxx to php artisan translation:xxx for better consistency, I hope you don't mind.

Please tell me if you see something weird in the package, I certainly did some mistakes.

Also, to change the language in your Laravel application, you need to do:

$t = new TranslationIO(config('translationio'));
$t->setLocale('fr');

Do you know if there is a way to do something like TranslationIO::setLocale('fr') instead? I think I saw something like this somewhere but I'm not very good with Facades and PHP meta-programming.

With a vanilla Laravel 8.10.0 project, I am getting the following error when calling translation:init

Init started

   Exception

  Folder "app" doest not exists. Gettext scan aborted.

  at /var/www/project/vendor/tio/laravel/src/GettextPOGenerator.php:52
     48▕
     49▕         // Extract GetText strings from project
     50▕         foreach ($directories as $dir) {
     51▕             if (!is_dir($dir)) {
  ➜  52▕                 throw new \Exception('Folder "' . $dir . '" doest not exists. Gettext scan aborted.');
     53▕             }
     54▕
     55▕             foreach ($this->scanDir($dir) as $file) {
     56▕                 if (strstr($file, '.blade.php')) {

      +18 vendor frames
  19  /var/www/project/artisan:37
      Illuminate\Foundation\Console\Kernel::handle()

The config which directories to scan is unchanged with 'gettext_parse_paths' => ['app', 'resources'],

Accept the Laravel 5 subdirectories structure: {{ trans('foo/bar/foo.key') }}

More info here: https://laravel.io/forum/02-23-2015-localization-load-files-from-subdirectories-at-resourceslanglocale

(with more tests for sync and sourceEdits)

I also debugged the SourceEditException that should have been SourceEditSyncException, and some behaviour that was wrong (sourceEdit must been executed before Sync to deal with more situations).

I hope the changes are ok with you.

Next, I'll find a way to use the Gettext syntax.

I'm still not sure if I'll use eusonlito/laravel-Gettext or build something myself with oscarotero/Gettext. Any thoughts?

Hello @armandsar,

Here is a pull request to allow source edits from Translation.io (read here for more info: https://translation.io/blog/new-feature-copywriting)

The main idea is to change source text AND translations from a centralised place. It allows copywriting from the marketing/management team without annoying developers.

Also, I added a snippet to pretty print translation files. So they are easier to read.

If you have any comment on the produced code, please tell me. As you know, I'm not very confortable with PHP since that's not my language of choice.

I think this package is already mature enough to be distributed to the Laravel community. I intend to create https://laravel.translation.io in the following month(s) and start to look for beta-testers.

So you know, I think the package still need to deal with special translation management of Laravel >5 with sub-folders and keys like "this/is/repository.and.here.are.keys". But I doubt I lot of users use that feature so it can certainly wait.

I added my name as author on the composer file, I hope you don't mind.

Oh, and Happy Christmas ! 🎅 🎄

Hello @armandsar,

I updated the README file for more consistency between https://github.com/aurels/translation-gem and https://github.com/armandsar/laravel-translationio/

I hope you'll like it that way. Feel free to amend it!

You'll notice that I removed --dev from the composer require command. If I'm not wrong, we need to require the package in production in order to be able to use GetText syntaxes like t__ and n__.

FYI now that the package seems ready, I will create a specific landing page for Laravel (https://translation.io/laravel) and start a beta-test period to gather feedbacks (I'll reach the Laravel community). I'll keep you in touch.

Thanks again for your support!

I just increased your trial period on Translation.io until 2050. Feel free to create as many free Rails/Laravel projects as you want ;-)

In reading the Laravel 9 upgrade, they are moving the lang directory from resources/lang to the project directory. Are you going to implement this change?

After I init the translation (seemingly successfully, see output below), the backend still shows the "setup" page. If i try to php artisan translation:sync it tells me: {"error":"This project has not been initialized yet. Please use the \"init\" operation."} wven though I already initialized.

My translation.php

<?php

return [
    'key' => env('TRANSLATIONIO_KEY'),
    'source_locale' => 'de-CH',
    'target_locales' => ['fr-FR'],

    /* Directories to scan for Gettext strings */
    'gettext_parse_paths' => ['app', 'resources'],

    /* Where the Gettext translations are stored */
    'gettext_locales_path' => 'resources/lang/gettext'
];

The key is in my .env

How i start the initialization: $ docker-compose exec app php artisan translation:init

The output I get

Init started
Init ended with success
----------
Use this URL to translate: https://translation.io/sandrotanner/my-project-name
----------

Do your logs give any insight on what might go wrong? Thanks in advance :)

BTW I use Laravel 8 and the official php docker image "php:8.0-fpm"

Hi! I am using the v1.12 of your package, and PHP 7.3.23.

I have a translation.php file as follows:

	...

	'source_locale' => 'de',

    'target_locales'       => ['en'],

    /*
    |--------------------------------------------------------------------------
    | # Ignored PHP key prefixes.
    |--------------------------------------------------------------------------
    |
    | Ex: * 'validation':        ignore the whole validation.php file.
    |     * 'validation.custom': ignore the "custom" subtree in validation.php file.
    |     * 'subfolder/more':    ignore the whole subfolder/more.php file.
    |
    */
    'ignored_key_prefixes' => ['legacy', 'validation'],

	...

So, I want to translate from german to english. The validation.php file is only available in the en, but not in the de folder (as I just need this file for internalt tests). So I have some structure like this:

de/
	file1.php
	file2.php
en/
	file1.php
	validation.php

But although validation is mentioned in the ignored_key_prefixes, the en/validation.php file is removed after I call php artisan translation:sync. My structure after syncing is:

de/
	file1.php
	file2.php
en/
	file1.php
	file2.php

If I understand correctly, the file en/validation.php should not be touched, because it is ignored, so I think I found a bug here?

We've encountered an issue where having a blade component with a translated string as a attribute. Example code below:

<x-form-row :label="t('Name')"></x-form-row>

This unfortunately won't get picked up when running the sync command. There are ways around this obviously but I just wondered if anyone has an idea on if this could be solved?

This PR makes application locale set in config('app.locale') independent to translation setup. This way one can set any default language he/she wants when working locally or in a server while syncing with translation.io the way defined in config('translation').

Examples:

• Working locally with Greek locale (set in config('app.locale')) enabled, using gettext/json strings in english, while syncing with source language English and target languages Greek and Polish
• Auto-deploying in 2 different application servers with default languages Polish and Greek respectively without any change in translation setup

This shouldn't break previous behavior as long as the config('app.locale')) == config('translation.source_locale'), while giving the flexibility mentioned above.

Having English as source_locale even someone is not using them at all (best practice for easy translations in any language) is also possible through this PR

Hello,

This isn't a bug report but simply a question. We've been using this package for a while now and everything works well. However I need to add a couple of hundred new translations (that I already have as .php files). However, when I run the sync command, I only get the source texts imported. All my translation files are overwritten with empty data from translation.io. I guess this is the way it's intended since it seems to use translation.io as a "source of truth".

But still, I don't really have the time to add all these manually. Is there a way to sort of "re-init" or sync with the codebase as the source? Or is the only solution to create a new project from scratch?

Hello,

I'm wondering if there is a way to register translation keys that come from other sources rather than being hardcoded. Example use case is having a set of data (e.g. API or local constants), which need to be translated, but they would need to be changed over time.

I would envision a need for a separate scanning tool, that would require a script to be fully functional and therefore would be able to read variables/constants runtime.

Use example:

class User  {
    const ROLE_ADMIN = 'admin';
}

//dynamic-translations.php
rtp('enums.user-roles', User::ROLE_ADMIN);

//config/translation.php
'scan_runtime' => [
    'runnable-file.php'
];

//Result:
msgctxt "enums.user-roles"
msgid "admin"
msgstr ""

If one wants to change the value of ROLE_ADMIN to let's say, administrator, it would need to be done in just one place. In theory, is this something that you would be eager to have as a part of your package?

this PR optionally uses https://github.com/themsaid/laravel-langman for dumping the translations to ensure compatibility of the formats

also handle case when a JSON file is invalid