Manage Laravel translation files

Hi, we are using this package and we found a bug with the "$stringPattern" regex for the @lang directive inside "findTranslations" method -If the file starts with @lang -If @lang is immediately after an html tag (no spacing before)

You can see links below: https://regex101.com/r/Kmz52y/1 https://regex101.com/r/crVgZD/1

https://regex101.com/r/FRV8ou/1 - works here

Thank You

After updating to L 5.4.13 The translation-manager interface normally opened but after choosing a group to edit translations, keys and translations didn't load. Then i returned to L 5.4.11 and everything work again.

Really want to make a PR to solve it but i'm not yet enough skilled to do so..

Hi. Tried to add this package to a laravel 5.3.x app and got the following error while publishing config/migrations:

  [BadMethodCallException]
  Method controller does not exist.

laravel.log trace

#0 C:\Work\www\projects\locales2\vendor\barryvdh\laravel-translation-manager\src\ManagerServiceProvider.php(89): Illuminate\Routing\Router->__call('controller', Array)
#1 [internal function]: Barryvdh\TranslationManager\ManagerServiceProvider->Barryvdh\TranslationManager\{closure}(Object(Illuminate\Routing\Router))
#2 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Routing\Router.php(319): call_user_func(Object(Closure), Object(Illuminate\Routing\Router))
#3 C:\Work\www\projects\locales2\vendor\barryvdh\laravel-translation-manager\src\ManagerServiceProvider.php(90): Illuminate\Routing\Router->group(Array, Object(Closure))
#4 [internal function]: Barryvdh\TranslationManager\ManagerServiceProvider->boot(Object(Illuminate\Routing\Router))
#5 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Container\Container.php(507): call_user_func_array(Array, Array)
#6 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Application.php(759): Illuminate\Container\Container->call(Array)
#7 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Application.php(742): Illuminate\Foundation\Application->bootProvider(Object(Barryvdh\TranslationManager\ManagerServiceProvider))
#8 [internal function]: Illuminate\Foundation\Application->Illuminate\Foundation\{closure}(Object(Barryvdh\TranslationManager\ManagerServiceProvider), 11)
#9 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Application.php(743): array_walk(Array, Object(Closure))
#10 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Bootstrap\BootProviders.php(17): Illuminate\Foundation\Application->boot()
#11 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Application.php(203): Illuminate\Foundation\Bootstrap\BootProviders->bootstrap(Object(Illuminate\Foundation\Application))
#12 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Console\Kernel.php(246): Illuminate\Foundation\Application->bootstrapWith(Array)
#13 C:\Work\www\projects\locales2\vendor\laravel\framework\src\Illuminate\Foundation\Console\Kernel.php(108): Illuminate\Foundation\Console\Kernel->bootstrap()
#14 C:\Work\www\projects\locales2\artisan(35): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#15 {main}  

Cheers

I'm getting the following error when I try to go to /translations:

exception 'Symfony\Component\Debug\Exception\FatalErrorException' with message 'Unsupported operand types' in vendor/barryvdh/laravel-translation-manager/src/Controller.php:31.

I've done everything like the manual shows. I'm using Laravel v5.1.45.

PDOException in PDOConnection.php line 77:
SQLSTATE[42000]: Syntax error or access violation: 1055 'invoices.ltm_translations.id' isn't in GROUP BY (SQL: select * from `ltm_translations` group by `locale`)

Clean Laravel 5.3 install, ltm version 2.5. Downgraded to 2.4 - problem vanished.

Hi Barry,

I was thinking about a new approach to translations in a project. I find myself writting trans('...') in the view and then have to open the translation file for each language and add the key by hand... It's boring and error proof! :smile:

This is just a raw example:

<?php

$directory = new RecursiveDirectoryIterator('./app');
$iterator = new RecursiveIteratorIterator($directory);
$phpFiles = new RegexIterator($iterator, '/^.+\.php$/i', RecursiveRegexIterator::GET_MATCH);

$transKeys = array();

$phpFilesCount = 0;

foreach ($phpFiles as $file) {
    $phpFilesCount++;
    $inputFile = file_get_contents($file[0]) or die("Could not access file");

    $findTranslation = "trans\(\'([a-zA-Z0-9_]+([-.][a-zA-Z0-9_]+))\'\)";

    if(preg_match_all("/$findTranslation/siU", $inputFile, $matches)) { 
        foreach ($matches[1] as $key) {
            $transKeys[] = $key;
        }
    } 
}

echo "Files scaned: " . $phpFilesCount    . PHP_EOL;
echo "Keys founded: " . count($transKeys) . PHP_EOL;
echo "Keys: " . PHP_EOL;
print_r($transKeys);

Save it to test.php and run it from you project root: $ php test.php

It's MEGA fast. $ time php test.php

Files scaned: 392
Keys founded: 1900
Keys:
...
php test.php  0,20s user 0,05s system 94% cpu 0,266 total

What do you think?

thanks

I've recently upgraded a project from using Laravel 5.4 and laravel-translation-manager 0.2.* to using Laravel 5.5 and laravel-translation-manager 0.4.1, and I started getting the above error from this line: https://github.com/barryvdh/laravel-translation-manager/blob/c9939e6199e92d36301143f37a735fcf36d022f5/src/Translator.php#L42

I'm a bit confused as to what's causing this error to appear, and specially why this problem didn't show up before. Also, I've never used the setTranslationManager function. However, I've managed to get things working by adding a protected $manager = null; to the Translator class. Is this property supposed to be inherited from Illuminate\Translation\Translator?

[ EDIT: upgraded Laravel to 5.5! ]

Added a where clausule to the registered routes to accept slashes.

Note sure if the extra added getView method is needed anymore. Can someone confirm?

Hi! I see PR's to accommodate for Laravel 5.6 are merged with master already. Any idea when a new release will be tagged? I need to upgrade one of my projects but feel a bit iffy ignoring my minimum stability settings in production. Thanks!

I have problems because my routes can't access to /translations

how can I change the route? or add a filter to my route that not allow to access translations

After updating composer i noticed this error in te firebug console upon pressng the "import groups" button. I don;t know if this issue existed before the update, or wether something else on my side is wrong.

ErrorException in Arr.php line 70: Invalid argument supplied for foreach()

in Arr.php line 70
at HandleExceptions->handleError('2', 'Invalid argument supplied for foreach()', 'C:\wamp\www\test\vendor\laravel\framework\src\Illuminate\Support\Arr.php', '70', array('array' => '1', 'prepend' => '', 'results' => array())) in Arr.php line 70
at Arr::dot('1', '') in helpers.php line 90
at array_dot('1') in Manager.php line 55
at Manager->importTranslations('0') in Controller.php line 107
at Controller->postImport()
at call_user_func_array(array(object(Controller), 'postImport'), array()) in Controller.php line 246
at Controller->callAction('postImport', array()) in ControllerDispatcher.php line 162
at ControllerDispatcher->call(object(Controller), object(Route), 'postImport') in ControllerDispatcher.php line 107
at ControllerDispatcher->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 141
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 101
at Pipeline->then(object(Closure)) in ControllerDispatcher.php line 108
at ControllerDispatcher->callWithinStack(object(Controller), object(Route), object(Request), 'postImport') in ControllerDispatcher.php line 67
at ControllerDispatcher->dispatch(object(Route), object(Request), 'Barryvdh\TranslationManager\Controller', 'postImport') in Route.php line 198
at Route->runWithCustomDispatcher(object(Request)) in Route.php line 131
at Route->run(object(Request)) in Router.php line 692
at Router->Illuminate\Routing\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 141
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in AuthenticateAdmin.php line 47
at AuthenticateAdmin->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 101
at Pipeline->then(object(Closure)) in Router.php line 694
at Router->runRouteWithinStack(object(Route), object(Request)) in Router.php line 661
at Router->dispatchToRoute(object(Request)) in Router.php line 619
at Router->dispatch(object(Request)) in Kernel.php line 214
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 141
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in VerifyCsrfToken.php line 43
at VerifyCsrfToken->handle(object(Request), object(Closure)) in VerifyCsrfToken.php line 17
at VerifyCsrfToken->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in ShareErrorsFromSession.php line 55
at ShareErrorsFromSession->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in StartSession.php line 61
at StartSession->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in AddQueuedCookiesToResponse.php line 36
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in EncryptCookies.php line 40
at EncryptCookies->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in CheckForMaintenanceMode.php line 42
at CheckForMaintenanceMode->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Language.php line 46
at Language->handle(object(Request), object(Closure)) in Pipeline.php line 125
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 101
at Pipeline->then(object(Closure)) in Kernel.php line 115
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 84
at Kernel->handle(object(Request)) in index.php line 53

Hi, Just a suggestion and may need some more input... but if you can detect missing translations, and add the translation key to the database so that it can be translated... why don't the package also just add in a default text as well??

say we have this kind of code __('file.parent.child.key', ['param' => 'example'], 'Default text here as :param')

a cons that I could think of is that this default text would just only be used once in the code, making it something not really that necessary.

@barryvdh congrats on the great work, but the repository seems to be abandoned.

Are you planning to insert more contributors to work and keep moving on?

Thanks

I have lang files:

\lang
  en\
    ocadmin\
      common\
        column_left.php
      setting\
        setting.php
    auth.php
    pagination.php
    password.php
    validation.php
  zh-Hant\
    ocadmin\
      common\
        column_left.php
      setting\
        setting.php
    auth.php
    pagination.php
    password.php
    validation.php

php artisan translations:import

en language:
the root four files of language folder are in database, but none of all other files

zh-Hant:
Only "ocadmin/common/column_left" in database. The original four files auth.php... are missing, and setting/abc.php is missing.

So strange...

vendor\barryvdh\laravel-translation-manager\src\Manager.php

                if (! $vendor) { // line 96
                    $translations = \Lang::getLoader()->load($locale, $group);
                } else {
                    $translations = include $file;
                    $group = 'vendor/'.$vendorName;
                }

                if ($translations && is_array($translations)) { // line 103
                    foreach (Arr::dot($translations) as $key => $value) {
                        $importedTranslation = $this->importTranslation($key, $value, $locale, $group, $replace);
                        $counter += $importedTranslation ? 1 : 0;
                    }
                }
                // I add 3 lines. Why do I get emtpy $translations?
                else{ 
                    echo "<pre>", print_r($group, 1), "</pre>\r\n"; exit;
                }

Why do I get emtpy $translations?

I fixed.

vendor\barryvdh\laravel-translation-manager\src\Manager.php

    public function importTranslations($replace = false, $base = null, $import_group = false)
    {
        ...
                if ($subLangPath != $langPath) {
                    //$group = $subLangPath.'/'.$group;
                    $group = str_replace($langPath.'/', '', $subLangPath) . '/' . $group;
                }

langPath D:/Codes/PHP/laravel.test/httpdocs/lang/en

subLangPath D:/Codes/PHP/laravel.test/httpdocs/lang/en/lang/en/ocadmin/common

group (before $group = $subLangPath.'/'.$group;) column_left

group (after that line) D:/Codes/PHP/backgarden.chinabing.test/httpdocs/lang/en/ocadmin/common/column_left

What it need is 'ocadmin/commoncolumn_left'

So I write another line to handle it. It seems works!

For export

    public function exportTranslations($group = null, $json = false)
    {
        // $group = basename($group);
        // $basePath = $this->app['path.lang'];

When doing an export of the translation files the state of the translation gets changed to saved. This is okay, but this statement also changes the updated_at timestamp of every translation in the exported groups. This way the updated_at column can't be used for anything.

My commit changes the Eloquent/Builder query to a Database/Builder query to only update the state column.