Hello, on some messages I get this notice:

ErrorException [ Notice ]: iconv(): Detected an illegal character in input string APPPATH/vendor/tedivm/fetch/src/Fetch/Message.php @ line 421:

I debuged thesemessages, I see that the values during error are: $parameters['charset'] = utf-8; self::$charset = UTF-8//TRANSLIT;

Any idea on how to fix it?

Adding requirement to if statement to check if message matches UTF-8 encoding via regex. This will prevent encoding errors when converting UTF-8 to UTF-8.

I notice Fetch will always return an HTML or plain text body when requested, even if the original message doesn't actually contain an HTML or plain text version. I have a need where I actually want to only return the HTML and/or plain text if the original message included it. Of course, I can extend Fetch for my needs, but it feels like this might be a general enough use that others would benefit. I'm happy to fork it, code it up (backwards-compatible, of course), and issue a pull request if you like, but I wanted to see if that's even something you want Fetch to do before I did anything.

Method \Fetch\Attachment\saveAs, this line (about 221, latest pull):

$result = imap_savebody($this->imapStream, $filePointer, $this->messageId, $this->partId ?: 1, FT_UID);

...on Windows (PHP 5.4.30 with XDebug, Apache 2.2.18) makes PHP crash. When the code reaches this line, the execution suddenly stops. No, errors, no lines in error.log, no HTTP status returned.

This is obviously not related to Fetch code, but I could bypass this problem by inserting a line like this (before the one with imap_savebody):

$temp = imap_fetchbody($this->imapStream, $this->messageId, $this->partId ?: 1, FT_UID);

Would it be possible to put something like this in the next pull?

Calling imap_fetchbody before imap_savebody seems to solve this strange issue. Here I read something about imap_fetchbody and Apache that crashes: http://www.tek-tips.com/viewthread.cfm?qid=1574115

Thank you for your attention.

Hi,

Thanks for a nice lib.

I needed a way to get the newest messages in a folder, so I implemented this.

Usage:

$server->getOrdered(SORTDATE, true, 2); # => returns the 2 newest messages

All the best.

Hi,

Commit 9334952ad2140ba08b81d3b525349709ac7e632d introduced the requirement for the PHP imap extension.

Unfortunately, this makes composer update fail (I do have php5-imap installed on my Ubuntu):

$ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - tedivm/fetch dev-master requires ext-imap * -> the requested PHP extension imap is missing from your system.
    - tedivm/fetch dev-master requires ext-imap * -> the requested PHP extension imap is missing from your system.
    - Installation request for tedivm/fetch dev-master -> satisfiable by tedivm/fetch[dev-master].

Apparently, the same problem (where a commit enforces this dependency and breaks compsoer update) appeared in the past: https://github.com/tedious/Fetch/issues/28

Thanks!

This patch makes fetching the sender address (as sent in the Sender header, or otherwise derived from the From header) easily accessibly through Message::getAddresses('sender').

currently, fetching messages automatically marks them as read. this is not always desirable behavior and there's currently no way to change this.

it would be helpful to either add the option (FT_PEEK) flag to getMessages() or something similar.

i think it makes sense to actually have it on by default.

thanks!

I was having trouble with fetching messages due to an illegal character when it was running the iconv() function.

[Symfony\Component\Debug\Exception\ContextErrorException]                                                                                  
  Notice: iconv(): Detected an illegal character in input string in /var/www/sites/cems2/vendor/tedivm/fetch/src/Fetch/Message.php line 430  

Since the purpose of using iconv() in this circumstance appears to be to convert it from its existing character set to utf-8, encoding the messageBody with utf8_encode() seemed appropriate. All tests and builds passed for me locally.

Haven't added tests for this yet (for the life of me, I can't get the Fetch test suite running), but in my real-world experience, these methods for decoding a message's subject and addresses have worked flawlessly.

If you can help me get the test suite running, I'm happy to write tests for these.

Hey! What would you think of adopting a "middleware" approach that would allow developers to add in middleware to messaging parsing.

For example, it would be nice to have a middleware which handled the UTF-8 encoding of the subject, html and plaintext email. Another middleware might be to attempt to clean HTML emails, which often come with a lot of useless cruft which makes displaying an html email in the browser difficult.

This helps in situations where more encoding or extra parsing is required by business logic. (You can likely wrap your business logic over/around this class, but the middleware approach makes for some interesting abilities).

Some middleware ("core middleware"?) could be created by extracting current functionalities such as encoding and other things which aren't strictly email related functionalities (potentially allowing you to clear that code out from being "hard coded" into the email classes).

Let me know what you think! (I can take constructive criticism :D )

I have the following code

$attachments = $message->getAttachments();

$attachmentPath = "storage path";

foreach ($attachments as $attachment) { $attachment->saveToDirectory($attachmentPath); }

Now and then when I call saveToDirectory method I get the following error ErrorException: imap_savebody(): stream filter (convert.base64-decode): invalid byte sequence

I can't solve the problem

Hello,

I have a case where I need to connect to a server running on port 143, with TLS and Plain U/P authentication I've modded the code to use TLS on 143, but not sure how to go about the Plain auth

public function setAuthentication($username, $password, $tryFasterAuth=true) { $this->username = $username; $this->password = $password; if ($tryFasterAuth) { $this->setParam('DISABLE_AUTHENTICATOR', array('GSSAPI','NTLM')); } }

Any suggestions please? Any way I can log verbatim errors to see what's going on?

Thanks

I'm trying to set two flags to connect to a shared inbox. However when I use following commands, Only one flag get set.

$server = new Server($config->mailserver->host, $config->mailserver->port);
$server->setAuthentication(USER_NAME, PASSWORD);
$server->setFlag("authuser", "[email protected]");
$server->setFlag("user", "[email protected]");

The server string comes as {outlook.office365.com:993/ssl/[email protected]}

The string I suppose to get is {outlook.office365.com:993/ssl/[email protected]/[email protected]}

looks like this issue is caused by following piece of code in function setFlag() .

$match = preg_grep('/' . $flag . '/', $this->flags);
if (reset($match)) {
      $this->flags[key($match)] = $flag . '=' . $value;
} else {
      $this->flags[] = $flag . '=' . $value;
}

Any idea?

If I want to change a filename of attachment, I must change method setFileName() visibility to public. I think that this method should be public defaultly.