This adds the Drupal coding standard to the tool.

I can imagine an alternative approach to this would be to allow the addSearchPath call to be a parameter that is passed or set somehow. I did not explore this scenario.

For my own future reference, it took me looking at src//DependencyInjection/CompilerPass/FixerWhitespaceConfigCompilerPass.php to understand why the sniff wasn't getting loaded. Also phpcs -e --standard=Drupal can be used to get a list of sniffs.

This simple bump allows for the 2.0 version of this lib, which leverages Composer 2 APIs and drops any sub dependency.

There are basically no BC; for more details, see the the changelog.

The file ecs.php.dist encourages developers to use an outdated Option class:

• Symplify\EasyCodingStandard\Configuration\Option is flagged as @deprecated
• it should be replaces with Symplify\EasyCodingStandard\ValueObject\Option

Move away from files infos, as bloated value objects without any value. They only slowdown the process and passing data between parallel processes. Now the ECS should be faster and easier to use with tests :slightly_smiling_face:

Mirror to https://github.com/rectorphp/rector-src/pull/2878

In version 11.1.11 and hight it fails with error Call to undefined function ECSPrefix202210\trigger_deprecation().

It fails at vendor/symplify/easy-coding-standard/vendor/symfony/dependency-injection/ContainerBuilder.php:896.

On some configuration changes the cache is not properly invalidated.

For example this fixer:

    $ecsConfig->ruleWithConfiguration(FinalInternalClassFixer::class, [
        'annotation_exclude' => ['@not-fix'],
        'consider_absent_docblock_as_internal_class' => \true
    ]);

When running it with the configuration array empty, it marks a lot of files as shiny. But then, if I change it to this:

    $ecsConfig->ruleWithConfiguration(FinalInternalClassFixer::class, [
        'annotation_exclude' => ['@not-fix'],
        'annotation_include' => [],
        'consider_absent_docblock_as_internal_class' => \true
    ]);

It becomes applicable to a lot more files (the default for annotation_include is to require an @internal entry). But rerunning ECS doesn't work discover those.

If I run it with ecs --clear-cache it does work correctly. Note that going the other way is not an issue since faulty files are always (re)checked.

A simple solution would be to take a "hash" of the ECSConfig instance and always fully invalidate the cache when it has changed. Since I'm not familiar with Symfony's DI configurator stuff I don't know if this is supported by default. Of course an easy naive implementation is to just log all calls to the ECSConfig to create a hash:

private string $liveHash = '';
public function ruleWithConfiguration(string $checkerClass, array $configuration) : void
{
    $this->liveHash = md5($this->liveHash . $checkClass . json_encode($configuration));
}

This would then need to be done for every function on ECS config. Note that even doing this partially improves the situation, since currently all changes are ignored.

Hello,

when using ECS without cache (ie with --clear-cache or after cache dir was manually deleted or invalidated after fixes) the process ends silently on error without any error message.

when running without clearing a cache, the process ends up as expected with green message about shiny code.

It's more apparent when running ecs as a composer script or as a part of series of scripts - because composer stops on error

I've created basic repository to reproduce the error: https://github.com/noximo/ecs-test

Turning off paralelization solves the issue but leads to significant slowdowns.

Passing -vvv or --debug doesn't provide any additional info, just a list of fixers.