When I use the latest version of the package (2.0.3) i have the following problem:

Google\Cloud\Core\Exception\BadRequestException
<?xml version='1.0' encoding='UTF-8'?><Error><Code>InvalidAuthentication</Code><Message>The provided authentication header is invalid.</Message><Details>Cannot use OAuth Authorization header with form POST.</Details></Error>

When reverting to 2.0.2... all work fine.

Hi,

I'm using it in my Laravel 9 project with the following code:

the put method returns false and no file is created.

No exception thrown.

Any help?

Hello,

We recently used this library for our laravel app. We followed the documentation in order to configure it. We face an issue where, even though we are setting some metadata options, we don't see them implemented on GCS.

'cdn' => [
            'driver' => 'gcs',
            'project_id' => env('GOOGLE_CDN_PROJECT_ID', 'test'),
            'key_file_path' => base_path(env('GOOGLE_COM_CDN_SERVICE_JSON', 'test.json')), // optional: /path/to/service-account.json
            'bucket' => env('GOOGLE_CLOUD_STORAGE_BUCKET', 'test'),
            'path_prefix' => env('GOOGLE_CLOUD_STORAGE_PATH_PREFIX', ''), // optional: /default/path/to/apply/in/bucket
            'storage_api_uri' => env('GOOGLE_CLOUD_STORAGE_API_URI', ''), // see: Public URLs below
            'visibility' => 'public', // optional: public|private
            'metadata' => ['cacheControl' => 'no-cache,max-age:0']
        ]

apiEndpoint was used as both apiEndpoint and storage_api_uri, this commit separates them.

The storage_api_uri config is used to change the URL of accessing objects, not the API calls.
ApiEndpoint is used to change the actual rest API endpoint of the storageClient. I have not found a use-case to change the apiEndpoint, but this PR leaves it up to the user to change it or not.

Fixes #25

With this PR we're able to use bucketBoundHostnames again by setting the storage_api_uri config:

'gcs' => [
    'driver' => 'gcs',
    'key_file_path' => env('GOOGLE_CLOUD_KEY_FILE', null), // optional: /path/to/service-account.json
    'key_file' => [], // optional: Array of data that substitutes the .json file (see below)
    'project_id' => env('GOOGLE_CLOUD_PROJECT_ID', 'your-project-id'), // optional: is included in key file
    'bucket' => env('GOOGLE_CLOUD_STORAGE_BUCKET', 'your-bucket'),
    'path_prefix' => env('GOOGLE_CLOUD_STORAGE_PATH_PREFIX', ''), // optional: /default/path/to/apply/in/bucket
    'storage_api_uri' => env('GOOGLE_CLOUD_STORAGE_API_URI', 'https://cdn.example.org'), // see: Public URLs below
    'apiEndpoint' => env('GOOGLE_CLOUD_STORAGE_API_ENDPOINT', null), // set storageClient apiEndpoint
    'visibility' => 'public', // optional: public|private
    'metadata' => ['cacheControl'=> 'public,max-age=86400'], // optional: default metadata
],

And generate the correct url() and temporaryUrl() for example: https://cdn.example.org/cats.jpeg instead of https://storage.googleapis.com/your-bucket/cats.jpeg.

A good default config would be:

'gcs' => [
    'driver' => 'gcs',
    'key_file_path' => env('GOOGLE_CLOUD_KEY_FILE', null), // optional: /path/to/service-account.json
    'key_file' => [], // optional: Array of data that substitutes the .json file (see below)
    'project_id' => env('GOOGLE_CLOUD_PROJECT_ID', 'your-project-id'), // optional: is included in key file
    'bucket' => env('GOOGLE_CLOUD_STORAGE_BUCKET', 'your-bucket'),
    'path_prefix' => env('GOOGLE_CLOUD_STORAGE_PATH_PREFIX', ''), // optional: /default/path/to/apply/in/bucket
    'storage_api_uri' => env('GOOGLE_CLOUD_STORAGE_API_URI', null), // see: Public URLs below
    'apiEndpoint' => env('GOOGLE_CLOUD_STORAGE_API_ENDPOINT', null), // set storageClient apiEndpoint
    'visibility' => 'public', // optional: public|private
    'metadata' => ['cacheControl'=> 'public,max-age=86400'], // optional: default metadata
],

When I run:

Storage::disk('local')->put('testphoto.png', file_get_contents('https://example.com/photo.png')

The method returns true and the file get placed in my local storage directory.

When I try to use the GCS driver (i called it images) I get this Exception:

Storage::disk('images')->put('testphoto.png', file_get_contents('https://example.com/photo.png')

League \ Flysystem\ UnableToWriteFile

Unable to write file at location: testphoto.png.

This is my configuration in filesystems.php:

'images' => [
            'driver' => 'gcs',
            'key_file_path' => env('GOOGLE_CLOUD_IMAGES_KEY_FILE', null),
            'key_file' => [], // optional: Array of data that substitutes the .json file (see below)
            'project_id' => env('GOOGLE_CLOUD_PROJECT_ID', 'your-project-id'), // optional: is included in key file
            'bucket' => env('GOOGLE_CLOUD_STORAGE_IMAGES_BUCKET', 'your-bucket'),
            'path_prefix' => env('GOOGLE_CLOUD_STORAGE_PATH_PREFIX', ''), // optional: /default/path/to/apply/in/bucket
            'apiEndpoint' => env('GOOGLE_CLOUD_STORAGE_API_URI', null), // see: Public URLs below
            'visibility' => 'public', // optional: public|private
            'metadata' => ['cacheControl'=> 'public,max-age=86400'], // optional: default metadata
            'throw' => true,
        ],

The error is thrown in League \ Flysystem \ GoogleCloudStorage \ GoogleCloudStorageAdapter: 156 when running $this->bucket->upload($contents, $options); but there is no Exception explaining why the file cannot be written.

Making this into an issue because I ran the exact same code in another Laravel 8.40 environment with version 1.0 of the spatie/laravel-google-cloud-storage package and it worked on that environment (using the GCS key config from the example below).

So for me the problem exists on Laravel 9 with the most recent version of the package.

What did I miss?

$path = Storage::exists('slXpLQ7xZ5xnf0Mi3kBSaq.png'); gives below error in laravel 9

League\Flysystem\UnableToCheckFileExistence: Unable to check existence for: slXpLQ7xZ5xnf0Mi3kBSaq.png in file \vendor\league\flysystem\src\UnableToCheckExistence.php on line 14

#0 \vendor\league\flysystem-google-cloud-storage\GoogleCloudStorageAdapter.php(76): League\Flysystem\UnableToCheckExistence::forLocation('slXpLQ...', Object(TypeError)) #1 \vendor\league\flysystem\src\Filesystem.php(48): League\Flysystem\GoogleCloudStorage\GoogleCloudStorageAdapter->fileExists('slXpLQ...') #2 \vendor\laravel\framework\src\Illuminate\Filesystem\FilesystemAdapter.php(174): League\Flysystem\Filesystem->has('slXpLQ...') #3 \vendor\laravel\framework\src\Illuminate\Filesystem\FilesystemManager.php(396): Illuminate\Filesystem\FilesystemAdapter->exists('slXpLQ...') #4 \vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php(337): Illuminate\Filesystem\FilesystemManager->__call('exists', Array) #5 \app\Http\Controllers\AdminSettingController.php(214): Illuminate\Support\Facades\Facade::__callStatic('exists', Array) #6 \vendor\laravel\framework\src\Illuminate\Routing\Controller.php(54): App\Http\Controllers\AdminSettingController->run(Object(Illuminate\Http\Request)) #7 \vendor\laravel\framework\src\Illuminate\Routing\ControllerDispatcher.php(45): Illuminate\Routing\Controller->callAction('run', Array) #8 \vendor\laravel\framework\src\Illuminate\Routing\Route.php(261): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\AdminSettingController), 'run') #9 \vendor\laravel\framework\src\Illuminate\Routing\Route.php(204): Illuminate\Routing\Route->runController() #10 \vendor\laravel\framework\src\Illuminate\Routing\Router.php(725): Illuminate\Routing\Route->run() #11 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(141): Illuminate\Routing\Router->Illuminate\Routing{closure}(Object(Illuminate\Http\Request)) #12 \vendor\laravel\framework\src\Illuminate\Routing\Middleware\SubstituteBindings.php(50): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #13 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure)) #14 \vendor\laravel\framework\src\Illuminate\Session\Middleware\StartSession.php(121): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #15 \vendor\laravel\framework\src\Illuminate\Session\Middleware\StartSession.php(64): Illuminate\Session\Middleware\StartSession->handleStatefulRequest(Object(Illuminate\Http\Request), Object(Illuminate\Session\Store), Object(Closure)) #16 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure)) #17 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #18 \vendor\laravel\framework\src\Illuminate\Routing\Router.php(727): Illuminate\Pipeline\Pipeline->then(Object(Closure)) #19 \vendor\laravel\framework\src\Illuminate\Routing\Router.php(702): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request)) #20 \vendor\laravel\framework\src\Illuminate\Routing\Router.php(666): Illuminate\Routing\Router->runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route)) #21 \vendor\laravel\framework\src\Illuminate\Routing\Router.php(655): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request)) #22 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(167): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request)) #23 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(141): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http{closure}(Object(Illuminate\Http\Request)) #24 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #25 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull.php(31): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure)) #26 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle(Object(Illuminate\Http\Request), Object(Closure)) #27 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #28 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TrimStrings.php(40): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure)) #29 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Foundation\Http\Middleware\TrimStrings->handle(Object(Illuminate\Http\Request), Object(Closure)) #30 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php(27): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #31 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure)) #32 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance.php(86): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #33 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle(Object(Illuminate\Http\Request), Object(Closure)) #34 \vendor\fruitcake\laravel-cors\src\HandleCors.php(52): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #35 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Fruitcake\Cors\HandleCors->handle(Object(Illuminate\Http\Request), Object(Closure)) #36 \vendor\laravel\framework\src\Illuminate\Http\Middleware\TrustProxies.php(39): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #37 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): Illuminate\Http\Middleware\TrustProxies->handle(Object(Illuminate\Http\Request), Object(Closure)) #38 \vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request)) #39 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(142): Illuminate\Pipeline\Pipeline->then(Object(Closure)) #40 \vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(111): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request)) #41 \public\index.php(52): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request)) #42 {main}

League\Flysystem\UnableToCheckFileExistence

"function": "forLocation", "class": "League\Flysystem\UnableToCheckExistence", "type": "::"

Make the getBucket() method public, so we can call the generateSignedPostPolicyV4() method on the bucket outside the class: $bucket->generateSignedPostPolicyV4($objectName,$dateTime)

https://cloud.google.com/storage/docs/xml-api/post-object-forms#php

Hello,

I just installed the package for Laravel 9 with the following config :

'gcs' => [ 'driver' => 'gcs', 'key_file_path' => env('GOOGLE_CLOUD_KEY_FILE', null), // optional: /path/to/service-account.json 'key_file' => json_decode(file_get_contents('credentials.json'), true), // optional: Array of data that substitutes the .json file (see below) 'project_id' => env('GOOGLE_CLOUD_PROJECT_ID', 'your-project-id'), // optional: is included in key file 'bucket' => env('GOOGLE_CLOUD_STORAGE_BUCKET', 'dev-eu-prioritis-developement'), 'path_prefix' => env('GOOGLE_CLOUD_STORAGE_PATH_PREFIX', null), // optional: /default/path/to/apply/in/bucket 'storage_api_uri' => env('GOOGLE_CLOUD_STORAGE_API_URI', null), // see: Public URLs below 'visibility' => 'public', // optional: public|private 'metadata' => ['cacheControl'=> 'public,max-age=86400'], // optional: default metadata ],

then I cleared the cache with artisan.

When I instanciate the storage : $disk = Storage::disk('gcs'); I get this error : TypeError: League\Flysystem\GoogleCloudStorage\GoogleCloudStorageAdapter::__construct(): Argument #2 ($prefix) must be of type string, null given, called in /Users/jeremyaublanc/Prioritis/laravel-prismaccess/vendor/spatie/laravel-google-cloud-storage/src/GoogleCloudStorageServiceProvider.php on line 45

Could you help me with this ? It seems something goes wrong because construct try to get 'root' field in config file but it doesn't exist.

Thank you Jeremy

Is not using the filesystem config properly.... When we set the path_prefix, it's actually ignoring it. Also, when we set the storage_api_url, the bucket url is not correctly formed, as it takes the storage.googleapis.com URL from the images instead of the one we set.

'products' => [
            'driver'                => 'gcs',
            'key_file_path'         => storage_path('xxx_gae.json'),
            'project_id'            => 'xxxxxxxxxxx',
            'bucket'                => 'static.xxxxxxxxx.com',
            'path_prefix'           => 'dev/products',
            'storage_api_uri'       => 'https://static.xxxxxxxxx.com/',
            'visibility'            => 'public'
        ],

And to get the URL Storage::disk('products')->url($this->image)

We are getting: https://storage.googleapis.com/static.xxxxxxxxx.com/<img>

Instead of: https://static.xxxxxxxxx.com/<path_prefix>/<img>

  I've done the composer install and added the section to my filesystem.php and configured my env variables but when I try to upload to it I get a message -

message: "Driver [gcs] is not supported.", exception: "InvalidArgumentException",…}
exception : "InvalidArgumentException"
file : "/app/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php"
line :  148
message :  "Driver [gcs] is not supported."

Ay ideas? I've only set the following 2 env variables as it appears all the others are optional.

GOOGLE_CLOUD_STORAGE_BUCKET=laravel_storage
GOOGLE_CLOUD_KEY_FILE=/app/360204-c02cb6578b45.json

before you say it my entire Laravel app is in an app folder so this is not the normal Laravel /app folder that folder is found at /app/app.

Originally posted by @mobreviews in https://github.com/spatie/laravel-google-cloud-storage/discussions/48

Hi there,

As this is my first ticket, firstly I'd like to thank everyone for maintaining this repository, it helped me out greatly! Second, I think this is a bug from what I can see, so my apologies if I'm incorrect.

I'm using on-demand disks where you can inject some configuration into the Storage facade, which then builds a disk merging existing filesystem.php configuration with the configuration you add:

 Storage::build([
            'driver' => 'scoped',
            'disk' => 'gcs',
            'prefix' => $path,
        ]);

However, it seems like the Google Cloud Storage adapter does not take into account the "prefix" part of the build configuration. I did some small debugging in the library itself and it looks like indeed, this property is not taken.

I believe what needs to be done is that in the GoogleCloudStorageServiceProvider - prepareConfig function, the 'prefix' might need to be added as an additional property to check for?

Edit

As I dig deeper, it seems like the prepareConfig is only called when the provider is booted, so I think the required changes might need to be done in the createClient function, as that is the one that is being called when calling Storage::build()

A quick and dirty fix is this, but I think what would be more preferable is that this function can always check for 'root', but currently I lack the deeper knowledge on where that change might best be made as I feel like the "prepareConfig" is called once, and that's where the mapping happens between possible path prefix keys and the "root" property for the FlySystem.

protected function createAdapter(StorageClient $client, array $config): FlysystemGoogleCloudStorageAdapter
    {
        $bucket = $client->bucket(Arr::get($config, 'bucket'));

        $pathPrefix = Arr::get($config, 'prefix') ?? Arr::get($config, 'root');  # This is the only line that changed
        $visibility = Arr::get($config, 'visibility');
        $defaultVisibility = in_array(
            $visibility,
            [
                Visibility::PRIVATE,
                Visibility::PUBLIC,
            ]
        ) ? $visibility : Visibility::PRIVATE;

        return new FlysystemGoogleCloudStorageAdapter($bucket, $pathPrefix, null, $defaultVisibility);
    }

Discussed in https://github.com/spatie/laravel-google-cloud-storage/discussions/29