https://github.com/highlightjs/highlight.js/issues/2375

You may want to follow this, not sure how important you consider this type of issue. I think it's pretty bad and plan to release 9.18.1 as soon as we have an approved fix.

I have a table with 25 records and on each row there is a column which needs to be highlighted. Without highlighter it loads in 0.3 ms. With highlighter it loads in 1 min 30 sec.

Is the performance so bad?

Thanks!

Source code

<?php
use yii\helpers\Html;
use yii\widgets\ActiveForm;

$form = ActiveForm::begin([
    'id' => 'login-form',
    'options' => ['class' => 'form-horizontal'],
]) ?>
    <?= $form->field($model, 'username') ?>
    <?= $form->field($model, 'password')->passwordInput() ?>

    <div class="form-group">
        <div class="col-lg-offset-1 col-lg-11">
            <?= Html::submitButton('Вход', ['class' => 'btn btn-primary']) ?>
        </div>
    </div>
<?php ActiveForm::end() ?>

Highlight code:

$hl = new \Highlight\Highlighter();
$highlighted = $hl->highlight('php', $code);
echo "<pre><code class=\"hljs {$highlighted->language}\">{$highlighted->value}</code></pre>";

Highlighted code, look here - ('Входодд:

<pre><code class="hljs php"><span class="hljs-meta">&lt;?php</span>
<span class="hljs-keyword">use</span> <span class="hljs-title">yii</span>\<span class="hljs-title">helpers</span>\<span class="hljs-title">Html</span>;
<span class="hljs-keyword">use</span> <span class="hljs-title">yii</span>\<span class="hljs-title">widgets</span>\<span class="hljs-title">ActiveForm</span>;

$form = ActiveForm::begin([
    <span class="hljs-string">'id'</span> =&gt; <span class="hljs-string">'login-form'</span>,
    <span class="hljs-string">'options'</span> =&gt; [<span class="hljs-string">'class'</span> =&gt; <span class="hljs-string">'form-horizontal'</span>],
]) <span class="hljs-meta">?&gt;</span>
    <span class="hljs-meta">&lt;?</span>= $form-&gt;field($model, <span class="hljs-string">'username'</span>) <span class="hljs-meta">?&gt;</span>
    <span class="hljs-meta">&lt;?</span>= $form-&gt;field($model, <span class="hljs-string">'password'</span>)-&gt;passwordInput() <span class="hljs-meta">?&gt;</span>

    &lt;div <span class="hljs-class"><span class="hljs-keyword">class</span>="<span class="hljs-title">form</span>-<span class="hljs-title">group</span>"&gt;
        &lt;<span class="hljs-title">div</span> <span class="hljs-title">class</span>="<span class="hljs-title">col</span>-<span class="hljs-title">lg</span>-<span class="hljs-title">offset</span>-1 <span class="hljs-title">col</span>-<span class="hljs-title">lg</span>-11"&gt;
            &lt;?= <span class="hljs-title">Html</span>::<span class="hljs-title">submitButton</span>('Входодд<span class="hljs-title">class</span>' =&gt; '<span class="hljs-title">btn</span> <span class="hljs-title">btn</span>-<span class="hljs-title">primary</span>']) ?&gt;
        &lt;/<span class="hljs-title">div</span>&gt;
    &lt;/<span class="hljs-title">div</span>&gt;
&lt;?<span class="hljs-title">php</span> <span class="hljs-title">ActiveForm</span>::<span class="hljs-title">end</span>() ?&gt;</span></code></pre>

The reason I use highlight.js in my blog was because it allows me to preserve HTML tags inside the code snippet. Knowing that there is a highlight.php project makes everything so perfect! But one thing is missing; that is the ability to retain HTML tags inside the code snippet. I used to add <mark> tags to explain to my readers about the important parts, and maybe some <a> tags to link some piece of code to the documentation page.

How do I keep the HTML markup in my code snippet? Disabling the “safe mode” does not work for me. It always throws “`self` is not supported at the top-level of a language.” message anyway.

By the way, I have used your project to complete my content management system extension here. This project fits my environment so well :+1:

Thanks.

Maybe there're some bugs in the demo(i didn't use composer) When i ran demo.php, it shows 504 and the CPU dashed to 98%. Then i use php demo.php and it says

PHP Fatal error: Uncaught Error: Call to undefined function Highlight\mb_strlen() in /home/judge/src/web/light/Highlight/RegEx.php:99 Stack trace: #0 /home/judge/src/web/light/Highlight/Terminators.php(98): Highlight\RegEx->exec('...') #1 /home/judge/src/web/light/Highlight/Highlighter.php(681): Highlight\Terminators->exec('...') #2 /home/judge/src/web/light/Highlight/Highlighter.php(765): Highlight\Highlighter->highlight('xml', '...', false) #3 /home/judge/src/web/light/demo/demo.php(59): Highlight\Highlighter->highlightAuto('...') #4 {main} thrown in /home/judge/src/web/light/Highlight/RegEx.php on line 99

Can you explain why this happen or fix it? Hope to hear from you.

In our Language class, we have a langRe() method, which is tasked with putting together our regular expressions.

https://github.com/scrivo/highlight.php/blob/a4930dde24bf6b9064fb52c22d71211144567e7f/Highlight/Language.php#L108-L111

As I was rewriting the unit tests, I noticed that the language files for 1c and ada contained the following two regular expressions:

• \d{4}([\.\\/:-]?\d{2}){0,5} <- the / is treated as a delimiter
• []{}%#'" <- the [ and ] aren't escaped

Since our method isn't very smart, putting these two regular expressions in between / caused E_ERRORs to be thrown. If these languages are registered in Highlighter for autodetection, then it'll fail due to the E_ERROR.

I manually modified the language files for the affected languages and tagged 9.12.0.1, but this needs a better solution. I'd be opposed to having to manually modify the language files since they're generated directly from highlight.js, so I'd favor improving our regex building in the Language class. Thoughts? Any better solutions?

/cc @S1SYPHOS

Edit: We could also add another round of patches to our get_language_definitions.php file, too I guess...

It looks like highlight.js v10 is in the planning. This means per our BC policy, we'll be removing any deprecated functionality once we release a v10 of this project.

Additionally, I would like to get feedback from the community about the minimum PHP version for the next major release of this project. I typically align my projects with the LTS versions of other major projects:

• Symfony 3.4 LTS (EOL: November 2021) PHP >= 5.5
• Symfony 4.4 LTS (EOL: November 2023) PHP >= 7.1
• Laravel 5.5 LTS (EOL: August 2020) PHP >= 7.0
• Laravel 6 LTS (EOL: September 2022) PHP >= 7.2
• Debian 8 LTS (EOL: June 2020) PHP >= 5.6
• Debian 9 LTS (EOL: June 2022) PHP >= 7.0
• Ubuntu 16.04 LTS (EOSS: April 2021) PHP >= 7.0
• Ubuntu 18.04 LTS (EOSS: April 2023) PHP >= 7.2
• WordPress PHP >= 5.6

Given this information, I'd like to hear from the users of this library as to what PHP version they're using and if it's an older version, why they're still supporting it. There's still time until highlight.php v10 but the more information I can get early the better.

There's nothing in this library that critically relies on a feature in PHP 7.x, so I don't mind keeping the minimum PHP 5.x but if there aren't enough users using an EOL'd version of PHP, I won't bother with it either.

Related

• https://github.com/highlightjs/highlight.js/issues/2273

I know that line numbers aren't officially supported by this project, but I wanted to flag that the line numbers demo fails on multi-line comments: Because the <span> tag wraps multiple lines, only the first line of the comment is properly styled once those lines are then placed in table cells.

Is there a way around this? If each line of the comment were wrapped in a <span> tag instead of the comment in its entirety, that would solve the problem, for example.

The purpose of this PR is to introduce ability to access information about the available language aliases via the Highligther class instances.

This can be particularly helpful in web applications if presenting user with a drop-down list of syntaxes to choose from.

Although the normalised names should be quite helpful, they can sometimes also be a bit confusing, for example the html language is merely an alias for xml. This is not super-obvious to most users (and in fact for a while I thought the library had no HTML syntax highlighting myself).

I've also tried to implement tests for methods that got changed/added to help with regression testing.

All input is welcome, so if you think something needs to be changed/improved, do let me know - especially since PHP is not something I delve into on regular basis :)

This PR

• Fixes PHP coding standards issues (PSR1/2)
• Make the classes extendible (by changing the scope of private to protected methods)
• Implements code to automatically resolved language dependencies
• Addresses the issue of invalid regexes #15
• Implements lazy-loading of language files
• Allows to fetch language files
• Simplifies code structure
• Adds docblocks

Hi, I tested the highlighter with PHP 8.2 today and found two potential issues.

Code in Highlighter::__construct() initialises two properties which don't exist in class RegExMatch:

$this->lastMatch = new RegExMatch(array());
$this->lastMatch->type = "";
$this->lastMatch->rule = null;

Code in Terminators::exec() initialises another property RegExMatch::extra, but apparently is never used:

$match->extra = array($this->mode->illegal, $this->mode->terminator_end);

Let me know if you need more information. Thanks for investigating.

Hello, I'm migrating from hihglight.js to hihglight.php.
I was able to setup basic things to make it work. However I have issue with the rendering.

In my case I want to highlight some PHP codes with Paraiso Dark theme. BUT the result is bit different. Consider:

So ones that was done with highlight.js is perfectly rendered, the enum keyword is recognized and so does the self:$key construct inside the match body. While ones that was done with hihglight.php is not as perfect as that.

I have tried to use both manual mode and auto detect mode but no luck :

$hl=new Highlighter();

//didn't work 
$hl->setAutodetectLanguages(["php"]);
$highlight=$hl->highlightAuto($codes);

//didn't work either
$highlight=$hl->highlight("php",$codes);

This is my env:

• PHP 8.2
• highlight.php v9.18.1.10

help?

UPDATE This is also affect other sources too, I've tried to highlight JS code and the rendering is different from it should be

echo $this->highlighter
    ->highlight(
        'php',
        <<<'CODE'
        <?php
        
        $high = $dog->cat();
        $dog = new Cat();
        CODE
    )
    ->value;

This code echos:

<span class="hljs-meta">&lt;?php</span>

$high = $dog-&gt;cat();
$dog = <span class="hljs-keyword">new</span> Cat();

Is there something that I'm doing wrong that prevents.. for example.. the class name to be wrapped in a span? Only the 'new' keyword and '<?php' meta seems to be specified.

I noticed some missing keywords from the latest versions of C#:

• record

Example: public record Movie(string Title);

• with

Example: var m = a with { Name = "Test"}

These were new keywords added in .NET 5 / C# 9. I'm kinda guessing there might be other missing keywords from the latest versions. I haven't noticed any, just these two.

For reference: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/

The "PHP Template" language is missing. Only "php" can be passed to Highlighter::highlight(), but it should allow something like "php-template" or "php_template".

See https://highlightjs.org/static/demo/:

For anyone curious and before anyone asks, highlight.php 10.x/11.x is planned ~~and development will start in the coming weeks~~. I first need to finish off my semester and a few other commitments.

highlight.php 10 will require PHP 5.6+ (see #55)

The current estimated release of highlight.php v10/11 is Winter 2021

Why the delay?

highlight.js v10 introduced some breaking changes where grammars can no longer be represented by just JSON; grammars now support JS callbacks. While not many grammars are using this feature as of yet, I'm hesitant to dedicate myself to manually porting JS to PHP.

Does this mean highlight.php is dead?

No. Not at all. I do have some ideas for automatically translating JS to PHP to address this problem. I simply have not had time to work on this.

It's been over a year since this issue was created. Why haven't you done it yet?

I've had other projects, work, and school that have required my attention/focus/time. Feel free to sponsor me to work on this project :smile: :heart: