| Q | A |-------------- | ------ | Documentation | no | Bugfix | yes | BC Break | no | New Feature | no

Description

The issue: LoggerServiceFactory does not inject the writer nor the processor plugin managers. But LoggerAbstractServiceFactory does. And I want to use the former with custom processors.

I changed the inheritance so LoggerAbstractServiceFactory extends LoggerServiceFactory and moved some logic, so both inject the relevant plugin managers in the same way.

I changed PsrLoggerAbstractAdapterFactory to compose LoggerAbstractServiceFactory, not inherit. It didn't make sense as the return types for __invoke were incompatible. So adding strict typing across much of the factories would be possible now

Added unit tests for LoggerServiceFactory. All other unit tests still pass, and the factories can still be used in exactly the same way. Only difference is now LoggerServiceFactory injects the plugin managers.

Typing only added to anything new to maintain BC

I want to target the 2.15.x branch, as i see this as a bugfix - however, i am new to open source, and am open to guidance.

Hey,

is there any information or discussion about implementing the PSR-3 standard for Logger (https://github.com/php-fig/log). We often have this problem (like using also Monolog Logger).

If not we will laminas-log and replace it with another framework.

Best regards, David

Bug Report

| Q | A |------------ | ------ | Version(s) | 2.12

Summary

Laminas\Log\Logger::registerErrorHandler wraps around set_error_handler. By default AbstractWriter starts Laminas\Stdlib\ErrorHandler before writing and stops it after. ErrorHandler's stop function in turn calls restore_error_handler. In practice this means that a very basic setup with a simple stream writer would not write any errors after the first one, since php error handler gets restored on the first write.

User can avoid this if he sets convertWriteErrorsToExceptions to false on the writer:

$writer->setConvertWriteErrorsToExceptions(false)

But this requires the user to first face this bug.

This bug is present since at least Zend 2.

Current behavior

Only one error gets written by the writer. After that Laminas\Log php error handler gets removed.

How to reproduce

Very basic one stream writer example would already suffer from this bug:

$logger = new Laminas\Log\Logger;
$writer = new Laminas\Log\Writer\Stream('/test.log');

$logger->addWriter($writer);
Laminas\Log\Logger::registerErrorHandler($logger);

$writer->setConvertWriteErrorsToExceptions(false);

trigger_error('test1');
trigger_error('test2');

Expected behavior

Ideally the ErrorHandler class should not call restore_error_handler and somehow remove only himself from the error handlers list. Unfortunately PHP does not have an API to do this. The easiest fix is probably setting convertWriteErrorsToExceptions to false by default, but this brings back the reason why it converts errors to exceptions: now user has no way of knowing that his logging has failed.

Bug Report

If I try to log something using Laminas library (embedded in Omeka S software), I end up with an exception (Omeka store logs in a database table).

| Q | A |------------ | ------ | Laminas Version(s) | 2.6.0 | Maria db version| 10.5.9 | Omeka S version|3.1.1

Summary

Current behavior

An exception is thrown

[Fri Apr 08 13:12:40.596256 2022] [php7:notice] [pid 17] [client 193.48.70.142:58478] PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"log" ("created","severity","message","owner_id","context") VALUES ('2022-04-...' at line 1 in /var/www/html/vendor/laminas/laminas-db/src/Adapter/Driver/Pdo/Statement.php:238
Stack trace:
#0 /var/www/html/vendor/laminas/laminas-db/src/Adapter/Driver/Pdo/Statement.php(238): PDOStatement->execute()
#1 /var/www/html/vendor/laminas/laminas-log/src/Writer/Db.php(128): Laminas\\Db\\Adapter\\Driver\\Pdo\\Statement->execute(Array)
#2 /var/www/html/vendor/laminas/laminas-log/src/Writer/AbstractWriter.php(282): Laminas\\Log\\Writer\\Db->doWrite(Array)
#3 /var/www/html/vendor/laminas/laminas-log/src/Logger.php(459): Laminas\\Log\\Writer\\AbstractWriter->write(Array)
#4 /var/www/html/vendor/laminas/laminas-log/src/Logger.php(502): Laminas\\Log\\Logger->log(3, 'Exception: Noid...', Array)
#5 /var/www/html/application/src/Mvc/ExceptionListener.php(54): Laminas\\Log\\Logger->err('Exception: Noid...')
#6 /var/www/html/vendor/laminas/laminas-eventmanager/src/EventManager.php(321): Omeka\\Mvc\\ExceptionListener->handleException(Object(Laminas\\Mvc\\MvcEvent))
#7 /var/www/html/vendor/laminas/laminas-eventmanager/src/EventManager.php(170): Laminas\\EventManager\\EventManager->triggerListeners(Object(Laminas\\Mvc\\MvcEvent))
#8 /var/www/html/vendor/laminas/laminas-mvc/src/DispatchListener.php(153): Laminas\\EventManager\\EventManager->triggerEvent(Object(Laminas\\Mvc\\MvcEvent))
#9 /var/www/html/vendor/laminas/laminas-eventmanager/src/EventManager.php(321): Laminas\\Mvc\\DispatchListener->onDispatch(Object(Laminas\\Mvc\\MvcEvent))
#10 /var/www/html/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\\EventManager\\EventManager->triggerListeners(Object(Laminas\\Mvc\\MvcEvent), Object(Closure))
#11 /var/www/html/vendor/laminas/laminas-mvc/src/Application.php(331): Laminas\\EventManager\\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\\Mvc\\MvcEvent))
#12 /var/www/html/index.php(21): Laminas\\Mvc\\Application->run()
#13 {main}

How to reproduce

Log any message.

Expected behavior

Log should be stored in database without any issue.

Identified causes and Workaround

This issue is caused because Mariadb only accepts backtick ` around identifiers by default. Double quote " needs to be specified in SQL_MODE (source) to be accepted. A way (the only way I found, actually) to get rid of this issue is to set SQL_MODE to ANSI_QUOTES.

https://github.com/laminas/laminas-log/runs/6223336132?check_suite_focus=true#step:3:11

@weierophinney or @Xerkus can you help here? Thanks in advance!

Hi Team,

not able to update laminas-log version from 2.12.1 to 2.13.1.

Current version is 2.12.1

and while update using composer I am seeing message "nothing to install or update"

My Current php version 7.4.18

Could you please let know If I am doing anything wrong ?

Fatal error: Maximum function nesting level of '100' reached, aborting! in ../library/zendframework/zend-log/src/LoggerAbstractServiceFactory.php on line 85

Problem resolve when we put a "Config" on $services->has('config') line 91...

Originally posted by @nsantosMyt at https://github.com/zendframework/zend-log/issues/34

Bug Report

| Q | A |------------ | ------ | Version(s) | 2.15.1

Summary

Simple formatter broken with non-array value extra array key when using PHP version 8++.

How to reproduce

        $date   = new DateTime('2012-08-28T18:15:00Z');
        $fields = [
            'timestamp'    => $date,
            'message'      => 'foo',
            'priority'     => 42,
            'priorityName' => 'bar',
            'extra'        => null,
        ];
        $formatter = new Simple();
        echo $formatter->format($fields);
        // Throws error: TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given

        $date   = new DateTime('2012-08-28T18:15:00Z');
        $fields = [
            'timestamp'    => $date,
            'message'      => 'foo',
            'priority'     => 42,
            'priorityName' => 'bar',
            'extra'        => '',
        ];
        $formatter = new Simple();

        echo $formatter->format($fields);
        // Throws error: TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given

Expected behavior

        $date   = new DateTime('2012-08-28T18:15:00Z');
        $fields = [
            'timestamp'    => $date,
            'message'      => 'foo',
            'priority'     => 42,
            'priorityName' => 'bar',
            'extra'        => null,
        ];
        $formatter = new Simple();
        echo $formatter->format($fields);
        // Output: 2012-08-28T18:15:00+00:00 bar (42): foo

        $date   = new DateTime('2012-08-28T18:15:00Z');
        $fields = [
            'timestamp'    => $date,
            'message'      => 'foo',
            'priority'     => 42,
            'priorityName' => 'bar',
            'extra'        => '',
        ];

        $formatter = new Simple();
        echo $formatter->format($fields);
        // Output: 2012-08-28T18:15:00+00:00 bar (42): foo

Bug Report

| Q | A |------------ | ------ | PHP | 8.1 | Composer | 2.4.4

Summary

Cannot install package on a clean mezzio skeleton installation

Current behavior

composer shows "Your requirements could not be resolved to an installable set of packages." after command composer require laminas/laminas-log

How to reproduce

create a fresh mezzio skeleton installation then run composer require laminas/laminas-log

Expected behavior

laminas-log installed

| Q | A |-------------- | ------ | Documentation | yes | Bugfix | no | BC Break | no | New Feature | no | RFC | no | QA | no

Description

Adding details about the second parameter for Laminas\Log\Formatter\Simple, the DateTime object format.

| Q | A |-------------- | ------ | QA | yes

Description

Updated to use up to php 7.4 syntax and typed property (for private modifier only to keep BC) as now requirement is minimal php 7.4