The object keyword became reserved in PHP 7, this conflicts with the Zend\Barcode\Object; namespace.

http://php.net/manual/en/reserved.other-reserved-words.php

Originally posted by @fntlnz at https://github.com/zendframework/zend-barcode/issues/14

| Q | A |-------------- | ------ | Documentation | yes | Bugfix | yes | BC Break | no | New Feature | no | RFC | yes | QA | no

Description

Looking at #1 I decided to try and move all the classes from Laminas\Barcode\Object namespace to Laminas\Barcode\Barcode namespace. I had some problems with it as there are several classes that are children of another class. In order to not break the chain of inheritance that's currently in the repository I introduced ObjectInheritanceTest.

The thing I am not sure about is is whether I should move tests to test Barcode classes instead of Object ones?

| Q | A |-------------- | ------ | Documentation | no | Bugfix | no | BC Break | no | New Feature | no | RFC | no | QA | yes

Description

Windows uses \r\n as a new-line symbol while DOMDocument returns file with \n. Because of that, we get untrue failures in tests.

| Q | A |-------------- | ------ | Documentation | no | Bugfix | no | BC Break | no | New Feature | no | RFC | no | QA | yes

Description

Added PHP 8.1 support.

Bug Report

| Q | A |------------ | ------ | Version(s) | 2.8.2

Summary

I am trying to install on Magento 2.4.1 via composer.

Below is the error coming on cli. Problem 1 - Conclusion: don't install laminas/laminas-developer-tools 2.1.1 - Conclusion: remove laminas/laminas-config 2.6.0 - Installation request for laminas/laminas-developer-tools ^2.1 -> satisfiable by laminas/laminas-developer-tools[2.1.0, 2.1.1]. - Conclusion: don't install laminas/laminas-config 2.6.0 - laminas/laminas-developer-tools 2.1.0 requires laminas/laminas-modulemanager ^2.10 -> satisfiable by laminas/laminas-modulemanager[2.10.0, 2.10.1, 2.10.2]. - laminas/laminas-modulemanager 2.10.0 requires laminas/laminas-config ^3.4 -> satisfiable by laminas/laminas-config[3.4.0, 3.5.0]. - laminas/laminas-modulemanager 2.10.1 requires laminas/laminas-config ^3.4 -> satisfiable by laminas/laminas-config[3.4.0, 3.5.0]. - laminas/laminas-modulemanager 2.10.2 requires laminas/laminas-config ^3.4 -> satisfiable by laminas/laminas-config[3.4.0, 3.5.0]. - Can only install one of: laminas/laminas-config[3.4.0, 2.6.0]. - Can only install one of: laminas/laminas-config[3.5.0, 2.6.0]. - Installation request for laminas/laminas-config (locked at 2.6.0) -> satisfiable by laminas/laminas-config[2.6.0].

Current behavior

How to reproduce

composer require laminas/laminas-barcode:2.8

Expected behavior

Must be installed successfully.

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

• composer.json (composer)
• .github/workflows/auto-close.yml (github-actions)
• .github/workflows/continuous-integration.yml (github-actions)
• .github/workflows/docs-build.yml (github-actions)
• .github/workflows/release-on-milestone-closed.yml (github-actions)

Configuration Summary

Based on the default config's presets, Renovate will:

• Start dependency updates only once this onboarding PR is merged
• Enable Renovate Dependency Dashboard creation.
• Ignore node_modules, bower_components, vendor and various test/tests directories.
• Automerge patch and minor upgrades if they pass tests.
• If automerging, push the new commit directly to the base branch (no PR).
• Wait for branch tests to pass or fail before creating the PR.
• Rebase existing PRs any time the base branch has been updated.
• Separate major versions of dependencies into individual branches/PRs.
• Do not separate patch and minor upgrades into separate PRs for the same dependency.
• Raise PR when vulnerability alerts are detected.
• Evaluate schedules according to timezone UTC.
• Append Signed-off-by: to signoff Git commits.
• Apply label renovate to PRs.
• Group all minor and patch updates together.
• Default configuration for repositories in the Laminas organisation

🔡 Would you like to change the way Renovate is upgrading your dependencies? Simply edit the renovate.json in this branch with your custom config and the list of Pull Requests in the "What to Expect" section below will be updated the next time Renovate runs.

What to Expect

With your current configuration, Renovate will create 2 Pull Requests:

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section. If you need any further assistance then you can also request help here.

Read more information about the use of Renovate Bot within Laminas.

From Fedora CI https://koschei.fedoraproject.org/package/php-laminas-barcode

Since laminas/validator 2.14.5

There was 1 error:
1) LaminasTest\Barcode\Object\RoyalmailTest::testProvidedChecksum
Laminas\Barcode\Object\Exception\BarcodeValidationException: The input failed checksum validation
/builddir/build/BUILDROOT/php-laminas-barcode-2.9.0-2.fc35.noarch/usr/share/php/Laminas/Barcode/Object/AbstractObject.php:1313
/builddir/build/BUILDROOT/php-laminas-barcode-2.9.0-2.fc35.noarch/usr/share/php/Laminas/Barcode/Object/AbstractObject.php:1284
/builddir/build/BUILDROOT/php-laminas-barcode-2.9.0-2.fc35.noarch/usr/share/php/Laminas/Barcode/Object/AbstractObject.php:959
/builddir/build/BUILDROOT/php-laminas-barcode-2.9.0-2.fc35.noarch/usr/share/php/Laminas/Barcode/Object/AbstractObject.php:633
/builddir/build/BUILD/laminas-barcode-74034895076d2305ce6716f93dd8d821f3c1e4fc/test/Object/RoyalmailTest.php:151

Feature Request

| Q | A |------------ | ------ | QA | yes

Summary

As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Implementing psalm is quite easy.

Required

• [ ] Create a psalm.xml in the project root
• [ ] Copy and paste the contents from this psalm.xml.dist
• [ ] Run $ composer require --dev vimeo/psalm
• [ ] Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
• [ ] Add a composer script static-analysis with the command psalm --shepherd --stats
• [ ] Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
• [ ] Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Optional

• [ ] Fix as many psalm errors as possible.

| Q | A |-------------- | ------ | Documentation | no | Bugfix | no | BC Break | no | New Feature | no | RFC | no | QA | yes

Description

Right now, when running tests, we get a message about two risky tests. Thanks to this PR that will no longer happen. Also, we will be sure that the object returned by setter is the same as the original one.

Running test suite with PHP 7.4.1

There were 36 errors:

1) ZendTest\Barcode\Object\CodabarTest::testForeColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:432
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:160

2) ZendTest\Barcode\Object\CodabarTest::testBackgroundColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:463
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:180

3) ZendTest\Barcode\Object\Code128Test::testForeColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:432
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:160

4) ZendTest\Barcode\Object\Code128Test::testBackgroundColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:463
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:180


etc

In short # must be removed from $value

| Q | A |-------------- | ------ | QA | yes

Description

• Update composer config platform.php to 8.0.99
• Update composer PHP to ~8.0.0 || ~8.1.0 || ~8.2.0
• Ignore PHP platform requirements via .laminas-ci.json

https://github.com/laminas/laminas-barcode/blob/0fae0391d77e7f4e23a3a2154046754e403f20cb/src/Renderer/Image.php#L490-L509

Fix is to remove $numPoints from line 501.

        if (! $filled) {
            return imagepolygon($this->resource, $points, $color);
        }
`