PHP Censor is an open source self-hosted continuous integration server for PHP projects.

Expected behavior

Clone successful, working dir created

Actual behavior

Project Gitlab URL: [email protected]:2424/abc/xyz.git

Initialized empty Git repository in ./.git/
ssh: connect to host git.newtelco.de port 22: Connection refused
fatal: The remote end hung up unexpectedly

According to my googling, many have suggested creating a ~/.ssh/config file to create an ssh shortcut, I did this, however php-censor does not seem to recognize this when executing its ssh git pull. I thought it might have been because it is being executed as the nginx user, so I put this config file also in the home dir of nginx (/var/lib/nginx/.ssh/config), but that wasn't recognized either. Contents of my .ssh/config file are:

Host git.xyz.de
        hostname git.xyz.de
        port 2424
        User git
        PubKeyAuthentication yes
        IdentityFile /home/xyz/.ssh/id_xyz

Then I tried to insert the port into the project URL, but that still wasn't recognized / applied either. It still always said ssh: connect to host git.newtelco.de port 22: Connection refused. I tried the following URL variations:

• [email protected]:2424/abc/xyz.git
• [email protected]:2424:abc/xyz.git
• [email protected]:abc/xyz.git:2424

Has anyone successfully pulled from a custom ssh port? This only applies to self-hosted Gitlab instances as well I guess since Github and Bitbucket and the like aren't going to be changing their SSH ports.. haha

EDIT: For example, when using [email protected]:2424/abc/xyz.git

We get the following output (scroll all the way to the right to see full attempted URL):

Command: export GIT_SSH="/tmp/sh_FSkiLt" && cd .. && git clone --recursive  -b "master" "[email protected]:2424/abc/xyz.git" "./"
Initialized empty Git repository in ./.git/
ssh: connect to host git.xyz.de port 22: Connection refused
fatal: The remote end hung up unexpectedly

EDIT2: When sshing in normally, my ~/.ssh/config works:

$(13:12)-(80Kb)$ ssh [email protected]
PTY allocation request failed on channel 0
Welcome to GitLab, @root!
Connection to git.xyz.de closed.

Environment

• PHP Censor version - 0.23.0
• nginx version - 1.10.2
• Operating System - CentOS 6.10
• PHP version - 7.0.31
• MySQL/PostgreSQL version - mysql 5.5.60

got this error :

RUNNING PLUGIN: Technical Debt (Stage: Test)
ErrorException: 1: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 2137320387 bytes) in /data/htdocs/phpci/src/PHPCensor/Plugin/TechnicalDebt.php line 174 (uncaught exception) at /data/htdocs/phpci/src/PHPCensor/Plugin/TechnicalDebt.php line 174
Can`t build - status is not pending

Expected behavior

Install dependencies defined in composer.json

Actual behavior

Error message in build log

RUNNING PLUGIN: Composer (Stage: Setup) Plugin options: {"action":"install"} Looking for binary: composer Looking for binary: composer.phar Exception: Could not find composer/composer.phar PLUGIN: FAILED Exception: Plugin failed: composer

BUILD FAILED

Steps to reproduce

Run a simple build (config below)

setup: composer: action: "install" test: php_unit: config: "phpunit.xml" php_mess_detector: allow_failures: true php_code_sniffer: standard: "PSR2" php_cpd: allow_failures: true complete: email: default_mailto_address: [email protected]

Environment

Ubuntu 16.04 Apache/2.4.18 MySQL server 5.7.22 PHP 7.0.30 PHP Censor 0.22.0

Are there any plans for Psalm support?

Useful resource: https://medium.com/vimeo-engineering-blog/uncovering-php-bugs-with-template-a4ca46eb9aeb

Examples:

Simulation of Generics

The following code is wrong because it defines the property $bar to be a type of array<int> which means an array with integer values only:

<?php
declare(strict_types=1);

namespace Test;

class Foo
{
  /** @var array<int> */
  private $bar;

  /**
   * @param array<int> $bar
   */
  public function __construct(array $bar)
  {
    $this->bar = $bar;
  }
}


$foo = new Foo(['a']);

$ psalm
Scanning files...
Analyzing files...

ERROR: InvalidScalarArgument - src/test.php:21:16 - Argument 1 of Test\Foo::__construct expects array<array-key, int>, array{0:string(a)} provided
$foo = new Foo(['a']);


------------------------------
1 errors found
------------------------------

Checks took 0.22 seconds and used 23.997MB of memory
Psalm was able to infer types for 100.000% of analyzed code (1 file)

The following code is correct because it defines the $bar property to be a type of array<string, int> which means an array where key is string and value is integer:

<?php
declare(strict_types=1);

namespace Test;

class Foo
{
  /** @var array<string, int> */
  private $bar;

  /**
   * @param array<string, int> $bar
   */
  public function __construct(array $bar)
  {
    $this->bar = $bar;
  }
}


$foo = new Foo(['a' => 1]);

$ psalm
Scanning files...
Analyzing files...

------------------------------
No errors found!
------------------------------

Checks took 0.26 seconds and used 23.779MB of memory
Psalm was able to infer types for 100.000% of analyzed code (1 file)

The following code is correct because it defines the $bar property to be a type of array<string, Bar> which means an array where key is string and value is instance of Bar object:

<?php
declare(strict_types=1);

namespace Test;

class Foo
{
  /** @var array<string, Bar> */
  private $bar;

  /**
   * @param array<string, Bar> $bar
   */
  public function __construct(array $bar)
  {
    $this->bar = $bar;
  }
}

class Bar {}

$foo = new Foo(['a' => new Bar()]);

$ psalm
Scanning files...
Analyzing files...

------------------------------
No errors found!
------------------------------

Checks took 0.28 seconds and used 23.810MB of memory
Psalm was able to infer types for 100.000% of analyzed code (1 file)

While that is the primary function I use, there is plenty of functionality that is worth checking.

This request is taken from an old request in the original PHPCI issues thread: https://github.com/Block8/PHPCI/issues/255.

Please see quoted descriptions below from the original thread.

This would be nice for build notifications, just like the IRC plugin. Some documentation is available at developer.apple.com.

Right now I think we just need to configure the message and the icon (success, failure). Any other ideas?

This is very good idea, something i have missed in other CIs.

Maybe a wrapper like this https://github.com/alexgibson/notify.js would make it easier to build this? That will make it work for other browsers, such as Chrome, Safari & Firefox.

Problem I can see is that this is a frontend plugin more or less. which can be hard to make work if the users is not active on the website. Is it any way to make that work?

What about logo?) Because, sometimes I publishing containers and docker-compose files in some community repos and want to publish PHPCensor. With logo it'll be better:smile:.

I'm trying to build the following project: https://github.com/omegad-biz/fault-manager/tree/develop

but it fails:

My .php-censor.yml file is:

build_settings:
  directory: ./src
  ignore:
    - ./vendor
    - ./tests
    - ./docs
    - ./build
    - ./_compiled
  allowed_warnings: -1

setup:
  composer:
    action: install

test:

  php_unit:
    config:
      - phpunit.xml.dist
    directories:
      - tests
    coverage: true

  security_checker: ~

  php_parallel_lint: ~

  pdepend: ~

  phan: ~

  php_code_sniffer:
    standard: PSR2
    allowed_errors: -1

  php_cpd: ~

  php_docblock_checker: ~

  php_loc: ~

  php_mess_detector:
    rules:
      - cleancode
      - controversial
      - codesize
      - design
      - naming
      - unusedcode

  technical_debt: ~

failure:
  email:
    committer: true
    default_mailto_address: [email protected]

complete:
  email:
    default_mailto_address: [email protected]

I'm not sure why it does not see composer.json since it is in place, also I'm getting Exception: Address in mailbox given [] does not comply with RFC 2822, 3.6.2. but the email is correct.

Build with debug:

Args: ["cd .. && git clone --recursive  -b \"%s\" \"%s\" \"%s\"","develop","https:/github.com/omegad-biz/fault-manager.git","<BUILD_PATH>/"]
Command: cd .. && git clone --recursive  -b "develop" "https:/github.com/omegad-biz/fault-manager.git" "<BUILD_PATH>/"
sh: 0: getcwd() failed: No such file or directory
Cloning into '<PHP_CENSOR_PATH>/runtime/builds/3/65_b358d515'...

Execution status: 0
Args: ["cd \"%s\" && git checkout %s --quiet","<BUILD_PATH>/","2f7a806d0b5dedfabf1f344d2107f846f085708f"]
Command: cd "<BUILD_PATH>/" && git checkout 2f7a806d0b5dedfabf1f344d2107f846f085708f --quiet
Execution status: 0
Args: ["cd \"%s\" && git rev-parse HEAD","<BUILD_PATH>/"]
Command: cd "<BUILD_PATH>/" && git rev-parse HEAD
2f7a806d0b5dedfabf1f344d2107f846f085708f
Execution status: 0
Args: ["cd \"%s\" && git log -1 --pretty=format:%%s %s","<BUILD_PATH>/","2f7a806d0b5dedfabf1f344d2107f846f085708f"]
Command: cd "<BUILD_PATH>/" && git log -1 --pretty=format:%s 2f7a806d0b5dedfabf1f344d2107f846f085708f
add php-censor.yml
Execution status: 0
Args: ["cd \"%s\" && git log -1 --pretty=format:%%ae %s","<BUILD_PATH>/","2f7a806d0b5dedfabf1f344d2107f846f085708f"]
Command: cd "<BUILD_PATH>/" && git log -1 --pretty=format:%ae 2f7a806d0b5dedfabf1f344d2107f846f085708f
[email protected]
Execution status: 0
Build config from repository (.php-censor.yml)
Final config: {"build_settings":{"directory":"./src","ignore":["./vendor","./tests","./docs","./build","./_compiled"],"allowed_warnings":-1},"setup":{"composer":{"action":"install"}},"test":{"php_unit":{"config":["phpunit.xml.dist"],"directories":["tests"],"coverage":true},"security_checker":null,"php_parallel_lint":null,"pdepend":null,"phan":null,"php_code_sniffer":{"standard":"PSR2","allowed_errors":-1},"php_cpd":null,"php_docblock_checker":null,"php_loc":null,"php_mess_detector":{"rules":["cleancode","controversial","codesize","design","naming","unusedcode"]},"technical_debt":null},"failure":{"email":{"committer":true,"default_mailto_address":"[email protected]"}},"complete":{"email":{"default_mailto_address":"[email protected]"}}}
Working copy created: <BUILD_PATH>/

RUNNING PLUGIN: Composer (Stage: Setup)
Directory: <BUILD_PATH>/src/
Plugin options: {"action":"install"}
Looking for binary: composer, priority = local
Found in  (system): composer
Args: ["/usr/local/bin/composer --no-ansi --no-interaction  --working-dir=\"%s\" %s","<BUILD_PATH>/src/","install"]
Command: /usr/local/bin/composer --no-ansi --no-interaction  --working-dir="<BUILD_PATH>/src/" install
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https:/getcomposer.org/xdebug
Do not run Composer as root/super user! See https:/getcomposer.org/root for details
Composer could not find a composer.json file in <BUILD_PATH>/src
To initialize a project, please create a composer.json file as described in the https:/getcomposer.org/ "Getting Started" section

Execution status: 1
PLUGIN: FAILED
Exception: Plugin failed: composer

RUNNING PLUGIN: Email (Stage: Failure)
Directory: <BUILD_PATH>/src/
Plugin options: {"committer":true,"default_mailto_address":"[email protected]"}
Committer email: '[email protected]'
Committer option: 'true'
Addresses option: 'false'
Default mailTo option: '[email protected]'
SMTP: 'false'
Exception: Address in mailbox given [] does not comply with RFC 2822, 3.6.2.
PLUGIN: FAILED (ALLOWED)

BUILD FAILED!

RUNNING PLUGIN: Email (Stage: Complete)
Directory: <BUILD_PATH>/src/
Plugin options: {"default_mailto_address":"[email protected]"}
Committer email: '[email protected]'
Committer option: 'false'
Addresses option: 'false'
Default mailTo option: '[email protected]'
SMTP: 'false'
Exception: Address in mailbox given [] does not comply with RFC 2822, 3.6.2.
PLUGIN: FAILED (ALLOWED)

REMOVING BUILD.

Project settings:

The right section To make it easier to get started, we've generated an SSH key... empty and does not generate any ssh key...

Thanks!

I didn't check this simple unit with PHPCensor server. Just tried to start it. So, it'll be great if you check this more carefully. And maybe I should write more about the unit and how to start it. Anyway, just leave comments about it and I can change it or just do it by yourself:)

When pushing a commit to my gogs repo the webhooked php-censor failed :

Args: ["git clone --recursive  -b \"%s\" \"%s\" \"%s\"","master","http:\/\/myrepo.loc/user/repo","\/data\/htdocs\/phpci\/runtime\/builds\/516_6f26c\/"]
Command: git clone --recursive  -b "master" "http://myrepo.loc/user/repo" "/"
fatal: Could not get current working directory: No such file or directory

Execution status: 128
Failed to clone remote git repository.
Exception: Could not create a working copy.

BUILD FAILED
Exception: Warning: array_key_exists() expects parameter 2 to be array, null given in /data/htdocs/phpci/src/PHPCensor/Plugin/Util/Executor.php line 58

Removing Build.

i manualy start with debug, same error. Another working project : same error

The created build directory are deleted after each succès (and disk where not full)

I restart the rkt container, all seen to work fine.

The error is not very clear for me. Forget to restart the worker before reboot, but file where up to date with the repo

Hi, I use BitBucket and can trigger manual builds without any problems. I recently tried to set-up automatic builds using BitBucket's Webhooks (https://confluence.atlassian.com/bitbucket/manage-webhooks-735643732.html) and this appears to only half work.

The webhook got triggered and sent a message to PHP Censor, which responded with a:{ "status": "ok" }

However in PHP Censor nothing happens and no builds get triggered. I resent the request twice but still nothing happened.

• PHP Censor v0.21.0

Expected behavior

Support for GitHub Enterprise would be interesting as a new addition, as it isn't currently supported.

Steps to reproduce

I was able to link it by changing the URL of GitHub.com to my GitHub Enterprise Instance's hostname at /var/www/php-censor.local/src/PHPCensor/Model/Build/GithubBuild.php

Environment

• PHP Censor version
• Operating System
• PHP version
• MySQL/PostgreSQL version

I wish to always use the SSH protocol for every project. I am using an SSH key that is set in the user's home directory at ~/.ssh/ that allows git to clone from GitHub; authentication like this seems reasonable and works correctly.

However, because of the check in the GithubBuild.php class https://github.com/php-censor/php-censor/blob/master/src/Model/Build/GithubBuild.php#L173, HTTP will be forced when there's no private key present at the project level.

Could it perhaps be possible to add another check here for some application level config that forces us to the SSH protocol regardless of project level settings?

Another option here could be to use the Git build type instead. The downside of this method, is we then lose the ability to get build updates in Github from php-censor. This is not ideal as it would be preferred to have all the features of the GithubBuild regardless of the authentication or cloning method.

Expected behavior

phpstan should not check files/folders defined as ignore

Actual behavior

ignore wasn't used

Steps to reproduce

See screenshots:

Environment

PHPStan: 0.12.33 PHP Censor version: 1.2.0 PHP version: 7.3 MySQL version: 5.7

Move config for periodical builds (periodical.yml) to DB:

• Add alternative periodical build config in DB with higher priority that yml.
• Deprecate yml periodical config (Release 1.2).
• Delete yml periodical config (Release 2.0).

Improve installation command by separating interactive installation from non-interactive:

• By new non-interactive flag:

# Interactive installation 
./bin/console php-censor:install

# Non-interactive installation
./bin/console php-censor:install --non-interactive
    --url='http://php-censor.local'
    --db-type=pgsql
    ...

• Or by separated commands:

# Interactive installation 
./bin/console php-censor:install

# Non-interactive installation
./bin/console php-censor:non-interactive-install
    --url='http://php-censor.local'
    --db-type=pgsql
    ...

P. S.: Also we should add interactive mode for flag db-pgsql-sslmode from #282 and #283.

It useful for legacy code. For exapmle:

test:
  php_code_sniffer:
    allowed_errors: last.errors_count

or

test:
  php_code_sniffer:
    fail_on: has_new_errors