Hello,

Do you think it could be possible to have the responses cached for a specific period of time ? Maybe in a separate table or something, and have the API first check if the postcode is already cached and return the CACHED responses ?

This could save a few roundtrips to any API provider and also could limit the number of the API requests -- therefore reducing costs.

This solves the authoritative mode of Composer not loading some classes

• all providers are affected
• This also runs the unit tests with an optimized, authoritative classmap, to check if it actually works (it'll explode if it's wrongly registered again)
• Also moved the tests from the nickurt\PostcodeApi\tests namespace to the nickurt\PostcodeApi\Tests namespace, to be more in line with PSR-4.

Fixes #19.

Hi,

It doesn't seem to be possible to set the http client. I expected to do something like:

$guzzle = new GuzzleHttp\Client();
$postcodeapi = app('PostcodeApi');
$postcodeapi->setHttpClient($guzzle);

This way I can mock the responses for the PostcodeApi. Same as you did with the openprovider package for laravel.

Regards, Matthijs

Hello,

I'm using Laravel 5.8 and I have the following issue:

?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;

class AddressController extends Controller
{

    public function byPostcodeAndHouseNumber(Request $request)
    {
        $postCode21 = PostcodeApi::create('PostcodeApiNu')->findByPostcodeAndHouseNumber('1118CP', '202');
        return response()->json([
            'data' => $postCode21
        ]);
    }
}

Results in the following error:

Symfony\Component\Debug\Exception\FatalThrowableError: Class 'App\Http\Controllers\PostcodeApi' not found in file /app/Http/Controllers/AddressController.php on line 12
Stack trace:
  1. Symfony\Component\Debug\Exception\FatalThrowableError->() /app/Http/Controllers/AddressController.php:12

I like to know what I need to change

Thanks, Roy

Laravel 5.5

When I make a call with the following address:

$address = PostcodeApi::create('PostcodeNL')->findByPostcodeAndHouseNumber($request->zipcode, $request->housenumber);

I get this error. Any ideas?

{message: "Undefined offset: 0", exception: "ErrorException",…}
exception: "ErrorException"
file: "C:\Projects\nspctr\vendor\guzzlehttp\guzzle\src\Client.php"
line: 348
message: "Undefined offset: 0"
[{file: "C:\Projects\nspctr\vendor\guzzlehttp\guzzle\src\Client.php", line: 348,…},…]

Tested this on a clean install of Laravel 9 with the PostcodeApiNu provider. Didn't have keys for the other ones but it Should be fine :)

Also noticed a small variable mistake in the Readme example.

Two providers have been added to find places for postal codes. They are Zippopotam.us and Geonames.org. Geonames however show a more reliable database

When fetching "Postbus" addresses they will be returned without lat/lng. This results in a TypeError as the setLatitude/setLongitude method expects a float. This PR will prevent that from happening when there is no lat/lng provided by Pro6PP.

Hello,

I've gotten this problem when calling functions. When calling functions like this:

$address = \PostcodeApi::create('ApiPostcode')->findByPostcodeAndHouseNumber($request->code, $request->house);

I get the following error: {message: "Unable to use the provider "ApiPostcode"",…} exception: "nickurt\PostcodeApi\Exception\InvalidArgumentException" file: "C:\wamp64\quartzline\vendor\nickurt\laravel-postcodeapi\src\ProviderFactory.php" line: 18 message: "Unable to use the provider "ApiPostcode"" trace: [{file: "C:\wamp64\quartzline\vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php",…},…].

Do you have any ideas to help me out?

Thanks in advance!

The PHP version was upgraded in https://github.com/nickurt/laravel-postcodeapi/commit/5a481caec3be0194c48b4e0aaa0946a2dd46fbc4 to support Laravel 5.8, but L5.8 only requires PHP 7.1.3. Would it be possible to keep to 7.1.3 for now, to make upgrades easier (PHP 7.1 is still in security support; https://www.php.net/supported-versions.php )

Issue

The nickurt\PostcodeApi\Entity\Address class that nickurt\postcodeapi\Providers\nl_NL\PostcodeApiNu returns does not contain the house number addition.

Reproduce

Execute the following function:

$provider = \PostcodeApi::create('PostcodeApiNu');
$provider->findByPostcodeAndHouseNumber('4817MK', '148EC6');

This will result in:

nickurt\PostcodeApi\Entity\Address {#1136
  #street: null
  #houseNo: null
  #town: null
  #municipality: null
  #province: null
  #latitude: null
  #longitude: null
}

The PostcodeApiNu API does include the house number addition as the addition field shown in the response from the PostcodeApiNu API:

...
{
 "_embedded": {
    "addresses": [{
			"purpose": "woonfunctie",
			"postcode": "4817MK",
			"addition": "C6",
			"number": 148,
			"year": 1980,
...