When trying to serialize properties that have date objects or carbon objects like when queuing a closure, I'm facing bugs/warnings similar to this:

• PHP Warning: serialize(): "date" returned as member variable from __sleep()
• The DateTime object has not been correctly initialized by its constructor

I found that the issue is with serializing the date objects and php version. Also found similar PRs. https://github.com/opis/closure/issues/75 https://github.com/opis/closure/pull/113

• Serializable Closure Version: 1.0.5
• Laravel Version: 8.81.0
• PHP Version: 8.1.1
• Database Driver & Version: MariaDB 10.6

Description:

Using Octane to run some concurrent functions I get the following : [2022-02-01 14:31:06 ^76940.11] WARNING Server::task_unpack(): open(ravel\SerializableClosure\SerializableClosure":1:{s:12:"serializable";O:46:"Laravel\SerializableClosure\Serializers\Signed":2:{s:12:"serializable";s:721:"O:46:"Laravel\SerializableClosure\Serializers\Native":5:{s:3:"use";a:2:{s:11:"current_job";O:45:"Illum) failed, Error: File name too long[36]

Steps To Reproduce:

Octane::concurrently([
                    fn () => (isset($track_input[0]) ? $this->jobtrack->insert($track_input) : null),
                    function () use ($image_input, $document_input) {
                        $this->job_images->insert($image_input);
                        $this->job_documents->insert($document_input);
                    }
                ]);

• Serializable Closure Version: 1.0.0
• Laravel Version: 8.62.0
• PHP Version: 8.0.11
• Database Driver & Version: -

Description:

I get Call to undefined method Laravel\SerializableClosure\Serializers\Native::from() when I serialize a closure that is using a $this object that contains closures.

Steps To Reproduce:

class BindToMe
{
    private Closure $closure;

    public function __construct(Closure $closure)
    {
        $this->closure = $closure;
    }

    public function hello()
    {
        echo ($this->closure)();
    }
}

$serializable = new \Laravel\SerializableClosure\SerializableClosure(
    Closure::bind(
        function () {
            $this->hello();
        },
        new BindToMe(fn() => 'Hi')
    )
);

serialize($serializable);

The current will attempt to do $property->setValue($data, $item) which in the case of a readonly property will result into failure.

Having a glance at the tests it appears this should already be supported in theory, but I am running into this issue with laravel/serializable-closure v1.2.2 with PHP-Scoper. So this needs deeper investigation

• Serializable Closure Version: dev-master (e4970ee)
• Laravel Version: 8.75
• PHP Version: 8.0.15
• Database Driver & Version: mysql

Description:

I have a very similar problem to this one here: https://github.com/laravel/serializable-closure/issues/32

However, latest commit doesn't seem to be working for me.

Steps To Reproduce:

composer create-project laravel/laravel test
php artisan queue:batches-table
php artisan migrate
composer require laravel/serializable-closure:dev-master

Then >>

➜  php artisan tinker
Psy Shell v0.11.1 (PHP 8.0.15 — cli) by Justin Hileman
>>> \Illuminate\Support\Facades\Bus::batch([])->name("test2")->then(function ($b) {
... echo 'asd';
... })->dispatch();
<warning>PHP Warning:  file_get_contents(/Users/user/work/testeval()'d code): Failed to open stream: No such file or directory in /Users/user/work/test/vendor/laravel/serializable-closure/src/Support/ReflectionClosure.php on line 805</warning>
PHP Error:  Call to a member function bindTo() on null in /Users/user/work/test/vendor/laravel/serializable-closure/src/Serializers/Native.php on line 193

Passing an array with a job to the batch method also gives the same result.

• Laravel Version: 8.73.2
• PHP Version: 8.0.7
• Database Driver & Version: mysql Ver 8.0.22 for osx10.16 on x86_64 (Homebrew)

Description:

The closure fails to serialize with:

syntax error, unexpected token ":", expecting ")" {"userId":7,"exception":"[object] (ParseError(code: 0): syntax error, unexpected token \":\", expecting \")\" at laravel-serializable-closure://fn () => $this->requestUpdate(
    \\App\\Models\\clearCollectionCache: false,
    \\App\\Jobs\\Duda\\RefreshSite: true,
):3)

Bus::chain([
    new CreateSite($this),
    fn () => $this->requestUpdate(
        clearCollectionCache: false,
        refreshSite: true,
    ),
])->dispatch();

Steps To Reproduce:

Just add a closure with a named argument call inside and it will fail to parse. Example above.

Workaround

Remove the named argument:

Bus::chain([
    new CreateSite($this),
    fn () => $this->requestUpdate(false, true),
])->dispatch();

Description

It seems like PHP8 Attributes are not properly serialized. When serializing a closure that was annotated with attributes, those cannot be received using ReflectionFunction::getAttributes() on the deserialized one (as shown by the test).

At the moment, Laravel does not use any attributes to change route behavior, but I can see this being useful in the future (for an example, see "Motivation"). If this is not intended to be supported, I feel like this should be at least documented in the "Caveats"-section of the Readme.

Motivation

I tried to build a package that does something similar to this closed PR on the laravel framework. Basically you configure a middleware, annotate your controller/closure with an Transactional-attribute, and they will automatically be wrapped in a transaction:

// web.php
Route::get('transactional', #[Transactional] function () {
    $a = User::factory()->create();
    $b = User::factory()->create();

    return [$a, $b];
}

This code works fine during development, but as soon as I run php artisan optimize and the route files are cached, the Transactional attribute disappears, and the function is not wrapped inside a transaction anymore. This is due to the behavior shown in the test.

Hi, good job with this fork!

I recently ran into a situation, where a class has an enum property, which prevents the call to ReflectionClass->newInstanceWithoutConstructor(), since an enum cannot be instantiated:

PHP Fatal error:  Uncaught Error: Cannot instantiate enum Project\AnEnum in ...\vendor\laravel\serializable-closure\src\Serializers\Native.php:261
Stack trace:
#0 ...\vendor\laravel\serializable-closure\src\Serializers\Native.php(261): ReflectionClass->newInstanceWithoutConstructor()
#1 ...\vendor\laravel\serializable-closure\src\Serializers\Native.php(282): Laravel\SerializableClosure\Serializers\Native::wrapClosures(Object(Project\AnEnum), Object(Laravel\SerializableClosure\Support\ClosureScope))
#2 ...\vendor\laravel\serializable-closure\src\Serializers\Native.php(122): Laravel\SerializableClosure\Serializers\Native::wrapClosures(Object(Project\ParentClass), Object(Laravel\SerializableClosure\Support\ClosureScope))
#3 [internal function]: Laravel\SerializableClosure\Serializers\Native->__serialize()
...

Any intention of supporting this use-case?

• Serializable Closure Version: v1.1.0
• Laravel Version: not laravel scope
• PHP Version: 8.0.15

Description:

I created closure from object method and tried to serialize it, however once unserialized it fails because of type hint used for this method.

Steps To Reproduce:

Minimal code example is below:

Entry point script:

<?php

use Laravel\SerializableClosure\SerializableClosure;
use Rela589n\PhpDecorationIssue\SerializableClosure\SerializableClosureIssue;

require 'vendor/autoload.php';

$object = new SerializableClosureIssue();

/** @var SerializableClosure $original */
$original = unserialize(
    serialize(
        new SerializableClosure(Closure::fromCallable([$object, 'reproduceIssue']))
    )
);

var_dump($original->getClosure()());

Class with method which will be used as closure:

<?php

declare(strict_types=1);

namespace Rela589n\PhpDecorationIssue\SerializableClosure;

use JetBrains\PhpStorm\Immutable;

#[Immutable]
final class SerializableClosureIssue
{
    public function reproduceIssue(): Issue
    {
        return new Issue();
    }
}

Class for type-hinting in method:

<?php

declare(strict_types=1);

namespace Rela589n\PhpDecorationIssue\SerializableClosure;

use JetBrains\PhpStorm\Immutable;

#[Immutable]
final class Issue
{

}

The foregoing code gives next issue:

PHP Fatal error:  Uncaught Error: Class "Issue" not found in laravel-serializable-closure://function (): \Issue
    {
        return new \Issue();
    }:4
Stack trace:
#0 /home/rela589n/projects/php-decoration-issue/serializable-closure.php(17): Rela589n\PhpDecorationIssue\SerializableClosure\SerializableClosureIssue::{closure}()
#1 {main}
  thrown in laravel-serializable-closure://function (): \Issue
    {
        return new \Issue();
    } on line 4

Thanks

Thank you for this amazing package, it really complements missing PHP feature.

• Serializable Closure Version: 1.2.2
• Laravel Version: 9.40.1
• PHP Version: 8.1.12
• Database Driver & Version: postgres 14

Description:

I was working on implementing batched jobs using Bus::batch when I noticed that chaining any completion callbacks will throw an error

Call to a member function bindTo() on null

Note Extracting the closure from ->then to a protected function then calling it works 🤷‍♂️ like ->then($this->notifyOwner())

I tried it with Tinker, and I got the same results, so I tried to simplify the work and tested the example stated in the readme file here using both Tinkerwell and tinker with the same results.

Psy Shell v0.11.9 (PHP 8.1.12 — cli) by Justin Hileman
> use Laravel\SerializableClosure\SerializableClosure;
> $closure = fn () => 'james';
= Closure() {#5091 …2}

> SerializableClosure::setSecretKey('secret');
= null

> $serialized = serialize(new SerializableClosure($closure));

   WARNING  file_get_contents(eval()'d code): Failed to open stream: No such file or directory in vendor/laravel/serializable-closure/src/Support/ReflectionClosure.php on line 829.

= "O:47:"Laravel\SerializableClosure\SerializableClosure":1:{s:12:"serializable";O:46:"Laravel\SerializableClosure\Serializers\Signed":2:{s:12:"serializable";s:174:"O:46:"Laravel\SerializableClosure\Serializers\Native":5:{s:3:"use";a:0:{}s:8:"function";s:0:"";s:5:"scope";N;s:4:"this";N;s:4:"self";s:32:"00000000000013e30000000000000000";}";s:4:"hash";s:44:"A3kjjoOaJHAtn4QzC61Wx//EuVlbAb8Q6PmTlStglb8=";}}"

> $closure = unserialize($serialized)->getClosure();

   ERROR  Call to a member function bindTo() on null in vendor/laravel/serializable-closure/src/Serializers/Native.php on line 194.

Steps To Reproduce:

Open tinker and try the usage example listed here

This pull request adds tests for closure created from object method, which defines type-hint of object residing in the same namespace, which is therefore imported implicitly.