Hello,

I've updated to 1.1.7, and the ->prop() method seems to be gone. Was it renamed to something else ?

Thank you,

FYI: I used to it to get the providers $app['modules']->prop("{$module}::providers") to register them.

Hi @gravitano,

I'm using your plugin to create a modulazired application. However, I can't figure out how to use an external library, like intervention/image, in a module. Here are the steps I took:

Create a new application and install pingpong modules

$ laravel new testcore

Crafting application...
> php -r "copy('.env.example', '.env');"
> php artisan clear-compiled
> php artisan optimize
Generating optimized class loader
> php artisan key:generate
Application key [3J6WvdEcA2IpTtuo6jV87XGUbNO8xJ39] set successfully.
Application ready! Build something amazing.

$ cd testcore
$ composer require pingpong/modules

Using version ^2.1 for pingpong/modules
./composer.json has been updated
> php artisan clear-compiled
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing laravelcollective/html (v5.1.3)
    Loading from cache

  - Installing erusev/parsedown (1.5.3)
    Loading from cache

  - Installing erusev/parsedown-extra (0.7.0)
    Loading from cache

  - Installing pingpong/support (v2.1.4)
    Loading from cache

  - Installing doctrine/lexer (v1.0.1)
    Loading from cache

  - Installing doctrine/annotations (v1.2.6)
    Loading from cache

  - Installing doctrine/collections (v1.3.0)
    Loading from cache

  - Installing doctrine/cache (v1.4.1)
    Loading from cache

  - Installing doctrine/common (v2.5.0)
    Loading from cache

  - Installing doctrine/dbal (v2.5.1)
    Loading from cache

  - Installing pingpong/generators (v2.1.4)
    Loading from cache

  - Installing pingpong/modules (v2.1.4)
    Loading from cache

Writing lock file
Generating autoload files
> php artisan optimize
Generating optimized class loader

Add Modules Service Provider and Alias to config/app.php

    'providers' => [
        Pingpong\Modules\ModulesServiceProvider::class,
        /*
         * Laravel Framework Service Providers...
         */
        Illuminate\Foundation\Providers\ArtisanServiceProvider::class,
        ...
    ],
    'aliases' => [
        'Module'    => Pingpong\Modules\Facades\Module::class,
        'App'       => Illuminate\Support\Facades\App::class,
        ...
    ],

Add PSR-4 loading of Modules namespace

{
  "autoload": {
    "psr-4": {
      "App\\": "app/",
      "Modules\\": "modules/"
    }
  }
}

$ composer dump-autoload

Publish vendor files

$ php artisan vendor:publish

Copied File [/vendor/pingpong/modules/src/config/config.php] To [/config/modules.php]
Publishing complete for tag []!

$ php artisan module:setup
Modules directory created successfully
Assets directory created successfully

Create a new module

$ php artisan module:make Media
Created : /var/www/testcore/modules/Media/start.php
Created : /var/www/testcore/modules/Media/Http/routes.php
Created : /var/www/testcore/modules/Media/module.json
Created : /var/www/testcore/modules/Media/Resources/views/index.blade.php
Created : /var/www/testcore/modules/Media/Resources/views/layouts/master.blade.php
Created : /var/www/testcore/modules/Media/Config/config.php
Created : /var/www/testcore/modules/Media/composer.json
Created : /var/www/testcore/modules/Media/Database/Seeders/MediaDatabaseSeeder.php
Created : /var/www/testcore/modules/Media/Providers/MediaServiceProvider.php
Created : /var/www/testcore/modules/Media/Http/Controllers/MediaController.php
Module [Media] created successfully.

Everything until this point works fine: i can browse to testcore.localhost/media and Laravel successfully shows me the module Welcome page. Even the module status shows me that everything is ok:

php artisan module:list
+-------+---------+-------+---------------------------------+
| Name  | Status  | Order | Path                            |
+-------+---------+-------+---------------------------------+
| Media | Enabled | 0     | /var/www/testcore/modules/Media |
+-------+---------+-------+---------------------------------+

Add composer dependency

$ cd modules/Media
$ composer require intervention/image
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing psr/http-message (1.0)
    Loading from cache

  - Installing guzzlehttp/psr7 (1.1.0)
    Loading from cache

  - Installing intervention/image (2.3.1)
    Loading from cache

intervention/image suggests installing intervention/imagecache (Caching extension for the Intervention Image library)
Writing lock file
Generating autoload files

Everything is fine again:

php artisan module:list
+-------+---------+-------+---------------------------------+
| Name  | Status  | Order | Path                            |
+-------+---------+-------+---------------------------------+
| Media | Enabled | 0     | /var/www/testcore/modules/Media |
+-------+---------+-------+---------------------------------+

But now i need to include the Intervention Service Provider to be able to use it, so i edit my module.json file like this:

{
    "name": "Media",
    "alias": "media",
    "description": "",
    "keywords": [],
    "active": 1,
    "order": 0,
    "providers": [
        "Modules\\Media\\Providers\\MediaServiceProvider",
        "Intervention\\Image\\ImageServiceProvider"
    ],
    "aliases":{},
    "files": [
        "start.php"
    ]
}

If I check again the modules statuses, artisan give me an error:

$ php artisan module:list
PHP Fatal error:  Class 'Intervention\Image\ImageServiceProvider' not found in /var/www/testcore/vendor/laravel/framework/src/Illuminate/Foundation/Application.php on line 575

  [Symfony\Component\Debug\Exception\FatalErrorException]    
  Class 'Intervention\Image\ImageServiceProvider' not found  

I think that this is related to not including composer's autoload.php inside modules/Media/vendor/.

Are there any correct ways to do this? I spotted a class named Starter inside pingpong/modules which seems to do exactly this, but I don't know how to use it.

Please help me!

Hi,

I tried the new module:filter-make command, the filter was correctly generated, but at the root of the module.

It had the correct namespace though, Modules\Session\Http\Filters

Hello! How does one access a translations file from a module? I have a module calles Vpns with the translation file help.php. I try to access the data with trans('vpns.help.new.name') but it will not work. The translation file looks like this: 'help' => [ 'new' => [ 'name' => 'Hilftetext für Name' ] ]

Hello,

Could you please load assets without specifying http://, for instance:

Example:

Module::asset(''core:js/keypressAction.js)

Don't load:

<script src="http://asgardcms.dev/modules/core/js/keypressAction.js" type="text/javascript"></script>

but:

<script src="//asgardcms.dev/modules/core/js/keypressAction.js" type="text/javascript"></script>

This will load the asset to the current protocol, either http or https.

You could also provide an optional argument, in addition to loading assets over //, to set secure true or false.

Thanks!

(This is pretty important since loading the site over https will fail because of this issue)

Hello,

I started to let some people in the AsgardCMS beta, and there's still the issue that pingpong/modules loads the routes by default. I have to tell them to comment line 193 on the Module class $this->registerRoutes(); since I use the L5 way of registering routes. Using a service provider. Could you please not register routes by default using your technique?

Thanks,

Hello,

after I created a module I published it to my private git repo. After that I installed it via composer and it's available at the vendor folder, now. But when I open my Browser and type an route in, which is available in route.php file i get a

NotFoundHttpException in RouteCollection.php line 145

composer dump-autoload has no effect.

Can u help me? Sorry for my bad english. I'm German.

Greetings.

Hey,

Did anything change since last update about accessing the module configuration? Since the composer update I did this morning I cannot access Config::get('core::core.admin-prefix') anymore. Which previously worked. My file structure hasn't changed since.

Thanks.

All artisan commands fail after enabling this module

{"error":{"type":"ReflectionException","message":"Class modules.finder does not exist","file":"\/var\/www\/vendor\/laravel\/framework\/src\/Illuminate\/Container\/Container.php","line":485}}

And the webapplication is broken too with the same error.

Hey,

I added a relation to my model like that:

    public function articles()
    {
        return $this->hasMany('App\Modules\XXX\Models\Articles');
    }

But always get:

FatalErrorException in Model.php line 902: Class 'App\Modules\XXX\Models\Articles' not found

Am I doing something wrong, or is the package not compatible with relations?

Thanks!

Hello @gravitano,

I want to generate a migration for my module (I use L5.1).

First I type in the command

 php artisan module:use Content

After that I want to execute

 php artisan module:make-migration create_content_table

But then I get an error:

 [Symfony\Component\Debug\Exception\FatalErrorException]
 Class 'Pingpong\Generators\Exceptions\InvalidMigrationNameException' not found

Can u help me ?

Thanks and greetings from Germany

Heiko

composer require pingpong/modules "dev-master" command executing the error occurred!

Problem 1 - Installation request for pingpong/modules dev-master -> satisfiable by pingpong/modules[dev-master]. - pingpong/modules dev-master requires pingpong/support dev-master -> satisfiable by pingpong/support[dev-master] but these conflict with your requirements or minimum-stability.

I'm in the process of upgrading to laravel 5.2, using version 2.2 of this package.

However since this upgrade, the application load time has increased by almost 2 seconds.

I've run a blackfire.io profiler, this is what it looks like: https://blackfire.io/profiles/1fa3c08e-c1df-4c3d-84e2-ea73be40361c/graph

On that profile there are 606 calls to file_get_contents which comes from the Json class. This is with caching enabled. Without caching this was close to 1300 calls!

I think this could still be reduced as the same module.json file is called multiple times. The following image only shows a very small amount of calls.

Adding some caching to the getAttributs method in the Json class.

public function getAttributes()
{
    return app('cache')->remember($this->getPath(), 10, function () {
        return json_decode($this->getContents(), 1);
    });
}

This reduces the amount of calls to 22!! After this change: https://blackfire.io/profiles/8e098e83-af3c-4638-b6f5-3ffca7136f44/graph

I think this is something that should be looked at asap.