Issue tracking application extending GitHub's issues and pull requests for the Joomla! project.

Implement this feature based off the framework branch. What would be the most helpful to me is to bring in the code and implement it into the template (copy it from /platformApp/templates/joomla/index.php).

There is currently an open issue where @mbabker points out the reasons why it might be good to have the JTracker application available in multiple languages.

I would agree with that completely.

Currently there have been responsible programmers creating about 50 language keys for the JTracker application (about a dozen of them being used) and we also have the "core CMS" language files containing houndreds of strings, not used anywhere.

The rest of the strings used in the application has been hard coded by a group of irresponsible developers (including the one opening this PR...). The reason why ?? I can only speak for myself: I was too lazy ;(

So - I think we have several options to go from here:

1) The J!Tracker remains "english only"

Nothing to do. This issue (and #73) can be closed.

2) Use ini files and ALL_CAPS_LANGUAGE_KEYS

Wait until somebody converts all those hard coded strings to ALL_CAPS_KEYS and spend some lazy evenigs on the creation and maintainance of the language files.

We might wait for that to happen.... or

3) Go crazy...

I might have stated before that I'm a very lazy person. So I like to spend my time creating scripts that do the "ugly work" for me. - Like the creation and maintainance of language files :P

The proposed solution to the above mentioned problem implemnents a (still) experimental language handler, that has not been tested out there in the wild.

The basic idea is:

• Read language files in multiple formats.
• Extract the key/value pairs.
• Store the result in a "permanent cache" to speed things up.

The language file format to use in JTracker will be po (gettext), the result is stored to a "native PHP array" which is written to a text file. Other options can be explored.

3a) Required changes

Changes to hard coded strings in Twig templates and PHP code:

// template.twig
<label>
    My String

    // change to:
    {{ translate("My String") }}

    // **OR** just use a pipe and a shortcut:
    {{ "My String"|_ }}
</label>

In PHP you would use the global function with an easy to remember name; g11n3t (*)

echo g11n3t('My String');

... and go home !

(_) _btw*: g11n3t means globalizationtext. If you don't like it, you may create your own alias ;)

The next step would be the creation of the language files.

3b) Language template creation

For gettext files, you first create a template that contains all the keys and empty values. These templates are used to create and update the localized language files. The file extension for template files is .pot.

# Extension.pot

msgid "My String"
msgstr ""

These files can be created and maintained manually, however... I'm a lazy person (did I say that before ? )

The gettext utility xgettext can read a wide range of code languages and supports a custom function name. It supports over 20 languages officially, others just "work" (like JavaScript can be parsed as Python...) but the only unsupported language I know is Twig :( Fortunately this is a known issues, so the solution is to compile the templates and then run xgettext over the generated PHP code.

There is a new script that just collects all relevant files and passes them, along with some options, to xgettext:

tracker.php make langtemplates

Will automatically generate the language templates for the core JTracker application, the JTracker template as well as all the Apps.

Those language templates, once created, are now ready to hand over to the translators or send them to an online translation service (e.g. transifex).

Job finished :)

3c) Localize It !

To actually "see" the site in different languages, you have to create a file that contains the localized strings for every language. The extension for language files is .po.

For example a german language file might look like this:

# de-DE.Extension.po

msgid "My String"
msgstr "Meine Zeichenkette"

A chinese language file might look like this (google says..):

# zh-CN.Extension.po

msgid "My String"
msgstr "我的字符串"

and so on...

Translators may notice here, that you always see the original in clear text above the translation. -- If you plan to handle the translations manually...

While you can also create those files manually, the gettext tools msginit and msgmerge can create and update language files from a given template - So why not use them (remember: me lazy...)

tracker.php make langfiles

will create language files for the core, the template and all extensions (Apps) in all defined languages.

What else ?

System requirements

To manually create and manage your language file(s) you will need:

• Your hand(s).

To have your language files created and managed automatically you will need:

• gnu gettext - from which you will only need it's utilities.

The gettext utilities should be available or installable on all *nix based systems, as well as some sons/daugthers and parents (like BSDs and apple stuff). If you are stuck on windows, your best bet may be cygwin (as always). There is also MinGW, a sourceforge project, as well as this site. I have not tried any of the above currently beside my own linux box, but I believe that if would be no problem for a windows developer with decent skills to modify the script ;)

Known issues

• There is one big FAT issue currently: Internally all strings are contained in a single array. Meaning that you can not translate the same key in two different ways in the same page call.
  I believe that our application is "small enough", so this wont really be an issue.
  There is a solution deep down in my head, but it hasn't been translated to code yet ;) WIP
• Pluralization is supported but not implemented yet. WIP
• JavaScript translations and pluralizations are supported but not implemented yet. WIP
• Performance... This will be the last time that I mention that I'm lazy but... to avoid ugly escaping/unescaping of quotes, I simply base64 encode and decode the string and md5 encode the key which is, I admit that, very very time consuming W-I-P...

Refs

• https://github.com/elkuku/g11n - The experimental language handler oO

Demo: If you want to see this in action there is a staging instance which is currently running with full debug enabled here (link will change)

P.S.: I tried to keep this post short but seems like I failed miserably... sorry for the long post and thanks if you made it that far =;) P.P.S.: I just realized, that this PR also contains commits from #123, so it should be clearer after that is merged ;)

Pull Request for Issue #705 .

Summary of Changes

This PR based on the code here: https://github.com/joomla/jissues/pull/705 and adds some checks to the Receive Hooks that the hookData is valid.

Testing Instructions

• Add a category with ID 3
• apply this patch
• Open a pull request that adds this file administrator/components/com_admin/sql/updates/sqlazure/test.sql

Expected result

The Tracker should add the category with ID 3 to your item without you doing something :smile:

@bz2 I have add some extra checks to the ReceiveIssuesHook.php file that should avoid the errors you got at https://github.com/joomla/jissues/pull/705#issuecomment-148161546 I hope it helps ;)

@mbabker can you have a look here too? i hope i have not break you extra Exception handling.

After running cli/tracker.php make langfiles, I have this in my environment:

Michaels-MacBook:jissues mbabker$ git status
# On branch framework
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#   modified:   src/App/Debug/g11n/de-DE/de-DE.Debug.po
#   modified:   src/App/Debug/g11n/ru-RU/ru-RU.Debug.po
#   modified:   src/App/Debug/g11n/templates/Debug.pot
#   modified:   src/App/GitHub/g11n/templates/GitHub.pot
#   modified:   src/JTracker/g11n/templates/JTracker.pot
#   modified:   templates/JTracker/g11n/de-DE/de-DE.JTracker.po
#   modified:   templates/JTracker/g11n/ru-RU/ru-RU.JTracker.po
#   modified:   templates/JTracker/g11n/templates/JTracker.pot
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#   src/App/Debug/g11n/de-DE/de-DE.Debug.po.~1~
#   src/App/Debug/g11n/ru-RU/ru-RU.Debug.po.~1~
#   templates/JTracker/g11n/de-DE/de-DE.JTracker.po.~1~
#   templates/JTracker/g11n/ru-RU/ru-RU.JTracker.po.~1~

What files should be committed, what should be deleted, and what should be ignored? Also note that the server is built from my local, so it'd be good to know so I don't break something uploading files.

This will add some more label management.

Note: It could be that there will be some "duplicate events" on the live site because I assume that changing a label will also fire a hook event - not sure.

Here is some new stuff I hacked together during the last week. Open for review ;)

Access control

Acces control is limited and very specific:

• Only Projects are tracked.
• There are only 4 "hard wired" Actions:
  view, create, edit and manage.
• It is based on groups a user automatically belongs to or can be assigned to.
  For every project two system groups are created by default:
  Public and User.

The special admin user role that is assigned using the config.json file is granted global access.

Following is an example setup for a security tracker with non public access and two additionally created custom groups:

However, this is a very first step... lots of optimization and testing required here.

Pagination

I searched the web for "PHP pagination MySQL" or similar, and this came up on the first page: http://www.awcore.com/dev/1/3/Create-Awesome-PHPMYSQL-Pagination_en

I liked the way the author solved "the problem", the code looked acceptable,... so I "forked" and Joomla!"d it :) The CSS was somewhat conflicting (for me), so I took one of the beautiful styles from the author, and now it looks like this:

For now it only generates "plain links" adding a &page=n parameter to the current URL. When we implement the search functionality, this must be revised. I can also imagine a JavaScript (AJAX) based solution using this.

Note: The license on this is very unclear. Seems that is provided as a "snippet". Maybe our legal department should have a look at this ;)

Database updates

Obsolete tables and table fields have been removed while others have been added ;)

Full reinstall required !

Avatar support

On the first log in, the application tries to fetch the users avatar and store it locally.

This requires cURL.

Debugging and Logging

Added a TrackerDebugger class that... handles debugging :P Added a CallbackLogger class to provide database query logging. A log file can be written to log queries even during redirects ;) Exception rendering has been improved to include clickable file links using the xdebug protocol.

Happy testing =;)

I can see how I can edit an item to change its status (is that something everyone can do or is it because of my own account settings) but is that the best way to do it. Currently you cannot change status and comment at the same time.

This branch starts working on implementing activity charts in the site to replace those that used to be on developer.joomla.org. Still a long way to go, but this chart does render the data it's pulling correctly.

TODO list:

• [x] Test points aren't logged properly
• [x] Using the GitHub username versus the user's real name
• [ ] Layout isn't optimized to the container width
• [ ] Most charts from https://developer.joomla.org/tracker/volunteer-activity.html (all of the component code is available at https://github.com/mbabker/bug-squad-stuff/tree/master/components/com_trackerstats)
  • [x] Individual Statistics (Tracker Points)
  • [ ] Total Project Activity (Total Tracker Points)
  • [x] Issues Open/Closed Over Time (Open/Fixed/Closed)
  • [x] Issues Open By Status
• [ ] Frontend UI to manage points
• [ ] Other optimizations or improvements based on feedback

@dextercowley if you have any suggestions or improvements you'd like to offer, I know I'd greatly appreciate the help.

This PR try to implement the RTC Label Check to run also if a comment was add.

What needs to be tested

• add a pull
• set status to RTC
• comment (using jissues)
• make sure the RTC label will add.
• add a new pull
• set the status to RTC
• comment (using github)
• make sure the RTC label will add.

I can't realy test it as i have no testserver setup. But in theory it should work or i miss something?

So it is not 100% idial but we have a bit more automagic in the Tracker.

I think we should improve our user test facility as it is one of those things we really add to the GitHub tracker.

I think we should start treating the user tests like the other automated test results (if possible). For this it is necessary to record the information when the PR has been tested. In terms of git this would be the git SHA hash corresponding to the last commit. (You may read more about it here, here or here).

This information has not to be entered by the user, but it is displayed (for verification) like this:

The testers might verify this SHA to ensure they are testing the latest commit.

The SHA can be obtained using the information provided by the users IDE, the command line or we can adapt com_patchtester to show it in the list:

The result of this change is that now every new commit to a PR will require all testers to resubmit their test results (!)

UI wise This PR also moves the elements for testing in the issue view from the right "module" to a sliding panel to unclutter the UI.

A comment box has been added to submit an additional comment and the test options have been removed from the comment box at the bottom.

I also think we should report back the test results to the GitHub tracker as in #596 but I'm quite unsure about the implementation...see #695

One thing that must be replicated here is the ability for registered users to upload files (screenshots, patch files, etc.) to items they have permissions on. Joomlacode makes it pretty much impossible to remove files after the fact, but we should be able to do this.

Basic requirements:

• Folks be able to upload patch files generated locally (GitHub is 1000% preferred, but some just aren't with the times)
• Folks be able to upload supporting files (images, documents, etc.)
• Selected file types aren't allowed (i.e. no PHP files, like Joomlacode)
• With permission, users are able to delete files

As noted below, I think we agree on blueimp for the frontend. Do we want/need anything for the backend?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• [ ] Lock file maintenance

Detected dependencies

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

Update Joomla 4.0.6 -> 4.1.0 by Admin Console or Install Fresh Install from Joomla Page Add a line to error.php in your tempate -> if (($this->error->getCode()) == '404') {header('Location: https://angloschool.com.pl/index.php?option=com_content&view=article&id=82'); exit; Try writing wrong address to old indexed page from Google to your site or just put something like /test to your html website address. Or try going to non existent article in your website.

Expected result

In Joomla 4.0.6 expected result was a website with Error information.

Actual result

The server returned a '500 - whoops like something went wrong.

System information (as much as possible)

PHP Version 8.1.0 Linux devel2004.vm.netart 5.4.0-66-generic #74-Ubuntu SMP Wed Jan 27 22:54:38 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux Checked on Windows 11 Chrome Browser

Additional comments

The problem occurs right after an update from the admin panel, but also on a clean install, in general I have never had a similar situation before. I have been updating Joomla for a long time and it has been a long time since I got such an error. PHP 8.1 is not important here, because even when I switched to version PHP 8.0 the same problem occurred.

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

I check that type="usergroup" is not working in Joomla 4. There is not way to select usergroup

Expected result

But it needs to be a dropdown to select them

Actual result

Nothing works.

System information (as much as possible)

Joomla 4

Additional comments

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

If we use note type in xml, then second note is not completely full width in joomla 4

type="note" class="alert alert-success"

Expected result

But two needs to be full width

Actual result

One shows full width and second shows half width

System information (as much as possible)

Joomla 4

Additional comments

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

Install Joomla4 via upgrade from 3.10 PHP 8 or 7.4 (installing on a subdomain) Go to Global Configuration and make any change. My first experience was when I tried to change the editor to JCE. After several attempts, I tried to make and save a change (Hide Author Meta Data) to Global Configuration without any extensions (e.g., JCE, Akeeba...) and save the config file. Once the save button was pressed a login screen appeared and did not allow me to logon. I tried to change the password via PHPmyadmin, but that did not work.

Expected result

Save the file without exiting

Actual result

Logs out and cannot login. I can load extensions and work with extensions successfully, but if I touch Global Configuration after the install I lose the system

System information (as much as possible)

Joomla 4 Upgraded from 3.10 tried with both PHP 8 and then 7.4 I have it installed on a subdomain.

Additional comments

Could someone tell me how to fix this. I have been trying to figure this out for two days.