I'm effectively defining the form as $form->add('phone_number', PhoneNumberType::class, ['data' => $user->getPhoneNumber()]) with LocalUser::getPhoneNumber(): ?libphonenumber\PhoneNumber. The column is defined with type 'phone_number'. Submitting the form works and the value is inserted in the database, after which the page shows the phone number with spaces between triplets, but if I go to that page again, I get the following error:

The form's view data is expected to be a "libphonenumber\PhoneNumber", but it is a "string". You can avoid this error by setting the "data_class" option to null or by adding a view transformer that transforms "string" to an instance of "libphonenumber\PhoneNumber".

Obviously I don't want to unset the data_class, but I did try adding 'constraint' => [ new Constraints\PhoneNumber([]) ]' like suggested in #32

^{I'm not sure if using the constraint without passing something inside the array is valid, but I just want any phone number}

TODOs:

• [x] adjust github action workflow matrix to test against all supported Symfony versions
• [x] fix PhoneNumberNormalizer so it works for Symfony <6.0 and >=6.0

Getting the following error now since the last update. What's changed? This is from using the annotation assertion.

ArgumentCountError: Too few arguments to function Misd\PhoneNumberBundle\Validator\Constraints\PhoneNumberValidator::__construct(), 0 passed

I need to inject PhoneNumberValidator into my custom validator (or into my other own services). Like I can do with Symfony EmailValidator:

// services.yaml

App\Validator\Constraints\MyOwnService:
        arguments: ['@validator.email']

Can I do some trick with PhoneNumberValidator? Or we need to do some changes in the bundle first?

Hi, I send this PR to handle falsy values.

I also change the format form E164 to INTERNATIONAL. To produce "+41 44 668 18 00" instead of "+41446681800". But I can revese it.

I'm curious on why you dropped the JMS Serializer integration. I wanted to use it and unfortunately discovered it is no longer available, why I do need to use this bundle as I'm using Symfony 5.

@odolbeau Can you tell me why, and if there is no specific reason (there is none given in the commit message), are you open for returning it?

Hello,

I've started using this bundle but noticed that one of the things that came over with the fork is that the twig functions phone_number_format and phone_number_is_type are marked as deprecated since 1.2. Are they being replaced? Is there a reason for the deprecation to stick? Just wondering if there's plans to do something there or not as its not really clear why there is a deprecation notice and no replacement.

I have tried to prepare test detecting wrong phone number when creating new user with API Platform and I have the following issue.

I'm sending

{
      "phone": "123456789"
}

and this pops up

Uncaught PHP Exception Symfony\Component\Serializer\Exception\UnexpectedValueException: "Missing or invalid default region." at /var/www/html/vendor/odolbeau/phone-number-bundle/src/Serializer/Normalizer/PhoneNumberNormalizer.php line 95

I have expected set default region to be passed but it's not happening and PhoneNumberNormalizer has default ZZ.

In my User entity I've got it like that:

use Doctrine\ORM\Mapping as ORM;
use Misd\PhoneNumberBundle\Validator\Constraints\PhoneNumber as AssertPhoneNumber;
use Symfony\Component\Validator\Constraints as Assert;
use Symfony\Component\Serializer\Annotation\Groups;

class User
{
    public const PHONE_DEFAULT_REGION = 'NO';

    /**
     * @ORM\Column(type="phone_number")
     * @Assert\NotNull()
     * @AssertPhoneNumber(defaultRegion=App\Entity\User::PHONE_DEFAULT_REGION)
     * @Groups({"user.read", "user.write"})
     */
    private ?PhoneNumber $phone = null;

    public function getPhone(): ?PhoneNumber
    {
        return $this->phone;
    }

    /**
     * @param PhoneNumber|string $phone
     * @throws NumberParseException
     */
    public function setPhone($phone): void
    {
        if (is_string($phone)) {
            $phone = PhoneNumberUtil::getInstance()->parse($phone, self::PHONE_DEFAULT_REGION);
        }

        $this->phone = $phone;
    }
}

Is there anything I'm doing wrong?

If using validation by @Attribute, when it fails, the default message when there is more than one type is:

https://github.com/odolbeau/phone-number-bundle/blob/40e330c21d24903fac53aca5acb4b2ebce7a38a3/src/Validator/Constraints/PhoneNumber.php#L115

Which does not have a translated message. As I see, the default message should be "This value is not a valid phone number.".

Catalan base language code is ca. The ca_ES code is just a country-specific dialect (Catalan from Spain). Just like en, es and pt are base language codes and en_AU (English from Australia), es_419 (Spanish from LATAM) and pt_BR (Portuguese from Brazil) are dialects.

Catalan in wikipedia Common IETF primary language subtags

HI @odolbeau

I'm getting a deprecation

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/vincentlanglet/VenteUnique/v8/vendor/odolbeau/phone-number-bundle/src/Form/DataTransformer/PhoneNumberToArrayTransformer.php on line 79

This would solve the deprecation.

The parse() function "will convert letters into numbers where appropriate, and strip the others", as mentioned here https://github.com/giggsey/libphonenumber-for-php/issues/470#issuecomment-947456303.

For example, when using the default single text form type with the number +49 30 12345 abc, the validation succeeds. However it is not actually valid, but the parsing changes it to +49 30 12345222 after submitting, which is a valid number. Same for the country choice widget.

I think this should be considered a bug here.

The fix is quite simple and I applied it like this in my app. There simply needs to be an additional regex constraint for the number field to exclude all letters. This is also what giggsey recommends in the issue linked above:

If you want to ensure it's numeric before you try libphonenumber, I'd suggest using additional validation first.

Example for country choice widget:

$builder->add(
    'phoneNumber',
    PhoneNumberType::class,
    [
        'widget' => PhoneNumberType::WIDGET_COUNTRY_CHOICE,
        'number_options' => [
            'constraints' => [new Regex(pattern: '/[\p{L}]/u', message: 'The number can not contain letters.', match: false)],
        ],
    ],
);

I could not get this simple solution to work for the single text widget though, because the number is already parsed, when it gets to this additional constraint with code like this:

$builder->add(
    'phoneNumber',
    PhoneNumberType::class,
    [
        'widget' => PhoneNumberType::WIDGET_SINGLE_TEXT,
        'constraints' => [new Regex(pattern: '/[\p{L}]/u', message: 'The number can not contain letters.', match: false)],
    ],
);

invalidValue is already a PhoneNumber here, instead of string. This makes the Regex constraint fail for every input, even valid numbers without letters.

I played around with the PhoneNumberValidator, but the $value there is also already a parsed PhoneNumber. Which also probably means that everything inside https://github.com/odolbeau/phone-number-bundle/blob/master/src/Validator/Constraints/PhoneNumberValidator.php#L73 is never executed.

For some reason it is parsed multiple times, but I don't know Symfony Form/Validation well enough to understand why/when/where this happens. Must be either the Transformer or Normalizer.

Currently, the validator is able to verify the type of phone number but not the country/region.

I think it would be a nice improvement to add this feature. WDYT?

I don't know if it would work that easy, but would it be possible to add country flags into the Form?

while searching for phone number features i found this: https://intl-tel-input.com/

might that be able to work with this Symfony Bundle?

The supported templates of the bundle would need a refresh to be aligned with what the twig bridge supports. There may be nothing to do on some integration but still worth checking :

• [x] Bootstrap 4 : https://github.com/odolbeau/phone-number-bundle/pull/74
• [x] Bootstrap 5 : https://github.com/odolbeau/phone-number-bundle/pull/79
• [ ] Foundation 5
• [ ] Foundation 6
• [ ] Tailwind 2

Perhaps the serialization format for dbal should be changed to RFC-3966?

Discussion at https://github.com/misd-service-development/phone-number-bundle/issues/183