Hi there, just found out about this interesting project and am checking it out. I followed the instructions for the manual installation and I'm seeing some things that seem very wrong.
First of all, I see that the dev-master is now running Laravel 7, but you did not properly upgrade to Laravel 7 which causes the install to fail. The problem is that you've kept the old /bootstrap
directory from a previous laravel version which makes a reference to /bootstrap/autoload.php
but this was dropped in laravel 7:
- Dropped `bootstrap/autoload.php` ([#4226](https://github.com/laravel/laravel/pull/4226), [#4227](https://github.com/laravel/laravel/pull/4227), [100f71e](https://github.com/laravel/laravel/commit/100f71e71a24fd8f339a7687557b77dd872b054b))
Which causes a fatal error when trying to do a fresh install and running composer install
I replaced the /bootstrap
folder, /public/index.php
, /artisan
and part of the phpunit.xml
file from a fresh Laravel 7 install (basically every file that had a reference to the now removed bootstrap/autoload.php
file, and I was then able to install without errors
I also had to add back the /Base/
to the namespace in those 3 references inside /bootstrap/app.php
I also had to remove "@php artisan plugin:discover"
from the composer.json
as this was also causing an error since /plugins/composer/installed.json
does not exist and as a result $packages is undefined
. Not sure what this plugins system is and if it's just a dinosaur from the past or necessary
Another observation is that the files in this repository are pretty small and should only make up about 3MB. However the .git
folder that you get when you run the git clone
operation is a staggering 400MB!!! This may be a good starting point on alleviating this issue: https://stackoverflow.com/questions/5613345/how-to-shrink-the-git-folder
Furthermore the /public/js
is full of huge files, many of which appear at first glance to be identical 4.3MB single.js
.
All these files can be generated running npm run dev
or npm run build
so I don't think they should be committed/exist in this repo, and instead the command npm run dev/build
should be added to the list of instructions when installing manually
Something also feels wrong that these files are so big when the source for them inside /resources/assets
is so small, you are probably duplicating a lot of data as a result of how you're splitting up the files during the build process
I realize now that https://github.com/iluminar/goodwork/pull/964 "fixes" some of these issues.. but this "fix" was not pulled when I followed the installation instructions just now. Furthermore, the PR appears to add back autoload.php
which doesn't make sense to me since you are now using Laravel 7, you should do a proper upgrade instead of re-adding things that have been officially removed.
Hope this helps,
Kind regards