It is possible that I am not doing it right since I am new to laravel. But I have been doing almost the same thing for other packages and it has been fine.

As for this package, it kept on reading the Models/User in the LoginUrl class. I will get the error like the title mentioned above.

But when I changed the LoginUrl to use App\User(which is my user model with a different table name), it works. Url generated nicely.

So I am not sure if this is a bug or an issue or it is meant to be this way.

Thanks!

I seriously need some help guys.

Generating the link is done but now I do not have the logic to pull a model type from the already generated link.

 public function login(Request $request)
    {
        abort_if(!$request->hasValidSignature(), 401);

        $user_model = config('laravel-passwordless-login.user_model');

        Auth::guard(config('laravel-passwordless-login.user_guard'))

        //more code there
    }

We used to fetch the user from the config file but now that we are migrating to a trait it means we opened room for more than one class (model).

The big question now is How can we retrieve the current modal from the current request? given the route is coming in with just the route life span and the model id

Hi, i don´t know if i am doing something wrong, but this is my controller:

    function sendLoginLink()
    {
        $user = User::find(8);

        $generator = new LoginUrl($user);
        $generator->setRedirectUrl('/home');
        $url = $generator->generate();

        return $url;
    }

and when i test the url a got this:

Illuminate\Routing\Exceptions\UrlGenerationException Missing required parameters for [Route: magic-login] [URI: magic-login/{expires}/{uid}].

I am in laravel 7.0.8 with default user model, but with a custom table name and password field.

What could be the problem?

Thanks.

Hi there,

Big Fan of your package, thanks for your nice work in advance!!

Unfortunately the newly added guest middleware causes a new problem. I have an app that highly relies on the redirect feature of the passwordless login package. Due to the new guest middleware the redirect will not be executed when a user is already logged in because the login method of LaravelPasswordlessLoginController will never be called and as far as i understand it correct after a dive into your package the redirect logic is executed within the login method of this Controller.

The redirect only happens when being logged out and clicking on the generated link.

Whilst setting this up with Laravel 6, I wasn't able to publish the config.

When I published with this php artisan vendor:publish --tag=passwordless-login-config: Kept getting the error:

Can't locate path: <0>
Can't locate path: <1>

Had to change from this:

$this->publishes([
   __DIR__.'../config/config.php', config_path('laravel-passwordless-login.php'),
], 'passwordless-login-config');

to

$this->publishes([
    __DIR__.'/../config/config.php' => config_path('laravel-passwordless-login.php'),
], 'passwordless-login-config');

Works fine now. If you want this as a PR lemme know 👍🏼 Love your work.

• Fixed missing config() for remember parameter.
• optimized authentication

Reference: https://github.com/laravel/framework/blob/5.8/src/Illuminate/Contracts/Auth/StatefulGuard.php#L40

Overview

This PR also resolves #12 and resolves #13.

(CC @innoflash @ashleighsims)

Refactoring

Followed best practices when developing third-party Laravel libraries.

• Don't use facades
  • Use dependency injection instead
• Don't use macros
• Don't use global helper functions
• Don't call unsafe magic methods as a shorthand
• Don't use closure routing
  • Closure routes cannot be cached, ./artisan route:cache will always fail
• Don't write logic directly in helper classes
  • The core logic should be written in a manager class
• Don't pollute src directory with the testing stubs

Adding GitHub Actions CI

LGTM: https://github.com/mpyw-forks/laravel-passwordless-login/runs/492935564

Hi, is possible to implement a dynamic redirect url ?? something like this

$user = User::find(1);
$generator = new LoginUrl($user);
$redirect_url = "/home";
$url = $generator->generate($redirect_url);

Thanks.

This PR aims to fix this issue https://github.com/grosv/laravel-passwordless-login/issues/28

Usage:

// on config.php
'login_use_once'  => true,

Or on a AuthenticatableUser that uses the trait:

public function getLoginUseOnceAttribute()
{
    return true;
}

I used caching the route for the minutes given.

Hi, i was thinking that maybe should be a variable that determine if the login route should expire after the first use, something like this:

LPL_LOGIN_ROUTE_EXPIRES_AFTER_FIRST_USE=true

Then you will have two expirations settings, whatever happends first (the minutes have passed or after first use)

Thanks.

So from the current setting i see this works only for a web interface but how about we extend it to API logins as well.

For an API a user might wanna generate a token or do something on success. I am thinking of making a callback in the trait to do extra staff. That might as well fix the issue the last issue was having. Will try implement it later today and you guys evaluate

I'm having difficulty using the newish LPL_MIDDLEWARE env var.

I need to inject some middleware called firetest before every request this package deals with. I can add it via the config like this and it works fine:

<?php

use Grosv\LaravelPasswordlessLogin\HandleAuthenticatedUsers;

return [
    'user_model' => env('LPL_USER_MODEL', 'App\User'),
    // etc etc 
    'middleware' => env('LPL_MIDDLEWARE', ['firetest', 'web', HandleAuthenticatedUsers::class]),
];

How would I add it in .env?

I've tried:

LPL_MIDDLEWARE="['firetest', 'web', HandleAuthenticatedUsers::class]" #result: Target class [['firetest', 'web', HandleAuthenticatedUsers] does not exist
LPL_MIDDLEWARE="['firetest', 'web', Grosv\LaravelPasswordlessLogin\HandleAuthenticatedUsers\HandleAuthenticatedUsers::class]" #result: White screen no visible errors.
LPL_MIDDLEWARE="['firetest', 'web', Grosv\LaravelPasswordlessLogin\HandleAuthenticatedUsers\HandleAuthenticatedUsers]" #result: White screen no visible errors.
LPL_MIDDLEWARE="['firetest', 'web']" #result: Target class [['firetest', 'web']] does not exist.
LPL_MIDDLEWARE="\['firetest', 'web'\]" #result: Target class [['firetest', 'web']] does not exist.

I'm thinking there's no way to define an array in .env without having it exploded or something to turn it into an array when it's retrieved, so is the LPL_MIDDLEWARE actually usable? I suppose if one only want's to define a single middleware it is. Any thoughts please?

So I have a use case my side. I am adding a payment Gateway and they are posting data to the URL specified.

Do you think we can make the package handle POST calls as well?

There is useful data incoming from the other server.

I did a setup as mentioned in the readme, it works fine on local, but when i deploy on production, it gives a 401 Unauthorised error on

/magic-url/1?expires=1661899121&redirect_to=portal&user_type=app-models-user&signature=xxx

I think using automatic injection in the constructor instead of global helper functions improves this package. https://laravel.com/docs/9.x/container#automatic-injection

@grosv What do you think?