Hey

I am used Froala Editor with Sonata Admin

$formMapper->add('content', 'froala');

And I have this exception :

Impossible to access an attribute ("options") on a null variable in SonataAdminBundle:Form:form_admin_fields.html.twig at line 326

Hello !

When trying to upload a file, the routes for file management seems to be broken. Here is the error message :

The "kms_froala_editor.media_manager" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

The "kms_froala_editor.media_manager" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

  at vendor\symfony\dependency-injection\Container.php:259
  at Symfony\Component\DependencyInjection\Container->get('kms_froala_editor.media_manager')
     (vendor\symfony\framework-bundle\Controller\ControllerTrait.php:61)
  at Symfony\Bundle\FrameworkBundle\Controller\Controller->get('kms_froala_editor.media_manager')
     (vendor\kms\froala-editor-bundle\Controller\MediaController.php:28)
  at KMS\FroalaEditorBundle\Controller\MediaController->uploadImageAction(object(Request))
     (vendor\symfony\http-kernel\HttpKernel.php:149)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
     (vendor\symfony\http-kernel\HttpKernel.php:66)
  at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
     (vendor\symfony\http-kernel\Kernel.php:190)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (public\index.php:37)```

I'm using Symfony 4.0

Thank you for you help !

I have installed and configured it as given in the instructions, but while adding it to the form as given below, it says Could not load type "froala"

$builder->add( "yourField", "froala" );

Can you specifically tell how to add it in form in Symfony 3, because Symfony 3 requires Type and Class to be included and declared, explicitly like below mentioned example:-

Type:- use Symfony\Component\Form\Extension\Core\Type\TextType;

and Class- builder->add('title', TextType::class)

Do we include it from any namespace, as above? Thanks..

Hi,

Following the v3.0.0 upgrade, I did some changes that I wanted to do for a long time.

I couldn't split it into several PRs, but I could try if needed.

Here are the main changes:

• Symfony 4.3+ support only. I could try to make it compatible with 3.4+ (so 4.0+) if needed
• PHP 7.1+; stop supporting unsupported PHP versions
• Added a command to download the editor instead of putting files in the repository; then the bundle won't need an upgrade for a simple editor upgrade (excluding new options): bin/console froala:install
• Fixed most deprecations for Symfony 4.1+ (routing, container injection in controller, doctrine inflector...)
• The form widget layout is no longer loaded using DI; it will be added to configuration using the flex recipe (see https://github.com/symfony/recipes-contrib/pull/686)

The README.md file still needs an upgrade, but before doing it I'd like to get your feedback about this PR and know, if it's accepted, how tags/branches will be handled so I could redirect people to the right docs.

Thanks!

This will show how this fix will be done.

There is a discrepancy with coding standard since my computer is set up for Symfony CS and the repository is now following it (big one is tab -> space).

I have test it (without any configured) and it's working so far.

Hi,

I'm wondering if Symfony 2 support should be dropped or not, as maintaining it becomes harder and harder - especially if support is for 2.3+.

Eg. Symfony 4.1 throws deprecations for the routing controller format - should be KMS\FroalaEditorBundle\Controller\MediaController::uploadImageAction instead of KMSFroalaEditorBundle:Media:uploadImage.
If I'm not wrong, this notation is available for 2.8 but not 2.3, so the fix would be hard to apply.

WDYT?

In Symfony4 editor is not working:

An exception has been thrown during the rendering of a template ("The "templating.helper.assets" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.").

{{ froala_display(form.content) }}

Hi! I've followed all the steps described in readme but when I try to use the form type it throws:

Notice: Undefined index: basePath in /vendor/kms/froala-editor-bundle/Service/OptionManager.php line 68

I've already defined a basePath in config but didn't worked.

Hi,

Sending a big PR :)

Here's what's been done:

• Escape form options/variables with "froala_" namespace (cherry-picked from @mpoiriert commit)
• Support for ajax loading (cherry-picked from @mpoiriert commit)
• Add options related to FontAwesome third party plugin
• Add parameter types & return types everywhere possible
• Fix Twig extension
• Change directory structure
• Exclude some files & directories for releases
• Fix plugins' CSS not loaded correctly
• Don't load packaged Froala JS/CSS files as they contain all plugins
• Setup php-cs-fixer for Github Actions
• Setup phpstan for Github Actions
• README update

After merging this PR, it will require a major version bump (to 4.0.0) as it introduces huge BC breaks, eg. form type option prefixes and added parameter/return types.

Even if it's not really easy, could you please review the PR before merging it?

Thank you!

Hi, When i want upload an image in froala editor i have this error :

Error log :

My code :

JS

$('.froala-editor').froalaEditor({
    toolbarButtons: ['fullscreen', 'undo', 'redo', '|',
        'bold', 'italic', 'underline', '|',
        'fontFamily', 'fontSize', 'color', 'emoticons', 'insertHR', 'clearFormatting', '|',
        'paragraphFormat', 'paragraphStyle', 'quote', 'align', 'formatOL', 'formatUL', 'outdent', 'indent', '|',
        'insertLink', 'insertImage', 'insertVideo', 'insertTable', '|',
        'html', 'help'
    ],

    saveURL: Routing.generate('admin_upload_image'),

    // Set the image upload URL.
    imageUploadURL: Routing.generate('admin_upload_image'),

    // Additional upload params.
    imageUploadParams: {id: 'my_editor'},

    // Set request type.
    imageUploadMethod: 'POST',

    // Set max image size to 5MB.
    imageMaxSize: 5 * 1024 * 1024,

    // Allow to upload PNG and JPG.
    imageAllowedTypes: ['jpeg', 'jpg', 'png']

}).on('froalaEditor.image.beforeUpload', function (e, editor, images) {
    // Return false if you want to stop the image upload.
    })
    .on('froalaEditor.image.uploaded', function (e, editor, response) {
        // Image was uploaded to the server.

        console.log(uploadUrl, uploadParam, uploadParams);
        console.log('Image uploaded');
        console.log(e);
        console.log(editor);
        console.log(response);
    })
    .on('froalaEditor.image.inserted', function (e, editor, $img, response) {
        // Image was inserted in the editor.
        console.log('Image inserted');
        console.log(e);
        console.log(editor);
        console.log($img);
        console.log(response);
    })
    .on('froalaEditor.image.replaced', function (e, editor, $img, response) {
        // Image was replaced in the editor.
    })
    .on('froalaEditor.image.error', function (e, editor, error, response) {
        console.log('Image error');
        console.log(e);
        console.log(editor);
        console.log(error);
        console.log(response);
    })
;

Upload function:

 /**
     * @Route("/uploadImage", name="admin_upload_image", options={"expose": true})
     * @Method({"GET", "POST"})
     * @param Request $request
     * @return JsonResponse
     */
    public function uploadImageAction(Request $request)
    {
        $mediaManager = $this->get("kms_froala_editor.media_manager");
        $path         = $request->request->get("path");
        $folder       = $request->request->get("folder") . '/upload';
        $rootDir      = $this->get("kernel")->getRootDir();
        $basePath     = $request->getBasePath() . '/upload';

        return $mediaManager->uploadImage($request->files, $rootDir, $basePath, $folder, $path);

    }

What could be the problem?

Hi, this package hasn't enabled auto-update inside Packagist so, the last merged PR is not referenced yet. Can you update the reference and by the way, can you tag a stable version?

Thanks in advance.

Hello,

I wonder if there is not a bug when using the customJS parameter

In the file "src / Resources / views / Form / froala_widget.html.twig" line 51

Shouldn't we use the "froala_customJS" variable?

Regards

Hi,

I'm wondering why version 4.0.0 has been tagged with this change? https://github.com/froala/KMSFroalaEditorBundle/commit/7e6856fcaf2b14933ad66e49a6e62562bd7e735e

The version number in the command is only an example, not the real value which will be pulled.

Can this tag/release be reverted please? And removed from packagist as well?

I think about to use this bundle for my projects. BUT - I wonder if there will be multiple includes of this css and js files:

 {# CSS. #}
    {% if froala_includeFontAwesome %}
        <link rel="stylesheet" type="text/css" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" />
    {% endif %}
    {% if froala_includeCodeMirror %}
        <link rel="stylesheet" type="text/css" href="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.3.0/codemirror.min.css" />
    {% endif %}

    {% if froala_includeCSS %}
        <link rel="stylesheet" type="text/css" href="{{ asset( froala_basePath ~ 'css/froala_editor.min.css' ) }}" />
        <link rel="stylesheet" type="text/css" href="{{ asset( froala_basePath ~ 'css/froala_style.min.css' ) }}" />

        {% if froala_arrOption[ "theme" ] is defined %}
            <link rel="stylesheet" type="text/css" href="{{ asset( froala_basePath ~ 'css/themes/' ~ froala_arrOption[ "theme" ] ~ '.min.css' ) }}" />
        {% endif %}

        {% for plugin in froala_arrPluginCSS %}
            <link rel="stylesheet" type="text/css" href="{{ asset( froala_basePath ~ 'css/' ~ plugin ~ '.min.css' ) }}" />
        {% endfor %}

    {% endif %}

    {# Editor textarea. #}
    <textarea {{ block( "widget_attributes" ) }}>{{ value }}</textarea>

    {# JS. #}

    {% if froala_includeCodeMirror %}
        <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.3.0/codemirror.min.js"></script>
        <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.3.0/mode/xml/xml.min.js"></script>
    {% endif %}

    {% if froala_includeJS %}
        <script type="text/javascript"  src="{{ asset( "bundles/kmsfroalaeditor/misc.js" ) }}"></script>
        <script type="text/javascript"  src="{{ asset( froala_basePath ~ 'js/froala_editor.min.js' ) }}"></script>

        <!--[if lt IE 9]>
		<script type="text/javascript" src="{{ asset( froala_basePath ~ 'js/froala_editor_ie8.min.js' ) }}"></script>
		<![endif]-->
        <script type="text/javascript" src="{{ asset( froala_basePath ~ 'js/languages/' ~ froala_arrOption.language ~ '.js' ) }}"></script>

        {% for plugin in froala_arrPluginJS %}
            <script type="text/javascript" src="{{ asset( froala_basePath ~ 'js/' ~ plugin ~ '.min.js' ) }}"></script>
        {% endfor %}
    {% endif %}

    {% if froala_customJS is defined %}
        <script type="text/javascript"  src="{{ asset( customJS ) }}"></script>
    {% endif %}

I mean - this will be included for every form field, when I have multiple on my pages?

Is that right?

Hello guys, When I click on getPdf button this seems to do nothing, I enabled all plugins especially the print plugin but it does nothing.

This is the same for spellChecker I have a js error Your subscription to the service has expired. Contact [email protected] to learn how to resume your subscription.

Do I have to buy Froala to get this working?

Hello,

On a symfony 3.4 with KMS Froala 2.9.8 i'm tring to use Twig : https://codemirror.net/mode/twig/index.html

$builder->add('twigContent', FroalaEditorType::class, array('codeMirrorOptions' => array(
                'indentWithTabs' => true,
                'lineNumbers' => true,
                'lineWrapping' => true,
                'mode'=> array('name' => "twig", 'base' => "text/html"),
                'tabMode' => 'indent',
                'tabSize' => 2
            )
            , 'label' => 'Contenu', 'attr' => array('class' => 'froalaMailTransTemplate', 'id' => 'froalaMailTransTemplate'), 'required' => false))

if i remove the code 'mode'=> array('name' => "twig", 'base' => "text/html") it's working i have HTML but no "twig" markup

What did i miss ?

thanks

Guldil