Hi,

During XDEBUG session I've noticed that param isAsyncRequest is set to false in TheIconic\Tracking\GoogleAnalytics\Analytics instance. I have to set $analytics->setAsyncRequest(true), to set the param to true.

My config.yml:

four_labs_gamp:
    protocol_version: 1
    tracking_id: "%google.analytics.tracking.id%"
    use_ssl: true
    anonymize_ip: false
    async_requests: true
    sandbox: %google.analytics.is.sandbox%

Also I noticed that async_requests prop is defaulted to true in FourLabs\GampBundle\DependencyInjection\Configuration::getConfigTreeBuilder() and I tried to remove is from my config, but the isAsyncRequest remained false. I think it must be something wrong with the setter.

Hi

Is it possible to send google analitics request for EventGa just to log website entry to statistics? Code below does not work:

$this->get('gamp.analytics')
->setEventCategory('test')
->setEventAction('test')
->setEventLabel('test')
->sendEvent()

Best Regards

Add a backward compatible fix for the deprecation warning "A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0." (discussed in https://symfony.com/blog/new-in-symfony-4-2-important-deprecations#deprecated-tree-builders-without-root-nodes)

This is a fix for issue #23

$this->get('gamp.analytics')
            ->setEventCategory('authorization')
            ->setEventAction('Authorization')
           ->setDocumentLocationUrl('/')
            ->sendEvent();

this is a dump of the request

{
hitParsingResult: [
{
valid: true,
parserMessage: [
{
messageType: "INFO",
description: "IP Address from this hit was anonymized to 46.30.167.0.",
messageCode: "VALUE_MODIFIED"
}
],
hit: "/debug/collect?v=1&tid=UA-109724385-2&aip=0&uip=127.0.0.1&ua=Mozilla%2F5.0%20%28X11%3B%20Linux%20x86_64%29%20AppleWebKit%2F537.36%20%28KHTML%2C%20like%20Gecko%29%20Chrome%2F70.0.3538.110%20Safari%2F537.36&cid=103528305.1546594228&ec=authorization&ea=Authorization&dl=%2F&t=event?_anon_uip=127.0.0.0"
}
],
parserMessage: [
{
messageType: "INFO",
description: "Found 1 hit in the request."
}
]
}

but nothing appear in dashboard

Hi @fourlabsldn

Thanks to the work in pull request #16 of @emmanuelballery the bundle was nearly compatible with Symfony4. Some required fixes would be added with this pull request,

Cheers Felix

Hi!

I updated the AnalyticsFactory to be able to inject it in my services/create multiple analytics without requiring the entire container and calling $container->get('gamp.analytics') each time. This way, I can simply create multiple Analytics like this :

use FourLabs\GampBundle\Service\AnalyticsFactory;

class Stats
{
    /** @var AnalyticsFactory */
    private $analyticsFactory;

    public function __construct(AnalyticsFactory $analyticsFactory)
    {
        $this->analyticsFactory = $analyticsFactory;
    }

    public function doSomething()
    {
        $analytics1 = $this->analyticsFactory->createAnalytics();
        // ...
        $analytics2 = $this->analyticsFactory->createAnalytics();
        // ...
    }
}

Could you take a look and tell me what you think.

Thanks!

Injecting this service into another service causes the createAnalytics() method to be called, which accesses the request stack to get the User-Agent header. In the case this is not set (which often happens with requests from bots or 3rd party API callbacks) an exception is thrown. Since this happens when the services are instantiated, it's hard to handle gracefully.

Passing an empty string to the setUserAgentOverride() method does not throw an exception, only a null value does. Since the user-agent isn't required by the GAMP API anyway, it seems this method should not be called in the constructor or gracefully handle a null value.

Hello, I create a fork of your bundle and I manage to handle properly the cookie issue #1 and the take into account Guzzle 5 dependencies #2

You can find in my fork repository 2 tags (1.1.0 and 2.0.0):

• 1.1.0 is for "theiconic/php-ga-measurement-protocol": "^1.1" with Guzzle 5
• 2.0.0 is for "theiconic/php-ga-measurement-protocol": "^2.0" with Guzzle 6

Thank you in advance for the merge!

If you have any question don't hesitate!

Hello,

I have a dependencies issue with GampBundle. In my project I already have dependencies which requires guzzlehttp/guzzle 5.x. But here we are, GampBundle (great bundle!) require "theiconic/php-ga-measurement-protocol": "^2.0"which require guzzlehttp/guzzle 6

It would be really nice if you could made two versions of GampBundle:

• One which require "theiconic/php-ga-measurement-protocol": "^1.1" for Guzzle 5
• and another which require "theiconic/php-ga-measurement-protocol": "^2.0" for Guzzle 6

Doc here

I am really stuck and I prefer use the main repository of the project whereas using a fork. I think it can be usefull for everyone!

Thanks in advance.

Regards,

Titouan

Per https://symfony.com/blog/new-in-symfony-4-2-important-deprecations#deprecated-tree-builders-without-root-nodes, the way to generate a TreeBuilder and get the root node has changed.

Hey, friends. Looks like somebody has posted a PR with a reasonable 'update' for Symfony 6 support, since all the underlying code is compliant with PHP 8.

Any chance you could merge this in and issue a new release to make migration a bit easier for folks using this library still?

Thanks!

Hi

I just installed GampBundle 2.0 in a Symfony 2.7 project.

I'm getting this exception:

Removing the shared attribute in fourlabs/gamp-bundle/Resources/config/services.xml on line 21 fixes the problem. However, I don't know if it may have other consequences:

Hi,

I noticed I had a lot of log entries with the following message : Uncaught PHP Exception InvalidArgumentException: "For Analytics object, you must specify a value to be set for setClientId"

Also, after looking for a while in my code, I found that there was an error in the AnalyticsFactory class on line 25. ->setClientId($request->cookies->get('_ga', null))

Based on the Google Analytics Measurement Protocol library for PHP the **setClientId _method need a value and cannot receive a _null.

Am I right and does anybody also had this problem ? Thanks for your advice.