Everything was working fine until today. Now I'm getting this error Undefined offset: 1 and error is pointed to this line of code list($controller,$method)=explode("@",$match['target']);

Here is the whole code from index.php :

<?php
     include(__DIR__.'/../bootstrap/start.php');
Dotenv::load(__DIR__."/../"); 
include(__DIR__.'/../bootstrap/db.php');
include(__DIR__."/../routes.php");

 $match=$router->match();

 list($controller,$method)=explode("@",$match['target']);

 if(is_callable(array($controller,$method))){
        $object=new $controller();
        call_user_func_array(array($object,$method), array($match['params']));
 }else{

    echo "Can not find $controller->$method";
    exit();
 }

Hello i want to match this url

http://localhost/en_US

the map is $router->map('GET', '/[a:lang]/?', '', 'language');

the country code regex is [A-Za-z]{2}_[A-Za-z]{2}

it is possible to work this?

Hi,

Is possible add external file (example .ini file) with all routes, something like:

[routes] home="GET|POST /home home#index" users="GET /users users#index"

then when we create new instance we can:

$router = new AltoRouter('routes.ini');

$match = $router->match();

Thanks!!

Hi, it's me again. Trying to upload a file with a form like this:

<form action='/admin/' method='post' enctype='multipart/form-data'>
	<input type='file' name='file' id='file'/>
	<input type='submit' value='upload'> 	
</form>
```
i have such path written 
$router->map('POST','/admin/', 'class/admin.php', 'edited');
but when i try to catch the file with this code
if($_POST){
			print_r($_FILES);
	}
nothing happens
Thx

hi there, just played a bit with AltoRouter and figured out that it leaves out to me to actually call the matched controller#action and pass the appropriate vars but i am not sure i implemented this correctly. it surely works but thought of making sure i am on the correct route :) you might want to include this in an example if this is the correct way of doing this to help others

$router = new AltoRouter();
$router->setBasePath('/demosite4.com'); 
$router->map('GET','/', 'home_controller#display_item', 'home');
$router->map('GET','/content/[:parent]/?[:child]?', 'content_controller#display_item', 'content');
$match = $router->match();

// not sure if code after this comment  is the best way to handle matched routes
list( $controller, $action ) = explode( '#', $match['target'] );
if ( is_callable(array($controller, $action)) ) {
    $obj = new $controller();
    call_user_func_array(array($obj,$action), array($match['params']));
} else if ($match['target']==''){
    echo 'Error: no route was matched'; 
    //possibly throw a 404 error
} else {
    echo 'Error: can not call '.$controller.'#'.$action; 
    //possibly throw a 404 error
}


// content_controller class file is autoloaded 
 <?php
class content_controller {
    public function display_item($args) {
        //echo our params to to make sure we got them
        echo 'parent: '. $args['parent'];
        echo 'child: '. $args['child'];
    }
?>

Hello, i have successfully implementing simple one query: $router->map('GET|POST', '/login/', 'module/user/login.php', 'login'); turn into : http://mydomain/login/

but when I have 2 GET parameters it not successfully passed, error said: Catchable fatal error: Object of class Closure could not be converted

my map: $router->map( 'GET', '/email/[*:getemail]/key/[*:getkey]/', 'module/user/activate.php', 'activate');

activate.php:

$email = filter_var($_GET["email"], FILTER_SANITIZE_EMAIL);
$key = htmlspecialchars($_GET["key"]);
$getemail = $match['params'][$email];
$getkey = $match['params'][$key];

// and more... code for validation

my expectation is: http://mydomain/email/user@email/key/user_key/

Thank you for your help.

Hello, I have a problem with Altorouter. I established routes and attached my views. In my views, I have images but they do not display because when the image tries to load, my index.php (where there are routes, the match() method, etc.) tries to match the url of the image to a mapped route...

There is possibility to make an exception for images / js scripts?

I hope you can help me :)

Thank you!

To speed up route matching it might make sense to move to a Radix tree-ish approach. While a full blown Radix tree is probably not suited for PHP unless we write to a file somewhere, a quick & easy win might be to split up the AltoRouter::$routes array into separate keys for each HTTP method.

This way, we do not have to loop through routes and compare the HTTP method which should slightly speed up the match process, especially for non-existing routes or routes other than the most commonly used GET.

Cons

• getRoutes() currently exposes the internal routes array, so this would most likely mean a BC break. Not sure if that's even worth the potential gain.
• AltoRouter accepts multiple HTTP methods, which means possibly storing a route more than once. We already do this for the $namedRoutes array though and PHP uses copy-on-write, so this should not be an issue really.

I have the following structure:

. project .. src .... controllers .... models .... views ...... layouts .. public .... js .... css

Everytime i try to load a css or js, it matches them routes and redirect to my 404 file... can i ignore the public path on routes??

1. example to process matched route by calling controller->method and passing params as a named array so params can be accessed by their name inside the method we called
2. example to load routes from an external yaml file

These were tested to be workign on a local setup

Signed-off-by: Paris Paraskeva [email protected]

When creating a URL request, it doesn't take your complete URL as the request. It gets matches from the URL in the order that they are mapped.

For example, if i have /login/ mapped to login.php and /home/ mapped to home.php (in that order), so: site.com/login/ shows login.php site.com/home/ shows home.php site.com/home/login/ shows login.php (since it's mapped first) site.com/gibberish/randomstuff/home shows home.php (even though gibberish and randomstuff isn't mapped at all, so it should throw an error.) but then: site.com/gibberish/randomstuff/login/home will show login.php (because its mapped first, even though home was the last one on the URL)

Just wanting to work out a way to fix this problem

Thanks!!

Hello,

i just found out about your router and how do you deal with the router with forum paging as i get the id get answers from the topic and i don't understand this is redirecting me to another topic

thank you

my route

$router->map('GET|POST', '/forum/viewtopic-[*:slug]-[i:id]', 'viewtopic','viewtopic'); //no paging
$router->map('GET|POST', '/forum/viewtopic-page-[*:slug]-[i:id]-[i:paginat]', 'viewtopic','viewtopic-page');

the route is not decomposed with the parameters

normally i should have this

titre-de-mon-topic-edite slug 1 id 3 page viewtopic-page name

but i am getting this

page-titre-de-mon-topic-edite-1 slug

array (size=3)
  'target' => string 'viewtopic' (length=9)
  'params' => 
    array (size=2)
      'slug' => string 'page-titre-de-mon-topic-edite-1' (length=31) 
      'id' => string '2' (length=1)
  'name' => string 'viewtopic' (length=9) 

translated by Google !

Hello,

I would create multilingual routes but I don't know how.

There is the flag [:lang] but then we are forced to have untranslated routes

domain.tld/en/my-home-page
domain.tld/fr/my-home-page

I would like to have :

domain.tld/en/my-home-page
domain.tld/fr/ma-page-d-accueil

How do I do it? create several similar routes?

->get('/en/my-home-page', 'home', 'home-en')
->get('/fr/ma-page-d-accueil', 'home', 'home-fr')

Thank you

It would be cool if on ->generate() params which was not used are added to as query string

public function generate($routeName, array $params = array()) {
	
	// Check if named route exists
	if(!isset($this->namedRoutes[$routeName])) {
		throw new \Exception("Route '{$routeName}' does not exist.");
	}
	
	// Replace named parameters
	$route = $this->namedRoutes[$routeName];
	
	// prepend base path to route url again
	$url = $this->basePath . $route;
	
	if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
		
		foreach($matches as $match) {
			list($block, $pre, $type, $param, $optional) = $match;
			
			if ($pre) {
				$block = substr($block, 1);
			}
			
			if(isset($params[$param])) {
				$url = str_replace($block, $params[$param], $url);
				unset($params[$param]);//set param as used
			} elseif ($optional) {
				$url = str_replace($pre . $block, '', $url);
			}
		}
	}
	
	if (count($params) > 0) //check is any params left to build url with
	{
		$url .= '?'.http_build_query($params);
	}
	
	return $url;
}

then

$alto->map( 'GET|POST', '/users/[i:id]/','handleContactForm');
$alto->generate('handleContactForm',['id'=>10,'myCustomParam'=>'blaah']);
// will outputs /users/10?myCustomParam=blaah

Hello OS: windows

i put my website in htdocs root directory. when i do this code it cannot load index.php from views directory without any error.

include ('router/AltoRouter.php');
$router = new AltoRouter();
$router->map( 'GET', '/', function() {
   require (__DIR__ . '/views/index.php');
},"home");

project structure:

• router : alto files
• views
  • index.php
• .htaccess => rewite works (i checked)
• index.php => rewite works (i checked)

urls i checked:

• http://127.0.0.1
• http://127.0.0.1/

also

• i added echo 'done' to $router->map but nothing happened
• i followed getting started articles.

Hello.

Can you give an example code of a controller that accepts parameter?

For instance an ArticleController that has 3 functions: getArticle($id) and updateArticle($id, $newTitle)