No duplicates 🥲.

• [X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

Ubuntu 22.04 LTS Testing and Wampserver 3.2.9 Testing Above error common to both Windows and Ubuntu Apache2 using fork rossaddison/yii-invoice. Event: A new product, not used in any quote, or invoice, when tax_rate_id BelongsTo dropdown edited and saved. Also if the product's family group BelongsTo relation changes, and is saved, same error occurs.

This error occurs when the record is edited, not created.

This error did not occur when I was using annotations instead of the current Atributes. This issue is similar to issue #329

Here is the entity that is being used:

<?php

declare(strict_types=1);

namespace App\Invoice\Entity;

use Cycle\Annotated\Annotation\Column;
use Cycle\Annotated\Annotation\Entity;
use App\Invoice\Entity\Family;
use App\Invoice\Entity\TaxRate;
use App\Invoice\Entity\Unit;
use Cycle\Annotated\Annotation\Relation\BelongsTo;

#[Entity(repository: \App\Invoice\Product\ProductRepository::class)]
class Product
{
    #[Column(type: 'primary')]
    private ?int $id = null;
        
    #[Column(type: 'text', nullable: true)]
    private ?string $product_sku = '';
    
    #[Column(type: 'text', nullable: true)]
    private ?string $product_name = '';
    
    #[Column(type: 'longText', nullable: false)]
    private ?string $product_description = '';
        
    #[Column(type: 'decimal(20,2)', nullable: true)]
    private ?float $product_price = null;
    
    #[Column(type: 'decimal(20,2)', nullable: true)]
    private ?float $purchase_price = null;
    
    #[Column(type: 'text', nullable: true)]
    private ?string $provider_name = '';
    
    #[BelongsTo(target:Family::class, nullable: false, fkAction: "NO ACTION")]
    private ?Family $family = null;        
    #[Column(type: 'integer(11)', nullable: true)]
    private ?int $family_id = null;
    
    // A product has to have a tax rate before it can be created even if it is a zero tax rate    
    #[BelongsTo(target:TaxRate::class, nullable: false, fkAction: "NO ACTION")]
    private ?TaxRate $tax_rate = null;    
    #[Column(type: 'integer(11)', nullable: false)]
    private ?int $tax_rate_id = null;
        
    #[BelongsTo(target:Unit::class, nullable: false, fkAction: "NO ACTION")]
    private ?Unit $unit = null;    
    #[Column(type: 'integer(11)', nullable: true)]
    private ?int $unit_id = null;
    
    #[Column(type: 'integer(11)', nullable: true)]
    private ?int $product_tariff = null;
    
    public function __construct(
        string $product_sku = '',
        string $product_name = '',
        string $product_description = '',
        float $product_price = null,
        float $purchase_price = null,
        string $provider_name = '',
        int $product_tariff = null,
        int $tax_rate_id = null,
        int $family_id = null,
        int $unit_id = null            
    )
    {
        $this->product_sku = $product_sku;  
        $this->product_name = $product_name;
        $this->product_description = $product_description;
        $this->product_price = $product_price;
        $this->purchase_price = $purchase_price;
        $this->provider_name = $provider_name;
        $this->product_tariff = $product_tariff;
        $this->tax_rate_id = $tax_rate_id;
        $this->family_id = $family_id;
        $this->unit_id = $unit_id;
    }
    //relation $family
    public function getFamily(): ?Family
    {
        return $this->family;
    }
    //relation $tax_rate
    public function getTaxrate(): ?TaxRate
    {
        return $this->tax_rate;
    }
    //relation $unit
    public function getUnit(): ?Unit
    {
        return $this->unit;
    }    
    
    public function getProduct_id(): ?string
    {
        return (string)$this->id;
    }
    
    public function setFamily_id(int $family_id): void
    {
        $this->family_id = $family_id;
    }
    
    public function getProduct_sku(): string
    {
        return $this->product_sku;
    }
    
    public function setProduct_sku(string $product_sku): void
    {
        $this->product_sku = $product_sku;
    }
    
    public function getProduct_name(): string
    {
        return $this->product_name;
    }
    
    public function setProduct_name(string $product_name): void
    {
        $this->product_name = $product_name;
    }
    
    public function getProduct_description(): string
    {
        return $this->product_description;
    }
    
    public function setProduct_description(string $product_description): void
    {
        $this->product_description = $product_description;
    }

    public function getProduct_price(): float
    {
        return $this->product_price;
    }
    
    public function setProduct_price(float $product_price): void
    {
        $this->product_price = $product_price;
    }
    
    public function getPurchase_price(): float
    {
        return $this->purchase_price;
    }
    
    public function setPurchase_price(float $purchase_price): void
    {
        $this->purchase_price = $purchase_price;
    }
    
    public function getProvider_name(): string
    {
        return $this->provider_name;
    }
    
    public function setProvider_name(string $provider_name): void
    {
        $this->provider_name = $provider_name;
    }

    public function setTax_rate_id(int $tax_rate_id): void
    {
        $this->tax_rate_id = $tax_rate_id;
    }

    public function getTax_rate_id(): ?int
    {
        return $this->tax_rate_id;
    }

    public function setUnit_id(int $unit_id): void
    {
        $this->unit_id = $unit_id;
    }

    public function getUnit_id(): ?int
    {
        return $this->unit_id;
    }

    public function getFamily_id(): ?int
    {
        return $this->family_id;
    }
    
    public function getProduct_tariff(): int
    {
        return $this->product_tariff;
    }

    public function setProduct_tariff(int $product_tariff): void
    {
        $this->product_tariff = $product_tariff;
    }
}

Version

ORM 2.0.0 
Ubuntu PHP 8.1.2, Wampserver PHP 8.1.7

Try to add php 7.4 property typing to any of the Entity examples from docs and persist it with db, you will get that exception.

For the reference see also doctrine issue and corresponding PR. As far as I see the issue is partially resolved, see this one.

Not sure whether the issue in Doctrine was only for id (i.e. primary keys), but here we have the issue for any typed field in Entity.

Всем привет!

Есть две сущности, одна наследует другую (STI), в этих сущностях используются типизированные свойства и в relation явно указывается на что ссылается Relation

class User {
    /** @ORM\Relation\BelongsTo(target="Studio", nullable=true)*/
    protected ?Studio $studio = null;

    // ...
} 

class Studio extends User {
    // ...
} 

И в этой ситуации наш код перестает работать, т.к. до полной загрузки связанной сущности мы работаем с другим объектом Reference Окей, думаем как исправить это, можно пойти по пути использования своей PromiseFactory, подключаем и ..., это нам также ничем не поможет, т.к. метод promise выгляит так:

public function promise(ORMInterface $orm, string $role, array $scope)

И мы можем узнать только то, что нам пришла роль user и ee scope также не содержит подсказки с чем имеем дело.

Вообще идея у меня была следующая, зная target можно было бы создать пустую сущность и предзаполнить все поля из scope, что помогло бы получить объект нужного типа. Т.е. фабрика нам позволяет поменять Reference на что-то своё, но полного контроля не дает.

Окей, думаем дальше. У вас есть пакет cycle/proxy-factory , он также не сможет создать правильный объект, т.к. он не знает что он имеет дело с STI, создаст просто User и код сломается.

Я вижу два пути выхода из положения

1. Передавать каким либо образом текущий Relation и корректный target в нем, чтобы понимать что ожидается
2. Давать возможность в анотации или схеме указывать класс, который мы ожидаем на выходе.

P.S. final class это реально зло! Чтобы немного доработать сущестующий код, мне приходится целые классы тащить за собой, вместо переопределения одного метода.

What happened?

I have two entities User and Tag related with the ManyToMany relation

If the ManyToMany relation is specified in both entities, then an error will be thrown with the message Transaction can't be finished. Some relations can't be resolved

To reproduce that case you can use the Cycle\ORM\Tests\Functional\Driver\Common\Relation\ManyToMany\ManyToManyRelationTest test case and add the ManyToMany relation for the Tag::class (in the getSchemaArray() method) as below:

         Tag::class => [
                ...
                Schema::RELATIONS => [
                    'users' => [
                        Relation::TYPE => Relation::MANY_TO_MANY,
                        Relation::TARGET => User::class,
                        Relation::SCHEMA => [
                            Relation::CASCADE => true,
                            Relation::THROUGH_ENTITY => TagContext::class,
                            Relation::INNER_KEY => 'id',
                            Relation::OUTER_KEY => 'id',
                            Relation::THROUGH_INNER_KEY => 'tag_id',
                            Relation::THROUGH_OUTER_KEY => 'user_id',
                        ],
                    ],
                ],
            ],

After testUnlinkManyToManyAndReplaceSome() calling you will see that error:

Cycle\ORM\Exception\TransactionException : Transaction can't be finished. Some relations can't be resolved:
Create new `tag_context`
 - tag.users:tag_context (Cycle\ORM\Relation\ShadowBelongsTo)
 /app/vendor/cycle/orm/src/Exception/TransactionException.php:40
 /app/vendor/cycle/orm/src/Transaction/UnitOfWork.php:104
 /app/vendor/cycle/orm/src/Transaction.php:48
 /app/app/src/Example/Functional/Driver/Common/BaseTest.php:248
 /app/app/src/Example/Functional/Driver/Common/Relation/ManyToMany/ManyToManyRelationTest.php:403

Version

ORM 2.0.0
PHP 8.0

Closes #65

• Replace "constrain" with "scope" all over the code base
• Add BC aliases with deprecation replacement suggestion (need to ignore cs warning on alias files)

Is there any opportunities for filtering columns rather than select()->buildQuery()->columns()?

I make some investigation and found that this behaviour can be implemented via implementation of LoaderInterface and so on.

Am I right or in this library exists other way to do what I want?

I want this behaviour:

class TestModel
{
    /** @Column(type="string")*/
    public $field1;
    /** @Column(type="string")*/
    public $field2;
    /** @Column(type="string")*/
    public $field3;
    
    public function __construct($field1, $field2, $field3)
    {
        $this->field1 = $field1;
        $this->field2 = $field2;
        $this->field3 = $field3;
    }
}

class TestCase
{
     public function testSelectFields()
     {
        $t = new Transaction($orm)->persist((new TestModel('1', '2', '3')))
        $t->run();
        $result = $orm->getRepository(TestModel::class)->select()->columns(['field1', 'field2'])->fetchOne();

        $this->assertEquals('1', $result->field1);
        $this->assertEquals('2', $result->field2);
        $this->assertNull($result->field3);
     }
}

В PostgreSQL можно использовать поля для хранения массивов https://www.postgresql.org/docs/9.1/arrays.html В документации не нашел информации по добавлению кастомных типов полей, поэтому хотел быт уточнить, какие есть способоы добавления новых типов?

Всем привет!

Сегодня столкнулся с новой, интересной задачкой:

Есть три сущности:

/** @ORM\Entity */
class User {
    ...
}

/** @ORM\Entity */
class Model extends User {
    ...
}

/** @ORM\Entity */
class Studio extends User {
    ...
}

Допустим мне необходимо User конвертировать в Model. Самый простой способ сделать это, грубо говоря, указать нужный тип $user->_type = 'Model'. Но как только мы хотим сделать Model -> Studio, то этот способ уже не прокатит, т.к. mapper вручную _type переопределит. Полагаю единтсвенный способ сделать это - переопределить mapper и в нем этот функционал выпилить.

По мне идеальным решением было бы иметь некий хелпер, который бы мог заниматсья конвертаций, типа переброски всех полей из одного объекта в другой и при этом корректировать Identity map, чтобы в момент persist'a объект сохранялся в базу как новая сущность.

I do not know this is by design or not, but I think it is a strange behavior.

This is my use case:

I have an entity, and I would like to check this entity exists or not in the database. A simplified example:

class CustomerRepository
{
    public function exists($entity)
    {
        /** @var \Cycle\ORM\Select $select */
        $select = $this->select();
        // .. adding conditions based on primary keys
        return $this->fetchOne() !== null;
    }
}

After calling fetchOne my $entity instance is overridden with the result of fetchOne

Использую PHP 7.4 Обычные сущности для Many To Many. Пытаюсь связать существующие записи. Ругается на типизированное свойство в pivot entity при сохранении. Typed property App\CategoryContractor::$id must not be accessed before initialization

/**
 * @Cycle\Entity(table="category_contractor")
 */
class CategoryContractor
{
    /**
     * @Cycle\Column(type="primary")
     */
    public int $id;
}

For this schema:

    'place' => [
        Schema::ROLE        => 'place',
        Schema::ENTITY      => StrClass::class,
        Schema::MAPPER      => StdMapper::class,
        Schema::DATABASE    => 'default',
        Schema::TABLE       => 'places',
        Schema::PRIMARY_KEY => 'id',
        Schema::COLUMNS     => [
            'id',
            'name'
        ],
        Schema::TYPECAST    => [
            "id" => "int"
        ],
        Schema::SCHEMA      => [],
        Schema::RELATIONS   => [
            'members' => [
                Relation::TYPE   => Relation::MANY_TO_MANY,
                Relation::TARGET => 'user',
                Relation::SCHEMA => [
                    Relation::CASCADE           => true,
                    Relation::THROUGH_ENTITY    => 'place_member',
                    Relation::INNER_KEY         => 'id',
                    Relation::OUTER_KEY         => 'id',
                    Relation::THROUGH_INNER_KEY => 'place_id',
                    Relation::THROUGH_OUTER_KEY => 'user_id'
                ]
            ]
        ]
    ],
    'place_member' => [
        Schema::ROLE        => 'place_member',
        Schema::ENTITY      => StrClass::class,
        Schema::MAPPER      => StdMapper::class,
        Schema::DATABASE    => 'default',
        Schema::TABLE       => 'place_members',
        Schema::PRIMARY_KEY => 'id',
        Schema::COLUMNS     => [
            'id',
            'user_id',
            'place_id',
            'role_id',
            'period_id'
        ],
        Schema::TYPECAST    => [
            "id" => "int",
            'user_id' => 'int',
            'place_id' => 'int',
            'period_id' => 'int',
            'role_id' => 'int'
        ],
        Schema::SCHEMA      => [],
        Schema::RELATIONS   => [
            'role' => [
                Relation::TYPE   => Relation::BELONGS_TO,
                Relation::TARGET => 'roles',
                Relation::SCHEMA => [
                    RELATION::NULLABLE => true,
                    Relation::CASCADE   => true,
                    Relation::INNER_KEY => 'role_id',
                    Relation::OUTER_KEY => 'id'
                ]
            ]
        ]
    ]
]

When I run this query:

    $place = $cycle
        ->getRepository('place')
        ->select()
        ->load([
            'members' => [ 'as' => 'membersOfThatPeriod', 'where' => [ '@[email protected]_id' => 2 ]], 
            '[email protected]' 
        ])
        ->wherePk(1)
        ->fetchData());

echo $place->members->getPivot($place->members[0])->role; // NULL <--- WRONG!

I know that the schema is OK, because if I remove the [email protected] from the query, it gives me a reference to 'role' with the right id. And doing something like:

$item = $cycle->>getRepository('place_member')->select()->load('role')->fetchOne(); 
echo $item->role->name; // display the name of that role corretly.

• Looking at the generated queries, the table roles was never used in any of them.

Now you can set case folder name (like Issue777) and provide tempate folder different from CaseTemplate

Set folder name

php tests/generate-case.php --case-name=Issue777

output:

Generating new test case 'Issue777'... 
Using template files from '/home/cycle/orm/tests/ORM/Functional/Driver/Common/Integration/CaseTemplate'...
Generating test classes for all database types...
Skip class Cycle\ORM\Tests\Functional\Driver\Common\Inheritance\STI\StiBaseTest with abstract methods.
Skip class Cycle\ORM\Tests\Functional\Driver\Common\Inheritance\JTI\JtiBaseTest with abstract methods.
Processing /home/cycle/orm/tests/ORM/Functional/Driver/SQLite/Integration/Issue777/CaseTest.php
Processing /home/cycle/orm/tests/ORM/Functional/Driver/MySQL/Integration/Issue777/CaseTest.php
Processing /home/cycle/orm/tests/ORM/Functional/Driver/Postgres/Integration/Issue777/CaseTest.php
Processing /home/cycle/orm/tests/ORM/Functional/Driver/SQLServer/Integration/Issue777/CaseTest.php
Done. New test case is here:
/home/cycle/orm/tests/ORM/Functional/Driver/Common/Integration/Issue777

Set template folder

php tests/generate-case.php --case-name=Issue888 --template=Issue777

output:

Generating new test case 'Issue888'... 
Using template files from '/home/cycle/orm/tests/ORM/Functional/Driver/Common/Integration/Issue777'...
Generating test classes for all database types...
Skip class Cycle\ORM\Tests\Functional\Driver\Common\Inheritance\STI\StiBaseTest with abstract methods.
Skip class Cycle\ORM\Tests\Functional\Driver\Common\Inheritance\JTI\JtiBaseTest with abstract methods.
Processing /home/cycle/orm/tests/ORM/Functional/Driver/SQLite/Integration/Issue888/CaseTest.php
Processing /home/cycle/orm/tests/ORM/Functional/Driver/MySQL/Integration/Issue888/CaseTest.php
Processing /home/cycle/orm/tests/ORM/Functional/Driver/Postgres/Integration/Issue888/CaseTest.php
Processing /home/cycle/orm/tests/ORM/Functional/Driver/SQLServer/Integration/Issue888/CaseTest.php
Done. New test case is here:
/home/cycle/orm/tests/ORM/Functional/Driver/Common/Integration/Issue888

No duplicates 🥲.

• [X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

We have classes below

class AClass {

   #[Cycle\Column(type: 'integer')]
   private int $userId;
}

class BClass {
    #[Cycle\Relation\BelongsTo(target: User::class)]
    private Exchanger $user;
}

class User {
     #[Cycle\Column(type: 'primary')]
     private ?int $id = null;
   
    // properties here
}

When I make requests like this. In the $aList the members have a userId property, and in the $bList there is a user_id property.

 $aList = $this->getOrm()->getRepository(AClass::class)
            ->select()
            ->fetchData();

// $alist = [ ['userId' => 1] ]
            
 $bList = $this->getOrm()->getRepository(BClass::class)
            ->select()
            ->fetchData();
// $bList = [ ['user_id' => 1, 'user' => ['id' => 1, 'foo' => 'bar']] ]

Is it possible to do something with the #[Cycle\Column(type: 'integer')] to fetch columns in different cases in queries?

Version

PHP 8.1
cycle/orm  2.2.1

https://github.com/loophp/collection/releases/tag/7.0.0 LoophpCollectionFactory should be compatible with CollectionDecorator.php and with any custom implementation.

No duplicates 🥲.

• [X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

If you save multiple related entities in the same transaction, there may be saved in broken order.

$em = (new EntityManager($orm));
$em->persist($user);

$i = 1;
$em->persist(new User\Alias($user, "{$user->age}-$i")) and $i++;

$em->persist(new User\Email($user, "{$user->age}-$i")) and $i++;
$em->persist(new User\Email($user, "{$user->age}-$i")) and $i++;

$em->persist(new User\Phone($user, "{$user->age}-$i")) and $i++;
$em->persist(new User\Phone($user, "{$user->age}-$i")) and $i++;
$em->persist(new User\Phone($user, "{$user->age}-$i")) and $i++;

$em->run();

will be saved in db in broken order

{
  "alias": [
    {
      "value": "246-1"
    }
  ],
  "email": [
    {
      "value": "246-2"
    },
    {
      "value": "246-3"
    }
  ],
  "phone": [
    {
      "value": "246-6"
    },
    {
      "value": "246-4"
    },
    {
      "value": "246-5"
    }
  ]
}

Bug demo: https://github.com/gam6itko/app/commit/70024f6c50527b2e21f25e5b3cc33217f32dd8c7

Bug detected on: http://localhost:8080/issue1 http://localhost:8080/issue2 http://localhost:8080/issue3

Bug NOT detected on: http://localhost:8080/no_issue1 http://localhost:8080/no_issue2

Version

ORM 2.2.0 
PHP 8.1.2

cycle/annotated                   v3.2.0          Cycle ORM Annotated Entities generator
cycle/database                    2.2.2           DBAL, schema introspection, migration and pagination
cycle/migrations                  v4.0.0          Database migrations, migration scaffolding
cycle/orm                         v2.2.0          PHP DataMapper ORM and Data Modelling Engine
cycle/schema-builder              v2.1.0          Cycle ORM Schema Builder
cycle/schema-migrations-generator 3.x-dev df0e391 Cycle ORM Migration generation
cycle/schema-renderer             1.1.0           Utils for Cycle ORM Schema rendering