Hello,

Whenever I run the migrate:auto command after the initial users table has been created, the command creates a new table called "table_users". I have a video demonstrating the issue happening on a fresh laravel project, (you can skip through to around 01:28 as it takes it's sweet time to create a new project on windows!): Video Link. It has the following error:

  SQLSTATE[42P07]: Duplicate table: 7 ERROR:  relation "table_users_email_unique" already exists (SQL: alter table "table_users" add constraint "table_users_email_unique" unique ("email"))

  at C:\Devspace\lam_error_test\vendor\laravel\framework\src\Illuminate\Database\Connection.php:692
    688▕         // If an exception occurs when attempting to run a query, we'll format the error
    689▕         // message to include the bindings with SQL, which will make this exception a
    690▕         // lot more helpful to the developer instead of just the database's errors.
    691▕         catch (Exception $e) {
  ➜ 692▕             throw new QueryException(
    693▕                 $query, $this->prepareBindings($bindings), $e
    694▕             );
    695▕         }
    696▕     }

  1   C:\Devspace\lam_error_test\vendor\laravel\framework\src\Illuminate\Database\Connection.php:485
      PDOException::("SQLSTATE[42P07]: Duplicate table: 7 ERROR:  relation "table_users_email_unique" already exists")

  2   C:\Devspace\lam_error_test\vendor\laravel\framework\src\Illuminate\Database\Connection.php:485
      PDOStatement::execute()

Hello @bastinald,

Thanks a lot for this awesome package. I'm Vincent from Indonesia, I recently explored your laravel-livewire-ui package. However I found a problem whenever I create migration for a table that has a foreign to other tables. An error would occurred because the migration of related table run before the foreign table exist:

SQLSTATE[HY000]: General error: 1215 Cannot add foreign key constraint (SQL: alter table `table_products` add constraint `table_products_category_id_foreign` foreign key (`category_id`) references `id` (`categories`))

I tried to make some modification by sorting the model files using defined $migration_sequence variable. Using this variable, we can defined the migration running sequence.

If you think this is a good solution, you can freely accept this PR.

Thanks.

One thing i am struggling to figure out how to do relations with the seed data in the definition(). Not sure how i can make that 'contact_id' in the seed related to an actual contact from the Contact model. Will be useful to know for other uses. Right now i just have a hard contact id set of 1.

<?php

namespace App\Models;

use Bastinald\UI\Traits\HasFillable;
use Faker\Generator;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;
use Illuminate\Database\Schema\Blueprint;

class Transaction extends Model
{
    use HasFactory;
    use HasFillable;
    use SoftDeletes;

    public function migration(Blueprint $table)
    {
        $table->id();
        $table->unsignedBigInteger('contact_id');
        $table->string('description');
        $table->string('payment_gateway');
        $table->string('gateway_transaction_id');
        // create unique relationship
        $table->unique(['payment_gateway', 'gateway_transaction_id']);
        $table->decimal('amount', 10, 2);
        $table->decimal('fees', 10, 2)->default(0.00);
        $table->timestamp('created_at')->nullable();
        $table->timestamp('updated_at')->nullable();
        $table->softDeletes();
    }

    public function definition(Generator $faker)
    {
        return [
            'contact_id' => 1,
            'description' => $faker->words,
            'payment_gateway' => 'square',
            'gateway_transaction_id' => $faker->unique()->numerify('########'),
            'amount' => $faker->randomFloat(2, 10, 20),
            'fees' => $faker->randomFloat(2, 0, 0.4),
        ];
    }
}

https://github.com/bastinald/laravel-automatic-migrations/blob/31d26e9ab35e41d25692524fd32b8ff92f7959fc/src/Providers/LaravelAutomaticMigrationsProvider.php#L23

First hi, I want to say that is very interesting project. Here on publish I see that multiple times are used same paths:

'/../../config'
'/../../resources'

As a purpose maybe will be better to extract them to variables or constants(if will be used on other classes), as example:

$configPath = __DIR__ . '/../../config';
$resourcesPath = __DIR__ . '/../../resources';

or in class

const CONFIG_PATH = __DIR__ . '/../../config';
const RESOURCES_PATH = __DIR__ . '/../../resources';

and usage will be

 $this->publishes(
            ["{$configPath}/laravel-automatic-migrations.php" => config_path('laravel-automatic-migrations.php')],
 ...

or

 $this->publishes(
            [CONFIG_PATH  . '/laravel-automatic-migrations.php' => config_path('laravel-automatic-migrations.php')],
 ...

I am developing my application using https://nwidart.com/laravel-modules and there is no way to auto-discover the models generated in the Modules folder.

Kindly provide way of specify preferred models files path,

this package has moved here: https://github.com/legodion/lucid

i am the author, this is my alt account

that repo will be updated and maintained going forward. it supports Laravel 9 etc.

This issue is only a proposal:

Since auto migration could lead to accidental column deletions and data loss while updating existing tables, I added some code to MigrateAutoCommand.php to alert the user if the running migration is about to delete some columns.

Here is my proposal:

     [ ... ]
           $tableDiff = (new Comparator)->diffTable($modelTableDetails, $tempTableDetails);

            if ($tableDiff) {
                $delcount=count($tableDiff->removedColumns);    
                if ($delcount==0 || 
                     $this->confirm('This migration will delete ' . $delcount . ' column(s): ['  . 
                           implode(', ',array_keys($tableDiff->removedColumns))  .   ']. Proceed?')){

                    $schemaManager->alterTable($tableDiff);

                    $this->line('<info>Table updated:</info> ' . $modelTable);
                }
                else {
                    $this->line('<info>Table update CANCELED:</info> ' . $modelTable);
                }
            }
     [ ... ]

Bye, Marco

Should i just create vanilla laravel migration tables for pivot tables or is there a way to handle it with this library? Lets say I have a Post model and a Category model and I want to be able to associate multiple Categories to a Post (belongsToMany).

Hi!

If I modify LaravelAutomaticMigrationsProvider class like this: ... if ($this->app->runningInConsole()) { $this->commands([ MakeAModelCommand::class, ]); }

    $this->commands([
            MigrateAutoCommand::class,
        ]);

...

It help to migrate an exist database where I can't run OS command.

I can use Artisan::call command browser Route::get('/migrate', function() { Artisan::call('migrate:auto');
return "Your database migrated"; });

I use this doc: https://nono.ma/laravel-artisan-the-command-does-not-exist

Nándi