Using Artax (composer require amphp/artax) and running the following code on Windows:

        Loop::run(function () {
            foreach (range(1, 1000) as $id) {
                $this->client->request('http://example.com')->onResolve(function ($error, $response) {
                    if ($error) {
                        echo "$error\n";

                        return;
                    }
                });
            }
        });

Generates the following error:

Amp\Process\ProcessException: Process did not connect to server before timeout elapsed in vendor\amphp\process\lib\Internal\Windows\SocketConnector.php:344

The key is to have a high concurrency limit (i.e. 1000 in this case). Lower limits can trigger trigger it, too, but they need to be at least in the region of ~500 on my Windows 7 system.

The error is strange because only a couple of seconds are passing, at most, before the errors start streaming in. The same code works (can successfully download a response) with lower concurrency limits (e.g. around 200 or so).

Edit: After further testing, I can trigger this with a limit as low as 50. It seems to depend on how long the destination server takes to respond. Loading larger pages is more likely to cause it to fail. Again, only a second or so of real user time is passing but even trying to load 50 heavy URLs at once will cause it to fail the majority of the time and there seems to be no way to override the timeout.

my process I try to start, errors while starting up.

I get errors like

Uncaught exception: 'Amp\Process\ProcessException' with message 'Could not start process' (0)
> in /cluster/www/www/www/rocket/vendor/amphp/process/lib/Internal/Posix/Runner.php:88
Stack trace:
#0 /cluster/www/www/www/rocket/vendor/amphp/process/lib/Process.php(96): Amp\Process\Internal\Posix\Runner->start('{ ('/usr/bin/ph...', '', Array, Array)
#1 /cluster/www/www/www/rocket/vendor/amphp/parallel/lib/Context/Process.php(166): Amp\Process\Process->start()
#2 /cluster/www/www/www/rocket/vendor/amphp/parallel/lib/Worker/AbstractWorker.php(59): Amp\Parallel\Context\Process->start()
#3 /cluster/www/www/www/rocket/vendor/amphp/parallel/lib/Worker/DefaultPool.php(137): Amp\Parallel\Worker\AbstractWorker->enqueue(Object(BlockingTask))
#4 /cluster/www/www/www/rocket/helpers/ImageHelper.php(73): Amp\Parallel\Worker\DefaultPool->enqueue(Object(BlockingTask))
#5 [internal function]: {closure}('a', NULL)
#6 /cluster/www/www/www/rocket/vendor/amphp/amp/lib/Coroutine.php(39): Generator->current()
#7 /cluster/www/www/www/rocket/vendor/amphp/amp/lib/Loop/Driver.php(119): Amp\Coroutine->__construct(Object(Generator))
#8 /cluster/www/www/www/rocket/vendor/amphp/amp/lib/Loop/Driver.php(70): Amp\Loop\Driver->tick()
#9 /cluster/www/www/www/rocket/vendor/amphp/amp/lib/Loop.php(76): Amp\Loop\Driver->run()
#10 /cluster/www/www/www/rocket/helpers/ImageHelper.php(80): Amp\Loop::run(Object(Closure))

I guess the problem itself is, that proc_open is on the disable_functions list and therefore php does not allow to start the process.

my calling code looks like

function resize_image($filename, $destinations = null, $allowEnlarge = false)
{
    $result = true;

    Amp\Loop::run(function () use ($filename, $destinations, $allowEnlarge, &$result) {
        $pool = new DefaultPool();

        $promises = array();
        foreach($destinations as $name => $params) {
            $promises[] = $pool->enqueue(new BlockingTask('resize_image_process', $filename, array($name => $params), $allowEnlarge));
        }

        foreach($promises as $promise) {
            $result = $result && yield $promise;
        }
        $result = $result && yield $pool->shutdown();
    });

    return $result;
}

while I am using classes from the examples from the parallel component https://github.com/amphp/parallel/tree/master/examples

One second is an insanely short timeout for a socket to respond. Many web services delivering heavy web applications easily trip this timeout during normal use. See #21.

@kelunik told me to open a ticket here.

Please open an issue at https://github.com/amphp/parallel for the infinite loop and https://github.com/amphp/process for the ports if you want.

its quite a while but as the problem with box was easy solvable by using the --no-parallel option i simply forgot until i hit the problem again with fink.

i am not sure where to write which info, it feels i would post the same text in parallel and process as i haven't used amphp directly but only tools which use it, i don't know the internals.

if i run fink it simply gets stuck forever on a windows system with a firewall.

php fink.phar https://getcomposer.org

if my firewall is in learning mode, it ask me to allow ampXXXX.tmp a local connection.

after allowing it, the connection monitor show the following:

this 3 php and amp processes stay there forever in an infinite loop and are doing nothing (no more as the initial 22 bytes are sent or received).

if i run the firewall in allow all mode (which sadly makes no sense at all), it works without a problem.

so it looks like amphp has a problem if the port is not instantly accessible but delayed by a firewall learning mode dialog. as the amp process names are randomly generated it is not possible to precreate the firewall rules. having some kind of check if ports can be accessed and if not some kind of fallback could be a solution. a slow synchronous processing is still faster as a infinite do nothing processing :) edit: non-dynamic ports can also help (only in combination with non random process names)

Some example code to reproduce

test.php

<?php
require __DIR__.'/vendor/autoload.php';

$onInterrupt = \Amp\Loop::onSignal(SIGINT, function ($reference){
	echo "sigterm\n";
	//\Amp\Loop::cancel($reference);
});
\Amp\Loop::run(function() use($onInterrupt ){
	$process = new \Amp\Process\Process("php test-process.php");
	$pid = yield $process->start();
	\Amp\ByteStream\pipe($process->getStdout(), \Amp\ByteStream\getStdout());
	\Amp\ByteStream\pipe($process->getStderr(), \Amp\ByteStream\getStderr());
	$code = yield $process->join();
	echo $code;
	if(file_exists("/proc/{$pid}")) {
		echo "Process still running\n";
	}
	yield new \Amp\Delayed(10000);
	\Amp\Loop::cancel($onInterrupt);
});

test-process.php

<?php
require __DIR__.'/vendor/autoload.php';

//pcntl_async_signals(true);
\Amp\Loop::onSignal(SIGINT, function (){
	echo "sigterm from parent\n";
});
echo "Start\n";
\Amp\Loop::repeat(100, function(){
	echo "test\n";
	sleep(1);
});
\Amp\Loop::run();
echo "exit\n";

Steps to reproduce

1. I start script test.php. Example output was:

Start
test
test
test

Process list:

26434 pts/7    S+     0:00 php ./test.php
26435 pts/7    S+     0:00 sh -c { (php test-process.php) <&3 3<&- 3>/dev/null & } 3<&0;pid=$!; echo $pid >&3; wait $pid; RC=$?; echo $RC >&3; exit $RC
26436 pts/7    S+     0:00 php test-process.php

2. I send sigint(ctrl+c) to script. Output was:

^C0Process still running
sigterm from parent
test
sigterm

Processs list:

27301 pts/7    S+     0:00 php ./test.php
27303 pts/7    S+     0:00 php test-process.php

3. I wait for script to finish. Output was:

test
test
test
test
test
test
test
test
test
test

Actual behavior

As you can see when sigint received php closed process wrapper (sh -c) and send sigint to test-process.php. amp/Process wait for process wrapper to finish but doesn't wait for test-process.php. But pipes will continue to work after that. The child process only killed after main process exit.

Expected behavior

Process::join only resolves when test-process.php finished/halted/cancelled.

Starting and stopping processes is a very time consuming thing.

Would it be possible to leave a process open after the command finished and let it run another command? Or maybe some kind of process pooling to reduce start/stop overhead?

Not sure its possible at all...

Actually killing a process which is detached does not work

$process = new \Amp\Process\Process("setsid sleep 100");
$process->start();

$pid = yield $process->getPid();

$process->kill();

Then doing a ps aufx|grep sleep show the process still running, it is possible to kill him since we have the correct id and we can use then posix_kill, but should we do that (it introduce maybe a new extension dependency)

• New getCommand(), status() and refactored pid() function.
• Added test for kill(), exec(), pid() and status() functions against UvReactor, LibeventReactor and NativeReactor.
• Added php-cs-fixed and phpunit/phpunit to dev-dependencies and added .php_cs file based on the others projects.
• Changed the structure of the repository according to amphp/amp

D:\sites\git\epmms2-award>vendor\bin\grumphp.bat run GrumPHP is sniffing your code! Running tasks with priority 0! ==============================

Running task 1/5: phpcs... Running task 2/5: phpcsfixer... Running task 3/5: shell... ✘ Running task 4/5: composer... Running task 5/5: yamllint... ✔ Aborted ... ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ▄▄▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ ▐▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▄ ▐▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ ▐▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ ▄███▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ █▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ ▐█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ ▀█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▌ ▀▀▓▓▓▓▓▓▓▓▓▓▓▓█▀▀▀▀▀▀▀▀▀▀▀▀▀▀████████████▄ ▄███████ ██████████ ███████▀ ▀▀▀▀▀▄ ▄▀▀▀▀▀ █████ ▀ ▐████ ▐██ ▐██ ████▌ ████▌ ███ ▌██▌ ▄▄ ▄▄ ▐███ ███ ▄▄▄▄▄▄▄▄▄▄▄▄ ▐███ ██▄ ▐███████████████████████████ █▀███████████▀ ▀▀███████████ ██████████▄███████▄███████████ ▐█████████████████████████████ █████████████████████████████ ██ █████████████████████▐██▀ ▀ ▐███████████████████▌ ▐▀ ████▀████████▀▐███ ▀█▌ ▐█████ ██▌ ██▀ ▐▀

   ██████████████████████████████████
   █░░░░░░▀█▀░░░░░░▀█░░░░░░▀█▀░░░░░▀█
   █░░▐█▌░░█░░░██░░░█░░██░░░█░░░██░░█
   █░░▐█▌░░█░░░██░░░█░░██░░░█░░░██░░█
   █░░▐█▌░░█░░░██░░░█░░░░░░▄█░░▄▄▄▄▄█
   █░░▐█▌░░█░░░██░░░█░░░░████░░░░░░░█
   █░░░█░░░█▄░░░░░░▄█░░░░████▄░░░░░▄█
   ██████████████████████████████████

shell

The executable for "sh" could not be found. To skip commit checks, add -n or --no-verify flag to commit command PHP Fatal error: Uncaught TypeError: fclose(): supplied resource is not a valid stream resource in D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php:221 Stack trace: #0 D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php(221): fclose(Resource id #530) amphp/amp#1 D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php(201): Amp\Process\Internal\Windows\Runner->free(Object(Amp\Process\Internal\Windows\Handle)) amphp/amp#2 D:\sites\git\epmms2-award\vendor\amphp\process\lib\Process.php(85): Amp\Process\Internal\Windows\Runner->destroy(Object(Amp\Process\Internal\Windows\Handle)) amphp/amp#3 [internal function]: Amp\Process\Process->__destruct() amphp/amp#4 {main} thrown in D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php on line 221

Fatal error: Uncaught TypeError: fclose(): supplied resource is not a valid stream resource in D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php:221 Stack trace: #0 D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php(221): fclose(Resource id #530) amphp/amp#1 D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php(201): Amp\Process\Internal\Windows\Runner->free(Object(Amp\Process\Internal\Windows\Handle)) amphp/amp#2 D:\sites\git\epmms2-award\vendor\amphp\process\lib\Process.php(85): Amp\Process\Internal\Windows\Runner->destroy(Object(Amp\Process\Internal\Windows\Handle)) amphp/amp#3 [internal function]: Amp\Process\Process->__destruct() amphp/amp#4 {main} thrown in D:\sites\git\epmms2-award\vendor\amphp\process\lib\Internal\Windows\Runner.php on line 221

I use an tool which requires the composer autoloader.php in order to use the class map.

When this tool is used with the library it issues a warning as these constants are then redefined.

This PR checks for the existence of the constants before defining them.

This might fix https://github.com/amphp/aerys/issues/192, @brstgt please test it.

@bwoebi Please test whether that works on macOS.

This should have a test, but I've not been able to write one yet.

It works locally, but apparently doesn't work on Travis, needs further investigation.

Hi, testing Parallel v2 with fibers on php 8.1 FPM with a simple task service, but it cannot work anymore because the underlaying Process requires pcntl which is not available on FPM. The same code with Promises works on Parallel/Process v1

The following code:

Loop::run(static function () {

    $process = new Process("diskpart");
    yield $process->start();

});

Problem: app just stucks and does not stdout anything, using a timeout completely breaks the script execution:

Loop::run(static function () {

    $process = new Process("diskpart");

    yield timeout($process->start(), 5000);

});

Here an exception:

PHP Fatal error:  Uncaught Exception: stream_select(): supplied resource is not a valid stream resource in C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\NativeDriver.php:79
Stack trace:
#0 [internal function]: Amp\Loop\NativeDriver->Amp\Loop\{closure}(2, 'stream_select()...', 'C:\\Users\\Admin\\...', 294, Array)
#1 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\NativeDriver.php(294): stream_select(Array, Array, NULL, 4, 0)
#2 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\NativeDriver.php(127): Amp\Loop\NativeDriver->selectStreams(Array, Array, 4)
#3 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\Driver.php(138): Amp\Loop\NativeDriver->dispatch(true)
#4 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\Driver.php(72): Amp\Loop\Driver->tick()
#5 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amp in C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\NativeDriver.php on line 79

Process finished with exit code 255

I found a possible solution to solve this problem, but I'm not good at creating PR.

By adding the following code to "lib/Internal/Windows/SocketConnector.php" at the end of the function "onProcessConnectTimeout" (I added after the line 367)

if ($handle->status === ProcessStatus::STARTING) {
    Loop::cancel($handle->childPidWatcher);
    $handle->pidDeferred->fail($error);
}

The problem is solved completely and now the output when running the first script:

PHP Fatal error:  Uncaught Amp\Process\ProcessException: Failed to create child process: 740: Запрошенная операция требует повышения. in C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\process\lib\Internal\Windows\SocketConnector.php:359
Stack trace:
#0 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\NativeDriver.php(142): Amp\Process\Internal\Windows\SocketConnector->onProcessConnectTimeout('e', Object(Amp\Process\Internal\Windows\Handle))
#1 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\Driver.php(138): Amp\Loop\NativeDriver->dispatch(true)
#2 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop\Driver.php(72): Amp\Loop\Driver->tick()
#3 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\amp\lib\Loop.php(95): Amp\Loop\Driver->run()
#4 C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\test.php(17): Amp\ in C:\Users\Admin\Documents\win_install_stuff\windows_installer_v0\vendor\amphp\process\lib\Internal\Windows\SocketConnector.php on line 359

Process finished with exit code 255

PS. Sorry for a little machine translation, English is not my first language

wrapper.php

<?php
echo 'foo';
sleep(1);
touch('a');

Following works as expected, outputs foo, exits immediately and after 1 second creates file 'a'.

<?php

$fd = [
    ["pipe", "r"], // stdin
    ["pipe", "w"], // stdout
];
$handle = @\proc_open('php wrapper.php', $fd, $pipes);

echo fread($pipes[1], 100);

Following does not work as expected. Outputs foo, exits immediately but file is not created.

<?php
require_once "vendor/autoload.php";
\Amp\Loop::run(function () {
    $process = new \Amp\Process\Process("php wrapper.php");
    yield $process->start();
    echo yield $process->getStdout()->read();
});