This module does not implement write lock, but read lock instead.

The lock is currently taken when the session is first read and released when written.

You can actually prove this misconception by simply reading the first comment of the read method on this line https://github.com/colinmollenhour/php-redis-session-abstract/blob/master/src/Cm/RedisSession/Handler.php#L429

This causes bad performance on numerous Magento projects (if not all), since there are multiple HTTP requests running in parallel that need to read the session (furthermore when combining AJAX and non-AJAX requests, and especially in the checkout, or in development mode where the static file symlinking process needs to read the session).

This issue is causing more problems as the number of AJAX requests and their duration are growing.

The lock should be taken just before writing and released immediately after.

To avoid concurrency issues, a "diff" must be calculated by comparing the first session read and the session that is programmed to be written, and applied to a fresh session that is fetched just after taking the lock, then write the merged result.

I am preparing a patch to overcome this situation.

PHP Notice for undefinded Index with Credis Release 1.9.0 (https://github.com/colinmollenhour/credis/releases/tag/1.9.0)

response from client is now a key/value array instead of values only

https://github.com/colinmollenhour/php-redis-session-abstract/blob/7e961834e1373058213765e7a3e391184282d863/src/Cm/RedisSession/Handler.php#L548

In New Relic I frequently see slow requests stuck trying to read the session due to being caught on the lock. Most of the time these are from bots as they crawl the site at speed.



I was thinking that the artificially slow request could potentially have some negative SEO effects, especially on Product pages and similar.



If we had the ability to disable session locking for bots only we could prevent this issue.

I have not had success previously with disabling session locking entirely so was thinking a little more granular control at this level could help out.

Let me know what you think of this idea.

The PHP 8.1 compatibility release 1.5.0 is not installable with Magento 2.4.5 because it uses the version constraint "colinmollenhour/php-redis-session-abstract": "~1.4.5",.

Looking at the CHANGELOG of php-redis-session-abstract from 1.4.5 to 1.5.0, but I do not see a reason why the minor version needs to be bumped to 5.
Could you please tag the same release as 1.4.6?

As I see, Zend framework is actually never used in v1.2.x of this library and already dropped in the v1.3.x. It would be nice to remove this dependency for v.1.2.x too as it locks specific zend framework version without a reason.

Hi,

The version 1.3 contains backward incompatible change (a new method has been added to the interface Cm\RedisSession\Handler\ConfigInterface. It is the undesirable side effect when we only want to make our code compatible with PHP 7.1.

I've checked the code for the version 1.2 and didn't find any incompatibility, so the only thing which is required to make it works with PHP 7.1 is to add this version as supported into composer.json.

But, as there is no branch for that specific version, I cannot send you a pull request with a fix.

Can you please make a new release v1.2.1 with added PHP 7.1 support in the composer.json?

Inside the README file it states:

Requires PHP >= 5.3. Yes, this is a feature. You're welcome. ;)

However in composer.json the minimum PHP version is set to 5.5 here: https://github.com/colinmollenhour/php-redis-session-abstract/blob/master/composer.json#L13

Which is correct?

Resolve warning: Deprecated Functionality: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /Cm/RedisSession/Handler.php on line 300

EDIT: on Redis 6 the error message returned when AUTH is not set on sentinels is different, so add it to check

In PHP 8.1, >> non-final internal methods now require overriding methods to declare a compatible return type, otherwise a deprecated notice is emitted during inheritance validation. RFC: https://wiki.php.net/rfc/internal_method_return_types

Because of this, we receive a deprecation notice when running our code with PHP8.1.

This PR adds #[ReturnTypeWillChange] attribute where it is needed, in order to avoid the described problem and keep backward compatibility.

"php": "^5.5 || ^7.0" allows to install any 7.x version, more info https://getcomposer.org/doc/articles/versions.md#caret-version-range-

This PR replaces DEL Command with UNLINK command.

Details about UNLINK can be found here https://redis.io/commands/unlink .

As noticed here redis/redis#1748 (comment) this will not change the behavior.

As there is no check of Redis version included, it will break Redis Versions < 4.0 through.

As Redis 4.0 was released on 2017-07-14 and Redis 3 went EOL with the Redis 5 on 2018-10-17, I don't expect this being an issue.

See also https://github.com/colinmollenhour/Cm_Cache_Backend_Redis/issues/158 for details.

Exception #0 (Exception): Deprecated Functionality: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /var/www/html/vendor/colinmollenhour/php-redis-session-abstract/src/Cm/RedisSession/Handler.php on line 300

Hello,

when using Redis-Sentinel settings in Magento 2.3.x for example in the Config-Section 'session' => [ 'save' => 'redis', 'redis' => [ 'sentinel_servers' => 'tcp://10.0.0.30:26379,tcp://10.0.0.31:26379,tcp://10.0.0.32:26379',

and one of the Sentinel-Servers is not reachable for some reason, for ex. the first 10.0.0.30 (this is also the Server used through your program logic), see Link: https://github.com/colinmollenhour/php-redis-session-abstract/blob/8d684bbacac99450f2a9ddf6f56be296997e2959/src/Cm/RedisSession/Handler.php#L303

nothing works anymore, because of the not correct CredisException handlig.

If the Sentinel-Server is not reachabel, the Credis Client.php (see Link: https://github.com/colinmollenhour/credis/issues/new?permalink=https%3A%2F%2Fgithub.com%2Fcolinmollenhour%2Fcredis%2Fblob%2F464804e67d0fe5707c9035c986f3850f83d9d177%2FClient.php%23L497 )

throws the Error but does not include the Error-Number (111) which can be used in Handler.php on Line https://github.com/colinmollenhour/credis/issues/new?permalink=https%3A%2F%2Fgithub.com%2Fcolinmollenhour%2Fcredis%2Fblob%2F464804e67d0fe5707c9035c986f3850f83d9d177%2FClient.php%23L497

Your Line: throw new CredisException("Connection to Redis {$this->host}:{$this->port} failed after $failures failures." . (isset($errno) && isset($errstr) ? "Last Error : ({$errno}) {$errstr}" : ""));

My Line: throw new CredisException("Connection to Redis {$this->host}:{$this->port} failed after $failures failures." . (isset($errno) && isset($errstr) ? "Last Error : ({$errno}) {$errstr}" : ""), $errno);

How the "Round-Robin" for-loop should work, i don't know...

And if the rest works (Sentinel without Pass) i haven't tested

For compression multiple compression libraries are supported. For the Cm_Cache_Backend_Redis the zstd library has been added in 2018 (https://github.com/colinmollenhour/Cm_Cache_Backend_Redis/commit/a9c4a5ae6001e04097aa7302abd89c9496c563e0) which IMHO gives a slightly better compression at a better speed. It would be beneficial to add zstd for the Redis session module as well.

Hey,

I know it may be not a good place to ask this question but I can't find anywhere else to ask it.

I see the package https://github.com/colinmollenhour/Cm_Cache_Backend_Redis support the ElastiCache (cluster disabled mode), and that is for Magento2 cache. However, the session only has Redis Sentinel relevant configurations. Why?

Thanks

Using sentinel configuration is not possibile to disable sentinel auth keeping master node auth enabled or to specify different passwords.

The problem is in Handler.php file because the same variable $pass si evaluated for $sentinelClient->auth and $redisMaster->auth

306   $sentinelClient = new \Credis_Client($server, NULL, $timeout, $persistent);
307   $sentinelClient->forceStandalone();
308   $sentinelClient->setMaxConnectRetries(0);
309   if ($pass) $sentinelClient->auth($pass);
310   
311   $sentinel = new \Credis_Sentinel($sentinelClient);
312   $sentinel
313      ->setClientTimeout($timeout)
314      ->setClientPersistent($persistent);
315   $redisMaster = $sentinel->getMasterClient($sentinelMaster);
316   if ($pass) $redisMaster->auth($pass);