Hey!

Issue

I'm implementing a OpenIDConnect Provider for Unity IDM and encountered the problem, that the JWT kid header attribute is required, even if the jwks_uri only returns a single key.

An InvalidJWT('No kid inside header, but $privateKeyOrSecret specified as JWKSet')-Exception is thrown.

The OpenIDConnect/AbstractProvider::getJWKSet-Method always returns a JWKSet, even though the JWT::decode Method only expects a JWKSet if there are multiple keys present and a string of the key if there is only one key? (That's the reason i report this against this repo and not SocialConnect/jwx)

My env

PHP: 7.4.1

Library: SocialConnect/auth

Provider: Provider extending \SocialConnect\OpenIDConnect\AbstractProvider

Provider options:

[
    'options' => []
];

Thanks :smiley_cat:

I have tried this

'Twitter' => [
       'enabled' => true,
       'keys' => [
               'key' => '*******',
               'secret' => 'd3DxnqDvh*******************zp1oY******'
        ],
        'includeEmail' => true
],

But it is giving error as

 Provider response is not success 
Undefined index: applicationId [ROOT/vendor/socialconnect/auth/src/Auth/CollectionFactory.php, line 86]
Undefined index: applicationSecret [ROOT/vendor/socialconnect/auth/src/Auth/CollectionFactory.php, line 86]

Hey!

Type: enhancement

Link to issue:

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [ ] I wrote some tests for this PR.

Small description of change:

This allows specifying each scope as a separate array value in config instead of an array with single space separated string.

Thanks :smiley_cat:

Issue

I upgraded CakePHP to v4 and with that auth plugin gets upgraded too to version 3.1.

Is there a way to add User-Agent to the github login configuration? After upgrade I get this error when trying to login:

2020-02-23 01:54:24 Error: [SocialConnect\Provider\Exception\InvalidResponse] API response with error code
Request URL: /social-auth/callback/github?code=c06d043cc8ea5fcd53b4&state=cb84af630eefaf5fe23e6e503df08efd
Referer URL: http://localhost:8765/
Provider Response: Request forbidden by administrative rules. Please make sure your request has a User-Agent header (http://developer.github.com/v3/#user-agent-required). Check https://developer.github.com for other possible causes.

Stack Trace:
#0 .../vendor/socialconnect/auth/src/Provider/AbstractBaseProvider.php(296): SocialConnect\Provider\AbstractBaseProvider->executeRequest(Object(Zend\Diactoros\Request))
#1 .../vendor/socialconnect/auth/src/OAuth2/Provider/GitHub.php(78): SocialConnect\Provider\AbstractBaseProvider->request('GET', 'user', Array, Object(SocialConnect\OAuth2\AccessToken))
#2 .../vendor/admad/cakephp-social-auth/src/Middleware/SocialAuthMiddleware.php(275): SocialConnect\OAuth2\Provider\GitHub->getIdentity(Object(SocialConnect\OAuth2\AccessToken))
#3 .../vendor/admad/cakephp-social-auth/src/Middleware/SocialAuthMiddleware.php(216): ADmad\SocialAuth\Middleware\SocialAuthMiddleware->_getProfile('github', Object(Cake\Http\ServerRequest))
#4 .../vendor/admad/cakephp-social-auth/src/Middleware/SocialAuthMiddleware.php(178): ADmad\SocialAuth\Middleware\SocialAuthMiddleware->_handleCallbackAction(Object(Cake\Http\ServerRequest))
#5 .../vendor/cakephp/cakephp/src/Http/Runner.php(73): ADmad\SocialAuth\Middleware\SocialAuthMiddleware->process(Object(Cake\Http\ServerRequest), Object(Cake\Http\Runner))
#6 .../vendor/cakephp/cakephp/src/Routing/Middleware/RoutingMiddleware.php(156): Cake\Http\Runner->handle(Object(Cake\Http\ServerRequest))
#7 .../vendor/cakephp/cakephp/src/Http/Runner.php(73): Cake\Routing\Middleware\RoutingMiddleware->process(Object(Cake\Http\ServerRequest), Object(Cake\Http\Runner))
#8 .../vendor/cakephp/cakephp/src/Routing/Middleware/AssetMiddleware.php(68): Cake\Http\Runner->handle(Object(Cake\Http\ServerRequest))
#9 .../vendor/cakephp/cakephp/src/Http/Runner.php(73): Cake\Routing\Middleware\AssetMiddleware->process(Object(Cake\Http\ServerRequest), Object(Cake\Http\Runner))
#10 .../vendor/cakephp/cakephp/src/Error/Middleware/ErrorHandlerMiddleware.php(118): Cake\Http\Runner->handle(Object(Cake\Http\ServerRequest))
#11 .../vendor/cakephp/cakephp/src/Http/Runner.php(73): Cake\Error\Middleware\ErrorHandlerMiddleware->process(Object(Cake\Http\ServerRequest), Object(Cake\Http\Runner))
#12 .../vendor/cakephp/debug_kit/src/Middleware/DebugKitMiddleware.php(60): Cake\Http\Runner->handle(Object(Cake\Http\ServerRequest))
#13 .../vendor/cakephp/cakephp/src/Http/Runner.php(73): DebugKit\Middleware\DebugKitMiddleware->process(Object(Cake\Http\ServerRequest), Object(Cake\Http\Runner))
#14 .../vendor/cakephp/cakephp/src/Http/Runner.php(58): Cake\Http\Runner->handle(Object(Cake\Http\ServerRequest))
#15 .../vendor/cakephp/cakephp/src/Http/Server.php(90): Cake\Http\Runner->run(Object(Cake\Http\MiddlewareQueue), Object(Cake\Http\ServerRequest), Object(App\Application))
#16 .../webroot/index.php(40): Cake\Http\Server->run()
#17 {main}

On old CakePHP version 3.8 auth plugin vas version 1.2 (if i remember correctly) and login was working.

My env

PHP: 7.2.x

Library: 3.1

Provider: github

Provider options:

[
    'options' => []
];

Will update some info later when I get to my machine.

Hey!

Type: code quality

For all OAuth1 providers error as below is shown for getIdentity() method:

Property SocialConnect\OAuth1\AbstractProvider::$consumerToken (SocialConnect\OAuth1\Token) does not accept SocialConnect\Provider\AccessTokenInterface.

for statement

$this->consumerToken = $accessToken;

That's a valid error since SocialConnect\OAuth1\AbstractProvider::$consumerToken property is supposed to be an SocialAuth\OAuth1\Token instance which does not extend the AccessTokenInterface.

I leave it to you to do the needful to fix it :slightly_smiling_face:.

Hey!

Type: code quality

Link to issue:

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the Contributing Guidelines.
• I have checked that another pull request for this purpose does not exist.

Small description of change: Hello I was sad to look at the code and I decided to put it in order a bit Thanks :smiley_cat:

laravel/socialite which provides OAuth authentication for laravel has Stateless Authentication mode. Would be nice if socialconnect/auth also had such a feature.

Hey!

Type: bug fix Link to issue:

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.

Small description of change: Facebook provider generate exception when try parse token. Thanks :smiley_cat:

Hey!

Type: bug fix | new feature | code quality | documentation

Link to issue:

https://github.com/SocialConnect/auth/issues/134

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [x] I wrote some tests for this PR.

Small description of change:

Thanks :smiley_cat:

Hey!

Type: new feature

Link to issue:

• [x ] I have read and understood the Contributing Guidelines.
• [ x] I have checked that another pull request for this purpose does not exist.
• [ ] I wrote some tests for this PR.

Small description of change:

Google returns only one simple string with profile picture instead of Facebook wich returns an object. So i have override "picture" variable in return , and saved the original object into "picture_object" (if you need)

Thanks lamasgergo

Hey!

Type: bug fix

Link to issue: #157

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [ ] I wrote some tests for this PR.

Small description of change:

Update of API Version, see #157

Thanks :smiley_cat:

I think it's a good idea to add new providers (they are very popular now).

Telegram - https://telegram.org

Metamask - https://metamask.io

What does the community and the author think?

Bumps addressable from 2.6.0 to 2.8.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hey!

Type: bug fix

Link to issue: https://github.com/SocialConnect/auth/issues/177#issue-1243331865

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [ ] I wrote some tests for this PR.

Small description of change: Error fix Fatal error: Uncaught TypeError: Argument 1 passed to SocialConnect\OAuth1\AbstractProvider::getAccessToken() must be an instance of SocialConnect\OAuth1\Token, instance of __PHP_Incomplete_Class given, called in /var/www//system/library/social/vendor/socialconnect/auth/src/OAuth1/AbstractProvider.php

Thanks :smiley_cat:

Hey!

Issue

Twitter connection error

Fatal error: Uncaught TypeError: Argument 1 passed to SocialConnect\OAuth1\AbstractProvider::getAccessToken() must be an instance of SocialConnect\OAuth1\Token, instance of __PHP_Incomplete_Class given, called in /var/www/***/system/library/social/vendor/socialconnect/auth/src/OAuth1/AbstractProvider.php on line 273 and defined in /var/www/***/system/library/social/vendor/socialconnect/auth/src/OAuth1/AbstractProvider.php:282 Stack trace: #0 /var/www/***/system/library/social/vendor/socialconnect/auth/src/OAuth1/AbstractProvider.php(273): SocialConnect\OAuth1\AbstractProvider->getAccessToken(Object(__PHP_Incomplete_Class), 'SsTxRkGpkj05tr2...') #1 /var/www/***/catalog/controller/extension/module/sociallogin.php(401): SocialConnect\OAuth1\AbstractProvider->getAccessTokenByRequestParameters(Array) #2 /var/www/***/system/storage/modification/system/engine/action.php(51): ControllerExtensionModuleSociallogin in /var/www/***/system/library/social/vendor/socialconnect/auth/src/OAuth1/AbstractProvider.php on line 282

My env

PHP: 7.4

Library: socialconnect/auth/src/OAuth1/Provider/Twitter.php

Provider: Twitter

Provider options:

[
    'options' => []
];

Thanks :smiley_cat:

Hey!

Issue

Facebook connection error

Fatal error: Uncaught SocialConnect\OAuth2\Exception\InvalidState: State parameter inside Request is not similar to value from Session, possible CSRF attack in /var/www/***/system/library/social/vendor/socialconnect/auth/src/OAuth2/AbstractProvider.php:167 Stack trace: #0 /var/www/***/catalog/controller/extension/module/sociallogin.php(264): SocialConnect\OAuth2\AbstractProvider->getAccessTokenByRequestParameters(Array) #1 /var/www/***/system/storage/modification/system/engine/action.php(51): ControllerExtensionModuleSociallogin->FacebookLogin() #2 /var/www/***/catalog/controller/startup/router.php(25): Action->execute(Object(Registry)) #3 /var/www/***/system/storage/modification/system/engine/action.php(51): ControllerStartupRouter->index() #4 /var/www/***/system/engine/front.php(34): Action->execute(Object(Registry)) #5 /var/www/***/system/engine/front.ph in /var/www/***/system/library/social/vendor/socialconnect/auth/src/OAuth2/AbstractProvider.php on line 167

My env

PHP: 7.4

Library: socialconnect/auth/src/OAuth2/Provider/Facebook.php

Provider: Facebook

Provider options:

[
    'options' => [
						'identity.fields' => [
							'id',
							'email',
							'name',
							'first_name',
							'last_name',
							'picture.width(99999)'
						],
					]
];

Thanks :smiley_cat:

Hey!

Issue

VK provider is throwing an error due to version. Please update it to '5.81'.

( ! ) Warning: Undefined property: stdClass::$response in /www/vendor/socialconnect/auth/src/OAuth2/Provider/Vk.php on line 119 Call Stack ... SocialConnect\OAuth2\Provider\Vk->getIdentity( $accessToken = class SocialConnect\OAuth2\AccessToken { protected $token = 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'; protected $expires = 1652336114; protected $uid = 99999999 } )

My env

PHP: 8

Library: socialconnect/auth/src/OAuth2/Provider/Vk.php

Provider: VK

Provider options:

[
    'options' => [...]
];

Thanks :smiley_cat: