This PR adds the Dutch translations for Wagonwheel.

I have also included some basic locale tests to make sure these are being pulled in correctly.

@ryangjchandler or @Jhnbrn90 do you guys mind having a quick look over the tests I have created please? (If you get a moment) I'm still relatively new to testing and not sure if I've done it the best way possible!

What has been done

• Added GitHub workflow file to run phpunit for every push to master and every PR to the master branch.

This will ensure the test suite is green before merging new code.

Todo

• @Sammyjo20, if you're open to add a codestyle checker as well I was thinking about using the symplify/easy-coding-standard. This codestyle would then also run as part of this GitHub Actions CI. We could also add a Git Hook to make sure newly comitted code adheres to the style and phpunit tests are passing. Let me know what you think that. If you like that idea, I can add that in a next PR.

As discussed in #3, this PR adds:

• Orchestra Testbench
• PHPUnit (+ configuration)
• Model factory for OnlineMailable model
• Basic TestCase.php
• Composer script as a shortcut to run the tests

Dear @Sammyjo20

I would like to add some tests for your package and I see that you want to support Laravel 7 and 8. To be able to use model factories in these tests I suggest we make use of the legacy factories, as described in the readme of Orchestra Testbench.

Alternatively, the repository could be split up in a version that supports up to Laravel 7 and one that supports Laravel 8 and beyond.

With your approval I'd like to submit a PR these days to add some tests using the legacy model factories approach.

What do you think would be best?

To support Dutch language (which is 'nl'), add the following please ^^

<?php

return [
    'message' => 'Is de e-mail niet goed leesbaar?',
    'link'    => 'Bekijk het in de browser',
];

Introduction

This PR allows mailables to never expire, in addition to the currently existing configuration options to specify an amount in days before the mailable expires.

<?php

return [
    /*
     * ...
     * To store indefinitely, set this value to: 0.
     */
    'message_expires_in_days' => 0,
];

What has been done

In this PR there are a lot of files changed, since I took an opportunity to refactor some logic around:

• the dertermination of an expiry date
• the generation of the signed route URL

I'll list the updates I made below:

• Added explanation (doc block) to store mailables indefinitely in config/wagonwheel.php
• Added unit tests for the OnlineMailable model
  • Test that a mailable can have a null expiration date
• Added test to DeleteExpiredMailables command to assure it doesn't delete OnlineMailables with a null expiration date
• Extract logic for determining the expiration date to the OnlineMailable model in a getExpirationDate() method.
• Extract logic for building signed route URL's to the OnlineMailable model itself in a getSignedUrl method.
  • This method returns a temporarySignedRoute when a mailable has a expiration date
  • It returns a signedRoute (which doesn't expire) when a mailable does not have an expiration date
• Removed redundant UrlHelper class
• Updated code to make use of the methods on the OnlineMailable model
• Added feature test for the package, testing that:
  • sent e-mails have an online variant when the SaveForOnlineViewing trait is used
  • mailables with expiration date URL's are valid until the expiration date
  • mailables without expiration date are always accessible

How to test

You can test the functionality within this PR by:

• checking out this branch
• adding the package to a Laravel package (locally) (instructions)
• add the SaveForOnlineViewing trait to a certain Laravel Mailable
• publish the packages configuration php artisan vendor:publish --tag=wagonwheel-config
• change the 'message_expires_in_days' value to 0.
• send the e-mail from the Laravel app (using the log driver or mailtrap of mailhog or ...)
• assert that the database has an expire_at column of null for the mailable in the online_mailables table
• run the command php artisan wagonwheel:delete-expired-mailables
• assert that the command does not delete this mailable
• assert that you can view this e-mail in the browser, by using the generated signed URL (check the logs / mailtrap / mailhog /...)

Notes

It might be well possible that there are other refactors to be made, but I tried to limit refactoring the code to the scope of allowing indefinite availability of online mailables.

Hi, First of all, I would like to thank you for your great work @Sammyjo20 :+1: I tried to install your package, but I encountered a slight problem during the migration of the table. So I decided to propose a simple improvement, so that everyone can install this package without encountering any error from the beginning.

My problem was this one:

SQLSTATE[42000]: Syntax error or access violation: 1067 Invalid default value for 'expires_at' (SQL: create table `online_mailables` (`id` bigint unsigned not null auto_increment primary key, `uuid` char(36) not null, `created_at` timestamp null, `updated_at` timestamp null, `expires_at` timestamp not null, `content` blob not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')

Just set "expires_at" nullable fix it.

Thanks again for your work, See ya!

Hi!

I think you got a problem with the code regarding absolute/relative paths. I'm using for example fedeisas/laravel-mail-css-inliner in combination with your package. This one converts my added css from the public folder into inline styles (e.g: "").

Because the url used to show the mailable is mail/view-online... it fails to load the css file. I've solved the issue by using mix.

mix.sass('resources/scss/app.scss', 'public/css') .copy('public/css', 'public/mail/view-online/css');

Maybe you should include this into the documentation as a known issue or try to solve it :)

I was wondering what you are thinking about this.

The easiest way is publish the view and empty it.

But maybe it is better to make it configurable? Something like wagonwheel.component_placement = none. Or a different key with true/false value.

Let me know and I will start working an a pull request.

This PR adds a test for the DeleteExpiredMailable command and asserts that it can succesfully delete expired mailables, but does not delete non-expired mailables.

@Sammyjo20 in my next PR, I'll write a test for the feature I'm working on, to allow users to store mailables indefinitely.

This PR is dependent on #6 (which should be merged first).