A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.

Detailed description of the problem [REQUIRED]

I have a tag album that seems to be getting null for all size_variants for all child images. I confirmed the size_variants are in db, and images load in their normal albums. This leads to an empty album being displayed. Not all tag albums are effected, and I am not able to reproduce this behavior in a new test tag album.

Sample of json response:

{
   "id":"MQTPtB8HTwEjaZqGyAsQNuzs",
   "show_tags":[
      "Alex"
   ],
   "max_taken_at":null,
   "min_taken_at":null,
   "thumb":{
      "id":"kdQAigqTbenfget2WUJkk5xW",
      "type":"image\/jpeg",
      "thumb":"uploads\/thumb\/a7ccb66be0baead7b7b02e6d264ecede.jpeg",
      "thumb2x":"uploads\/thumb\/[email protected]"
   },
   "photos":[
      {
         "id":"GPjbt0B3KBKQm_iCStmEWZXb",
         "created_at":"2022-05-13T18:13:13.113101-07:00",
         "updated_at":"2022-05-13T18:13:59.488932-07:00",
         "album_id":"NpvFgSmSs1fqocFavGATgq_X",
         "title":"2022-05-13-0034",
         "description":"Red Cliffs, NV",
         "tags":[
            "Alex"
         ],
         "license":"CC-BY-NC-ND-4.0",
         "is_public":0,
         "is_starred":false,
         "iso":null,
         "make":"Nikon",
         "model":"LS-4000",
         "lens":null,
         "aperture":null,
         "shutter":null,
         "focal":null,
         "latitude":null,
         "longitude":null,
         "altitude":null,
         "img_direction":null,
         "location":null,
         "taken_at":"2022-05-01T12:00:00.000000-07:00",
         "taken_at_orig_tz":"America\/Los_Angeles",
         "type":"image\/jpeg",
         "filesize":0,
         "checksum":"a3b4f128860cb566927cd699e7ef19b0d6c15537",
         "original_checksum":"a3b4f128860cb566927cd699e7ef19b0d6c15537",
         "live_photo_content_id":null,
         "live_photo_checksum":null,
         "live_photo_url":null,
         "is_downloadable":true,
         "is_share_button_visible":true,
         "size_variants":{
            "original":null,
            "medium2x":null,
            "medium":null,
            "small2x":null,
            "small":null,
            "thumb2x":null,
            "thumb":null
         },
         "next_photo_id":"656pjb4jIMx_gstz3jS32wkt",
         "previous_photo_id":"Ql4Ef8AQPE-G83yz-lRivhNq"
      },
      {
         "id":"656pjb4jIMx_gstz3jS32wkt",
         "created_at":"2022-05-13T18:13:07.534035-07:00",
         "updated_at":"2022-05-13T18:13:59.452552-07:00",
         "album_id":"NpvFgSmSs1fqocFavGATgq_X",
         "title":"2022-05-13-0031",
         "description":"Red Cliffs, NV",
         "tags":[
            "Alex"
         ],
         "license":"CC-BY-NC-ND-4.0",
         "is_public":0,
         "is_starred":false,
         "iso":null,
         "make":"Nikon",
         "model":"LS-4000",
         "lens":null,
         "aperture":null,
         "shutter":null,
         "focal":null,
         "latitude":null,
         "longitude":null,
         "altitude":null,
         "img_direction":null,
         "location":null,
         "taken_at":"2022-05-01T12:00:00.000000-07:00",
         "taken_at_orig_tz":"America\/Los_Angeles",
         "type":"image\/jpeg",
         "filesize":0,
         "checksum":"4bf5ec7a2678ca6fb386705e932900457174a389",
         "original_checksum":"4bf5ec7a2678ca6fb386705e932900457174a389",
         "live_photo_content_id":null,
         "live_photo_checksum":null,
         "live_photo_url":null,
         "is_downloadable":true,
         "is_share_button_visible":true,
         "size_variants":{
            "original":null,
            "medium2x":null,
            "medium":null,
            "small2x":null,
            "small":null,
            "thumb2x":null,
            "thumb":null
         },
         "previous_photo_id":"GPjbt0B3KBKQm_iCStmEWZXb",
         "next_photo_id":"CcjCgUHwqcO7K8affrREgdCC"
      },

Console error msg: Uncaught TypeError: _photo.size_variants.original is null

In DB: MariaDB [lychee]> select * from size_variants where photo_id='GPjbt0B3KBKQm_iCStmEWZXb'; +-------+--------------------------+------+-------------------------------------------------+-------+--------+----------+ | id | photo_id | type | short_path | width | height | filesize | +-------+--------------------------+------+-------------------------------------------------+-------+--------+----------+ | 63697 | GPjbt0B3KBKQm_iCStmEWZXb | 0 | big/a3b4f128860cb566927cd699e7ef19b0.jpeg | 5632 | 3688 | 7582218 | | 63705 | GPjbt0B3KBKQm_iCStmEWZXb | 1 | medium/[email protected] | 3299 | 2160 | 2253539 | | 63704 | GPjbt0B3KBKQm_iCStmEWZXb | 2 | medium/a3b4f128860cb566927cd699e7ef19b0.jpeg | 1649 | 1080 | 651860 | | 63703 | GPjbt0B3KBKQm_iCStmEWZXb | 3 | small/[email protected] | 1100 | 720 | 316462 | | 63701 | GPjbt0B3KBKQm_iCStmEWZXb | 4 | small/a3b4f128860cb566927cd699e7ef19b0.jpeg | 550 | 360 | 90236 | | 63699 | GPjbt0B3KBKQm_iCStmEWZXb | 5 | thumb/[email protected] | 400 | 400 | 65902 | | 63698 | GPjbt0B3KBKQm_iCStmEWZXb | 6 | thumb/a3b4f128860cb566927cd699e7ef19b0.jpeg | 200 | 200 | 20629 | +-------+--------------------------+------+-------------------------------------------------+-------+--------+----------+

Steps to reproduce the issue

Steps to reproduce the behavior: I am not sure what triggered this condition or what it is choking on.

Screenshots If applicable, add screenshots to help explain your problem.

Output of the diagnostics [REQUIRED]

Diagnostics
-----------
Warning: Dropbox import not working. dropbox_key is empty.
Warning: zend.assertions is disabled although Lychee is in debug mode. For easier debugging code generation for assertions should be enabled.

System Information
------------------
Lychee Version (git):            master (2fdd6bc) --  - Up to date (13 seconds ago).
DB Version:                      4.5.1

composer install:                dev
APP_ENV:                         production
APP_DEBUG:                       true

System:                          Linux
PHP Version:                     8.1
PHP User agent:                  Lychee/4 (https://lycheeorg.github.io/)
Timezone:                        America/Los_Angeles
Max uploaded file size:          500M
Max post size:                   500M
Max execution time:              200
MySQL Version:                   10.6.7-MariaDB-2ubuntu1

Imagick:                         1
Imagick Active:                  1
Imagick Version:                 1691
GD Version:                      2.3.0

Config Information
------------------
version:                         040501
check_for_updates:               1
sorting_photos_col:              created_at
sorting_photos_order:            DESC
sorting_albums_col:              max_taken_at
sorting_albums_order:            DESC
imagick:                         1
skip_duplicates:                 1
small_max_width:                 0
small_max_height:                360
medium_max_width:                1920
medium_max_height:               1080
lang:                            en
layout:                          1
image_overlay_type:              none
default_license:                 CC-BY-NC-ND-4.0
compression_quality:             90
full_photo:                      1
delete_imported:                 1
Mod_Frame:                       1
Mod_Frame_refresh:               30
thumb_2x:                        1
small_2x:                        1
medium_2x:                       1
landing_page_enable:             1
landing_owner:                   Vincent Juliano
landing_title:                   Life on 35mm
landing_subtitle:                Click top right to continue.  Next page top left to login
landing_facebook:                
landing_flickr:                  
landing_twitter:                 
landing_instagram:               
landing_youtube:                 
landing_background:              /uploads/medium/3d4bf4e35e5ea06853d7983c88efb6a2.jpg
site_title:                      Vince Juliano's Photo Gallery
site_copyright_enable:           1
site_copyright_begin:            2021
site_copyright_end:              2022
additional_footer_text:          "Alex's Photos" copyright Alex Panicacci 2022
display_social_in_gallery:       0
public_search:                   0
SL_enable:                       0
SL_for_admin:                    0
public_recent:                   0
recent_age:                      60
public_starred:                  0
downloadable:                    1
photos_wraparound:               1
map_display:                     1
zip64:                           1
map_display_public:              1
map_provider:                    Wikimedia
force_32bit_ids:                 0
map_include_subalbums:           1
update_check_every_days:         3
has_exiftool:                    1
share_button_visible:            1
import_via_symlink:              0
has_ffmpeg:                      1
location_decoding:               1
location_decoding_timeout:       30
location_show:                   1
location_show_public:            1
rss_enable:                      0
rss_recent_days:                 7
rss_max_items:                   100
prefer_available_xmp_metadata:   0
editor_enabled:                  1
lossless_optimization:           1
swipe_tolerance_x:               150
swipe_tolerance_y:               250
local_takestamp_video_formats:   .avi|.mov
log_max_num_line:                10000
unlock_password_photos_with_url_param: 0
nsfw_visible:                    0
nsfw_blur:                       0
nsfw_warning:                    0
nsfw_warning_admin:              0
map_display_direction:           1
album_subtitle_type:             oldstyle
upload_processing_limit:         4
public_photos_hidden:            1
new_photos_notification:         1
legacy_id_redirection:           1

Browser and system

Firefox 100.0 Mac Os 12.3.1

Detailed description of the problem [REQUIRED]

After updating uploading a new image gives an error. There is no thumbnail created, the space for the photo in the album is black. However if you click on this space, the uploaded image is shown. So somehow the thumbnail is not created.

Steps to reproduce the issue

Steps to reproduce the behavior:

1. Go to an album
2. Click on the plus and upload an image from the local machine.
3. Error in webserver log: Sun 16 Jan 2022 10:03:57 +0100|CGI returned 500 Internal Error

Screenshots

Output of the diagnostics [REQUIRED]

sudo -u www php artisan lychee:diagnostics

Diagnostics

Info: Latest version of PHP is 8.1

System Information

Lychee Version (git): master (a7de020) - Up to date (2 days ago). DB Version: 4.4.0

composer install: --no-dev APP_ENV: local APP_DEBUG: false

System: FreeBSD PHP Version: 8 PHP User agent: Lychee/4 (https://lycheeorg.github.io/) Max uploaded file size: 100M Max post size: 100M Max execution time: 0 MySQL Version: 8.0.27

Imagick: 1 Imagick Active: 1 Imagick Version: 1692 GD Version: 2.3.1

Config Information

version: 040400 check_for_updates: 1 sorting_Photos_col: taken_at sorting_Photos_order: ASC sorting_Albums_col: title sorting_Albums_order: DESC imagick: 1 skip_duplicates: 0 small_max_width: 0 small_max_height: 360 medium_max_width: 1920 medium_max_height: 1080 lang: en layout: 1 image_overlay_type: date default_license: none compression_quality: 90 full_photo: 1 delete_imported: 0 Mod_Frame: 1 Mod_Frame_refresh: 30 thumb_2x: 1 small_2x: 1 medium_2x: 1 landing_page_enable: 1 landing_owner: Marc landing_title: Marc landing_subtitle:
landing_facebook:
landing_flickr:
landing_twitter:
landing_instagram:
landing_youtube:
landing_background: dist/finland.jpg site_title: fotos site_copyright_enable: 1 site_copyright_begin: 1984 site_copyright_end: 2021 additional_footer_text:
display_social_in_gallery: 0 public_search: 0 SL_enable: 0 SL_for_admin: 0 public_recent: 0 recent_age: 1 public_starred: 0 downloadable: 0 photos_wraparound: 1 map_display: 0 zip64: 1 map_display_public: 0 map_provider: OpenStreetMap.org force_32bit_ids: 0 map_include_subalbums: 0 update_check_every_days: 3 has_exiftool: 1 share_button_visible: 0 import_via_symlink: 0 has_ffmpeg: 0 location_decoding: 0 location_decoding_timeout: 30 location_show: 0 location_show_public: 0 rss_enable: 0 rss_recent_days: 7 rss_max_items: 100 prefer_available_xmp_metadata: 0 editor_enabled: 1 lossless_optimization: 0 swipe_tolerance_x: 150 swipe_tolerance_y: 250 local_takestamp_video_formats: .avi|.mov log_max_num_line: 1000 unlock_password_photos_with_url_param: 0 nsfw_visible: 1 nsfw_blur: 0 nsfw_warning: 0 nsfw_warning_admin: 0 map_display_direction: 1 album_subtitle_type: oldstyle upload_processing_limit: 4 public_photos_hidden: 1 new_photos_notification: 0

Browser and system

Browser: Firefox 91.0.1 Server: FreeBSD 13.0

Detailed description of the problem [REQUIRED]

Issue 1: Missing thumbs on map. Right click on the thumb and click show picture in new tab, it showed "404 not found", and the URL is http://x.x.x.x/null.

Issue 2: Thumbs of album covers are sometimes missing and sometimes normal. After manually specifying a photo as the cover, the cover thumb can be displayed all the time.

Issue 3: Nothing in some albums, but other albums are normal.

Issue 4: Sometimes I got "Server error or API not found" error during importing photos from server, or just during I visist the website. It will disappear after a webpage reloading.

My thoughts: I'm wondering if it is because I uploaded too many photos. The album mentioned in issue 2 has about 1150 photos. And there are about 6500 photos in the whole server. I remember the thumbs on map were normally showing on the day before yesterday. I only uploaded 100 photos at that time. Yesterday I reinstall the server and then import all of my photos. So I don't know if it's the reason. Another possibility about issue 1: Because I'm using TrueNAS, I mounted extenal strorage to these paths:

• ../uploads/import
• ../uploads/big
• ../uploads/medium
• ../uploads/small
• ../uploads/raw
• ../uploads/thumbs

I don't know if thumbs on map are stored in ../uploads/thumbs, or somewhere else.

Steps to reproduce the issue

Steps to reproduce the behavior: Issue 1: Click on map. Issue 2: Just visit Lychee. Issue 3: Just open an album. Issue 4: Click "import from server" or just switch albums or click on settings, logs and so on.

Screenshots Issue 1:

Issue 2: Missing:

Normal after reloading webpage several times:

Issue 3: Problematic album: At first a blue process line showed on the top.

Then an video album with blank thumb appeared, then disappeard very soon (about 0.1s).

Then nothing here.

Normal albums:

Issue 4: Don't have chance to screenshot yet.

Output of the diagnostics [REQUIRED]

Diagnostics
-------
Warning: Dropbox import not working. dropbox_key is empty.
Info: Latest version of PHP is 8.1



System Information
--------------
Lychee Version (git):            master (e150930) - Data not in Cache
DB Version:                      4.5.0

composer install:                --no-dev
APP_ENV:                         production
APP_DEBUG:                       false

System:                          FreeBSD
PHP Version:                     8
PHP User agent:                  Lychee/4 (https://lycheeorg.github.io/)
Timezone:                        Asia/Shanghai
Max uploaded file size:          10240M
Max post size:                   10240M
Max execution time:              300
MySQL Version:                   10.4.24-MariaDB

Imagick:                         1
Imagick Active:                  1
Imagick Version:                 1692
GD Version:                      2.3.1

Browser and system

Microsoft Edge 99.0.1150.55 on Windows 10

Detailed description of the problem

Updating breaks Lychee. ( thank $deity for backups and databasedumps)

Steps to reproduce the issue

Steps to reproduce the behavior:

1. log on to (working) Lychee
2. Click on 'update'
3. After updating there is an error about missing admin in the database. please run: php artisan lychee:reset_admin
4. Error page:database out of date.

Screenshots If applicable, add screenshots to help explain your problem.

Output of the diagnostics

Diagnostics

Info: Latest version of PHP is 8.1

System Information

Lychee Version (git): master (a7de020) - Up to date (13 hours ago). DB Version: 4.4.0

composer install: --no-dev APP_ENV: local APP_DEBUG: false

System: FreeBSD PHP Version: 8 PHP User agent: Lychee/4 (https://lycheeorg.github.io/) Max uploaded file size: 100M Max post size: 100M Max execution time: 0 MySQL Version: 8.0.27

Imagick: 1 Imagick Active: 1 Imagick Version: 1692 GD Version: 2.3.1

Config Information

version: 040400 check_for_updates: 1 sorting_Photos_col: taken_at sorting_Photos_order: ASC sorting_Albums_col: title sorting_Albums_order: DESC imagick: 1 skip_duplicates: 0 small_max_width: 0 small_max_height: 360 medium_max_width: 1920 medium_max_height: 1080 lang: en layout: 1 image_overlay_type: date default_license: none compression_quality: 90 full_photo: 1 delete_imported: 0 Mod_Frame: 1 Mod_Frame_refresh: 30 thumb_2x: 1 small_2x: 1 medium_2x: 1 landing_page_enable: 1 landing_owner: Marc landing_title: Marc landing_subtitle: Why stop now? landing_facebook: landing_flickr: landing_twitter: landing_instagram: landing_youtube: landing_background: dist/finland.jpg site_title: fotos site_copyright_enable: 1 site_copyright_begin: 1984 site_copyright_end: 2021 additional_footer_text:
display_social_in_gallery: 0 public_search: 0 SL_enable: 0 SL_for_admin: 0 public_recent: 0 recent_age: 1 public_starred: 0 downloadable: 0 photos_wraparound: 1 map_display: 0 zip64: 1 map_display_public: 0 map_provider: OpenStreetMap.org force_32bit_ids: 0 map_include_subalbums: 0 update_check_every_days: 3 has_exiftool: 1 share_button_visible: 0 import_via_symlink: 0 has_ffmpeg: 0 location_decoding: 0 location_decoding_timeout: 30 location_show: 0 location_show_public: 0 rss_enable: 0 rss_recent_days: 7 rss_max_items: 100 prefer_available_xmp_metadata: 0 editor_enabled: 1 lossless_optimization: 0 swipe_tolerance_x: 150 swipe_tolerance_y: 250 local_takestamp_video_formats: .avi|.mov log_max_num_line: 1000 unlock_password_photos_with_url_param: 0 nsfw_visible: 1 nsfw_blur: 0 nsfw_warning: 0 nsfw_warning_admin: 0 map_display_direction: 1 album_subtitle_type: oldstyle upload_processing_limit: 4 public_photos_hidden: 1 new_photos_notification: 0

Browser and system

Browser: Firefox 96.0

Albums::get (and thus the main gallery view) times out when there are a lot of albums and/or photos.

I started uploading a lot of older albums to Lychee recently, and now I can no longer see the album list when logged in. When not logged in, the gallery does load quickly (but shows no albums, since all are private still).

The problematic gallery has 232 albums (nested a few levels deep) with 8701 photographs in total.

The failing URL is /api/Albums::get, which returns 500. The error log says:

PHP Fatal error:  Maximum execution time of 30 seconds exceeded in /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Application.php on line 753
PHP Stack trace:
PHP   1. {main}() /Lychee-Laravel/public/index.php:0
PHP   2. App\Http\Kernel->handle() /Lychee-Laravel/public/index.php:53
PHP   3. App\Http\Kernel->sendRequestThroughRouter() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:116
PHP   4. Illuminate\Routing\Pipeline->then() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:151
PHP   5. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:104
PHP   6. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP   7. Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP   8. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php:62
PHP   9. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  10. Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  11. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php:27
PHP  12. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  13. App\Http\Middleware\TrimStrings->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  14. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php:21
PHP  15. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  16. Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  17. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php:21
PHP  18. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  19. App\Http\Middleware\TrustProxies->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  20. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/fideloper/proxy/src/TrustProxies.php:57
PHP  21. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  22. Bepsvpt\SecureHeaders\SecureHeadersMiddleware->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  23. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:28-36}() /Lychee-Laravel/vendor/bepsvpt/secure-headers/src/SecureHeadersMiddleware.php:21
PHP  24. App\Http\Kernel->Illuminate\Foundation\Http\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:173-177}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:30
PHP  25. Illuminate\Routing\Router->dispatch() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:176
PHP  26. Illuminate\Routing\Router->dispatchToRoute() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Router.php:612
PHP  27. Illuminate\Routing\Router->runRoute() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Router.php:623
PHP  28. Illuminate\Routing\Router->runRouteWithinStack() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Router.php:657
PHP  29. Illuminate\Routing\Pipeline->then() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Router.php:682
PHP  30. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:104
PHP  31. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  32. App\Http\Middleware\EncryptCookies->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  33. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php:66
PHP  34. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  35. Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  36. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php:37
PHP  37. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  38. Illuminate\Session\Middleware\StartSession->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  39. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php:56
PHP  40. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  41. Illuminate\View\Middleware\ShareErrorsFromSession->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  42. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php:49
PHP  43. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  44. Illuminate\Session\Middleware\AuthenticateSession->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  45. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Session/Middleware/AuthenticateSession.php:39
PHP  46. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  47. App\Http\Middleware\VerifyCsrfToken->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  48. App\Http\Middleware\VerifyCsrfToken->handle() /Lychee-Laravel/app/Http/Middleware/VerifyCsrfToken.php:60
PHP  49. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:47-59}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php:75
PHP  50. Illuminate\Routing\Pipeline->Illuminate\Pipeline\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:140-169}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:53
PHP  51. Illuminate\Routing\Middleware\SubstituteBindings->handle() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:163
PHP  52. Illuminate\Routing\Pipeline->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:28-36}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php:41
PHP  53. Illuminate\Routing\Router->Illuminate\Routing\{closure:/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Router.php:678-682}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php:30
PHP  54. Illuminate\Routing\Route->run() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Router.php:680
PHP  55. Illuminate\Routing\Route->runController() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Route.php:176
PHP  56. Illuminate\Routing\ControllerDispatcher->dispatch() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Route.php:219
PHP  57. App\Http\Controllers\AlbumsController->callAction() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php:45
PHP  58. call_user_func_array:{/Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Controller.php:54}() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Controller.php:54
PHP  59. App\Http\Controllers\AlbumsController->get() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Routing/Controller.php:54
PHP  60. App\ModelFunctions\AlbumFunctions->prepare_albums() /Lychee-Laravel/app/Http/Controllers/AlbumsController.php:55
PHP  61. App\ModelFunctions\AlbumFunctions->get_albums() /Lychee-Laravel/app/ModelFunctions/AlbumFunctions.php:245
PHP  62. App\ModelFunctions\AlbumFunctions->get_sub_albums() /Lychee-Laravel/app/ModelFunctions/AlbumFunctions.php:446
PHP  63. App\ModelFunctions\AlbumFunctions->get_sub_albums() /Lychee-Laravel/app/ModelFunctions/AlbumFunctions.php:516
PHP  64. App\ModelFunctions\AlbumFunctions->get_sub_albums() /Lychee-Laravel/app/ModelFunctions/AlbumFunctions.php:516
PHP  65. App\ControllerFunctions\ReadAccessFunctions->album() /Lychee-Laravel/app/ModelFunctions/AlbumFunctions.php:510
PHP  66. App\ModelFunctions\SessionFunctions->is_current_user() /Lychee-Laravel/app/ControllerFunctions/ReadAccessFunctions.php:68
PHP  67. Illuminate\Support\Facades\Facade::get() /Lychee-Laravel/app/ModelFunctions/SessionFunctions.php:70
PHP  68. Illuminate\Support\Facades\Facade::__callStatic() /Lychee-Laravel/app/ModelFunctions/SessionFunctions.php:70
PHP  69. Illuminate\Session\SessionManager->get() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:237
PHP  70. Illuminate\Session\SessionManager->__call() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:237
PHP  71. Illuminate\Session\SessionManager->driver() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Support/Manager.php:146
PHP  72. Illuminate\Session\SessionManager->getDefaultDriver() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Support/Manager.php:59
PHP  73. Illuminate\Foundation\Application->offsetGet() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Session/SessionManager.php:210
PHP  74. Illuminate\Foundation\Application->make() /Lychee-Laravel/vendor/laravel/framework/src/Illuminate/Container/Container.php:1233

Output of the diagnostics

I can't access the settings right now, since the mainpage fails to load...

I know i am being a bit of invasive lately.... Sorry the covid stay at home is pushing me to work harder on my photos....

Anyway, is there a way to rotate images after they have been uploaded? I find sometimes some photos are rotated, specially from my analog film scanned, and it would be a nice feature to be able to rotate them in Lychee....

Just to be nice...

• The workflow is disabled so the code still passes CI.
• Once merged in master this will allow to then merge in WIP branches and hopefully decrease the conflicts.

In order to run it just do: make phpstan (and cry)

The rules so far are:

1. basic checks, unknown classes, unknown functions, unknown methods called on $this, wrong number of arguments passed to those methods and functions, always undefined variables
2. possibly undefined variables, unknown magic methods and properties on classes with __call and __get
3. unknown methods checked on all expressions (not just $this), validating PHPDocs return types, types assigned to properties
4. basic dead code checking - always false instanceof and other type checks, dead else branches, unreachable code after return; etc.
5. checking types of arguments passed to methods and functions
6. report missing typehints
7. report partially wrong union types - if you call a method that only exists on some types in a union type, level 7 starts to report that; other possibly incorrect situations

Also the following: https://github.com/phpstan/phpstan-strict-rules

• Require booleans in if, elseif, ternary operator, after !, and on both sides of && and ||.
• Require numeric operands or arrays in + and numeric operands in -/*///**/%.
• Require numeric operand in $var++, $var--, ++$varand --$var.
• These functions contain a $strict parameter for better type safety, it must be set to true:
  • in_array (3rd parameter)
  • array_search (3rd parameter)
  • array_keys (3rd parameter; only if the 2nd parameter $search_value is provided)
  • base64_decode (2nd parameter)
• Variables assigned in while loop condition and for loop initial assignment cannot be used after the loop.
• Variables set in foreach that's always looped thanks to non-empty arrays cannot be used after the loop.
• Types in switch condition and case value must match. PHP compares them loosely by default and that can lead to unexpected results.
• Check that statically declared methods are called statically.
• ~~Disallow empty() - it's a very loose comparison (see manual), it's recommended to use more strict one.~~
• ~~Disallow short ternary operator (?:) - implies weak comparison, it's recommended to use null coalesce operator (??) or ternary operator with strict condition.~~
• Disallow variable variables ($$foo, $this->$method() etc.)
• Disallow overwriting variables with foreach key and value variables
• Always true instanceof, type-checking is_* functions and strict comparisons ===/!==. These checks can be turned off by setting checkAlwaysTrueInstanceof/checkAlwaysTrueCheckTypeFunctionCall/checkAlwaysTrueStrictComparison to false.
• Correct case for referenced and called function names.
• Correct case for inherited and implemented method names.
• ~~Contravariance for parameter types and covariance for return types in inherited methods (also known as Liskov substitution principle - LSP)~~
• Check LSP even for static methods
• Require calling parent constructor
• Disallow usage of backtick operator ($ls = `ls -la`)
• Closure should use $this directly instead of using $this variable indirectly

Fruthermore:

• Enforce the use of \Safe\functions when available.

Detailed description of the problem [REQUIRED]

main.js?1597871784:2 POST /public/api/Albums::get 400 (Bad Request)

I get this error and then the page reloads immediately after. I also get a glimpse of an error saying "ERROR: Session Time Out"

Also, I am using the MYSQL method to connect to database. It worked for creating all the tables just fine, so I'm not sure why it would say "username" and "password" is empty in DIAGNOSTICS since it didn't have that issue when creating the tables... I was curious though, MYSQL is actually depreciated since PHP 7.0, so does the mysql method actually use MYSQLI??

Steps to reproduce the issue

After initial setup is done, I go to the /public folder again and it'll pop up the create account dialog, but then immediately go into a reload loop with the above errors

Output of the diagnostics [REQUIRED]

Diagnostics ----------- Error: username empty or not set in database Error: password empty or not set in database Warning: Dropbox import not working. dropbox_key is empty. Warning: Pictures that are rotated lose their metadata! Please install Imagick to avoid that.

System Information
------------------
Lychee Version (release):   4.0.6
DB Version:                 4.0.6

composer install:           --no-dev
APP_ENV:                    production
APP_DEBUG:                  false

System:                     Linux
PHP Version:                7.4
MySQL Version:              5.6.49-cll-lve

Imagick:                    -
Imagick Active:             1
Imagick Version:            -
GD Version:                 2.2.5

Config Information
------------------
version:                    040006
check_for_updates:          0
sorting_Photos_col:         takestamp
sorting_Photos_order:       ASC
sorting_Albums_col:         max_takestamp
sorting_Albums_order:       ASC
imagick:                    1
skip_duplicates:            0
small_max_width:            0
small_max_height:           360
medium_max_width:           1920
medium_max_height:          1080
lang:                       en
layout:                     1
image_overlay:              1
image_overlay_type:         desc
default_license:            none
compression_quality:        90
full_photo:                 1
delete_imported:            0
Mod_Frame:                  1
Mod_Frame_refresh:          30
thumb_2x:                   1
small_2x:                   1
medium_2x:                  1
landing_page_enable:        0
landing_owner:              John Smith
landing_title:              John Smith
landing_subtitle:           Cats, Dogs & Humans Photography
landing_facebook:           https://www.facebook.com/JohnSmith
landing_flickr:             https://www.flickr.com/JohnSmith
landing_twitter:            https://www.twitter.com/JohnSmith
landing_instagram:          https://instagram.com/JohnSmith
landing_youtube:            https://www.youtube.com/JohnSmith
landing_background:         dist/cat.jpg
site_title:                 Lychee v4
site_copyright_enable:      1
site_copyright_begin:       2019
site_copyright_end:         2019
additional_footer_text:     
display_social_in_gallery:  0
public_search:              0
SL_enable:                  0
SL_for_admin:               0
public_recent:              0
recent_age:                 1
public_starred:             0
downloadable:               0
photos_wraparound:          1
map_display:                0
zip64:                      1
map_display_public:         0
map_provider:               Wikimedia
force_32bit_ids:            0
map_include_subalbums:      0
update_check_every_days:    3
has_exiftool:               0
share_button_visible:       0
import_via_symlink:         0
has_ffmpeg:                 0
location_decoding:          0
location_decoding_timeout:  30
location_show:              1
location_show_public:       0
rss_enable:                 0
rss_recent_days:            7
rss_max_items:              100
prefer_available_xmp_metadata: 0

fixes https://github.com/LycheeOrg/Lychee/issues/60

This is the follow up of #1309. The file objects for images use file streams internally and therewith save a lot of read-write cycles to disk. Previously, every image operation followed the pattern: read file, do image operation, write file. Now, the image file is loaded once, all image operations are done in memory and then the various target files (i.e. the original and the size variants) are written once.

In the long run, this approach will also allow to store the media files on a non-local storage (such as AWS 3). The old approach would have triggered a complete file transfer for every elementary image operation.

I promised 85% test coverage for the source code in /app/Actions/Photo and /app/Image. I already have pushed /app/Actions/Photo above 90%. :tada: The coverage of /app/Image is still as low as it always has been. But I am going to push more tests to the PR. Nonetheless the PR is ready for review.

A change being worth of discussion

This PR includes a change in the naming strategy which needs discussion. We already had a discussion about that on Gitter. Previously, the name of the image files was based on the checksum of the final image (i.e. after optional auto-rotation, etc.) With the new approach the final checksum is unknown until the image stream has been written onto disk which means that the file cannot be named after the checksum. (Well, it could, but at the cost of higher code complexity.)

Now, the image files are named randomly. This PR includes three different naming strategies. Eventually, I only want to include one naming strategy in order to reduce test and maintenance efforts:

1. SizeVariantFullyRandomNamingStrategy: As the name suggests every image file (incl. the different size variants) is named completely random. There is no way to tell if two image files are size variants of the same photo. The directory structure of /uploads/ contains two level of sub-directories from /uploads/aa/aa/... through /uploads/ff/ff/.... This avoids thousands of files in a single directory. The directories are created on-the-fly as necessary. The old directories /uploads/thumb, /uploads/small, ..., /uploads/big are not used anymore, but they remain in place for existing photos which already have been uploaded. There is no migration of existing photos to the new naming scheme.
2. SizeVariantSharedPrefixRandomNamingStrategy: Similar to the first strategy except that files for different size variants of the same photo share an identical random prefix and then use a suffix to distinguish the different size variants, i.e. file names look like uploads/<xx>/<yy>/<zzzzzzzzzzz>-{full|medium2x|medium|small2x|small|thumb2x|thumb}.ext. This allows to easily identify files which "belong together". In particular size variants of the same photo are placed in the same sub-directory next to each other.
3. SizeVariantGroupedRandomNamingStrategy: Very similar to the old strategy, except that the file name is not based on the checksum of the original size variant but chosen randomly. Except for that the files are still placed in the traditional directories /uploads/small, ..., /uploads/big and use a @2x-infix for the HiDPI-variants.

Currently, the strategy SizeVariantSharedPrefixRandomNamingStrategy is active, because it is my favorite. But we can discuss that.

• start using Livewire for the front-end, for now accessible at example.com/livewire if enabled via LIVEWIRE_ENABLED in .env
• use Facade AccessControl to access Session information (basically home-brewed Auth)
• use Facade Lang to access Lang information (Easier to use through the blade template)
• heavy refactoring of the core, introducing more granularity:
  • Interfaces are Contracts
  • Group Factories
  • use trait on album for smaller dedicated operations
  • add Nested Set theory to Album to allow access to all descendants

Will probably be a bump to version 4.2.0 to be honest given the amount of change applied.

Additionally fixes #843

This is a simpler variant of the "Additional login screen" PR (https://github.com/LycheeOrg/Lychee/pull/1325) by hfr which we closed. It allows to hide every public album and photo from users not logged in.

Unfortunately, the way how to get empty result sets are very bad. For example, $query2->where('null', '=', 'never-true');. Is there a way to get empty result sets with "native" code?

Detailed description of the problem [REQUIRED]

The new photos weekly email has all broken thumbnails. It looks like they link back to password protected files. As none of my photos are in public albums, it makes this email sort of pointless. Could we generate public thumbnails for the email or somehow handle this better?

Steps to reproduce the issue

Steps to reproduce the behavior:

1. Add private photos
2. Open weekly notification email
3. See none of the thumbnails load

Screenshots

Output of the diagnostics [REQUIRED]

Diagnostics
-------
Warning: Dropbox import not working. dropbox_key is empty.
Info: Latest version of PHP is 8.2




System Information
--------------
Lychee Version (git):                    local (2902bee) -- Could not compare.
DB Version:                              4.6.5

composer install:                        dev
APP_ENV:                                 production
APP_DEBUG:                               false

System:                                  Linux
PHP Version:                             8.1.13
PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                America/Los_Angeles
Max uploaded file size:                  200M
Max post size:                           200M
Max execution time:                      200
MySQL Version:                           10.9.4-MariaDB-1:10.9.4+maria~ubu2204

exec() Available:                        yes
Imagick Available:                       1
Imagick Enabled:                         1
Imagick Version:                         1691
GD Version:                              2.3.3
Number of foreign key:                   26 found.




Config Information
--------------
version:                                 040605
check_for_updates:                       1
sorting_photos_col:                      created_at
sorting_photos_order:                    DESC
sorting_albums_col:                      max_taken_at
sorting_albums_order:                    DESC
imagick:                                 1
skip_duplicates:                         1
small_max_width:                         0
small_max_height:                        360
medium_max_width:                        1920
medium_max_height:                       1080
lang:                                    en
layout:                                  1
image_overlay_type:                      none
default_license:                         CC-BY-NC-ND-4.0
compression_quality:                     90
grants_full_photo_access:                1
delete_imported:                         1
mod_frame_enabled:                       1
mod_frame_refresh:                       30
thumb_2x:                                1
small_2x:                                1
medium_2x:                               1
landing_page_enable:                     1
site_owner:                              Vincent Juliano
landing_title:                           Life on 35mm
landing_subtitle:                        Click top right to continue.  Next page top left to login
sm_facebook_url:                         
sm_flickr_url:                           
sm_twitter_url:                          
sm_instagram_url:                        
sm_youtube_url:                          
landing_background:                      dist/cat.webp
site_title:                              Vince Juliano's Photo Gallery
footer_show_copyright:                   1
site_copyright_begin:                    2021
site_copyright_end:                      2023
footer_additional_text:                  "Alex's Photos" copyright Alex Panicacci 2022
footer_show_social_media:                0
public_search:                           0
SL_enable:                               0
SL_for_admin:                            0
public_recent:                           0
recent_age:                              60
public_starred:                          0
grants_download:                         1
photos_wraparound:                       1
map_display:                             1
zip64:                                   1
map_display_public:                      1
map_provider:                            Wikimedia
force_32bit_ids:                         0
map_include_subalbums:                   1
update_check_every_days:                 3
has_exiftool:                            1
share_button_visible:                    1
import_via_symlink:                      0
has_ffmpeg:                              1
location_decoding:                       1
location_decoding_timeout:               30
location_show:                           1
location_show_public:                    1
rss_enable:                              0
rss_recent_days:                         7
rss_max_items:                           100
prefer_available_xmp_metadata:           0
editor_enabled:                          1
lossless_optimization:                   1
swipe_tolerance_x:                       150
swipe_tolerance_y:                       250
local_takestamp_video_formats:           .avi|.mov
log_max_num_line:                        10000
unlock_password_photos_with_url_param:   0
nsfw_visible:                            0
nsfw_blur:                               0
nsfw_warning:                            0
nsfw_warning_admin:                      0
nsfw_banner_override:                    
map_display_direction:                   1
album_subtitle_type:                     oldstyle
upload_processing_limit:                 4
public_photos_hidden:                    1
new_photos_notification:                 1
legacy_id_redirection:                   1
zip_deflate_level:                       6
SA_enabled:                              1
default_album_protection:                1
allow_username_change:                   1

About

Browser and system

Server: Ubuntu Server 22.10 Lychee 4.6.5 Client: MacOs 12.6.2 Firefox 108.0.1

Explain in a few words which functionality or improvements you would like to see in Lychee. Would there be an option to send photos directly from the gallery of an iPhone or Android Gallery to our personal Lychee website ?

Detailed description of the problem

While trying to get to the bottom of #1674, I stumbled across this curious issue. Normally, closing the sidebar refreshes to the home page. However, following the below steps will close the sidebar without refreshing--and you're unable to open the sidebar again. In order to navigate away, you need to refresh the browser or otherwise alter the URL directly.

Steps to reproduce the issue

1. Log in as admin
2. Click settings cog on top left
3. Open an album
4. Click "Settings", "Users", "U2F", "Sharing", "Show Logs", or "Diagnostics" on the left sidebar
5. Click "Close" on the left sidebar (NOT the chevron to the right of the sidebar)
6. Click the chevron on the top left and the sidebar will not open

Screenshots After step 3, an album and the side bar are opened

Opened the logs after step 4. Note how the URL has not changed.

Following step 5, sidebar is closed, log screen is still open, and the URL has not changed. Clicking the chevron changes the color but otherwise does nothing.

Output of the diagnostics

Diagnostics
-------
Warning: Dropbox import not working. dropbox_key is empty.
Info: Latest version of PHP is 8.2


System Information
--------------
Lychee Version (git):                    master (6ca3066) -- 1 commits behind 923bfb4 (11 seconds ago)
DB Version:                              4.6.5

composer install:                        --no-dev
APP_ENV:                                 production
APP_DEBUG:                               false

System:                                  Linux
PHP Version:                             8.1.13
PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                America/Chicago
Max uploaded file size:                  500M
Max post size:                           500M
Max execution time:                      200
MySQL Version:                           8.0.31-0ubuntu0.20.04.2

exec() Available:                        yes
Imagick Available:                       1
Imagick Enabled:                         1
Imagick Version:                         1690
GD Version:                              2.3.3
Number of foreign key:                   11 found.

Lychee total space:                      37.72 GB
Upload folder space:                     37.56 GB
System total space:                      72.50 GB
System free space:                       22.96 GB (31%)


Config Information
--------------
version:                                 040605
check_for_updates:                       1
sorting_photos_col:                      taken_at
sorting_photos_order:                    ASC
sorting_albums_col:                      max_taken_at
sorting_albums_order:                    ASC
imagick:                                 1
skip_duplicates:                         0
small_max_width:                         0
small_max_height:                        360
medium_max_width:                        1920
medium_max_height:                       1080
lang:                                    en
layout:                                  1
image_overlay_type:                      date
default_license:                         CC-BY-NC-SA-4.0
compression_quality:                     90
grants_full_photo_access:                1
delete_imported:                         0
mod_frame_enabled:                       1
mod_frame_refresh:                       30
thumb_2x:                                1
small_2x:                                1
medium_2x:                               1
landing_page_enable:                     0
site_owner:                              [Fname] [Lname]
landing_title:                           [Name]'s Photos!
landing_subtitle:                        Pictures and movies of various trips
sm_facebook_url:                         https://www.facebook.com/[user]
sm_flickr_url:                           
sm_twitter_url:                          https://www.twitter.com/[user]
sm_instagram_url:                        
sm_youtube_url:                          
landing_background:                      dist/cat.webp
site_title:                              [Name]'s Photos
footer_show_copyright:                   1
site_copyright_begin:                    2019
site_copyright_end:                      2022
footer_additional_text:                  
footer_show_social_media:                0
public_search:                           0
SL_enable:                               0
SL_for_admin:                            0
public_recent:                           0
recent_age:                              1
public_starred:                          0
grants_download:                         0
photos_wraparound:                       1
map_display:                             1
zip64:                                   1
map_display_public:                      0
map_provider:                            Wikimedia
force_32bit_ids:                         0
map_include_subalbums:                   1
update_check_every_days:                 3
has_exiftool:                            0
share_button_visible:                    1
import_via_symlink:                      0
has_ffmpeg:                              1
location_decoding:                       1
location_decoding_timeout:               30
location_show:                           0
location_show_public:                    0
rss_enable:                              0
rss_recent_days:                         7
rss_max_items:                           100
prefer_available_xmp_metadata:           0
editor_enabled:                          1
lossless_optimization:                   0
swipe_tolerance_x:                       150
swipe_tolerance_y:                       250
local_takestamp_video_formats:           .avi|.mov
log_max_num_line:                        1000
unlock_password_photos_with_url_param:   0
nsfw_visible:                            0
nsfw_blur:                               0
nsfw_warning:                            0
nsfw_warning_admin:                      0
nsfw_banner_override:                    
map_display_direction:                   1
album_subtitle_type:                     oldstyle
upload_processing_limit:                 8
public_photos_hidden:                    1
new_photos_notification:                 0
legacy_id_redirection:                   1
zip_deflate_level:                       6
SA_enabled:                              1
default_album_protection:                1
allow_username_change:                   1

Browser and system

• Win 10 Pro 22H2
  • Firefox 102.6.0esr (64-bit)
  • Chrome 108.0.5359.125 (Official Build) (64-bit)
• iPadOS 16.1.1 (20B101)
  • Safari
• Android 13 build TP1A.221105.002
  • Firefox 108.1.0 (Build #2015920443) (had to rotate to landscape)
  • Chrome 108.0.5359.128 (had to rotate to landscape)
• Ubuntu 20.04.5 LTS
  • Firefox 108.0 (64-bit)

Detailed description of the problem [REQUIRED]

Just installed the latest docker container to test out lychee. Everything seems to work great! However, I am looking for a way to implement some images in another tool/program, and I really need an easy access share/link.

After installing and setting up, I added a few various images to various albums (Some in the public one and in others). However when I do, nothing happens. All other icons/buttons seem to work as intended.

Steps to reproduce the issue

Steps to reproduce the behavior:

1. Install the latest docker container. (I used v4.6.5)
2. setup admin account per normal, and upload some folders
3. Click the share gear/button after selecting a specific image
4. Nothing happens... it highlights with a click/mouseover. But no menu or anything

As a side note, I assume the popovers are javascript or bootstrap based, but I see no errors in the console.

Screenshots

Output of the diagnostics [REQUIRED]

    Diagnostics
    -------
    Warning: Dropbox import not working. dropbox_key is empty.
    Warning: Default timezone not properly set; you might experience strange results when importing photos without explicit EXIF timezone
    Warning: git (software) is not available.
    Foreign key: albums.id                      → base_albums.id       : NO ACTION
    Foreign key: base_albums.owner_id           → users.id             : NO ACTION
    Foreign key: photos.album_id                → albums.id            : NO ACTION
    Foreign key: photos.owner_id                → users.id             : NO ACTION
    Foreign key: size_variants.photo_id         → photos.id            : NO ACTION
    Foreign key: sym_links.size_variant_id      → size_variants.id     : NO ACTION
    Foreign key: tag_albums.id                  → base_albums.id       : NO ACTION
    Foreign key: user_base_album.base_album_id  → base_albums.id       : CASCADE
    Foreign key: user_base_album.user_id        → users.id             : CASCADE



    System Information
    --------------
    Lychee Version (git):                    ?? (26b5393) -- Could not compare.
    DB Version:                              4.6.5
    
    composer install:                        --no-dev
    APP_ENV:                                 production
    APP_DEBUG:                               false
    
    System:                                  Linux
    PHP Version:                             8.1.12
    PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
    Timezone:                                UTC
    Max uploaded file size:                  100M
    Max post size:                           100M
    Max execution time:                      3600
    SQLite Version:                          3.40.0
    
    exec() Available:                        yes
    Imagick Available:                       1
    Imagick Enabled:                         1
    Imagick Version:                         1691
    GD Version:                              2.3.3
    Number of foreign key:                   9 found.



    Config Information
    --------------
    version:                                 040605
    check_for_updates:                       0
    sorting_photos_col:                      taken_at
    sorting_photos_order:                    ASC
    sorting_albums_col:                      max_taken_at
    sorting_albums_order:                    ASC
    imagick:                                 1
    skip_duplicates:                         0
    small_max_width:                         0
    small_max_height:                        360
    medium_max_width:                        1920
    medium_max_height:                       1080
    lang:                                    en
    layout:                                  1
    image_overlay_type:                      desc
    default_license:                         none
    compression_quality:                     90
    grants_full_photo_access:                1
    delete_imported:                         0
    mod_frame_enabled:                       1
    mod_frame_refresh:                       30
    thumb_2x:                                1
    small_2x:                                1
    medium_2x:                               1
    landing_page_enable:                     0
    site_owner:                              John Smith
    landing_title:                           John Smith
    landing_subtitle:                        Cats, Dogs & Humans Photography
    sm_facebook_url:                         https://www.facebook.com/JohnSmith
    sm_flickr_url:                           https://www.flickr.com/JohnSmith
    sm_twitter_url:                          https://www.twitter.com/JohnSmith
    sm_instagram_url:                        https://instagram.com/JohnSmith
    sm_youtube_url:                          https://www.youtube.com/JohnSmith
    landing_background:                      dist/cat.webp
    site_title:                              Lychee v4
    footer_show_copyright:                   1
    site_copyright_begin:                    2019
    site_copyright_end:                      2019
    footer_additional_text:                  
    footer_show_social_media:                0
    public_search:                           0
    SL_enable:                               0
    SL_for_admin:                            0
    public_recent:                           0
    recent_age:                              1
    public_starred:                          0
    grants_download:                         0
    photos_wraparound:                       1
    map_display:                             0
    zip64:                                   1
    map_display_public:                      0
    map_provider:                            Wikimedia
    force_32bit_ids:                         0
    map_include_subalbums:                   0
    update_check_every_days:                 3
    has_exiftool:                            1
    share_button_visible:                    0
    import_via_symlink:                      0
    has_ffmpeg:                              1
    location_decoding:                       0
    location_decoding_timeout:               30
    location_show:                           1
    location_show_public:                    0
    rss_enable:                              0
    rss_recent_days:                         7
    rss_max_items:                           100
    prefer_available_xmp_metadata:           0
    editor_enabled:                          1
    lossless_optimization:                   0
    swipe_tolerance_x:                       150
    swipe_tolerance_y:                       250
    local_takestamp_video_formats:           .avi|.mov
    log_max_num_line:                        1000
    unlock_password_photos_with_url_param:   0
    nsfw_visible:                            1
    nsfw_blur:                               0
    nsfw_warning:                            0
    nsfw_warning_admin:                      0
    nsfw_banner_override:                    
    map_display_direction:                   1
    album_subtitle_type:                     oldstyle
    upload_processing_limit:                 4
    public_photos_hidden:                    1
    new_photos_notification:                 0
    legacy_id_redirection:                   1
    zip_deflate_level:                       6
    SA_enabled:                              1
    default_album_protection:                1
    allow_username_change:                   1

Browser and system

Chrome - MacOS

Fixes #1642

Leverage of Laravel Resources for a more explicit attributes in responses. No hidden surprises.

• [x] : add json missing tests for smart albums as we no longer return null.