Manage your photos with Piwigo, a full featured open source photo gallery application for the web. Star us on Github! More than 200 plugins and themes available. Join us and contribute!

Fixes for create_function and each()

See #812

##TODO

• [x] Upgrade Smarty see https://github.com/smarty-php/smarty/pull/399
• [x] Replace create_function (not done for mysql since not supported in PHP7)
• [ ] Replace each()
• [x] Upgrade cssmin with https://github.com/natxet/CssMin

My users where complaining, that downloaded images with download button, are corrupted (right click on image was fine). I've check all plugins and it came out, there is a problem in gallery core file. Pictures where downloaded, but file content was a complete garbage (it had noting to do with a file, except right size). After investigation, it looks like we need to "ob_clean — Clean (erase) the output buffer" and "flush — Flush system output buffer" before doing readfile(). This could be perhaps only something characteristic for my configuration (apache2.4.25, php5.6.26,Linux) but as far as I can see, those two commands are consider "recommended" for "readfile" (http://php.net/manual/en/function.readfile.php#81925) streaming, they fixed my problem, and they should not be harmful for others.

I get an error 3065 regardless of which ordering option I select in configuration. I narrowed it down to:

mysql> SELECT DISTINCT(image_id) -> FROM piwigo_image_category -> INNER JOIN piwigo_images ON id = image_id -> WHERE -> category_id = 6178 -> -> ORDER BY piwigo_images.file ASC; ERROR 3065 (HY000): Expression #1 of ORDER BY clause is not in SELECT list, references column 'piwigo.piwigo_images.file' which is not in SELECT list; this is incompatible with DISTINCT

The above is from mysql - the browser reports a similar error. To get past this, I changed section_init.inc.php and added piwigo_images.file to the select line to force it for my site.

SELECT DISTINCT(image_id),piwigo_images.file FROM '.IMAGE_CATEGORY_TABLE.' INNER JOIN '.IMAGES_TABLE.' ON id = image_id WHERE '.$where_sql.' '.$forbidden.' '.$conf['order_by'].' ;';

Server version: 5.7.9 MySQL Community Server (GPL) Piwigo 2.7.4

Hi, after updating to 2.8.6 I get an error when I use the user-manager "DataTables warning (table id = 'userList'): DataTables warning: JSON data from server could not be parsed. This is caused by a JSON formatting error"

What´s wrong?

best regards Jörg

Hello,

In case of reverse proxy SSL, lot function doesn't work properly. To fix it, I applied these change in ./include/functions_url.inc.php function get_absolute_root_url

Detect SSL :

    if (isset($_SERVER['HTTPS']) &&
      ((strtolower($_SERVER['HTTPS']) == 'on') or ($_SERVER['HTTPS'] == 1)))
    {
      $is_https = true;
      $url .= 'https://';
    }

to

    if (isset($_SERVER['HTTPS']) && ((strtolower($_SERVER['HTTPS']) == 'on') or ($_SERVER['HTTPS'] == 1)) or ($_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https'))
    {
      $is_https = true;
      $url .= 'https://';
    }

AND ignore port change in this case:

      if ( (!$is_https && $_SERVER['SERVER_PORT'] != 80)
            ||($is_https && $_SERVER['SERVER_PORT'] != 443))
      {

 if ( ((!$is_https && $_SERVER['SERVER_PORT'] != 80)
            ||($is_https && $_SERVER['SERVER_PORT'] != 443)) && (!$_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https'))
      {

Regards,

Thomas.

I have on premise Piwigo server My environment is as follows: Piwigo 12.2.0 Operating system: Linux PHP: 7.4.26 MySQL: 5.5.5-10.3.28-MariaDB Graphics Library: ImageMagick 6.9.12-31

Activated plugin list: Admin Tools Batch Downloader Community Extended Description Language Switch Look_like_gbo2 Show Photo Identifier Tag Access Management User Mass Register

The issue is on the Manage users page. When adding a user the admin got Missing parameters: pwg_token. I've found that this occurs on interface in Polish language. With English it doesn't occurs. Please see attached screenshots.

when on an album or a photo that appears in several albums including private albums to which the current user does not have access, the name of these albums is displayed and active in the "related albums" menu .

The related album menu should not show album names to which the current user have no access.

This poses a double problem for me:

• security / confidentiality : a user or an anonymous visitor does not have to know the existence or the name of private albums to which he does not have access
• ergonomics and use since, obviously, if I click on the name of this inaccessible album, I have nothing in my search, since I cross with an album which I do not do not have access to and I am afraid this will be very confusing for an unsuspecting user.

piwigo 11.3.0

I just setup a brand new Piwigo v2.9.0 on my web hosting. The site is configured with a Let's Encrypt SSL certificate, and everything works fine.

Then I installed the Protected Albums, and got an error from the browser when opening a protected album, as shown in the 2 screenshots below

For some reason, Piwigo (I don't think it's the plugin itself, because the same behavior can be observed with other plugins as well) added port 80 to the https URL. Note that if I manually edit the URL to remove the port, then I can continue without further issues:

http://i.imgur.com/JRBGS3u.png This issue happens when using hhvm's fastcgi with nginx The proposed temp fix from hhvm is to replace all instances that try to retrieve upload_max_file_size with ini_get('hhvm.server.upload.upload_max_file_size');

Reported by jeremyhu on 12 Jul 2012 01:36

Version: 2.4.1

If a user visits your site (http://mypiwigogallery.com) and registers for an account or logs in with the quickconnect form, their password will be sent unencrypted. Visitors must first manually edit the address in their browser's address bar (something I doubt more than 0.1% of visitors will do) in order to avoid this issue.

I want visitors to be able to goto my site using http, but use https for authentication. This is also an issue because my SSL cert is self-signed, and I don't want casual visitors and guests to have to accept the self-signed cert

Steps to reproduce: 1) Create a user account. 2) Feel insecure.

Piwigo Bugtracker #2689

Hello,

i updated to 13.1.0 recently, but the photo view inside an album is not working anymore. Thrown error in GUI:

Fatal error: Uncaught --> Smarty Compiler: Syntax error in template "file:/var/www/vhosts/xxxx/xxxx/themes/smartpocket/template/footer.tpl" on line 20 "document.cookie = 'screen_size='+jQuery(document).width()+'x'+jQuery(document).height()+';path={isset($COOKIE_PATH) ? $COOKIE_PATH : ''}';" - Unexpected " ? ", expected one of: "}" <-- thrown in /var/www/vhosts/xxxx/xxxxx/include/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php on line 20

Standard view works fine. Albums are still listed on mobile, but when opening an album, no photos are shown and the error is listed at the bottom of the page

Hi, ################################## Env: Piwigo 13.4.0 Check for upgrade Installed on 10 November 2022, 1 month 2 weeks 5 days ago Operating system: Linux PHP: 7.4.33 (Show info) [2022-12-29 17:20:22] MySQL: 5.5.5-10.5.15-MariaDB-0+deb11u1 [2022-12-29 16:20:22] Graphics Library: External ImageMagick 6.9.11-60

ffmpeg -version ffmpeg version 4.3.5-0+deb11u1+rpt2 Copyright (c) 2000-2022 the FFmpeg developers built with gcc 10 (Raspbian 10.2.1-6+rpi1) configuration: --prefix=/usr --extra-version=0+deb11u1+rpt2 --toolchain=hardened --incdir=/usr/include/arm-linux-gnueabihf --enable-gpl --disable-stripping --enable-avresample --disable-filter=resample --enable-gnutls --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libcodec2 --enable-libdav1d --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libjack --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librabbitmq --enable-librsvg --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-lv2 --enable-omx --enable-openal --enable-opencl --enable-opengl --enable-sdl2 --enable-mmal --enable-neon --enable-rpi --enable-v4l2-request --enable-libudev --enable-epoxy --enable-pocketsphinx --enable-libdc1394 --enable-libdrm --enable-vout-drm --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libx264 --enable-shared --libdir=/usr/lib/arm-linux-gnueabihf --cpu=arm1176jzf-s --arch=arm libavutil 56. 51.100 / 56. 51.100 libavcodec 58. 91.100 / 58. 91.100 libavformat 58. 45.100 / 58. 45.100 libavdevice 58. 10.100 / 58. 10.100 libavfilter 7. 85.100 / 7. 85.100 libavresample 4. 0. 0 / 4. 0. 0 libswscale 5. 7.100 / 5. 7.100 libswresample 3. 7.100 / 3. 7.100 libpostproc 55. 7.100 / 55. 7.100

mediainfo --version MediaInfo Command line, MediaInfoLib - v22.03 ################################## Two videos selected, "photos " > "Batch manager" > " Global mode" Action " Videos" "Thumbnail" checked "Apply actions" ################################## -results (see hereunder and screenshots attached) -displayed in red "You ask me to do nothing, are you sure?" -displayed in green"
Array Array"

• bunch of error lines: Warning: array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/piwigo/plugins/piwigo-videojs/admin/admin_batchmanager.php on line 151

Warning: array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/piwigo/plugins/piwigo-videojs/admin/admin_batchmanager.php on line 176

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 52

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 52

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 52

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 77

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 84

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 112

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 202

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 77

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 84

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 112

Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 202 ##################################

Would it be possible to add an alt-text field to each photo? It would be nice if my blind friends could follow along as well.

The alt attribute is used by people who depend on a screenreader. It reads out a description of what you can see on an image, if that description is provided.

A description could be something like "A red cat on a news paper on a table". This is something else that the title of an image, which, in this case could be: "Go away, cat!" As you can see, the title has a different function than the alt-text. In this case they complement each other. And even now, where I didn’t provide the image of that cat, you can still imagine what it looks like. That’s the power of the alt-attribute.

Right now, Piwigo uses the title field to fill the alt attribute. This means that the title will be read out twice if you use a screen reader. Once when you hear the alt attribute, and then again when the title is read out. Hearing your screenreader say something like "Image: Go away, cat! Title: Go away, cat!" is in no way comparable to "Image: A red cat on a newspaper on a table. Title: Go away, cat!"

But it even gets a bit worse: if no title is added (which is by default), the alt text is the name of the image file, with its extension. Which in the above example where we see a red can on a table, would result in a blind person hearing "Image: DSC01790.JPG". This is not considered to be good UX since it really has nothing to do with a red cat on a newspaper on a table.

It would therefore be fantastic if it was possible to add an extra alt-text field to the single image edit mode. When this alt-text-field is filled, it will show up in the alt-attribute, and when it is left empty, the alt attribute is left empty as well, which is better than filling it with the file name, or a redundant title. (it should be left empty, not removed. If you remove the alt attribute from the image, the file name will be read out…)

It would then be very helpful for many people if a good explanation was added next to this field, so that people would start to use it properly. And yes, I have taught photographers who don’t know anything about the web about alt-text, and the all use it and they even like it (-:

I'm interested in using the web api, but I wonder if there is any schema files or similar documentation?

I've found the link to discover all methods (http://yourdomain/yourpiwigo/tools/ws.htm), but what I'm looking for is information that could be used to generate code. I'm thinking about writing some java services on top with help of the rest api and json, and it would be create to be able to automatically generate the classes to be used with the rest interface.

We want to add a filter badge to keep track of the number of filters active and a little phrase to show how many users are filtered.

• [x] Badge
• [x] User filtered sentence

$conf['question_mark_in_urls'] = false; $conf['php_extension_in_urls'] = false;

.htaccess

AcceptPathInfo On
Options +MultiViews

Since upgrading to php 8.x for PIWIGO 13.x the above options no longer work.

For me this is a major issue, as all my sitemaps used this option, and of course, with it now broken if anyone searches on the web for my photography the link no loner works as / is.

I did manage to get working a rather messy workaround that adds .php? to incoming URL, but I have not been able to generate a new sitemap, as hopefully this will get fixed in the future.