Hello. I love that someone is finally making a nice specification-pattern library for PHP. However, I have a concern I've ran across.

In the example below, it appears that if I want to filter by more than one group, it will overwrite the parameter with the last group that was specified. This effectively makes the specification as if I had set $spec to new GroupSpec('group 2').

Are there any plans to remedy this within the library itself, or is it something users will need to be aware of when writing custom specifications?

class GroupSpec implements RulerZ\Spec\Specification
{
    private $group;

    public function __construct($group)
    {
        $this->group = $group;
    }

    public function getRule()
    {
        return 'group = :group';
    }

    public function getParameters()
    {
        return [
            'group' => $this->group
        ];
    }
}


$spec = new RulerZ\Spec\OrX([
    new GroupSpec('group 1'),
    new GroupSpec('group 2')
]);

var_dump($spec->getParameters());
/*
 * array(1) {
 *  'group' =>
 *  string(7) "group 2"
 * }
 */

var_dump($spec->getRule());
// string(32) "group = :group OR group = :group"

First off, this library is excellent. I would really, really like to use this library in our project but the DSL makes it a nonstarter for our specific use case. Is it possible to use this library without the DSL? Is it possible to split the library into reusable components? From a high level (without looking at the internals), the DSL, the spec pattern, and the storage abstraction layer seem like they might be better off as separate pieces.

The latest version of coduo/phpspec-data-provider-extension broke BC: https://github.com/coduo/phpspec-data-provider-extension/commit/f6e33b689f3c3e9c91392130ba1257101b210a2e

I write a rule manager for the end-users. How can I extract all parameters from a rule like user.group in :group? I would like to generate the form which it asks a value for each parameter. I can do it with a regexp: \b:\w+\b but I'm not sure that it matches exactly like the RuerZ pattern. Moreover this function should be in the same workspace as the other RulerZ tools.

Ahead this form, I display the rule. But some complex rules are difficult to read. How can I colorize it? (highlighting keywords, parameters, opertator…)

Thanks

Hi, here is the code generated by the FileCompiler when calling filter() for the following rule price = 30 ($rulerz->filter($elasticsearch, 'price = 30', [], $context)):

<?php
namespace RulerZ\Compiled\Executor;

use RulerZ\Executor\Executor;

class Executor_3f155154 implements Executor
{
        use \RulerZ\Executor\Elasticsearch\ElasticsearchFilterTrait;
        use \RulerZ\Executor\Polyfill\FilterBasedSatisfaction;

    protected function execute($target, array $operators, array $parameters)
    {
        return Array;
    }
}

As you can see, there's an error: execute() returns Array (the compiled rules seem to be an array instead of a string).

I believe (I might be wrong) that this is because the elasticsearch implementation returns arrays (instead of strings) for operators.

Am I doing something wrong here? Here is the configuration of RulerZ:

$compiler = new RulerZ\Compiler\FileCompiler(new RulerZ\Parser\HoaParser);
$rulerz = new RulerZ\RulerZ($compiler, [
    new RulerZ\Compiler\Target\Elasticsearch\ElasticsearchVisitor,
])

In my FilterTrait i want to inject metadata in ExecutionContext. Right now i pushing metadata in parameters : $parameters['ting.metadata'] = $repository->getMetadata();

But i think metadata is more context related than parameters related. So is there any reason to make ExecutionContext immutable ?

Hello,

I'm having an issue with RulerZ when attempting to auto-join tables with obscure aliases. In particular, when an association is assigned an alias in the query builder that does not match the name of the association.

This query builder works fine in the current version (0.19.1) of RulerZ:

$entity_manager->createQueryBuilder()
    ->select('permission')
    ->from('Permission', 'permission')
    ->innerJoin('permission.entitlement', 'entitlement')
    ->innerJoin('entitlement.product', 'product');

However, this query builder throws a RuntimeException: Could not automatically join table "product"

$entity_manager->createQueryBuilder()
    ->select('permission')
    ->from('Permission', 'permission')
    ->innerJoin('permission.entitlement', 'entitlement')
    ->innerJoin('entitlement.product', 'product_1');

In both cases, my specification rule looks like this:

public function getRule()
{
    return 'entitlement.product.id = :entitlement_product_id';
}

Do you have any thoughts on this issue? My fix appears to revolve it.

\RulerZ\Compiler\Target\Sql\DoctrineQueryBuilderVisitor::$detectedJoins must be reseted after compilation, otherwise one rule will use $detectedJoins data of previous rule

This pull request configures the Composer bin-dir, so you can type bin/phpspec instead of vendor/phpspec/phpspec/bin/phpspec in order to run tests.

Also, it adds PHPStorm's .idea directory to .gitignore.

Hi,

Sometime, when we deploy our code, we have the following error:

Uncaught PHP Exception Symfony\Component\Debug\Exception\ClassNotFoundException: 
"Attempted to load class "Executor_e54f2a89" from namespace "\RulerZ\Compiled\Executor". 
Did you forget a "use" statement for another namespace?"
 at /.../vendor/kphoen/rulerz/src/Compiler/Compiler.php line 47

If I read correctly, the compiled class is generated at runtime and is not written to disk (in fact, the bundle cache directory seems to be always empty).

Do you have any idea where it could come from ?

Thanks !

When I'm using a complex composite specification on master branch that uses some autojoin multiple times then for DoctrineORMVisitor detected joins include duplicates. E.g. if my rule contains sections like foo.id = ? AND foo.name = ? it results in two joins to foo table, both having the same alias like _3_foo. This results in Doctrine throwing an exception when query is executed as same alias for join is used multiple times (e.g. there are two identical LEFT JOINs with the same alias).

Am I doing something wrong here? For now I did a simple workaround just to keep me going (you can have a look at it at https://github.com/malef/rulerz/commit/28f8ac1c8291525e0bf8633124f26ac780ffa697) but I'm not sure if this is a bug or if I'm misusing this library.

Satisfies return null value instead of bool

The error occurs when the rule is written incorrectly, Like below: any-example=123 Instead of: any-example = 123

Hi,

Composite must be extends AbstractSpecification to chain multiple specifications.

Sample :

class specificationA extends AbstractSpecification 
{
    ...
}

class specificationB extends AbstractSpecification 
{
    ...
}

class specificationC extends AbstractSpecification 
{
    ...
}

$specificationA
    ->andX($specificationB)
    ->andX($specificationC);

Keep chain support to specification type composite

class specificationD extends AndX
{
    public function __construct()
    {
        parent::__construct([
            new specificationA(),
            new specificationB(),
            new specificationC()
        ]);
    }
}

class specificationE extends Composite
{
    public function __construct()
    {
        parent::__construct(
            "MyOperator",
            [
                new specificationA(),
                new specificationB(),
                new specificationC()
            ]
        );
    }
}

$specificationD->andX($specificationE)->andX(...)

Hello! I cannot install this package in symfony 5 project.

composer require 'kphoen/rulerz' -w Using version ^0.21.1 for kphoen/rulerz ./composer.json has been updated Running composer update kphoen/rulerz --with-dependencies Loading composer repositories with package information Updating dependencies Restricting packages listed in "symfony/symfony" to "5.1.*" Your requirements could not be resolved to an installable set of packages.

Problem 1 - Root composer.json requires kphoen/rulerz ^0.21.1 -> satisfiable by kphoen/rulerz[0.21.1]. - kphoen/rulerz 0.21.1 requires symfony/property-access ~3.0|~4.0 -> found symfony/property-access[v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.17] but it conflicts with another require. Problem 2 - scheb/two-factor-bundle is locked to version v4.18.0 and an update of this package was not requested. - scheb/two-factor-bundle v4.18.0 requires symfony/property-access ^3.4|^4.0|^5.0 -> found symfony/property-access[v3.4.0, ..., v3.4.47, v4.0.0, ..., v4.4.17, v5.0.0, ..., v5.2.0] but it conflicts with another require. Problem 3 - symfony/form is locked to version v5.0.10 and an update of this package was not requested. - symfony/form v5.0.10 requires symfony/property-access ^5.0 -> found symfony/property-access[v5.0.0, ..., v5.2.0] but it conflicts with another require. Problem 4 - symfony/serializer-pack is locked to version v1.0.3 and an update of this package was not requested. - symfony/serializer-pack v1.0.3 requires symfony/property-access * -> found symfony/property-access[v2.2.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.17, v5.0.0, ..., v5.2.0] but it conflicts with another require. Problem 5 - symfony/form v5.0.10 requires symfony/property-access ^5.0 -> found symfony/property-access[v5.0.0, ..., v5.2.0] but it conflicts with another require. - hwi/oauth-bundle dev-master requires symfony/form ^3.4|^4.3|^5.0 -> satisfiable by symfony/form[v5.0.10]. - hwi/oauth-bundle is locked to version dev-master and an update of this package was not requested.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Are you planing to provide property accessor 5 support? Because it's impossible to install the package in symfony 5 projects without it.